Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2221862/?format=api
{ "id": 2221862, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2221862/?format=api", "web_url": "http://patchwork.ozlabs.org/project/sparclinux/patch/20260410120318.658719117@kernel.org/", "project": { "id": 10, "url": "http://patchwork.ozlabs.org/api/1.2/projects/10/?format=api", "name": "Linux SPARC Development ", "link_name": "sparclinux", "list_id": "sparclinux.vger.kernel.org", "list_email": "sparclinux@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260410120318.658719117@kernel.org>", "list_archive_url": null, "date": "2026-04-10T12:19:47", "name": "[16/38] fbdev: udlfb: Replace get_cycles() with ktime_get()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "065e82e44ec474ebac6f14d7b60ceb21beff22bc", "submitter": { "id": 92397, "url": "http://patchwork.ozlabs.org/api/1.2/people/92397/?format=api", "name": "Thomas Gleixner", "email": "tglx@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/sparclinux/patch/20260410120318.658719117@kernel.org/mbox/", "series": [ { "id": 499450, "url": "http://patchwork.ozlabs.org/api/1.2/series/499450/?format=api", "web_url": "http://patchwork.ozlabs.org/project/sparclinux/list/?series=499450", "date": "2026-04-10T12:18:27", "name": "treewide: Cleanup LATCH, CLOCK_TICK_RATE and get_cycles() [ab]use", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499450/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221862/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221862/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=+xcL=CJ=vger.kernel.org=sparclinux+bounces-6664-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "sparclinux@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=okWRwWiK;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=+xcl=cj=vger.kernel.org=sparclinux+bounces-6664-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c09:e001:a7::12fc:5321\"\n arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=okWRwWiK;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=sparclinux+bounces-6664-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"okWRwWiK\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsbjh6vfgz1yGS\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 22:30:16 +1000 (AEST)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fsbjh6RD8z4wJR\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 22:30:16 +1000 (AEST)", "by gandalf.ozlabs.org (Postfix)\n\tid 4fsbjh6JhTz4wJP; Fri, 10 Apr 2026 22:30:16 +1000 (AEST)", "from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fsbjd1M8mz4wJR\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 10 Apr 2026 22:30:13 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 3EAE730858F2\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 10 Apr 2026 12:22:58 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C0CDC3C3450;\n\tFri, 10 Apr 2026 12:19:50 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 98D2137DE96;\n\tFri, 10 Apr 2026 12:19:50 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 704BDC19425;\n\tFri, 10 Apr 2026 12:19:49 +0000 (UTC)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775824216; cv=pass;\n\tb=iECC+8AXtteZPsUWHz4GYH4NCEbhWqPE4kgsJ21qxK+d+orsc091R/J7xxNCcfrm8ZYqL6KR3S7gFPaEwBtKAylQjOvB/h3EN5dpxgtTeB8JOZRKvxht4q4+v5VcYDPCcQ8zKQBXIOPCUNsZBAMAlgcZlgq1649UjPJ81khlGlPcOMzuhhBIIt9UIU6sRSXU2NxA+KOwP30S1uB6w2NqF8h/ts+GadkaKJ/mFNqJCiwDF5t/gf2mrDZV38WQINnjd7vjjeld6HOfRqkarBxJUD4ViJAirSf2MvsgpyIK/c2eBf0fy50CUnA9TTrOBosd1e3MF/Pj7Uyhs2FHOzzoBA==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775823590; cv=none;\n b=dTl4tKcdQ4/iwzVpq5qkkc6IVN7VHh9WEXbfpOT+xWe7EWerc/xv2dvsHM3FNxkgmBMZWCFPAf5+JHSm6m/0l9fGrOCk0uyBQnnR3Lme9CAtLOcsfg3+hQ7zUouQU0AY+QYXoddWCFJCEWrN8hYk+m9N8wpJ6heihZ4+X8T3XfM=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775824216; c=relaxed/relaxed;\n\tbh=u2KrsjOZZc+bQEPw3J7+YcyUcAZcAFTN5sTexf8i1No=;\n\th=Date:Message-ID:From:To:Cc:Subject:References:MIME-Version:\n\t Content-Type;\n b=Z1Ki51ky8PtiBECy4asLn4jGsrNXJK6oufD3V5pPMknEcB2qOaJOIl9pjB1QcMqdtXA+GzLAstcTWEBmLAhNbmKM4lust2Yihgx6vXtU+/azs5F/u4FEnHDOsEvkCSKuX0IR+RWQAkJttJqylKTcbxl0XfWN8LXbbjuymVDunQxxmMXT1Mk9NxBsxIniiUacbLY3CgqBr5Rbsb2vgC4N6Nj+3uJhgzjB/OrHxzVSIzYlr7z9yBNX/xTAoO8goV5w3BSHqqnetG4FIeFVfHeEs94k4BjB3XQBq+GeI4W31aPvfYbF5JSLR+LG5KtYsJpaxqMcFC0Qk0cUa63O8nkHlQ==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775823590; c=relaxed/simple;\n\tbh=r17Pe0N1ahBhrB3JYh2nj0lozuwWxFWE8s4wbHnNz1U=;\n\th=Date:Message-ID:From:To:Cc:Subject:References:MIME-Version:\n\t Content-Type;\n b=LaNkLv/JG7BZsfehwcyrh4pS9fsCCcGrRH0IN+S4JTBwN7FfTeOZ7FCztdt3R4jCXe5h2aoqCHUQI1gb572reKNb9m85twmbNWAXUb49vdiauJxQZtBUB31di4FroogJPw5AzzJWclj4y0dW4USXNEpR0ZywVJgZMZBrdhUxdJc=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=okWRwWiK; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=sparclinux+bounces-6664-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=okWRwWiK; arc=none smtp.client-ip=10.30.226.201" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775823590;\n\tbh=r17Pe0N1ahBhrB3JYh2nj0lozuwWxFWE8s4wbHnNz1U=;\n\th=Date:From:To:Cc:Subject:References:From;\n\tb=okWRwWiKRXWxIOYd0Peg6lhswEXmgs6TDBmjhAnD7Q9a6usCqNg9OYWu+roqFftQt\n\t CXuq9wugiKbiMxTD+p64hE/DfyXI2OVOyYyt+MQaYOMvBz3HQvYNGX8W9+b4gE14hU\n\t 1DViHL5lpk9k7rS0TYmec/vPv8+l0l72HHkjevm3yaDtlLwCxfiyVTiYsTY5w9OTh5\n\t Ju9iD//e8k54q8KUH3ojDg3WjR+Vu3B/cuQgNtmo0Zn1MW3hNX3wOdJ7kCRM+fO7Bg\n\t 3Yz29lBDAALUYxAqFMkB8dpm5Y3XPhihE7EzHhldnKqOW+zQ+3nRrzSdk9MbluRvBK\n\t 0NZT2IviOMPvg==", "Date": "Fri, 10 Apr 2026 14:19:47 +0200", "Message-ID": "<20260410120318.658719117@kernel.org>", "User-Agent": "quilt/0.68", "From": "Thomas Gleixner <tglx@kernel.org>", "To": "LKML <linux-kernel@vger.kernel.org>", "Cc": "Bernie Thompson <bernie@plugable.com>,\n linux-fbdev@vger.kernel.org,\n Arnd Bergmann <arnd@arndb.de>,\n x86@kernel.org,\n Lu Baolu <baolu.lu@linux.intel.com>,\n iommu@lists.linux.dev,\n Michael Grzeschik <m.grzeschik@pengutronix.de>,\n netdev@vger.kernel.org,\n linux-wireless@vger.kernel.org,\n Herbert Xu <herbert@gondor.apana.org.au>,\n linux-crypto@vger.kernel.org,\n Vlastimil Babka <vbabka@kernel.org>,\n linux-mm@kvack.org,\n David Woodhouse <dwmw2@infradead.org>,\n \"Theodore Tso\" <tytso@mit.edu>,\n linux-ext4@vger.kernel.org,\n Andrew Morton <akpm@linux-foundation.org>,\n Uladzislau Rezki <urezki@gmail.com>,\n Marco Elver <elver@google.com>,\n Dmitry Vyukov <dvyukov@google.com>,\n kasan-dev@googlegroups.com,\n Andrey Ryabinin <ryabinin.a.a@gmail.com>,\n Thomas Sailer <t.sailer@alumni.ethz.ch>,\n linux-hams@vger.kernel.org,\n \"Jason A. Donenfeld\" <Jason@zx2c4.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n linux-alpha@vger.kernel.org,\n Russell King <linux@armlinux.org.uk>,\n linux-arm-kernel@lists.infradead.org,\n Catalin Marinas <catalin.marinas@arm.com>,\n Huacai Chen <chenhuacai@kernel.org>,\n loongarch@lists.linux.dev,\n Geert Uytterhoeven <geert@linux-m68k.org>,\n linux-m68k@lists.linux-m68k.org,\n Dinh Nguyen <dinguyen@kernel.org>,\n Jonas Bonn <jonas@southpole.se>,\n linux-openrisc@vger.kernel.org,\n Helge Deller <deller@gmx.de>,\n linux-parisc@vger.kernel.org,\n Michael Ellerman <mpe@ellerman.id.au>,\n linuxppc-dev@lists.ozlabs.org,\n Paul Walmsley <pjw@kernel.org>,\n linux-riscv@lists.infradead.org,\n Heiko Carstens <hca@linux.ibm.com>,\n linux-s390@vger.kernel.org,\n \"David S. Miller\" <davem@davemloft.net>,\n sparclinux@vger.kernel.org", "Subject": "[patch 16/38] fbdev: udlfb: Replace get_cycles() with ktime_get()", "References": "<20260410120044.031381086@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "sparclinux@vger.kernel.org", "List-Id": "<sparclinux.vger.kernel.org>", "List-Subscribe": "<mailto:sparclinux+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:sparclinux+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Spam-Status": "No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "These metrics are not really requiring CPU cycles and as those are\nmeanlingless when the CPU is running at a different frequency, this can use\nktime_get() and achieve the same result.\n\nPart of a larger effort to confine get_cycles() access to low level\narchitecture code.\n\nSigned-off-by: Thomas Gleixner <tglx@kernel.org>\nCc: Bernie Thompson <bernie@plugable.com>\nCc: linux-fbdev@vger.kernel.org\n---\n Documentation/fb/udlfb.rst | 4 ++--\n drivers/video/fbdev/udlfb.c | 24 ++++++++++++------------\n 2 files changed, 14 insertions(+), 14 deletions(-)", "diff": "--- a/Documentation/fb/udlfb.rst\n+++ b/Documentation/fb/udlfb.rst\n@@ -156,8 +156,8 @@ metrics_bytes_sent\t 32-bit count of how\n \t\t\t USB to communicate the resulting changed pixels to the\n \t\t\t hardware. Includes compression and protocol overhead\n \n-metrics_cpu_kcycles_used 32-bit count of CPU cycles used in processing the\n-\t\t\t above pixels (in thousands of cycles).\n+metrics_cpu_kcycles_used 32-bit count of microseconds used in processing the\n+\t\t\t above pixels\n \n metrics_reset\t\t Write-only. Any write to this file resets all metrics\n \t\t\t above to zero. Note that the 32-bit counters above\n--- a/drivers/video/fbdev/udlfb.c\n+++ b/drivers/video/fbdev/udlfb.c\n@@ -24,6 +24,7 @@\n #include <linux/slab.h>\n #include <linux/delay.h>\n #include <linux/unaligned.h>\n+#include <linux/timekeeping.h>\n #include <video/udlfb.h>\n #include \"edid.h\"\n \n@@ -600,15 +601,15 @@ static int dlfb_render_hline(struct dlfb\n \n static int dlfb_handle_damage(struct dlfb_data *dlfb, int x, int y, int width, int height)\n {\n+\tktime_t t_start, t_delta;\n \tint i, ret;\n \tchar *cmd;\n-\tcycles_t start_cycles, end_cycles;\n \tint bytes_sent = 0;\n \tint bytes_identical = 0;\n \tstruct urb *urb;\n \tint aligned_x;\n \n-\tstart_cycles = get_cycles();\n+\tt_start = ktime_get();\n \n \tmutex_lock(&dlfb->render_mutex);\n \n@@ -661,10 +662,9 @@ static int dlfb_handle_damage(struct dlf\n \tatomic_add(bytes_sent, &dlfb->bytes_sent);\n \tatomic_add(bytes_identical, &dlfb->bytes_identical);\n \tatomic_add(width*height*2, &dlfb->bytes_rendered);\n-\tend_cycles = get_cycles();\n-\tatomic_add(((unsigned int) ((end_cycles - start_cycles)\n-\t\t >> 10)), /* Kcycles */\n-\t\t &dlfb->cpu_kcycles_used);\n+\tt_delta = ktime_get() - t_start;\n+\t/* Avoid a division and approximate microseconds with shift right ten */\n+\tatomic_add(((int)(t_delta >> 10)), &dlfb->cpu_kcycles_used);\n \n \tret = 0;\n \n@@ -727,9 +727,9 @@ static void dlfb_dpy_deferred_io(struct\n {\n \tstruct fb_deferred_io_pageref *pageref;\n \tstruct dlfb_data *dlfb = info->par;\n+\tktime_t t_start, t_delta;\n \tstruct urb *urb;\n \tchar *cmd;\n-\tcycles_t start_cycles, end_cycles;\n \tint bytes_sent = 0;\n \tint bytes_identical = 0;\n \tint bytes_rendered = 0;\n@@ -742,7 +742,7 @@ static void dlfb_dpy_deferred_io(struct\n \tif (!atomic_read(&dlfb->usb_active))\n \t\tgoto unlock_ret;\n \n-\tstart_cycles = get_cycles();\n+\tt_start = ktime_get();\n \n \turb = dlfb_get_urb(dlfb);\n \tif (!urb)\n@@ -774,10 +774,10 @@ static void dlfb_dpy_deferred_io(struct\n \tatomic_add(bytes_sent, &dlfb->bytes_sent);\n \tatomic_add(bytes_identical, &dlfb->bytes_identical);\n \tatomic_add(bytes_rendered, &dlfb->bytes_rendered);\n-\tend_cycles = get_cycles();\n-\tatomic_add(((unsigned int) ((end_cycles - start_cycles)\n-\t\t >> 10)), /* Kcycles */\n-\t\t &dlfb->cpu_kcycles_used);\n+\tt_delta = ktime_get() - t_start;\n+\t/* Avoid a division and approximate microseconds with shift right ten */\n+\tatomic_add(((int)(t_delta >> 10)), &dlfb->cpu_kcycles_used);\n+\n unlock_ret:\n \tmutex_unlock(&dlfb->render_mutex);\n }\n", "prefixes": [ "16/38" ] }