Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2221494/?format=api
{ "id": 2221494, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2221494/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409142137.58349-4-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260409142137.58349-4-philmd@linaro.org>", "list_archive_url": null, "date": "2026-04-09T14:21:35", "name": "[PULL,3/4] ati-vga: Fix check for overflowing vram", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "eaddb97c27d9b7e2249852e7a2ea393f5611ec31", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.2/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409142137.58349-4-philmd@linaro.org/mbox/", "series": [ { "id": 499309, "url": "http://patchwork.ozlabs.org/api/1.2/series/499309/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499309", "date": "2026-04-09T14:21:32", "name": "[PULL,1/4] ati-vga: Fix pitch and offset registers mask", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499309/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221494/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221494/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=BhlOCzMI;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs2G758R8z1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 00:22:55 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAqGl-0003It-Tq; Thu, 09 Apr 2026 10:22:07 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wAqGh-0003F9-A1\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 10:22:03 -0400", "from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wAqGf-00039N-Cu\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 10:22:02 -0400", "by mail-wr1-x42a.google.com with SMTP id\n ffacd0b85a97d-43d02a71526so567439f8f.3\n for <qemu-devel@nongnu.org>; Thu, 09 Apr 2026 07:22:01 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d5e969bbfsm5043612f8f.1.2026.04.09.07.21.58\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 09 Apr 2026 07:21:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775744519; x=1776349319; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=VjuOAzMxe2056w6Ss/yMMT0oZPZyJj/YY1kbGnOufgk=;\n b=BhlOCzMI3J7NKM1pDL6dlIcm6S6EQpxuUJNwIB0Ri0UgatrH7+jRb00b4AwG0LvNiI\n r5mLnKUPqTptntyj+D/nmakDUuRtvePWoE0rpbPe8dBTNFQmpRPeMpWJLb2Xj3+jbIyL\n ZV7LxNPbWIyUlMUdLxHQ/wwDnhV9iSw6LgaMfvT8W7fMcxbcoCEvCdk7UX1oP5UJwC2a\n OszcMKzgoC1x2g8fPaRp8b5/rR4HqMkq7ynnMDDCCoJ21jB1Gw0XzI4HWIc9PTN6S22u\n zetXq+3dSX0grak6QoqBjPpt3nKMXRbrBAZB8NCkKD9cKWI2hy5d7zT6lhZvSprM/aHt\n lxrQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775744519; x=1776349319;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=VjuOAzMxe2056w6Ss/yMMT0oZPZyJj/YY1kbGnOufgk=;\n b=bTn4acBUuKF9850KrSefUKt0Mr2geK8Jv48S+17Y9xP2gJvCL4tPTjeSQfVsne7bZE\n 9uXNA6pvxWlcX0bDDpJyG/7VCKyqHfWwQs0H8CiSKkoIAmmO39mryI7YT0czlRxcs2RV\n xipv28f9VTFqdqr1uZXnb6Aeby6uv17ds7BJY3SE1Bhk3/xP6LA9zamkTOxhwCMsPo7f\n sfX6SRFa4doGv9z8zk438sNBXBbRNjU3ftg2wrSfgN0Lgq7uAzRs3x6zNXncfFxMNgvh\n EG1zM12ddp9taKlpxv4qrQ4TSZp0JxepXc6TeNBE8Ti2ZwegdDFW2NUFSjeF6yeunycO\n mx/w==", "X-Gm-Message-State": "AOJu0YwLBk25aZAFqaMTOkOBygZ/np5gKd/zETzIgAMB/TYKuabSTaW9\n X+HFl7q+Z0oSVOcptflCBCtKzVCv4wldMNEicU//wqV4yaQocOYnXv//k/BLLHVxMNm8BzxYVSL\n QyEnYpw8=", "X-Gm-Gg": "AeBDiesKhNisGh7JIqN3u0Eh5gFUBx/k8l9B+/OW/Wiek3cS7wBdPuBh4ytq8b63Hwx\n x8UbSxTOB14akEPU0SaFg0UmGNSQ2tNDYA6uB/GjbUTdSER6hT4AyVAg11Ccr3WoXQrCXuRPDH7\n FLFLJ6uaIScamaPuAzr76bfmaAQrhYkZ/R6uxLAKvCpUD/gvtewem27Y/tmO4HKGUKh12tS0Rj2\n LJt/NSbk3+LXrk13iEe85TsrkDJEejznrykryNFBd1oI/dt55YUvHovhI6B9FthOhytQOOEk0AD\n CspZknd88UIc1FMwd2Fo0oIQaqs04WPF7mRcHj6kuhVHXJ5dyFATnliQhCvG83b3JI05qbDCVNk\n heie9JRsu5Gfqa562y0e6/TI0WfW1NRaDlXy8L4w6d6XhWxw/VrE9aO4JinFAkfHaEO01ej+eW2\n kaAtxX0IGrLErCtAZxjqLKnoBH3VmJv22siPwH7rOJ0s8Uz8tqnH1jE9Ngx4J12LHlRqa1cKSm", "X-Received": "by 2002:a05:6000:40ca:b0:43b:80a0:d92 with SMTP id\n ffacd0b85a97d-43d5a1b107dmr5243479f8f.45.1775744519260;\n Thu, 09 Apr 2026 07:21:59 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Peter Maydell <peter.maydell@linaro.org>", "Subject": "[PULL 3/4] ati-vga: Fix check for overflowing vram", "Date": "Thu, 9 Apr 2026 16:21:35 +0200", "Message-ID": "<20260409142137.58349-4-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260409142137.58349-1-philmd@linaro.org>", "References": "<20260409142137.58349-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42a;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: BALATON Zoltan <balaton@eik.bme.hu>\n\nTake into account the bytes per pixels when checking for accessing\nbeyond end of vram area.\n\nSigned-off-by: BALATON Zoltan <balaton@eik.bme.hu>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nMessage-ID: <20260408104935.1A55A5969F6@zero.eik.bme.hu>\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n hw/display/ati_2d.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/hw/display/ati_2d.c b/hw/display/ati_2d.c\nindex f0f77cecc65..504d1c57085 100644\n--- a/hw/display/ati_2d.c\n+++ b/hw/display/ati_2d.c\n@@ -146,6 +146,7 @@ static uint32_t make_filler(int bpp, uint32_t color)\n static bool ati_2d_do_blt(ATI2DCtx *ctx, uint8_t use_pixman)\n {\n QemuRect vis_src, vis_dst;\n+ unsigned int x, y, i, j, bypp = ctx->bpp / 8;\n \n if (!ctx->bpp) {\n qemu_log_mask(LOG_GUEST_ERROR, \"Invalid bpp\\n\");\n@@ -156,8 +157,9 @@ static bool ati_2d_do_blt(ATI2DCtx *ctx, uint8_t use_pixman)\n return false;\n }\n if (ctx->dst.x > 0x3fff || ctx->dst.y > 0x3fff ||\n- ctx->dst_bits >= ctx->vram_end || ctx->dst_bits + ctx->dst.x +\n- (ctx->dst.y + ctx->dst.height) * ctx->dst_stride >= ctx->vram_end) {\n+ ctx->dst_bits >= ctx->vram_end - bypp ||\n+ ctx->dst_bits + ctx->dst.x * bypp + (ctx->dst.y + ctx->dst.height) *\n+ ctx->dst_stride >= ctx->vram_end - bypp) {\n qemu_log_mask(LOG_UNIMP, \"blt outside vram not implemented\\n\");\n return false;\n }\n@@ -194,8 +196,9 @@ static bool ati_2d_do_blt(ATI2DCtx *ctx, uint8_t use_pixman)\n }\n if (!ctx->host_data_active &&\n (vis_src.x > 0x3fff || vis_src.y > 0x3fff ||\n- ctx->src_bits >= ctx->vram_end || ctx->src_bits + vis_src.x +\n- (vis_src.y + vis_dst.height) * ctx->src_stride >= ctx->vram_end)) {\n+ ctx->src_bits >= ctx->vram_end - bypp ||\n+ ctx->src_bits + vis_src.x * bypp + (vis_src.y + vis_dst.height) *\n+ ctx->src_stride >= ctx->vram_end - bypp)) {\n qemu_log_mask(LOG_UNIMP, \"blt outside vram not implemented\\n\");\n return false;\n }\n@@ -240,7 +243,6 @@ static bool ati_2d_do_blt(ATI2DCtx *ctx, uint8_t use_pixman)\n fallback = true;\n }\n if (fallback) {\n- unsigned int y, i, j, bypp = ctx->bpp / 8;\n for (y = 0; y < vis_dst.height; y++) {\n i = vis_dst.x * bypp;\n j = vis_src.x * bypp;\n@@ -299,7 +301,6 @@ static bool ati_2d_do_blt(ATI2DCtx *ctx, uint8_t use_pixman)\n #endif\n {\n /* fallback when pixman failed or we don't want to call it */\n- unsigned int x, y, i, bypp = ctx->bpp / 8;\n for (y = 0; y < vis_dst.height; y++) {\n i = vis_dst.x * bypp + (vis_dst.y + y) * ctx->dst_stride;\n for (x = 0; x < vis_dst.width; x++, i += bypp) {\n", "prefixes": [ "PULL", "3/4" ] }