Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2221488/?format=api
{ "id": 2221488, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2221488/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409141352.997844-3-akrowiak@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260409141352.997844-3-akrowiak@linux.ibm.com>", "list_archive_url": null, "date": "2026-04-09T14:13:45", "name": "[v2,2/2] hw/vfio/ap: Callbacks for migration of guests with pass-through access to AP devices", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "70a9729a365b554f7ca11e12713a6f68eabfd850", "submitter": { "id": 74509, "url": "http://patchwork.ozlabs.org/api/1.2/people/74509/?format=api", "name": "Anthony Krowiak", "email": "akrowiak@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409141352.997844-3-akrowiak@linux.ibm.com/mbox/", "series": [ { "id": 499308, "url": "http://patchwork.ozlabs.org/api/1.2/series/499308/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499308", "date": "2026-04-09T14:13:44", "name": "Enable live migration of vfio-ap devices", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499308/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221488/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221488/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=co1o48VT;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs24R2Ptvz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 00:14:31 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAq91-0008Mn-Ng; Thu, 09 Apr 2026 10:14:07 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <akrowiak@linux.ibm.com>)\n id 1wAq8y-0008ME-5C; Thu, 09 Apr 2026 10:14:04 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <akrowiak@linux.ibm.com>)\n id 1wAq8w-0000hX-KT; Thu, 09 Apr 2026 10:14:03 -0400", "from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 639BbK7i2211629; Thu, 9 Apr 2026 14:14:01 GMT", "from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dcn2hmf1n-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 09 Apr 2026 14:14:01 +0000 (GMT)", "from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 639D088F030063;\n Thu, 9 Apr 2026 14:14:00 GMT", "from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69])\n by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dcme7kve4-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 09 Apr 2026 14:14:00 +0000", "from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 639EDxEY24183520\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 9 Apr 2026 14:13:59 GMT", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 335B55805D;\n Thu, 9 Apr 2026 14:13:59 +0000 (GMT)", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 6739C58052;\n Thu, 9 Apr 2026 14:13:58 +0000 (GMT)", "from li-4c4c4544-004d-4810-8043-b7c04f423534.ibm.com.com (unknown\n [9.61.93.104]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 9 Apr 2026 14:13:58 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=AWFhyEEbRYqvGNebo\n Mncanft41maUJsvjia+OSWLOMw=; b=co1o48VTY7SyQa1PeBiJalUbroWtdKn96\n zlnegyDaG/VmWF6bqWyU2GNRqoKe/W2YlOvmStktmeprRoXScvk+wEF+5JXlKqaY\n HtTqYJ1JgZ3jq1qq/mjQ3mnDYaCliIzzccH8bczMpWIHrilpoUMmXZ/IS2pNprzo\n CqYYm6N9o/n8X6GIP+GtLkFH10wdTP3P4YnPZlAHfwknXYPXI23IqVqUNlVFJ0ZY\n MqoRvRFVlxWm4ANorN8djnhXFuu12BfCrETdK03mtskD2rCFgAgHn63HxQg2R3XH\n 3U7+fjCLHGN+n6MbUkbgI0joWL/FSeeRpIx9e9ast7B41gyYX87Cw==", "From": "Anthony Krowiak <akrowiak@linux.ibm.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-s390x@nongnu.org, mjrosato@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, clg@redhat.com, farman@linux.ibm.com,\n borntraeger@linux.ibm.com, alex@shazbot.org, cohuck@redhat.com,\n Anthony Krowiak <akrowiak@linux.ibm.com>", "Subject": "[PATCH v2 2/2] hw/vfio/ap: Callbacks for migration of guests with\n pass-through access to AP devices", "Date": "Thu, 9 Apr 2026 10:13:45 -0400", "Message-ID": "<20260409141352.997844-3-akrowiak@linux.ibm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260409141352.997844-1-akrowiak@linux.ibm.com>", "References": "<20260409141352.997844-1-akrowiak@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDA5MDEyNiBTYWx0ZWRfX2lLYsPISAyWu\n rrcCEWH7SUl9U7DOszV4hrstJyQ46tKun/Bq69wHwdX3eD/XpmSDvHFuYTTYKv4UXSHPcNjv86h\n lyZ+ANu1cuhUwJI2RxJrgRZLN1GmxxZ41NFDbfJj7km3ffZXxn97F7MrOiEHFA1IzTnJZO7MlzV\n GQW0geDqsMNwLnlzqtCUo25Au7Gu707m01TTixweu7ilFh03HxuS8fn8rDSl5cnnOeFR+2Hy1oq\n 2BHPlLE3qznPIapCOkDLMbAajEGvTIzZIUR1g4PX3g2Yfhe5FU/Ov7AqTz2SRxWfRd8FUEHOy1V\n pEaH7NZhW888hQqBnlAGdvQnB/f+PafMN76C4Lo9M5wqGToYDEzyP3kowDrmb85j8wEqqz7D1tz\n ILD5cv8iBx2EWl/0aMIRI/3N+GE4iYO4XK6jO5Xos+/8OlPnfnmix4y0abzJlKzdib9NQTFNX1I\n d1uy7ezT4uo5pvT3Etw==", "X-Proofpoint-GUID": "ZW-PGTcr803UkRXkmA2PLwLF4beMfHVn", "X-Authority-Analysis": "v=2.4 cv=a/wAM0SF c=1 sm=1 tr=0 ts=69d7b429 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=_xvLCLdD-WGpu_BjdYgA:9", "X-Proofpoint-ORIG-GUID": "ZW-PGTcr803UkRXkmA2PLwLF4beMfHVn", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-09_04,2026-04-09_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n bulkscore=0 clxscore=1011 spamscore=0 impostorscore=0 priorityscore=1501\n phishscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 suspectscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604090126", "Received-SPF": "pass client-ip=148.163.158.5;\n envelope-from=akrowiak@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Anthony Krowiak <akrowiak@linux.ibm.com>\n\nImplements the callbacks used by the VFIO migration framework to migrate\nguests with pass-through access to s390 crypto devices.\n\nSigned-off-by: Anthony Krowiak <akrowiak@linux.ibm.com>\n---\n hw/vfio/ap.c | 43 +++++++++++++++++++++++++++++++++++++++----\n 1 file changed, 39 insertions(+), 4 deletions(-)", "diff": "diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c\nindex fd68983702..49947b18c3 100644\n--- a/hw/vfio/ap.c\n+++ b/hw/vfio/ap.c\n@@ -32,6 +32,7 @@\n #include \"hw/s390x/ap-bridge.h\"\n #include \"system/address-spaces.h\"\n #include \"qom/object.h\"\n+#include \"vfio-migration-internal.h\"\n \n #define TYPE_VFIO_AP_DEVICE \"vfio-ap\"\n \n@@ -47,6 +48,7 @@ static const VMStateDescription vmstate_ap_device = {\n .name = \"vfio-ap-device\",\n .version_id = 1,\n .minimum_version_id = 1,\n+ .unmigratable = 0,\n .fields = (const VMStateField[]) {\n VMSTATE_END_OF_LIST()\n },\n@@ -66,17 +68,44 @@ static void __attribute__((constructor)) vfio_ap_global_init(void)\n qemu_mutex_init(&cfg_chg_events_lock);\n }\n \n+static int vfio_ap_save_config(VFIODevice *vdev, QEMUFile *f, Error **errp)\n+{\n+ VFIOAPDevice *vapdev = container_of(vdev, VFIOAPDevice, vdev);\n+\n+ return vmstate_save_state(f, &vmstate_ap_device, vapdev, NULL, errp);\n+}\n+\n+static int vfio_ap_load_config(VFIODevice *vdev, QEMUFile *f)\n+{\n+ VFIOAPDevice *vapdev = container_of(vdev, VFIOAPDevice, vdev);\n+ Error *err = NULL;\n+ int ret;\n+\n+ ret = vmstate_load_state(f, &vmstate_ap_device, vapdev, 1, &err);\n+ if (ret) {\n+ error_report_err(err);\n+ }\n+\n+ return ret;\n+}\n+\n+static Object *vfio_ap_get_object(VFIODevice *vbasedev)\n+{\n+ VFIOAPDevice *vdev = container_of(vbasedev, VFIOAPDevice, vdev);\n+\n+ return OBJECT(vdev);\n+}\n+\n static void vfio_ap_compute_needs_reset(VFIODevice *vdev)\n {\n vdev->needs_reset = false;\n }\n \n-/*\n- * We don't need vfio_hot_reset_multi and vfio_eoi operations for\n- * vfio-ap device now.\n- */\n struct VFIODeviceOps vfio_ap_ops = {\n .vfio_compute_needs_reset = vfio_ap_compute_needs_reset,\n+ .vfio_save_config = vfio_ap_save_config,\n+ .vfio_load_config = vfio_ap_load_config,\n+ .vfio_get_object = vfio_ap_get_object,\n };\n \n static void vfio_ap_req_notifier_handler(void *opaque)\n@@ -251,6 +280,10 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp)\n goto error;\n }\n \n+ if (!vfio_migration_realize(vbasedev, errp)) {\n+ goto error;\n+ }\n+\n if (!vfio_ap_register_irq_notifier(vapdev, VFIO_AP_REQ_IRQ_INDEX, &err)) {\n /*\n * Report this error, but do not make it a failing condition.\n@@ -287,6 +320,8 @@ static void vfio_ap_unrealize(DeviceState *dev)\n \n static const Property vfio_ap_properties[] = {\n DEFINE_PROP_STRING(\"sysfsdev\", VFIOAPDevice, vdev.sysfsdev),\n+ DEFINE_PROP_ON_OFF_AUTO(\"enable-migration\", VFIOAPDevice,\n+ vdev.enable_migration, ON_OFF_AUTO_ON),\n #ifdef CONFIG_IOMMUFD\n DEFINE_PROP_LINK(\"iommufd\", VFIOAPDevice, vdev.iommufd,\n TYPE_IOMMUFD_BACKEND, IOMMUFDBackend *),\n", "prefixes": [ "v2", "2/2" ] }