Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2221393/?format=api
{ "id": 2221393, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2221393/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409-fix_ioevent-v1-1-053b810ae6fb@linux.microsoft.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260409-fix_ioevent-v1-1-053b810ae6fb@linux.microsoft.com>", "list_archive_url": null, "date": "2026-04-09T11:53:06", "name": "[1/2] accel/mshv: fix ioeventfd deassignment to forward correct datamatch value", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ad7f04a799cebdd0f3d255fb704af63e377a2463", "submitter": { "id": 92925, "url": "http://patchwork.ozlabs.org/api/1.2/people/92925/?format=api", "name": "Aastha Rawat", "email": "aastharawat@linux.microsoft.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409-fix_ioevent-v1-1-053b810ae6fb@linux.microsoft.com/mbox/", "series": [ { "id": 499282, "url": "http://patchwork.ozlabs.org/api/1.2/series/499282/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499282", "date": "2026-04-09T11:53:06", "name": "Fix issues in accel/mshv ioeventfd handling", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499282/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221393/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221393/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=d0QaIUOG;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fryyQ0FTTz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 21:54:05 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAnx9-0006Fm-SO; Thu, 09 Apr 2026 07:53:43 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <aastharawat@linux.microsoft.com>)\n id 1wAnx8-0006FR-Ue\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 07:53:42 -0400", "from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from <aastharawat@linux.microsoft.com>) id 1wAnx7-0000DX-E8\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 07:53:42 -0400", "from localhost (unknown [131.107.147.136])\n by linux.microsoft.com (Postfix) with ESMTPSA id 5106420B710C;\n Thu, 9 Apr 2026 04:53:39 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 5106420B710C", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1775735619;\n bh=A2gkHzyyrgJ48tKH/NCs6vPTaw/e/Fxg1+vebw64BvU=;\n h=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n b=d0QaIUOGkgNgLtMF7F4SnXDYriMh3mO/8k0r79DN+v/69py14Pylv09AVzopb6gnS\n Q7AE3YQJzqJfhJy8/cr3HfiOY/8ADXbVSclCGK/5YvziSDgkN1lTl6xq6xx0EXWE1i\n QVSK5GaUtyQco7vIHjTghA3KVIoEvSh4roepkzrE=", "From": "Aastha Rawat <aastharawat@linux.microsoft.com>", "Date": "Thu, 09 Apr 2026 11:53:06 +0000", "Subject": "[PATCH 1/2] accel/mshv: fix ioeventfd deassignment to forward\n correct datamatch value", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260409-fix_ioevent-v1-1-053b810ae6fb@linux.microsoft.com>", "References": "<20260409-fix_ioevent-v1-0-053b810ae6fb@linux.microsoft.com>", "In-Reply-To": "<20260409-fix_ioevent-v1-0-053b810ae6fb@linux.microsoft.com>", "To": "qemu-devel@nongnu.org", "Cc": "Magnus Kulke <magnuskulke@linux.microsoft.com>,\n Wei Liu <wei.liu@kernel.org>,\n Aastha Rawat <aastharawat@linux.microsoft.com>", "X-Mailer": "b4 0.15.1", "Received-SPF": "pass client-ip=13.77.154.182;\n envelope-from=aastharawat@linux.microsoft.com; helo=linux.microsoft.com", "X-Spam_score_int": "-42", "X-Spam_score": "-4.3", "X-Spam_bar": "----", "X-Spam_report": "(-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "unregister_ioevent() is not forwarding the datamatch (queue index) to\nthe mshv driver, causing only the first VirtIO-MMIO queue to be\ndeassigned correctly. Subsequent queues fail with `-ENOENT`, triggering\na fatal abort().\n\nThis failure was discovered while booting arm64 EDK2 firmware with mshv\naccel.\n\nSigned-off-by: Aastha Rawat <aastharawat@linux.microsoft.com>\n---\n accel/mshv/mshv-all.c | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)", "diff": "diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c\nindex d4cc7f5371..e1a8d62f8d 100644\n--- a/accel/mshv/mshv-all.c\n+++ b/accel/mshv/mshv-all.c\n@@ -278,13 +278,22 @@ static int ioeventfd(int vm_fd, int event_fd, uint64_t addr, Datamatch dm,\n return ioctl(vm_fd, MSHV_IOEVENTFD, &args);\n }\n \n-static int unregister_ioevent(int vm_fd, int event_fd, uint64_t mmio_addr)\n+static int unregister_ioevent(int vm_fd, int event_fd, uint64_t mmio_addr,\n+ uint64_t data, uint32_t len, bool data_match)\n {\n uint32_t flags = 0;\n Datamatch dm = {0};\n \n flags |= BIT(MSHV_IOEVENTFD_BIT_DEASSIGN);\n- dm.tag = DATAMATCH_NONE;\n+ if (!data_match) {\n+ dm.tag = DATAMATCH_NONE;\n+ } else if (len == sizeof(uint64_t)) {\n+ dm.tag = DATAMATCH_U64;\n+ dm.value.u64 = data;\n+ } else {\n+ dm.tag = DATAMATCH_U32;\n+ dm.value.u32 = data;\n+ }\n \n return ioeventfd(vm_fd, event_fd, mmio_addr, dm, flags);\n }\n@@ -337,11 +346,12 @@ static void mem_ioeventfd_del(MemoryListener *listener,\n int fd = event_notifier_get_fd(e);\n int ret;\n uint64_t addr = section->offset_within_address_space;\n+ uint64_t len = int128_get64(section->size);\n \n trace_mshv_mem_ioeventfd_del(section->offset_within_address_space,\n int128_get64(section->size), data);\n \n- ret = unregister_ioevent(mshv_state->vm, fd, addr);\n+ ret = unregister_ioevent(mshv_state->vm, fd, addr, data, len, match_data);\n if (ret < 0) {\n error_report(\"Failed to unregister ioeventfd: %s (%d)\", strerror(-ret),\n -ret);\n", "prefixes": [ "1/2" ] }