Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2221377/?format=api
{ "id": 2221377, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2221377/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409103310.1884968-2-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260409103310.1884968-2-pbonzini@redhat.com>", "list_archive_url": null, "date": "2026-04-09T10:33:09", "name": "[PULL,1/1] virtio-scsi: pass the same cdb_size to virtio_scsi_pop_req and virtio_scsi_handle_cmd_req_prepare", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b9fb51e53acc6c19bd5fd9edb3623030d975aeae", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/1.2/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409103310.1884968-2-pbonzini@redhat.com/mbox/", "series": [ { "id": 499270, "url": "http://patchwork.ozlabs.org/api/1.2/series/499270/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499270", "date": "2026-04-09T10:33:08", "name": "[PULL,1/1] virtio-scsi: pass the same cdb_size to virtio_scsi_pop_req and virtio_scsi_handle_cmd_req_prepare", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499270/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221377/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221377/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=XoLOGds/;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=N29H4NAv;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frxBK1VNYz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 20:34:15 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAmhP-00019D-Bx; Thu, 09 Apr 2026 06:33:23 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1wAmhN-00018l-Tp\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 06:33:21 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1wAmhL-00009C-7t\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 06:33:21 -0400", "from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-655-ppFr4BtKPbGkmnyQTzf2ag-1; Thu, 09 Apr 2026 06:33:15 -0400", "by mail-wr1-f70.google.com with SMTP id\n ffacd0b85a97d-43cff5bc312so694200f8f.1\n for <qemu-devel@nongnu.org>; Thu, 09 Apr 2026 03:33:15 -0700 (PDT)", "from [192.168.122.1] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488cd23058dsm64871575e9.13.2026.04.09.03.33.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 03:33:12 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775730797;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=K6wVzzxEUdru13XNf+9PuoXL/B9TF0wuj0LinPwBVT4=;\n b=XoLOGds/gbKs6otu4FCAEnPFGCEPndOALLcUCtNMupJKj9HTluW7gR6R7sO+ztz3Mv2Tai\n eFVgxadHjfV9jduYVYCSmdYq5m18ykSzKsn3QlcX64+/ElXc6ynvh811o7KtuF7yPOKyhF\n DVk1NXi3GL0k+3R/om+6itQ5QqlxV5c=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775730793; x=1776335593; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=K6wVzzxEUdru13XNf+9PuoXL/B9TF0wuj0LinPwBVT4=;\n b=N29H4NAvPyYPjTxjdQiHlPxxfc8/jJZMgQU0G+efNSOZAVGGuGlxcqM5OtwWkAcgiM\n sHCIsMUMzJ6/p4CEAXhSlMwQj05o1C5gnvKLUMhKGclKNdFWVzq2HK672wOI2XXUtccr\n P7B4SbiMsv44/h98r2CZMD9DUmNIWc8TKOzYT/aPglQUMBYYJL06csT6uGQ1Yx1DlO0t\n yPEd/rHuDt/mIbUts3/nBSYGcFUZUVdwv0Snp3n/XPXjC4LX8gW7RxGPP4iTQ3QHqXrV\n sEbBrnViHm+iCp1nlLKGhv6h2wA/HAS2QoflH9Qt0EnZmwtIqQxTjK6ISGKqhEhFTO5R\n /aGQ==" ], "X-MC-Unique": "ppFr4BtKPbGkmnyQTzf2ag-1", "X-Mimecast-MFC-AGG-ID": "ppFr4BtKPbGkmnyQTzf2ag_1775730794", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775730793; x=1776335593;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=K6wVzzxEUdru13XNf+9PuoXL/B9TF0wuj0LinPwBVT4=;\n b=fqOwX9f2u4/2YbsYCsSlYtJr5jKqhoDHCWMpT+hZ2KogwroPwgd4F/8gkZ35h1UJ/m\n ix74NzD7see4EeDRmYhx+STRP0FS8fKavFOfxh0bSP+zWnVqsLWMc4Gc2SAMCsTWQt40\n xJOgQLat4oyAMWWFtrwgZy9cgH2qe0I6alMMnReb5T9y4mBsJCTJaBe3dvedlkzCNtPd\n +/HRhJW8DFHJKUGnbCNOTClHRyj9WcGGqfxtyWZdfQt1GcAoXviBtuCjbnFXoXJcsuCI\n W0uBfc9ndcKqSBpnph2CIhatWZeK4VfgIAd4EF5NSYI4t607wNE7SaqCbjjlWmo0wEgo\n b6Cw==", "X-Gm-Message-State": "AOJu0Yx1+8a9CcOMlKG65IrAjQzh087sOxxQLLvSVIwEK+WYChNrapFJ\n f46obLy/UnEanUsFyqf3KNA22xVMUN3AdO4udxGyxZa+3a9dEMebA3To44Hw/CMQCcU+jjtxEbf\n MZBmNdzFQT0ErgTGfZMd9Lio1f0NtHk2Sh2lOBUGJj5P5JB/OAbGSqoBmSBtJOKNpp3w26YYXn6\n 31AYLVnWPpkaYJmBqBdVnSlmU5uvac46RCdL5jsh7P", "X-Gm-Gg": "AeBDieskMTLz3dchhgBFJlSoTYk+n0IcrkUYISoj7lzDv4Lv8co4566PoZOmb6qIf2K\n fuhGF/n+Bulkx8gG5IpH1SVI+nXwRJwnvRQFGbH7ARBDcdR3D1GIkuY91lrOsMsTeJCb+as5eO5\n 1M3HNipWbWvOgbjMmEIJiGr0vfT5aDL2vgNgPDsyyQb9SeZqXe1X278d9jXMFWhftkVdPfGFjhJ\n l94N/TyIqLGknQkncM+U54KwssM0gTnKgJcAvZcGXd3/TP2Nb/pMlbwpHUl3YoaDskwMhnhaqEB\n 9yfryChdcsp3gefsPQ9UMPjawTcv0H4NK+IQWDF6aSKM6yD/kNujJV/9Va6cReWnzH/SisdLj+Q\n lsyDt0GvdrpXkvPYS5Xg688bezWZmkc4Y2mS426G4FDfg+DfnYJcNK3SiuQnzWDdgb1NRZ4P8sB\n 6YLGMn4nL/m+L41lCPmgIM4J/v", "X-Received": [ "by 2002:a05:600c:314d:b0:488:bc6a:5285 with SMTP id\n 5b1f17b1804b1-488bc6a538bmr150325595e9.30.1775730793115;\n Thu, 09 Apr 2026 03:33:13 -0700 (PDT)", "by 2002:a05:600c:314d:b0:488:bc6a:5285 with SMTP id\n 5b1f17b1804b1-488bc6a538bmr150324965e9.30.1775730792543;\n Thu, 09 Apr 2026 03:33:12 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Jihe Wang <wangjihe.mail@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>", "Subject": "[PULL 1/1] virtio-scsi: pass the same cdb_size to virtio_scsi_pop_req\n and virtio_scsi_handle_cmd_req_prepare", "Date": "Thu, 9 Apr 2026 12:33:09 +0200", "Message-ID": "<20260409103310.1884968-2-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260409103310.1884968-1-pbonzini@redhat.com>", "References": "<20260409103310.1884968-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-25", "X-Spam_score": "-2.6", "X-Spam_bar": "--", "X-Spam_report": "(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Ensure that there is no allocation/usage mismatch when requests\nare processed in virtio_scsi_handle_cmd_vq. To do this,\nretrieve the value once and pass it to both functions.\n\nFor other calls to virtio_scsi_pop_req the extra size\ncan be 0, because control and event requests fit\nentirely in VirtIOSCSIReq.\n\nReported-by: Jihe Wang <wangjihe.mail@gmail.com>\nTested-by: Jihe Wang <wangjihe.mail@gmail.com>\nReviewed-by: Stefan Hajnoczi <stefanha@redhat.com>\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/scsi/virtio-scsi.c | 26 +++++++++++++++-----------\n 1 file changed, 15 insertions(+), 11 deletions(-)", "diff": "diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c\nindex 774968d8c70..6c737680119 100644\n--- a/hw/scsi/virtio-scsi.c\n+++ b/hw/scsi/virtio-scsi.c\n@@ -227,16 +227,16 @@ static int virtio_scsi_parse_req(VirtIOSCSIReq *req,\n return 0;\n }\n \n-static VirtIOSCSIReq *virtio_scsi_pop_req(VirtIOSCSI *s, VirtQueue *vq, QemuMutex *vq_lock)\n+static VirtIOSCSIReq *virtio_scsi_pop_req(VirtIOSCSI *s, VirtQueue *vq, size_t extra_req_size,\n+ QemuMutex *vq_lock)\n {\n- VirtIOSCSICommon *vs = (VirtIOSCSICommon *)s;\n VirtIOSCSIReq *req;\n \n if (vq_lock) {\n qemu_mutex_lock(vq_lock);\n }\n \n- req = virtqueue_pop(vq, sizeof(VirtIOSCSIReq) + vs->cdb_size);\n+ req = virtqueue_pop(vq, sizeof(VirtIOSCSIReq) + extra_req_size);\n \n if (vq_lock) {\n qemu_mutex_unlock(vq_lock);\n@@ -682,7 +682,7 @@ static void virtio_scsi_handle_ctrl_vq(VirtIOSCSI *s, VirtQueue *vq)\n {\n VirtIOSCSIReq *req;\n \n- while ((req = virtio_scsi_pop_req(s, vq, &s->ctrl_lock))) {\n+ while ((req = virtio_scsi_pop_req(s, vq, 0, &s->ctrl_lock))) {\n virtio_scsi_handle_ctrl_req(s, req);\n }\n }\n@@ -850,13 +850,14 @@ static void virtio_scsi_fail_cmd_req(VirtIOSCSIReq *req)\n virtio_scsi_complete_cmd_req(req);\n }\n \n-static int virtio_scsi_handle_cmd_req_prepare(VirtIOSCSI *s, VirtIOSCSIReq *req)\n+static int virtio_scsi_handle_cmd_req_prepare(VirtIOSCSI *s, VirtIOSCSIReq *req,\n+ size_t cdb_size)\n {\n VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(s);\n SCSIDevice *d;\n int rc;\n \n- rc = virtio_scsi_parse_req(req, sizeof(VirtIOSCSICmdReq) + vs->cdb_size,\n+ rc = virtio_scsi_parse_req(req, sizeof(VirtIOSCSICmdReq) + cdb_size,\n sizeof(VirtIOSCSICmdResp) + vs->sense_size);\n if (rc < 0) {\n if (rc == -ENOTSUP) {\n@@ -878,7 +879,7 @@ static int virtio_scsi_handle_cmd_req_prepare(VirtIOSCSI *s, VirtIOSCSIReq *req)\n }\n req->sreq = scsi_req_new(d, req->req.cmd.tag,\n virtio_scsi_get_lun(req->req.cmd.lun),\n- req->req.cmd.cdb, vs->cdb_size, req);\n+ req->req.cmd.cdb, cdb_size, req);\n \n if (req->sreq->cmd.mode != SCSI_XFER_NONE\n && (req->sreq->cmd.mode != req->mode ||\n@@ -913,12 +914,15 @@ static void virtio_scsi_handle_cmd_vq(VirtIOSCSI *s, VirtQueue *vq)\n QTAILQ_HEAD(, VirtIOSCSIReq) reqs = QTAILQ_HEAD_INITIALIZER(reqs);\n \n do {\n+ VirtIOSCSICommon *vs = (VirtIOSCSICommon *)s;\n+ size_t cdb_size = qatomic_read(&vs->cdb_size);\n+\n if (suppress_notifications) {\n virtio_queue_set_notification(vq, 0);\n }\n \n- while ((req = virtio_scsi_pop_req(s, vq, NULL))) {\n- ret = virtio_scsi_handle_cmd_req_prepare(s, req);\n+ while ((req = virtio_scsi_pop_req(s, vq, cdb_size, NULL))) {\n+ ret = virtio_scsi_handle_cmd_req_prepare(s, req, cdb_size);\n if (!ret) {\n QTAILQ_INSERT_TAIL(&reqs, req, next);\n } else if (ret == -EINVAL) {\n@@ -989,7 +993,7 @@ static void virtio_scsi_set_config(VirtIODevice *vdev,\n }\n \n vs->sense_size = virtio_ldl_p(vdev, &scsiconf->sense_size);\n- vs->cdb_size = virtio_ldl_p(vdev, &scsiconf->cdb_size);\n+ qatomic_set(&vs->cdb_size, virtio_ldl_p(vdev, &scsiconf->cdb_size));\n }\n \n static uint64_t virtio_scsi_get_features(VirtIODevice *vdev,\n@@ -1050,7 +1054,7 @@ static void virtio_scsi_push_event(VirtIOSCSI *s,\n return;\n }\n \n- req = virtio_scsi_pop_req(s, vs->event_vq, &s->event_lock);\n+ req = virtio_scsi_pop_req(s, vs->event_vq, 0, &s->event_lock);\n WITH_QEMU_LOCK_GUARD(&s->event_lock) {\n if (!req) {\n s->events_dropped = true;\n", "prefixes": [ "PULL", "1/1" ] }