Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2219857/?format=api
{ "id": 2219857, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2219857/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260405023409.23142-12-mohamed@unpredictable.fr/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260405023409.23142-12-mohamed@unpredictable.fr>", "list_archive_url": null, "date": "2026-04-05T02:34:09", "name": "[v7,11/11] whpx: i386: IO port fast path cleanup", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "31475a5ad9d98230a9d0aa6d0b833df4a17e1e62", "submitter": { "id": 91318, "url": "http://patchwork.ozlabs.org/api/1.2/people/91318/?format=api", "name": "Mohamed Mediouni", "email": "mohamed@unpredictable.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260405023409.23142-12-mohamed@unpredictable.fr/mbox/", "series": [ { "id": 498757, "url": "http://patchwork.ozlabs.org/api/1.2/series/498757/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498757", "date": "2026-04-05T02:34:08", "name": "whpx: i386: bug fixes, feature probing and CPUID", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/498757/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219857/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219857/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=MboLBv8z;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpGlS5fR9z1yG6\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 05 Apr 2026 12:35:16 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w9DJu-0003c8-IO; Sat, 04 Apr 2026 22:34:38 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1w9DJs-0003bz-TO\n for qemu-devel@nongnu.org; Sat, 04 Apr 2026 22:34:36 -0400", "from p-east2-cluster5-host1-snip4-7.eps.apple.com ([57.103.79.10]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1w9DJr-0008H0-Fj\n for qemu-devel@nongnu.org; Sat, 04 Apr 2026 22:34:36 -0400", "from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-60-percent-10 (Postfix) with ESMTPS id\n F048B18000B8; Sun, 05 Apr 2026 02:34:30 +0000 (UTC)", "from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-60-percent-10 (Postfix) with ESMTPSA id\n B337518000AB; Sun, 05 Apr 2026 02:34:28 +0000 (UTC)" ], "Dkim-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1775356474; x=1777948474;\n bh=iMaqy92qTMtN0/VpAFedvsY2TEecY1Ap34g33JpCGSc=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=MboLBv8zrWuc9eztSTqp/Ehg5u+voWXOdl46GmT8nPXJO0sD6JqPDysw2Qqyff2lqhVL19yuKgh/MiK5vpDJws1og3U16Kf0Nbrgl4oGahP9wgFfINuUNSDWMfUiVsLRU8BeYCKP0dWgEqH6YS/sNqH4IZhLc4tB1RJPKEZIB2ngliEkBNVw72pCDg/OvMzIYh02Zgn+Fv+uBuJBpX957j/JFLXAK+HDvgyMwDx9+gq/Q/h94Jt60oO7iYtLktL5cHagEWYcHUt2tzNTCijWtF0MTtEiRGQxu2zHwnZ9gIa3LCJ6UbLWprgcosK9vI4tR/8T0cwfr5fH0oa/vVJ6xg==", "mail-alias-created-date": "1752046281608", "From": "Mohamed Mediouni <mohamed@unpredictable.fr>", "To": "qemu-devel@nongnu.org", "Cc": "Pedro Barbuda <pbarbuda@microsoft.com>, Wei Liu <wei.liu@kernel.org>,\n Mohamed Mediouni <mohamed@unpredictable.fr>,\n Paolo Bonzini <pbonzini@redhat.com>, Roman Bolshakov <rbolshakov@ddn.com>,\n Phil Dennis-Jordan <phil@philjordan.eu>, Zhao Liu <zhao1.liu@intel.com>", "Subject": "[PATCH v7 11/11] whpx: i386: IO port fast path cleanup", "Date": "Sun, 5 Apr 2026 04:34:09 +0200", "Message-ID": "<20260405023409.23142-12-mohamed@unpredictable.fr>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260405023409.23142-1-mohamed@unpredictable.fr>", "References": "<20260405023409.23142-1-mohamed@unpredictable.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDA1MDAyNCBTYWx0ZWRfXyPP7HYNF/E2Z\n CdyZnYmgjWPtPOygU8UF+zqfSOp/9p1RkKTQXncsqb0dVTeFRlJi5LaOK66ZLvmWJbJfTsHgwYg\n betGk56SmJi4vAbqvRGzTiWokqsV4spWgLLOT+Q+a0ViJyLPMCs2kL+I0LLQDlMaXrG90OQAjbs\n 6iwvJCpC9RXdQe4ygYnYDuwLUTLEYbGptpB12qnwDoSYJYgXKVfem0rx0A2Ms/CsZE4eNBq4NdK\n CQWI6ewGrQbkLbGRWtgBxWXb6lBIP/Bi4JLlx+RLacz1fRLMq7E0G5yLddiAvA7nfloUK6i//sC\n yQWrBN2tnkAU1zZD1tde9vv6tgOG1txrZQWWkmj3kBkE5DkZCoydSRP/Itqse8=", "X-Authority-Info-Out": "v=2.4 cv=De8aa/tW c=1 sm=1 tr=0 ts=69d1ca38\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Vrzv6M8N8vcM0KmfSJEA:9", "X-Proofpoint-GUID": "izskt5RAIr3rHo9hQcGhc2YlmPxy1uhQ", "X-Proofpoint-ORIG-GUID": "izskt5RAIr3rHo9hQcGhc2YlmPxy1uhQ", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-05_01,2026-04-03_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 malwarescore=0\n clxscore=1030 spamscore=0 adultscore=0\n lowpriorityscore=0 phishscore=0\n suspectscore=0 mlxscore=0 mlxlogscore=811 bulkscore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604050024", "Received-SPF": "pass client-ip=57.103.79.10;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "vmport calls synchronise_state within an I/O port read.\nSupport that properly.\n\nWhat was there before worked because of a side effect of\nwhpx_get_reg synchronising context if cpu->vcpu_dirty.\n\nRemove that whpx_get_reg call in whpx_bump_rip too as it's no longer\nneeded now.\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n target/i386/whpx/whpx-all.c | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 8bc1a609d2..0cc04c38fe 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -862,7 +862,6 @@ static void handle_io(CPUState *env, uint16_t port, void *buffer,\n static void whpx_bump_rip(CPUState *cpu, WHV_RUN_VP_EXIT_CONTEXT *exit_ctx)\n {\n WHV_REGISTER_VALUE reg;\n- whpx_get_reg(cpu, WHvX64RegisterRip, ®);\n reg.Reg64 = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n whpx_set_reg(cpu, WHvX64RegisterRip, reg);\n }\n@@ -890,13 +889,23 @@ static int whpx_handle_portio(CPUState *cpu,\n } else {\n reg.Reg64 = (uint64_t)val;\n }\n- whpx_bump_rip(cpu, exit_ctx);\n- whpx_set_reg(cpu, WHvX64RegisterRax, reg);\n+ /* vmport calls cpu_synchronize_state on an I/O port read */\n+ if (!cpu->vcpu_dirty) {\n+ whpx_bump_rip(cpu, exit_ctx);\n+ whpx_set_reg(cpu, WHvX64RegisterRax, reg);\n+ } else {\n+ env->eip = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n+ env->regs[R_EAX] = reg.Reg64;\n+ }\n return 0;\n } else if (!ctx->AccessInfo.StringOp && ctx->AccessInfo.IsWrite) {\n RAX(env) = ctx->Rax;\n handle_io(cpu, ctx->PortNumber, &RAX(env), 1, ctx->AccessInfo.AccessSize, 1);\n- whpx_bump_rip(cpu, exit_ctx);\n+ if (!cpu->vcpu_dirty) {\n+ whpx_bump_rip(cpu, exit_ctx);\n+ } else {\n+ env->eip = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n+ }\n return 0;\n }\n \n", "prefixes": [ "v7", "11/11" ] }