Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2189858/?format=api
{ "id": 2189858, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2189858/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260128021609.4061686-1-yi.zhang@huaweicloud.com/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/1.2/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260128021609.4061686-1-yi.zhang@huaweicloud.com>", "list_archive_url": null, "date": "2026-01-28T02:16:09", "name": "ext4: do not check fast symlink during orphan recovery", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2babde0638bcd7c2d1ab435cdb01f83e5cc98a08", "submitter": { "id": 85428, "url": "http://patchwork.ozlabs.org/api/1.2/people/85428/?format=api", "name": "Zhang Yi", "email": "yi.zhang@huaweicloud.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260128021609.4061686-1-yi.zhang@huaweicloud.com/mbox/", "series": [ { "id": 490009, "url": "http://patchwork.ozlabs.org/api/1.2/series/490009/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=490009", "date": "2026-01-28T02:16:09", "name": "ext4: do not check fast symlink during orphan recovery", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/490009/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2189858/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2189858/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=O3Yr=AB=vger.kernel.org=linux-ext4+bounces-13366-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=o3yr=ab=vger.kernel.org=linux-ext4+bounces-13366-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.234.253.10 arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13366-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=45.249.212.51", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com", "smtp.subspace.kernel.org;\n spf=none smtp.mailfrom=huaweicloud.com" ], "Received": [ "from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f15bz1kW0z1xr1\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 28 Jan 2026 13:21:03 +1100 (AEDT)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4f15bz0v0sz4w1g\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 28 Jan 2026 13:21:03 +1100 (AEDT)", "by gandalf.ozlabs.org (Postfix)\n\tid 4f15bz0qSkz4wCx; Wed, 28 Jan 2026 13:21:03 +1100 (AEDT)", "from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4f15bv2bkxz4w1g\n\tfor <patchwork-incoming@ozlabs.org>; Wed, 28 Jan 2026 13:20:59 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 41164300B46B\n\tfor <patchwork-incoming@ozlabs.org>; Wed, 28 Jan 2026 02:20:48 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 07C40287247;\n\tWed, 28 Jan 2026 02:20:47 +0000 (UTC)", "from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com\n [45.249.212.51])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2450C1DC997;\n\tWed, 28 Jan 2026 02:20:42 +0000 (UTC)", "from mail.maildlp.com (unknown [172.19.163.198])\n\tby dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4f15Zj6305zYQtlf;\n\tWed, 28 Jan 2026 10:19:57 +0800 (CST)", "from mail02.huawei.com (unknown [10.116.40.128])\n\tby mail.maildlp.com (Postfix) with ESMTP id 61F6340539;\n\tWed, 28 Jan 2026 10:20:34 +0800 (CST)", "from huaweicloud.com (unknown [10.50.85.155])\n\tby APP4 (Coremail) with SMTP id gCh0CgB3JPVqcnlpnzB5FQ--.31477S4;\n\tWed, 28 Jan 2026 10:20:34 +0800 (CST)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1769566863; cv=pass;\n\tb=NGFw8PMCW1lxxuQ/5V5BtFVNcVBkdZAkvbaTShhQTPvbTVnlW82TldoErMKGONlrgr6fhVra6d8XUC1vry1dQOe0pwecb4ljjtyePED2MyIwr7tEXOKXSW4nJk/WZaCBsi1gpB7ZIdXjHyVmh5KL46E8D3SEBDAfRuJ0Wp4hwSCP0/OZfrLbWYlNrMOOzBsK2fIV0c2vN3IVDnm/5O5XAhJDl3eiisqXdMfTKd6j3iFm+2DMR6xg3iJ1GJBXfoFHbMEEiwuIUDhzASyL3Sq6EtJWx+PiicbApxSBDyT8qiwt2yOxfiS6Hc9aUeAKw5KcngiM5D9uTZAZ1hQKuTmUfg==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1769566846; cv=none;\n b=B3LEvOSP8ufhIFMb38evGiaojXXXGt50qC24SNvOKgE42hmkcbQYVEG7uYt+HSmyvMiyoyCppvJpwscxYhtVlvQxaXDPM2ipx/g2j71LpU9dwrmJkOFFRH9n6yOrQmmN81mM+i6/T221rXsFU0d4SpZ1gfAzooWmbBNDPU7w2ZY=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1769566863; c=relaxed/relaxed;\n\tbh=+UafY++8Yg5FWZPNXU15A5U585+AaouM68AyfegH6y8=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=xF/mnJgxgxZaUQhsi6uZiNbDgqq47Qian32Y1ZDbAGUXlinIyddhmztX26gJDBgj3+KPB3FTpbjIx5q9M+vvoth+zGHNT83kpqAqmcQkAZLEYe0d/QjsIR1jd4C114YG58Zk63yRfHOYWrn7o+IpP72zu9B9Uf2BdIHW0ZdY0IoynvWedBD9DrOPxzttFkqv2VET2Zj4W300vqGAbmqxMhVaLfnY9O0wPxB87IDAfMRshsXJ2usjJ8Z/Kkfp0roCKAH7mhO+ut7KhOEetMkviDasYuvhfc35NOgw4agq8dhJhZ+NdLRgNaAvY1Ck+JvlEc+rdaQMuKZg/MuLGA6ZUQ==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1769566846; c=relaxed/simple;\n\tbh=8bPNlRSRv2AZEv8dpGv0opFY2PkUMGBnwl0qOls0MeU=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=t0RIS8zTv6rwm/ae50QTqz35nkg1ykxxeaicFkMLSlWF+btaXP1poWDoO+Pf2tjTR9y5F7aUtbjzhHIMPW8IYf/xkVl5+4/v2akSI6yHlOKLncIKxngGAscCS673NADp8AsHy9G+6iqMrpisqBAlWWOWQY08iXHiLcpL8J/H81g=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com;\n spf=pass (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13366-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com;\n spf=none smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51" ], "From": "Zhang Yi <yi.zhang@huaweicloud.com>", "To": "linux-ext4@vger.kernel.org", "Cc": "linux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\ttytso@mit.edu,\n\tadilger.kernel@dilger.ca,\n\tjack@suse.cz,\n\tojaswin@linux.ibm.com,\n\tritesh.list@gmail.com,\n\tyi.zhang@huawei.com,\n\tyi.zhang@huaweicloud.com,\n\tyizhang089@gmail.com,\n\tlibaokun1@huawei.com,\n\tyangerkun@huawei.com,\n\tyukuai@fnnas.com", "Subject": "[PATCH] ext4: do not check fast symlink during orphan recovery", "Date": "Wed, 28 Jan 2026 10:16:09 +0800", "Message-ID": "<20260128021609.4061686-1-yi.zhang@huaweicloud.com>", "X-Mailer": "git-send-email 2.52.0", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "gCh0CgB3JPVqcnlpnzB5FQ--.31477S4", "X-Coremail-Antispam": "1UD129KBjvJXoW7ZFWkKr4kWrWxWF15KFyrXrb_yoW8KF4kpa\n\tyaka4kGr48XF9Ygw4IqrW7Xr1Fq3WYyr4UAFZ3Ar4UZr98Ja4xKF1qgF15Zay5trWkAw4F\n\tqFyxKry3Cwn8CFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDU0xBIdaVrnRJUUU9014x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0\n\trVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02\n\t1l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j\n\t6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV\n\tCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0\n\tI7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r\n\t4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v\n\tn2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7x\n\tkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E\n\t67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCw\n\tCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1x\n\tMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIda\n\tVFxhVjvjDU0xZFpf9x0JUpwZcUUUUU=", "X-CM-SenderInfo": "d1lo6xhdqjqx5xdzvxpfor3voofrz/", "X-Spam-Status": "No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDMARC_MISSING,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "From: Zhang Yi <yi.zhang@huawei.com>\n\nCommit '5f920d5d6083 (\"ext4: verify fast symlink length\")' causes the\ngeneric/475 test to fail during orphan cleanup of zero-length symlinks.\n\n generic/475 84s ... _check_generic_filesystem: filesystem on /dev/vde is inconsistent\n\nThe fsck reports are provided below:\n\n Deleted inode 9686 has zero dtime.\n Deleted inode 158230 has zero dtime.\n ...\n Inode bitmap differences: -9686 -158230\n Orphan file (inode 12) block 13 is not clean.\n Failed to initialize orphan file.\n\nIn ext4_symlink(), a newly created symlink can be added to the orphan\nlist due to ENOSPC. Its data has not been initialized, and its size is\nzero. Therefore, we need to disregard the length check of the symbolic\nlink when cleaning up orphan inodes.\n\nFixes: 5f920d5d6083 (\"ext4: verify fast symlink length\")\nSigned-off-by: Zhang Yi <yi.zhang@huawei.com>\n---\n fs/ext4/inode.c | 26 +++++++++++++++-----------\n 1 file changed, 15 insertions(+), 11 deletions(-)", "diff": "diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c\nindex 6fba4948e040..44054a04fc4b 100644\n--- a/fs/ext4/inode.c\n+++ b/fs/ext4/inode.c\n@@ -6079,18 +6079,22 @@ struct inode *__ext4_iget(struct super_block *sb, unsigned long ino,\n \t\t\tinode->i_op = &ext4_encrypted_symlink_inode_operations;\n \t\t} else if (ext4_inode_is_fast_symlink(inode)) {\n \t\t\tinode->i_op = &ext4_fast_symlink_inode_operations;\n-\t\t\tif (inode->i_size == 0 ||\n-\t\t\t inode->i_size >= sizeof(ei->i_data) ||\n-\t\t\t strnlen((char *)ei->i_data, inode->i_size + 1) !=\n-\t\t\t\t\t\t\t\tinode->i_size) {\n-\t\t\t\text4_error_inode(inode, function, line, 0,\n-\t\t\t\t\t\"invalid fast symlink length %llu\",\n-\t\t\t\t\t (unsigned long long)inode->i_size);\n-\t\t\t\tret = -EFSCORRUPTED;\n-\t\t\t\tgoto bad_inode;\n+\n+\t\t\t/* Orphan cleanup can get a zero-sized symlink. */\n+\t\t\tif (!(EXT4_SB(sb)->s_mount_state & EXT4_ORPHAN_FS)) {\n+\t\t\t\tif (inode->i_size == 0 ||\n+\t\t\t\t inode->i_size >= sizeof(ei->i_data) ||\n+\t\t\t\t strnlen((char *)ei->i_data, inode->i_size + 1) !=\n+\t\t\t\t\t\tinode->i_size) {\n+\t\t\t\t\text4_error_inode(inode, function, line, 0,\n+\t\t\t\t\t\t\"invalid fast symlink length %llu\",\n+\t\t\t\t\t\t(unsigned long long)inode->i_size);\n+\t\t\t\t\tret = -EFSCORRUPTED;\n+\t\t\t\t\tgoto bad_inode;\n+\t\t\t\t}\n+\t\t\t\tinode_set_cached_link(inode, (char *)ei->i_data,\n+\t\t\t\t\t\t inode->i_size);\n \t\t\t}\n-\t\t\tinode_set_cached_link(inode, (char *)ei->i_data,\n-\t\t\t\t\t inode->i_size);\n \t\t} else {\n \t\t\tinode->i_op = &ext4_symlink_inode_operations;\n \t\t}\n", "prefixes": [] }