Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2186634/?format=api
{ "id": 2186634, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2186634/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260120112538.132774-3-me@linux.beauty/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/1.2/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260120112538.132774-3-me@linux.beauty>", "list_archive_url": null, "date": "2026-01-20T11:25:31", "name": "[RFC,v4,2/7] ext4: lockdep: handle i_data_sem subclassing for special inodes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5d684ead445116215d627590765107565a8360d8", "submitter": { "id": 84264, "url": "http://patchwork.ozlabs.org/api/1.2/people/84264/?format=api", "name": "Li Chen", "email": "me@linux.beauty" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260120112538.132774-3-me@linux.beauty/mbox/", "series": [ { "id": 489032, "url": "http://patchwork.ozlabs.org/api/1.2/series/489032/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=489032", "date": "2026-01-20T11:25:32", "name": "ext4: fast commit: snapshot inode state for FC log", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/489032/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2186634/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2186634/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=WKJI=7Z=vger.kernel.org=linux-ext4+bounces-13100-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.beauty header.i=me@linux.beauty\n header.a=rsa-sha256 header.s=zmail header.b=Vngf29Az;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=wkji=7z=vger.kernel.org=linux-ext4+bounces-13100-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=213.196.21.55\n arc.chain=\"subspace.kernel.org:zohomail.com\"", "gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=linux.beauty", "gandalf.ozlabs.org;\n spf=fail smtp.mailfrom=vger.kernel.org", "gandalf.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.beauty header.i=me@linux.beauty\n header.a=rsa-sha256 header.s=zmail header.b=Vngf29Az;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=softfail (domain owner discourages use of this host)\n smtp.mailfrom=vger.kernel.org (client-ip=213.196.21.55;\n helo=ams.mirrors.kernel.org;\n envelope-from=linux-ext4+bounces-13100-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=linux.beauty header.i=me@linux.beauty\n header.b=\"Vngf29Az\"", "smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=136.143.188.112", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux.beauty", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.beauty" ], "Received": [ "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dwQGs6xF9z1xsW\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 20 Jan 2026 22:35:01 +1100 (AEDT)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4dwQGs6TdHz4w8x\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 20 Jan 2026 22:35:01 +1100 (AEDT)", "by gandalf.ozlabs.org (Postfix)\n\tid 4dwQGs6NbFz4wC8; Tue, 20 Jan 2026 22:35:01 +1100 (AEDT)", "from ams.mirrors.kernel.org (ams.mirrors.kernel.org [213.196.21.55])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4dwQGp06BQz4w8x\n\tfor <patchwork-incoming@ozlabs.org>; Tue, 20 Jan 2026 22:34:57 +1100 (AEDT)", "from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ams.mirrors.kernel.org (Postfix) with ESMTPS id 6A7F5608F20\n\tfor <patchwork-incoming@ozlabs.org>; Tue, 20 Jan 2026 11:27:10 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 31AB74219EE;\n\tTue, 20 Jan 2026 11:26:33 +0000 (UTC)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n [136.143.188.112])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 678763DA7E0;\n\tTue, 20 Jan 2026 11:26:31 +0000 (UTC)", "by mx.zohomail.com with SMTPS id 1768908362400491.0950849878243;\n\tTue, 20 Jan 2026 03:26:02 -0800 (PST)" ], "ARC-Seal": [ "i=3; a=rsa-sha256; d=ozlabs.org; s=201707; t=1768908901; cv=pass;\n\tb=aO4H5sp00JJy2yISgjzFIy3nxQR/Acz1ES3YAOLNvWKD6KPzWbOVBNeP/5VSbIN0tePSGV5OtnOnGlcCUp/L9s2JVl0V4kFYAOT6xYJa2xS/bNq+MZBWXZt4XNGIoTEi8OJagCIQibjL15WWCu/vdMClKg8tbZbUjV3iYWmUuUIpfsjAggpiLlDZXybdY+y3ftmsWwNR2fJQPDMwHcU3mk94VzBEP5H+bd3/h83r2wKxR0fVNsxExt3l4aVTpw7bHgfSUtV2tB8WXcyXYGA9WGj8HNqocZjiYQDbSNDazGJqkDFvQ/Lvb0GXwsYMW3fxG9KmfiA4jvt3noerMCYs3w==", "i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1768908392; cv=pass;\n b=OHk/YWZ8ETlPhpiaufCwprVA4q5tTblCx+bwAoYed4Jj9L3HYjuT6cOrXi5y/nqoUQy+fqglEKYVt1ClVrQpB5/LIkuNJb9FPcZOBFtCZuOyKVnSod7Ul08EdWMbRRFVOSN5qlWuq8AE58kiyG+jlDqCWDjeGREv+JDiZ+5xzBw=", "i=1; a=rsa-sha256; t=1768908364; cv=none;\n\td=zohomail.com; s=zohoarc;\n\tb=Mj8Hsu2GN8exqbo2RtPFvNh7SN8VVCXnzLolSypwD7wtVs3lyPaNWSpx+Y93cPhMiyDtjRI9Y+unBgdCiXEuMw+0BL7Gvs2XosxEALOZaU2Jow/ombl/mKRwdhQBUP65RF7Eq8bRj1+8e6AR5wHqCeI4JTCpErjiPXzblu1Wsd0=" ], "ARC-Message-Signature": [ "i=3; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1768908901; c=relaxed/relaxed;\n\tbh=yKejCATUyZqrS6ujYrAGRZE1yOygBj9zrFryy9vTZig=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=gjMmjEaiywNKnm3gpUdoBOKHWYnXPyrL9PQ0h+E+q0BFRNk+wamtaw2fpgL5blaxbWpTYUtTo0mm13INTawSxfqXWyoL8DcSRZRO5yfzuY7c+Ot4yxz5PjoMrdkjakTtOdSBLbE3yPCvtEq9ft+svFbeHy48SO6sLnFV/6iNcenW3TXdIAaEGgWG2gB3TLJ8fVZomLGvjqJr5yHMMkc3EPK8HeBgvSEjUe2Uw9qGptOd/DHshAyPl3vZJsKRVtYDVCbJTZjn091XWg67sMXfRQJC6fyvHEertRuFPy49iElPEYuDdDw0k9I4hK1FwgSghGUzneGgJNlLRXKHhV7tqA==", "i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1768908392; c=relaxed/simple;\n\tbh=+vj3eC7w8HstmJ2wIqkBqSlDqhfIY4teVzWTxaJPezs=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=t9UNeS5bIUmYCA6rAoOFm3rRWDIkTTVjq3GCIoWYWvqHKFfbQDY0hoJg9+ULKpy0mvCipgIjFR4mhjNSgVxfT7yRbRDZt9dn1n+GCr2Q8IlvabDpnwMf/bBPFZPLCsVaJR/SPh6YjE17osx3Am+LMrYSXJvpHPlwkYevrPZ7ujI=", "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc;\n\tt=1768908364;\n h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=yKejCATUyZqrS6ujYrAGRZE1yOygBj9zrFryy9vTZig=;\n\tb=ODgEUfROJzour4MgszzDraBbSZB4mH3T3eVf6AKy8pq10y4/zFzrV2ozAYor7TPmueYWp80b0n58Eb04ggzg9h+1KLGIoj2KuPreo775xCqNIo+sKRLCwy5dSnKIS8ZMZYXLKUZnI+Y1bA3Z2FSlsYOTsHIt77Uk5rA49rW0lwk=" ], "ARC-Authentication-Results": [ "i=3; gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=linux.beauty;\n spf=fail smtp.mailfrom=vger.kernel.org; dkim=pass (1024-bit key;\n unprotected) header.d=linux.beauty header.i=me@linux.beauty\n header.a=rsa-sha256 header.s=zmail header.b=Vngf29Az; dkim-atps=neutral;\n spf=softfail (client-ip=213.196.21.55; helo=ams.mirrors.kernel.org;\n envelope-from=linux-ext4+bounces-13100-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=2; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux.beauty;\n spf=pass smtp.mailfrom=linux.beauty;\n dkim=pass (1024-bit key) header.d=linux.beauty header.i=me@linux.beauty\n header.b=Vngf29Az; arc=pass smtp.client-ip=136.143.188.112", "i=1; mx.zohomail.com;\n\tdkim=pass header.i=linux.beauty;\n\tspf=pass smtp.mailfrom=me@linux.beauty;\n\tdmarc=pass header.from=<me@linux.beauty>" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768908364;\n\ts=zmail; d=linux.beauty; i=me@linux.beauty;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=yKejCATUyZqrS6ujYrAGRZE1yOygBj9zrFryy9vTZig=;\n\tb=Vngf29AztLQso0JJOjN0PPPqUchx8DjCLQV02SYTZ7fC0xCFzusrb5xN44Rq48Rb\n\toxMqLMGoJzx704zGvg9QfVdsnThX0/0u9xEHBNzPxUWRqibEOYhzIL4w2yboxZcgy0p\n\tnts9RslxCme1F9q8/N+zcGugcm+vuv4stPPlMFA4=", "From": "Li Chen <me@linux.beauty>", "To": "Zhang Yi <yi.zhang@huaweicloud.com>,\n\t\"Theodore Ts'o\" <tytso@mit.edu>,\n\tAndreas Dilger <adilger.kernel@dilger.ca>,\n\tlinux-ext4@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org", "Cc": "Li Chen <me@linux.beauty>", "Subject": "[RFC v4 2/7] ext4: lockdep: handle i_data_sem subclassing for special\n inodes", "Date": "Tue, 20 Jan 2026 19:25:31 +0800", "Message-ID": "<20260120112538.132774-3-me@linux.beauty>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260120112538.132774-1-me@linux.beauty>", "References": "<20260120112538.132774-1-me@linux.beauty>", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-ZohoMailClient": "External", "X-Spam-Status": "No, score=-0.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_MISSING,\n\tHEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,\n\tSPF_SOFTFAIL autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "Fast commit can hold s_fc_lock while writing journal blocks. Mapping the\njournal inode can take its i_data_sem. Normal inode update paths can take a\ndata inode i_data_sem and then s_fc_lock, which makes lockdep report a\ncircular dependency.\n\nlockdep treats all i_data_sem instances as one lock class and cannot\ndistinguish the journal inode i_data_sem from a regular inode i_data_sem.\nThe journal inode is not tracked by fast commit and no FC waiters ever\ndepend on it, so this is not a real ABBA deadlock. Assign the journal inode\na dedicated i_data_sem lockdep subclass to avoid the false positive.\n\nInode cache objects can be recycled, so also reset i_data_sem to\nI_DATA_SEM_NORMAL when allocating an ext4 inode. Otherwise a new inode may\ninherit an old subclass (journal/quota/ea) and trigger lockdep warnings.\n\nSigned-off-by: Li Chen <me@linux.beauty>\n---\n fs/ext4/ext4.h | 4 +++-\n fs/ext4/super.c | 8 ++++++++\n 2 files changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h\nindex bd30c24d4f94..2e1681057196 100644\n--- a/fs/ext4/ext4.h\n+++ b/fs/ext4/ext4.h\n@@ -1025,12 +1025,14 @@ do {\t\t\t\t\t\t\t\t\t\t\\\n *\t\t\t than the first\n * I_DATA_SEM_QUOTA - Used for quota inodes only\n * I_DATA_SEM_EA - Used for ea_inodes only\n+ * I_DATA_SEM_JOURNAL - Used for journal inode only\n */\n enum {\n \tI_DATA_SEM_NORMAL = 0,\n \tI_DATA_SEM_OTHER,\n \tI_DATA_SEM_QUOTA,\n-\tI_DATA_SEM_EA\n+\tI_DATA_SEM_EA,\n+\tI_DATA_SEM_JOURNAL\n };\n \n struct ext4_fc_inode_snap;\ndiff --git a/fs/ext4/super.c b/fs/ext4/super.c\nindex 79762c3e0dff..4f5f0c21d436 100644\n--- a/fs/ext4/super.c\n+++ b/fs/ext4/super.c\n@@ -1423,6 +1423,9 @@ static struct inode *ext4_alloc_inode(struct super_block *sb)\n \tINIT_WORK(&ei->i_rsv_conversion_work, ext4_end_io_rsv_work);\n \text4_fc_init_inode(&ei->vfs_inode);\n \tspin_lock_init(&ei->i_fc_lock);\n+#ifdef CONFIG_LOCKDEP\n+\tlockdep_set_subclass(&ei->i_data_sem, I_DATA_SEM_NORMAL);\n+#endif\n \treturn &ei->vfs_inode;\n }\n \n@@ -5863,6 +5866,11 @@ static struct inode *ext4_get_journal_inode(struct super_block *sb,\n \t\treturn ERR_PTR(-EFSCORRUPTED);\n \t}\n \n+#ifdef CONFIG_LOCKDEP\n+\tlockdep_set_subclass(&EXT4_I(journal_inode)->i_data_sem,\n+\t\t\t I_DATA_SEM_JOURNAL);\n+#endif\n+\n \text4_debug(\"Journal inode found at %p: %lld bytes\\n\",\n \t\t journal_inode, journal_inode->i_size);\n \treturn journal_inode;\n", "prefixes": [ "RFC", "v4", "2/7" ] }