Cover Letter Detail
Show a cover letter.
GET /api/1.2/covers/830409/?format=api
{ "id": 830409, "url": "http://patchwork.ozlabs.org/api/1.2/covers/830409/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/cover/1508971954-3567-1-git-send-email-nikolay@cumulusnetworks.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1508971954-3567-1-git-send-email-nikolay@cumulusnetworks.com>", "list_archive_url": null, "date": "2017-10-25T22:52:32", "name": "[net-next,v4,0/2] bridge: make setlink/dellink notifications more accurate", "submitter": { "id": 66448, "url": "http://patchwork.ozlabs.org/api/1.2/people/66448/?format=api", "name": "Nikolay Aleksandrov", "email": "nikolay@cumulusnetworks.com" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/cover/1508971954-3567-1-git-send-email-nikolay@cumulusnetworks.com/mbox/", "series": [ { "id": 10239, "url": "http://patchwork.ozlabs.org/api/1.2/series/10239/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=10239", "date": "2017-10-25T22:52:32", "name": "bridge: make setlink/dellink notifications more accurate", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/10239/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/830409/comments/", "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"EzpsGTpv\"; \n\tdkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yMlmx2YxLz9t3Z\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 26 Oct 2017 09:53:53 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751882AbdJYWxv (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 25 Oct 2017 18:53:51 -0400", "from mail-wr0-f193.google.com ([209.85.128.193]:53569 \"EHLO\n\tmail-wr0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751753AbdJYWxt (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 25 Oct 2017 18:53:49 -0400", "by mail-wr0-f193.google.com with SMTP id u40so1450151wrf.10\n\tfor <netdev@vger.kernel.org>; Wed, 25 Oct 2017 15:53:49 -0700 (PDT)", "from debil.mediahub-bg.com (46-10-142-144.ip.btc-net.bg.\n\t[46.10.142.144]) by smtp.gmail.com with ESMTPSA id\n\tk9sm4393483wrk.88.2017.10.25.15.53.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 25 Oct 2017 15:53:46 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=G970lE9g9LZ3XiS7CgUQUDq5QMrmhrSkS4SJJi0H0GU=;\n\tb=EzpsGTpvCRV8BvwD4++9UFYJQrGwh3MQVKSqqkXRdIJCz+9uDROCC6Z0ScY5S+infD\n\tj5LzqPjeVyHFKFLNt6SpbhEln/wias/h8+HF3ixvNH9r0AIoiKUE/AkR9VPPIW0XGX+a\n\tYCh+eVCzd7ctDBFvg3sioRvrYawy0/IZ0QYB8=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=G970lE9g9LZ3XiS7CgUQUDq5QMrmhrSkS4SJJi0H0GU=;\n\tb=A5/3FJtIJ4eqhQ9Qaua56nXUJCYpZdTlGQ3bplacjhGcJnppcJ9HQOJf+8HrXL9wNV\n\tnCwvMshSROvbU4usy8eqcpE8L13TrkNnc5mMooYTVrpoRmnRFOry7j8c2aM04PaUQZK+\n\tzidi+DKjIIlZS5rbdbSgts4HVNFiTRrwQ3oNJQpzOokZ8XxHikZn3RkMHMxgMuDYWeqg\n\tRIT8gmIOUL6mjKI4CH3qs1JS7VXkRHH7niZxeeHexmsdt+FRB081umq/gOkQ6GGIiPXW\n\t4H3komi4Xq3lDiwBM55YmLK3G4UoxvsBNMsdCGu+8dyqqjgIzuwttDYbtbWCj8iT8Jyw\n\tcRkw==", "X-Gm-Message-State": "AMCzsaUO7rs8ciBZwoX7KKIIpTQWHfSi8rkLRpQIzsVgJWbgfrYvqAI4\n\tQUy9mwL4YOK7Xy3QtZhRru8R/6tZ", "X-Google-Smtp-Source": "ABhQp+Rf0XsJDABjWDolbqO13LShNATCN7/VHOiycANGN93jVBbyHyOLJudm+uvnSVJxpVKaKRpqsA==", "X-Received": "by 10.223.184.140 with SMTP id i12mr3329771wrf.31.1508972028337; \n\tWed, 25 Oct 2017 15:53:48 -0700 (PDT)", "From": "Nikolay Aleksandrov <nikolay@cumulusnetworks.com>", "To": "netdev@vger.kernel.org", "Cc": "dsa@cumulusnetworks.com, mrv@mojatatu.com, davem@davemloft.net,\n\tbridge@lists.linux-foundation.org, roopa@cumulusnetworks.com,\n\tstephen@networkplumber.org,\n\tNikolay Aleksandrov <nikolay@cumulusnetworks.com>", "Subject": "[PATCH net-next v4 0/2] bridge: make setlink/dellink notifications\n\tmore accurate", "Date": "Thu, 26 Oct 2017 01:52:32 +0300", "Message-Id": "<1508971954-3567-1-git-send-email-nikolay@cumulusnetworks.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<f6c0da96-77f0-db19-7a9a-13b246d83d39@cumulusnetworks.com>", "References": "<f6c0da96-77f0-db19-7a9a-13b246d83d39@cumulusnetworks.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Hi,\nBefore this set the bridge would generate a notification on vlan add or del\neven if they didn't actually do any changes, which confuses listeners and\nis generally not preferred. We could also lose notifications on actual\nchanges if one adds a range of vlans and there's an error in the middle.\nThe problem with just breaking and returning an error is that we could\nbreak existing user-space scripts which rely on the vlan delete to clear\nall existing entries in the specified range and ignore the non-existing\nerrors (typically used to clear the current vlan config).\nSo in order to make the notifications more accurate while keeping backwards\ncompatibility we add a boolean that tracks if anything actually changed\nduring the config calls.\n\nThe vlan add is more difficult to fix because it always returns 0 even if\nnothing changed, but we cannot use a specific error because the drivers\ncan return anything and we may mask it, also we'd need to update all places\nthat directly return the add result, thus to signal that a vlan was created\nor updated and in order not to break overlapping vlan range add we pass\ndown the new boolean that tracks changes to the add functions to check\nif anything was actually updated.\n\nv4: set changed always to false in the non-vlan config case and retested\nv3: rebased to latest net-next and fixed non-vlan config functions reported\n by kbuild test bot\nv2: pass changed down to vlan add instead of masking errors\n\nThanks,\n Nik\n\n\nNikolay Aleksandrov (2):\n bridge: netlink: make setlink/dellink notifications more accurate\n bridge: vlan: signal if anything changed on vlan add\n\n net/bridge/br_netlink.c | 51 ++++++++++++++++-----------\n net/bridge/br_netlink_tunnel.c | 14 +++++---\n net/bridge/br_private.h | 14 +++++---\n net/bridge/br_private_tunnel.h | 3 +-\n net/bridge/br_vlan.c | 78 ++++++++++++++++++++++++++++++------------\n 5 files changed, 108 insertions(+), 52 deletions(-)" }