Cover Letter Detail
Show a cover letter.
GET /api/1.2/covers/814774/?format=api
{ "id": 814774, "url": "http://patchwork.ozlabs.org/api/1.2/covers/814774/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/cover/20170918054905.16470-1-andrew@aj.id.au/", "project": { "id": 56, "url": "http://patchwork.ozlabs.org/api/1.2/projects/56/?format=api", "name": "OpenBMC development", "link_name": "openbmc", "list_id": "openbmc.lists.ozlabs.org", "list_email": "openbmc@lists.ozlabs.org", "web_url": "http://github.com/openbmc/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170918054905.16470-1-andrew@aj.id.au>", "list_archive_url": null, "date": "2017-09-18T05:49:01", "name": "[0/4] watchdog: aspeed: Retain enabled state and move to", "submitter": { "id": 68332, "url": "http://patchwork.ozlabs.org/api/1.2/people/68332/?format=api", "name": "Andrew Jeffery", "email": "andrew@aj.id.au" }, "mbox": "http://patchwork.ozlabs.org/project/openbmc/cover/20170918054905.16470-1-andrew@aj.id.au/mbox/", "series": [ { "id": 3562, "url": "http://patchwork.ozlabs.org/api/1.2/series/3562/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/list/?series=3562", "date": "2017-09-18T05:49:01", "name": "watchdog: aspeed: Retain enabled state and move to", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3562/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/814774/comments/", "headers": { "Return-Path": "<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwZsV3pGkz9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 15:52:30 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xwZsV2fFyzDrnb\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 15:52:30 +1000 (AEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xwZpj5NyvzDrZv;\n\tMon, 18 Sep 2017 15:50:05 +1000 (AEST)", "from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 91C8E208A1;\n\tMon, 18 Sep 2017 01:50:02 -0400 (EDT)", "from frontend1 ([10.202.2.160])\n\tby compute4.internal (MEProxy); Mon, 18 Sep 2017 01:50:02 -0400", "from keelia.au.ibm.com (ppp14-2-0-125.bras21.adl4.internode.on.net\n\t[14.2.0.125])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 25F0F7E183;\n\tMon, 18 Sep 2017 01:49:58 -0400 (EDT)" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"LS8iRgDI\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"TnrX+qUD\"; \n\tdkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"LS8iRgDI\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"TnrX+qUD\"; \n\tdkim-atps=neutral", "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=aj.id.au\n\t(client-ip=66.111.4.25; helo=out1-smtp.messagingengine.com;\n\tenvelope-from=andrew@aj.id.au; receiver=<UNKNOWN>)", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"LS8iRgDI\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"TnrX+qUD\"; dkim-atps=neutral" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:date:from:message-id:subject:to:x-me-sender:x-me-sender\n\t:x-sasl-enc:x-sasl-enc; s=fm1; bh=AM4v3BLQsCek5vZhg09F+v5N1Hfwx9\n\tsv/M+tw9K44C8=; b=LS8iRgDIVvrFpy/hB2gfK/DCiRbeJSUOJpKI9RFBVsFdjr\n\tl3xRKPa8TFYch3zbgqHpru+AEnNGE67FncpKQxU2sHFAYf46kNRYNdrWscmi2wjX\n\t4+BXR48bVUGNYD6f6/q1fLlZMIIY+8ojWH8szm3MVeHOKP6BYVa54OEBYZU7I2Xs\n\tZ9Rel0ALozIujKtgbBAOIrynjshqtN69mW06DjTxZVvc8qG2kWGmTg3KjlVz/ICN\n\tZr5n+O4x68QZ7+nbsTkF0Q3G08QdvfWsvq92qv6go0NLDvsznmtVPrtoTaWeX6Dl\n\t1mbB+XBdz9OvZLWrldCnZgc44+jVWrkboUEakh7g==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:message-id:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=AM4v3B\n\tLQsCek5vZhg09F+v5N1Hfwx9sv/M+tw9K44C8=; b=TnrX+qUDYbxMVc24oqXy6N\n\tBYhbDm7LpROcvf98DyL7kuaJRW/aFuf1mY/WriPusv2/A4e2li3hoRwiwO/lOFDU\n\tW1XQxbXRJJ8Zdvg0GW+UxPGAk8bawv2AkurVOmIVMUKNoMoj5Ss7IeNXJQXZjuVL\n\tKxJqzqYmH6snix0H5D88xu7uKgR00Pv/mgRjh7gjmY9I2YKusiNJTLrzem/HmgZz\n\t4AGDHycq2+3YKWsgC2JtB/h76M3SGFsg84ZYZo4YxzU9Znjwxd5xoukIGp9Baz8X\n\tmf9ICWjcQh3hRuKEhZ48cCqqKfTiBI1hArU5m9UCsa+KlDdif1W/TsBffRXbY+tg\n\t==" ], "X-ME-Sender": "<xms:il6_WbrFruhAX0_1H5KctvW0Dvn9s0xFgW8vY3ZGpolWHHY__OMQgw>", "X-Sasl-enc": "7Ig/HjrQR4/JN/YQI8MU/hrN10Et9r2vq9pPgFj5vF0U 1505713801", "From": "Andrew Jeffery <andrew@aj.id.au>", "To": "linux-watchdog@vger.kernel.org", "Subject": "[PATCH 0/4] watchdog: aspeed: Retain enabled state and move to", "Date": "Mon, 18 Sep 2017 15:19:01 +0930", "Message-Id": "<20170918054905.16470-1-andrew@aj.id.au>", "X-Mailer": "git-send-email 2.11.0", "X-BeenThere": "openbmc@lists.ozlabs.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Development list for OpenBMC <openbmc.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/openbmc/>", "List-Post": "<mailto:openbmc@lists.ozlabs.org>", "List-Help": "<mailto:openbmc-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>", "Cc": "ryan_chen@aspeedtech.com, linux-aspeed@lists.ozlabs.org,\n\tAndrew Jeffery <andrew@aj.id.au>, openbmc@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org, wim@iguana.be, linux@roeck-us.net", "Errors-To": "openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"openbmc\"\n\t<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Hello,\n\nWe had reports of Aspeed BMC systems entering a reboot loop, each time\nattempting and failing to probe some PMBus devices. For whatever reason the\nPMBus devices weren't appearing on the I2C bus, and several factors came into\nplay:\n\n1. i2c-aspeed's transfer timeout is set to 5 seconds\n2. The kernel's pmbus core now tests for the presence of the status\n word, then the status byte. Not all devices support the status word,\n therefore on error we fall back to probing the status byte. This leads to\n back-to-back uninterruptible transfers, totalling 10 seconds of delay if the\n device is not present before propagating a probe error back up the call\n chain\n3. The BMC watchdogs are enabled by u-boot to catch a kernel hang\n4. The hardware's default watchdog counter value equates to a 22 second period\n5. The watchdog driver is probed after the I2C subsystem iterates all the\n described devices.\n\nThus as it stands nearly 50% of the watchdog period can be spent dealing with\none missing PMBus device. Arguably the I2C timeout value is too large, but as\nthe watchdog driver is not probed until after the I2C busses are iterated, the\nwork to ping the watchdog cannot even be scheduled to take place between\ntransfers.\n\nPatch 4 shifts aspeed_wdt to arch_initcall so the watchdog can be pinged as\nneeded. Patch 1 fixes an oversight that lead to the watchdogs being disabled\nuntil userspace opened the chardev. The remaining two patches are minor fixes\nto the Kconfig.\n\nPlease review!\n\nCheers,\n\nAndrew\n\nAndrew Jeffery (4):\n watchdog: aspeed: Retain watchdog enabled state\n watchdog: aspeed: Fix 'Apseed' typo in Kconfig\n watchdog: aspeed: Remove specific reference to AST2400 in Kconfig\n watchdog: aspeed: Move init to arch_initcall\n\n drivers/watchdog/Kconfig | 8 +++-----\n drivers/watchdog/aspeed_wdt.c | 16 +++++++++++-----\n 2 files changed, 14 insertions(+), 10 deletions(-)" }