Cover Letter Detail
Show a cover letter.
GET /api/1.2/covers/2234482/?format=api
{ "id": 2234482, "url": "http://patchwork.ozlabs.org/api/1.2/covers/2234482/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/cover/20260507-kerbmi-v3-0-397ebbb53eff@microsoft.com/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/1.2/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260507-kerbmi-v3-0-397ebbb53eff@microsoft.com>", "list_archive_url": null, "date": "2026-05-07T16:52:12", "name": "[v3,0/2] smb: client: Spec-compliance fixes for Kerberos key derivation", "submitter": { "id": 92318, "url": "http://patchwork.ozlabs.org/api/1.2/people/92318/?format=api", "name": "Piyush Sachdeva", "email": "s.piyush1024@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/cover/20260507-kerbmi-v3-0-397ebbb53eff@microsoft.com/mbox/", "series": [ { "id": 503227, "url": "http://patchwork.ozlabs.org/api/1.2/series/503227/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=503227", "date": "2026-05-07T16:52:12", "name": "smb: client: Spec-compliance fixes for Kerberos key derivation", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/503227/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2234482/comments/", "headers": { "Return-Path": "\n <linux-cifs+bounces-11418-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=IZ8vnqbX;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11418-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"IZ8vnqbX\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.43", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBJJS51QPz1yKd\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 02:54:48 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 656083021B93\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 7 May 2026 16:52:30 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8E3FF44CF5F;\n\tThu, 7 May 2026 16:52:24 +0000 (UTC)", "from mail-pj1-f43.google.com (mail-pj1-f43.google.com\n [209.85.216.43])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 208783C661D\n\tfor <linux-cifs@vger.kernel.org>; Thu, 7 May 2026 16:52:23 +0000 (UTC)", "by mail-pj1-f43.google.com with SMTP id\n 98e67ed59e1d1-36608b2f2dcso628589a91.2\n for <linux-cifs@vger.kernel.org>;\n Thu, 07 May 2026 09:52:22 -0700 (PDT)", "from localhost ([49.207.150.30])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-365b4bd67b1sm9638608a91.1.2026.05.07.09.52.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 07 May 2026 09:52:21 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778172744; cv=none;\n b=ecEIYsFFAfvAomOke3mUj8B4TN48WYzNtK4MAokRvIQb35D3E9N9iMXKKtGc+2V/p65IRQzeSgK3kZJpnQJzuW8MvuYjsVnGmGv07prm/jQrAo0fuDCXWK+O+5ORuy4npy1hyG6omZzFOoLaD3/8at/i5NJXYWKP6Dqj0580ATY=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778172744; c=relaxed/simple;\n\tbh=QhvtuPuYuRikxrXlvfGt1GYpisVF2O1XfkkjalC53Gw=;\n\th=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc;\n b=SchTgqI29oJ+TjKB0/jxOKGWXVaMjMgQ7d+slW0/oJ/pwjSlNzgH6CHig0o9TRsOAAz84QcqiaOGnCIHFbT44n8PeId0O7LLUE8AYaN7Do3AjW/q59LusNBLknkgWfOFKJHsd9ZlFh2u1i6HxYU97wgoJkGySZankaZxmbLIzH0=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=IZ8vnqbX; arc=none smtp.client-ip=209.85.216.43", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778172742; x=1778777542;\n darn=vger.kernel.org;\n h=cc:to:content-transfer-encoding:mime-version:message-id:date\n :subject:from:from:to:cc:subject:date:message-id:reply-to;\n bh=gHS86kLfvSZEt6u0DRNxMP3AK+yT0cLfftthW3UK2M0=;\n b=IZ8vnqbX0ySDjCyZnYCi2oTYizpZSy/rVnU90FHeNnXCe/lG4H5VguUR5szRgmVgnn\n hOI55m1zbS7oJMLKoKeD5HQRxElDZgU3TPDjDfdZTgKIWV8d5Ryuj/8k+5YxhxyV5rZi\n kPLSokG9f3YNwpKfrrldIUtgixlmT/8s0FScal0JniyqyrkWd8iTp0I5Z0hd1vZo5txc\n JhP1XByDbBoH3tzyjwpBv+nQW66tIzxjWZ/cMekvkuwQ2saiOdYAWF126Ko3Vv39Kk40\n Gf+ygIXEWk7xdvXlGUPQb9QV972j5vx+b/3DWMPVafy1RM3YIWYaEn9d4ms9O44jEfed\n lERw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778172742; x=1778777542;\n h=cc:to:content-transfer-encoding:mime-version:message-id:date\n :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=gHS86kLfvSZEt6u0DRNxMP3AK+yT0cLfftthW3UK2M0=;\n b=AuGM0MI54Iw+d+E6Tvxwgu937tCBdyJ0KKZkBcLBk6oWiQqvzvpu2R6iaEBS2M1+l1\n 0Ncwn+ruZmuVJq/cTRyETcfjyjwn9ynLIUeFI1hX+6vPVyqmve5qYZrfWYq5knnTnJQ3\n Ut0H+DooBNPvXe0mtCfC7TSdHVRdNkQSiV/aOkFJ0OyxVh3GUI/URtX26FV5cKNwWDLb\n f624VixcbdKywiq/Nef2KCwrhizP7HZJA5RpmGzjc6qPPP00XRPQ8SD7ZNwl+E2WvgwL\n R3JTFzIS+tD7U847a7xFoHZItvgKne0pwtsup1MwpdG/XeEy+sElQyn2P2sF+akE2vcw\n jnwQ==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ+CaOuU6ncThTm2MDufoeeNFQRgJzVbgHNTsiPrQPrjacu2/Jn17l9Cvs400InhQdbgfw0uqA5fyTDO@vger.kernel.org", "X-Gm-Message-State": "AOJu0Yydv+bj2SEj9bjkjx64IMN8nqk+1GChKtLaXGELUm/oNWgpd3K6\n\tunJYFlWr9JAnZRtcgtvqwkcK7AbUEszYJAfQ/KTd/8jJcaSU9Slx7iug", "X-Gm-Gg": "AeBDies7lMNJSxdWI6pJJ9WIb7pYWK/5zQBUnX2lp4lXqqqwjnfDA6g9NhUAFnLKGmF\n\t2t14KgWiZHadBt9HG9ksF4vO9yVC4ETqYOkYJLoCmaZeYMHIubvqzM4uNdQFkvtm2oWUnBpgkMk\n\tLWjJtziCPls2AHq9ke8nQkFebUeGRC9FSv93wtTdTnwrnGrowurF6YQXW9F43OrG+77FtG5rU+p\n\tL1P05ROn/yIIxr37J2/R2dd+jOq/4iT5/A46JSXk5+7LM0kDLZ/zPTRd9kDTwvDedHol65pauxy\n\tV1uEb0P969lN7yguA6RO944EPPY5d/blMb8uglSkk+4M4u8NrQTWk1h0KJUyqcJRSF+caCZRzTc\n\tJ3lw2VZACdtbi571u5Ot1fuUT0UjzOIrYEcSkhyleDcbhxvFpu1usqDUeBvV7lUzuisDgV+H0zO\n\teBHF4txmS/YwcpmuuKfjYxSZ/MYcYYXgzl+e/Z8hnYH7oOfJCOTg==", "X-Received": "by 2002:a17:90b:3ecd:b0:366:3517:1a98 with SMTP id\n 98e67ed59e1d1-36635171b07mr1354381a91.0.1778172742408;\n Thu, 07 May 2026 09:52:22 -0700 (PDT)", "From": "Piyush Sachdeva <s.piyush1024@gmail.com>", "X-Google-Original-From": "Piyush Sachdeva <psachdeva@microsoft.com>", "Subject": "[PATCH v3 0/2] smb: client: Spec-compliance fixes for Kerberos key\n derivation", "Date": "Thu, 07 May 2026 22:22:12 +0530", "Message-Id": "<20260507-kerbmi-v3-0-397ebbb53eff@microsoft.com>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-B4-Tracking": "v=1; b=H4sIAAAAAAAC/zWNQQ6CMBBFr0JmbU0zFQOuvIdhYYepjAZKWiQa0\n rtbUJcvef/9BSIH4QinYoHAs0TxQwazK4C663BjJW1mQI1HfcBaPTjYXlRLuioNtVg7giyPgZ2\n 8ttCl+XJ82jvTtK5Xo5M4+fDenmZcvV/U6H90RqWVtnXlGMv8Vp57oeCjd9OefA9NSukDAbn91\n LIAAAA=", "X-Change-ID": "20260429-kerbmi-dc0853cd29fc", "To": "Steve French <sfrench@samba.org>, linux-cifs@vger.kernel.org,\n Shyam Prasad N <sprasad@microsoft.com>,\n Bharath SM <bharathsm@microsoft.com>, Paulo Alcantara <pc@manguebit.org>,\n Ronnie Sahlberg <ronniesahlberg@gmail.com>, Tom Talpey <tom@talpey.com>", "Cc": "samba-technical@lists.samba.org, linux-kernel@vger.kernel.org,\n stable@vger.kernel.org, vaibsharma@microsoft.com", "X-Mailer": "b4 0.15.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3196;\n i=psachdeva@microsoft.com; h=from:subject:message-id;\n bh=QhvtuPuYuRikxrXlvfGt1GYpisVF2O1XfkkjalC53Gw=;\n b=owGbwMvMwCV29FJ3ncRHDT/G02pJDJl/Djt29ets/C4cHbakV6Ptv5ByCLPywWLreA9z4eML9\n KJebz7dMZGFQYyLwVJMkWXDiTuyvPG7JOd9emIEM4eVCWSItEgDAxCwMPDlJuaVGukY6ZlqG+oZ\n GukY6BgzcHEKwFRrTGJkmL5nbW9+q87HpdH5Gr17C1T+v/k2eTlbEKfbJwt7td2rtzEynKn8cSI\n rwac1bWFr6Oy59+Q9pi9UZUgVfyW3hnt6NIc6IwA=", "X-Developer-Key": "i=psachdeva@microsoft.com; a=openpgp;\n fpr=80350F71F916134953C3EB979E19C6F9839C3CFC" }, "content": "This series fixes two MS-SMB2 section 3.2.5.3 spec violations in the\nKerberos session key handling path of fs/smb/client.\n\nPatch 1/2 (resend of v1 with a small cleanup folded in) fixes the\nAES-256 mount failure with sec=krb5: encryption and decryption key\nderivation must use Session.FullSessionKey (the full Kerberos session\nkey, typically 32 bytes for the aes256-cts-hmac-sha1-96 enctype)\ninstead of Session.SessionKey (the first 16 bytes).\n\nPatch 2/2 closes the related corner case in the same section of the\nspec: when the GSS protocol returns a session key shorter than 16\nbytes, the buffer must be right-padded with zero bytes. The current\ncode copies the GSS key verbatim, which causes generate_key() to read\npast the end of the allocated buffer and derive keys that do not match\nthe server. The trigger is deprecated short-key Kerberos enctypes\n(e.g. single-DES, 8-byte session key); modern KDCs disable these by\ndefault, so this is a latent issue rather than a reachable one, but it\nis still a kernel slab over-read and a literal spec violation.\n\nVerified against Azure Files (AES-256-GCM + Kerberos aes256-cts) which\npreviously failed to mount with EAGAIN; the dmesg \"Session Key\" trace\nunder CONFIG_CIFS_DEBUG_DUMP_KEYS now shows the full 32-byte session\nkey being used for encryption/decryption KDF input.\n\nLink: https://lore.kernel.org/linux-cifs/20260409161538.3618-1-s.piyush1024@gmail.com/\n\nChanges since v2:\n - Patch 1/2: cast ses->auth_key.len to int when used as field width\n for \"%*ph\" in the CONFIG_CIFS_DEBUG_DUMP_KEYS dump, fixing a\n -Wformat warning. Reported by Sashiko.\n\nChanges since v1:\n - Patch 1/2: initialize full_key_size at declaration to silence\n -Wmaybe-uninitialized on some toolchains, and drop the now-\n redundant else branch (self-review).\n - Patch 1/2: tighten the FullSessionKey condition to also require\n Connection.Dialect == \"3.1.1\", matching MS-SMB2 3.2.5.3.1 verbatim.\n - New patch 2/2: zero-pad short GSS session keys per MS-SMB2 3.2.5.3,\n eliminating a latent slab over-read in generate_key().\n\nSigned-off-by: Piyush Sachdeva <psachdeva@microsoft.com>\nSigned-off-by: Piyush Sachdeva <s.piyush1024@gmail.com>\n---\nTo: Steve French <sfrench@samba.org>\nTo: Paulo Alcantara <pc@manguebit.org>\nTo: Ronnie Sahlberg <ronniesahlberg@gmail.com>\nTo: Shyam Prasad N <sprasad@microsoft.com>\nTo: Tom Talpey <tom@talpey.com>\nTo: Bharath SM <bharathsm@microsoft.com>\nCc: linux-cifs@vger.kernel.org\nCc: stable@vger.kernel.org\nCc: samba-technical@lists.samba.org\nCc: linux-kernel@vger.kernel.org\nCc: vaibsharma@microsoft.com\n\n---\nPiyush Sachdeva (2):\n smb: client: Use FullSessionKey for AES-256 encryption key derivation\n smb: client: Zero-pad short GSS session keys per MS-SMB2\n\n fs/smb/client/ioctl.c | 2 +-\n fs/smb/client/smb2pdu.c | 23 ++++++++++++++++++-----\n fs/smb/client/smb2transport.c | 35 ++++++++++++++++++++++++++---------\n 3 files changed, 45 insertions(+), 15 deletions(-)\n---\nbase-commit: 0cbc300257d9b399491909806777f504ec687c1d\nchange-id: 20260429-kerbmi-dc0853cd29fc\n\nBest regards,\n-- \nPiyush Sachdeva <s.piyush1024@gmail.com>" }