Cover Letter Detail
Show a cover letter.
GET /api/1.2/covers/2233994/?format=api
{ "id": 2233994, "url": "http://patchwork.ozlabs.org/api/1.2/covers/2233994/?format=api", "web_url": "http://patchwork.ozlabs.org/project/fwts/cover/20260507065638.2809947-1-thuth@redhat.com/", "project": { "id": 24, "url": "http://patchwork.ozlabs.org/api/1.2/projects/24/?format=api", "name": "Firmware Test Suite development", "link_name": "fwts", "list_id": "fwts-devel.lists.ubuntu.com", "list_email": "fwts-devel@lists.ubuntu.com", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260507065638.2809947-1-thuth@redhat.com>", "list_archive_url": null, "date": "2026-05-07T06:56:35", "name": "[0/3] Fix compiler warnings with GCC v16", "submitter": { "id": 66152, "url": "http://patchwork.ozlabs.org/api/1.2/people/66152/?format=api", "name": "Thomas Huth", "email": "thuth@redhat.com" }, "mbox": "http://patchwork.ozlabs.org/project/fwts/cover/20260507065638.2809947-1-thuth@redhat.com/mbox/", "series": [ { "id": 503112, "url": "http://patchwork.ozlabs.org/api/1.2/series/503112/?format=api", "web_url": "http://patchwork.ozlabs.org/project/fwts/list/?series=503112", "date": "2026-05-07T06:56:35", "name": "Fix compiler warnings with GCC v16", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/503112/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2233994/comments/", "headers": { "Return-Path": "<fwts-devel-bounces@lists.ubuntu.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=YTs75oQP;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=fwts-devel-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)" ], "X-Greylist": "delayed 1001 seconds by postgrey-1.37 at legolas;\n Thu, 07 May 2026 17:13:35 AEST", "Received": [ "from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gB3Pq1Mz0z1yKd\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 07 May 2026 17:13:34 +1000 (AEST)", "from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from <fwts-devel-bounces@lists.ubuntu.com>)\n\tid 1wKsf9-0006DD-6U; Thu, 07 May 2026 06:56:47 +0000", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by lists.ubuntu.com with esmtp (Exim 4.86_2)\n (envelope-from <thuth@redhat.com>) id 1wKsf7-0006D2-Qi\n for fwts-devel@lists.ubuntu.com; Thu, 07 May 2026 06:56:45 +0000", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-_5dcyylSN02Oz4YvTFsrZQ-1; Thu,\n 07 May 2026 02:56:42 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 93272180047F\n for <fwts-devel@lists.ubuntu.com>; Thu, 7 May 2026 06:56:41 +0000 (UTC)", "from thuth-p1g4.redhat.com (unknown [10.44.48.97])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 6C8C21801A63\n for <fwts-devel@lists.ubuntu.com>; Thu, 7 May 2026 06:56:39 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1778137004;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=mqGEixZYgnMz6df1oJP4AjL4C1M/gk1ZIaHfrj9v95c=;\n b=YTs75oQPYQrRUkhqkgrIoTVIU0epofqIF/6jkQvUvkRwq84d50jrKK+AZVjOB0CmIJoB+I\n ArZTx4pClyYj/Y4ij1rcVv2CQfw+AbfOO0BAxb70E5gZ/MDP0mXo7aCLOUY1QS0t/jBo3C\n GMyoBHdYcKo+MPbpk9TbrfPiEUaekmk=", "X-MC-Unique": "_5dcyylSN02Oz4YvTFsrZQ-1", "X-Mimecast-MFC-AGG-ID": "_5dcyylSN02Oz4YvTFsrZQ_1778137001", "From": "Thomas Huth <thuth@redhat.com>", "To": "fwts-devel@lists.ubuntu.com", "Subject": "[PATCH 0/3] Fix compiler warnings with GCC v16", "Date": "Thu, 7 May 2026 08:56:35 +0200", "Message-ID": "<20260507065638.2809947-1-thuth@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "3AGpKdTbSoqHm5WN7pv1yYA9FeSdl5vbTMQiHE_k_P8_1778137001", "X-Mimecast-Originator": "redhat.com", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-BeenThere": "fwts-devel@lists.ubuntu.com", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Firmware Test Suite Development <fwts-devel.lists.ubuntu.com>", "List-Unsubscribe": "<https://lists.ubuntu.com/mailman/options/fwts-devel>,\n <mailto:fwts-devel-request@lists.ubuntu.com?subject=unsubscribe>", "List-Archive": "<https://lists.ubuntu.com/archives/fwts-devel>", "List-Post": "<mailto:fwts-devel@lists.ubuntu.com>", "List-Help": "<mailto:fwts-devel-request@lists.ubuntu.com?subject=help>", "List-Subscribe": "<https://lists.ubuntu.com/mailman/listinfo/fwts-devel>,\n <mailto:fwts-devel-request@lists.ubuntu.com?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "fwts-devel-bounces@lists.ubuntu.com", "Sender": "\"fwts-devel\" <fwts-devel-bounces@lists.ubuntu.com>" }, "content": "Hi!\n\nCompiling fwts currently does not work with GCC v16 (e.g. on Fedora),\nsince the compiler emits some new warnings about unused variables,\nand -Werror is enabled by default. Remove these unused variables to\nfix the problems.\n\n Regards,\n Thomas\n\n\nPS: I initially opened https://github.com/fwts/fwts/pull/36 first\nbefore I spotted a comment in some other PR that patches should be\nsent to the mailing list ... Could you maybe add some easy-to-discover\ninstructions in (either in the README or in the project description at\nsourceforge) for new contributors like me to avoid this this confusion?\nThanks!\n\n\nThomas Huth (3):\n fwts_args: Silence compiler warning about unused \"master_option_index\"\n lib: framework: Remove unused variable to avoid compiler warning\n acpi: hest: Remove unused variable to avoid compiler warning\n\n src/acpi/hest/hest.c | 4 +---\n src/lib/src/fwts_args.c | 4 ----\n src/lib/src/fwts_framework.c | 2 --\n 3 files changed, 1 insertion(+), 9 deletions(-)" }