Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2233417/?format=api
{ "id": 2233417, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2233417/?format=api", "web_url": "http://patchwork.ozlabs.org/project/sparclinux/patch/20260506121606.5805-3-john.ogness@linutronix.de/", "project": { "id": 10, "url": "http://patchwork.ozlabs.org/api/1.1/projects/10/?format=api", "name": "Linux SPARC Development ", "link_name": "sparclinux", "list_id": "sparclinux.vger.kernel.org", "list_email": "sparclinux@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260506121606.5805-3-john.ogness@linutronix.de>", "date": "2026-05-06T12:15:57", "name": "[tty,v4,2/6] serial: Replace driver usage of UPF_CONS_FLOW", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2095e78160fcb32915ca00464d90cbb33dcc226c", "submitter": { "id": 207, "url": "http://patchwork.ozlabs.org/api/1.1/people/207/?format=api", "name": "John Ogness", "email": "john.ogness@linutronix.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/sparclinux/patch/20260506121606.5805-3-john.ogness@linutronix.de/mbox/", "series": [ { "id": 502977, "url": "http://patchwork.ozlabs.org/api/1.1/series/502977/?format=api", "web_url": "http://patchwork.ozlabs.org/project/sparclinux/list/?series=502977", "date": "2026-05-06T12:15:55", "name": "8250: Add console flow control", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/502977/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2233417/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2233417/checks/", "tags": {}, "headers": { "Return-Path": "\n <SRS0=PYFl=DD=vger.kernel.org=sparclinux+bounces-6761-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "sparclinux@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256\n header.s=2020 header.b=xFWnkskh;\n\tdkim=pass header.d=linutronix.de header.i=@linutronix.de\n header.a=ed25519-sha256 header.s=2020e header.b=gbuMKKHK;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=pyfl=dd=vger.kernel.org=sparclinux+bounces-6761-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c0a:e001:db::12fc:5321\"\n arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linutronix.de", "gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256\n header.s=2020 header.b=xFWnkskh;\n\tdkim=pass header.d=linutronix.de header.i=@linutronix.de\n header.a=ed25519-sha256 header.s=2020e header.b=gbuMKKHK;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=sparclinux+bounces-6761-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de\n header.b=\"xFWnkskh\";\n\tdkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de\n header.b=\"gbuMKKHK\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=193.142.43.55", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linutronix.de", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linutronix.de" ], "Received": [ "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9ZFr4MJjz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 22:20:00 +1000 (AEST)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4g9ZFr4BTCz4w9g\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 22:20:00 +1000 (AEST)", "by gandalf.ozlabs.org (Postfix)\n\tid 4g9ZFr45Zdz4wL2; Wed, 06 May 2026 22:20:00 +1000 (AEST)", "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4g9ZFn17TZz4w9g\n\tfor <patchwork-incoming@ozlabs.org>; Wed, 06 May 2026 22:19:57 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 5C282305B453\n\tfor <patchwork-incoming@ozlabs.org>; Wed, 6 May 2026 12:16:12 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 245A63E3DB9;\n\tWed, 6 May 2026 12:16:11 +0000 (UTC)", "from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F00E441033;\n\tWed, 6 May 2026 12:16:09 +0000 (UTC)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1778070000; cv=pass;\n\tb=l3wgfO9gydBrUKEEwA/gX1TdSQN7YmVxCs2ZWDfl67pvh+1iC0VuSjr6yFk4oFkPC6lZ8MftyvyxHm7MhcAZNPP9tCq8bQI3vH0D8IpluAvUwhRixAiNnPxt1MYKcwv8jfgelTzxiAOR8ts24W1GIRPaPj1RqXaxAQHEZI+jg2ZukDVuBUcAcvjUyVlGTbdIctvjJISTOv6LUAVS5mgfL8LL/EDYMl+PQTOjU4ooj48+/pjEc9tD9um0jnH4jk7d3TvHZM3P6G/2CGkmgxqzdlYTWBm7iHomP6RWHqjZyAmtzHFJYuxUVp1/dv5dNmCBPY3lFY6056qt8h9zTrPIOw==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778069771; cv=none;\n b=mroLRdhq4riAaRRm5L2aaH0fsSjbbPGs4x6wRnscQtvPodPI4AR9Y6Sul96e9r70+FtEiZ7dfe8tiE0sQXNBQOL6OWYgHnqtQrjMAyZPRJazFfmRwkMyDLzPZh1XYEvUxlmLbHrKXk8kXhSAvAZD5xMf71CiZ87DJ2hQGaoBoqg=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1778070000; c=relaxed/relaxed;\n\tbh=vE7RdfFrv3z5SE91ZG6pmeFTFDF5vNPcNpZ+sQ+T1TI=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=vfmZrT23YF6cDB6QdF6hX4mYNoF4b4dDuUE2NEEmYvzpez0nfm1zgzv0QTCo6zh0pFJNBWWCZ2LU0o7Ow76Eofen+ok2gz7IJSHuiHshD02NnOz3WvYjg77K1WZYDYk6MbHl9vSpTM4tZWniK55GE4tSip53yK6Q2F6of4TJeNWU7ElLE50EYrHfmBrL5eZ7rqXFadb+mdH9AfNs773hTBTntsDP66Rj65pByWx3WDdfXaKm7jkXvt/+e9UTvTvjhJQPbYf4GKdH+jhuvJJ7QUaTVd3JXyqehr7hsBE+ONKCMbzomsXs+gIonIzshj0ETrUbsqzDaR9qjTLrreoIjQ==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778069771; c=relaxed/simple;\n\tbh=oGdnYzwS2KxBBPOTkydJBt0oLCQIbgX6je1aQYE6Afo=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=AJVBrWuqGibX7oi70CJE+dcirs9A0Ufx+aTr1bATT0zMAWLILHjrb+grZLFzw/EQOOJJiAky0V7PZNacDtonUR/CWQ7nlUUpn2Zs8nDqQrZRvRVP3YuxeZ4LPARUMM7ZOPXsvvPVq84x2zkakclLqgNVkSt+mPsk8lk+tZYcahM=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linutronix.de;\n dkim=pass (2048-bit key;\n secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256\n header.s=2020 header.b=xFWnkskh;\n dkim=pass header.d=linutronix.de header.i=@linutronix.de\n header.a=ed25519-sha256 header.s=2020e header.b=gbuMKKHK; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=sparclinux+bounces-6761-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linutronix.de;\n spf=pass smtp.mailfrom=linutronix.de;\n dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de\n header.b=xFWnkskh;\n dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de\n header.b=gbuMKKHK; arc=none smtp.client-ip=193.142.43.55" ], "From": "John Ogness <john.ogness@linutronix.de>", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;\n\ts=2020; t=1778069768;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=vE7RdfFrv3z5SE91ZG6pmeFTFDF5vNPcNpZ+sQ+T1TI=;\n\tb=xFWnkskhPGgbQOkrcHPHBsstkhAM00sSjLFAeRB7VzAGCrQd59JlHjM9TCgWEEmGIKRJ7/\n\tk2bYdKFleAMOKjMHNIcEOl/uTVR6/5zhe5UfT+ah4SV/9UC470291f5Cy/OCazslWDWX3V\n\txI6AOJHY9Vb5Z2Lp18gttQNdO12+m3FCXz6EmHkgsFQUYkycZ8y3QKUZ5oZcfRs2vDSzmj\n\tYmuN2wQMvqAVxj4MMcrOqjRtJ2ArZt9u3FxssTpjJjUKGlc5XPAzpreqPcNTFrUBhU7jHQ\n\tYG0pjdXUpioFaEKxBXJ8HfUjc7XqkwLCAtnbUgsUvojn6RE1WMGAdJ0N6g3NbA==", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;\n\ts=2020e; t=1778069768;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=vE7RdfFrv3z5SE91ZG6pmeFTFDF5vNPcNpZ+sQ+T1TI=;\n\tb=gbuMKKHK9iOhMyI9k4nDA6P3GImdUXN5z+ClLWkNQ4asJJ6vbp9KZQCLfDC7BZWxClqLI0\n\tb8SM7ivQMkIu1fDQ==" ], "To": "\"Greg Kroah-Hartman\" <gregkh@linuxfoundation.org>,\n\tJiri Slaby <jirislaby@kernel.org>", "Cc": "Andy Shevchenko <andy.shevchenko@gmail.com>, linux-kernel@vger.kernel.org,\n Krzysztof Kozlowski <krzk@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>,\n \"David S. Miller\" <davem@davemloft.net>,\n =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n Andy Shevchenko <andriy.shevchenko@linux.intel.com>,\n Thomas Fourier <fourier.thomas@gmail.com>, Kees Cook <kees@kernel.org>,\n linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n linux-samsung-soc@vger.kernel.org, sparclinux@vger.kernel.org", "Subject": "[PATCH tty v4 2/6] serial: Replace driver usage of UPF_CONS_FLOW", "Date": "Wed, 6 May 2026 14:21:57 +0206", "Message-ID": "<20260506121606.5805-3-john.ogness@linutronix.de>", "In-Reply-To": "<20260506121606.5805-1-john.ogness@linutronix.de>", "References": "<20260506121606.5805-1-john.ogness@linutronix.de>", "Precedence": "bulk", "X-Mailing-List": "sparclinux@vger.kernel.org", "List-Id": "<sparclinux.vger.kernel.org>", "List-Subscribe": "<mailto:sparclinux+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:sparclinux+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tHEADER_FROM_DIFFERENT_DOMAINS,INVALID_DATE_TZ_ABSURD,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "Rather than using the UPF_CONS_FLOW bit of uart_port.flags to track\nthe user configuration of console flow control, use the newly added\nuart_port.cons_flow (via its getter/setter functions).\n\nA coccinelle script was used to perform the search/replace.\n\nNote1: The sh-sci driver is blindly copying platform data configuration\n flags to uart_port.flags. Thus UPF_CONS_FLOW could get set for\n uart_port.flags. A follow-up commit will address this.\n\nNote2: The samsung_tty driver is using UPF_CONS_FLOW as a platform data\n configuration flag. However, the driver explicitly checks for\n this configuration flag and thus setting UPF_CONS_FLOW in\n uart_port.flags is avoided.\n\nSigned-off-by: John Ogness <john.ogness@linutronix.de>\n---\n drivers/tty/serial/8250/8250_port.c | 4 ++--\n drivers/tty/serial/bcm63xx_uart.c | 2 +-\n drivers/tty/serial/omap-serial.c | 2 +-\n drivers/tty/serial/pch_uart.c | 2 +-\n drivers/tty/serial/pxa.c | 2 +-\n drivers/tty/serial/samsung_tty.c | 8 ++++----\n drivers/tty/serial/serial_txx9.c | 4 ++--\n drivers/tty/serial/sunsu.c | 2 +-\n 8 files changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c\nindex af78cc02f38e7..dbed5e5767541 100644\n--- a/drivers/tty/serial/8250/8250_port.c\n+++ b/drivers/tty/serial/8250/8250_port.c\n@@ -1988,7 +1988,7 @@ static void wait_for_xmitr(struct uart_8250_port *up, int bits)\n \twait_for_lsr(up, bits);\n \n \t/* Wait up to 1s for flow control if necessary */\n-\tif (up->port.flags & UPF_CONS_FLOW) {\n+\tif (uart_cons_flow_enabled(&up->port)) {\n \t\tfor (tmout = 1000000; tmout; tmout--) {\n \t\t\tunsigned int msr = serial_in(up, UART_MSR);\n \t\t\tup->msr_saved_flags |= msr & MSR_SAVE_FLAGS;\n@@ -3351,7 +3351,7 @@ void serial8250_console_write(struct uart_8250_port *up, const char *s,\n \t\t * it regardless of the CTS state. Therefore, only use fifo\n \t\t * if we don't use control flow.\n \t\t */\n-\t\t!(up->port.flags & UPF_CONS_FLOW);\n+\t\t!uart_cons_flow_enabled(&up->port);\n \n \tif (likely(use_fifo))\n \t\tserial8250_console_fifo_write(up, s, count);\ndiff --git a/drivers/tty/serial/bcm63xx_uart.c b/drivers/tty/serial/bcm63xx_uart.c\nindex 51df9d2d8bfc5..544695cb184c3 100644\n--- a/drivers/tty/serial/bcm63xx_uart.c\n+++ b/drivers/tty/serial/bcm63xx_uart.c\n@@ -675,7 +675,7 @@ static void wait_for_xmitr(struct uart_port *port)\n \t}\n \n \t/* Wait up to 1s for flow control if necessary */\n-\tif (port->flags & UPF_CONS_FLOW) {\n+\tif (uart_cons_flow_enabled(port)) {\n \t\ttmout = 1000000;\n \t\twhile (--tmout) {\n \t\t\tunsigned int val;\ndiff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c\nindex 0b85f47ff19e0..a689d190940cf 100644\n--- a/drivers/tty/serial/omap-serial.c\n+++ b/drivers/tty/serial/omap-serial.c\n@@ -1092,7 +1092,7 @@ static void __maybe_unused wait_for_xmitr(struct uart_omap_port *up)\n \t} while (!uart_lsr_tx_empty(status));\n \n \t/* Wait up to 1s for flow control if necessary */\n-\tif (up->port.flags & UPF_CONS_FLOW) {\n+\tif (uart_cons_flow_enabled(&up->port)) {\n \t\tfor (tmout = 1000000; tmout; tmout--) {\n \t\t\tunsigned int msr = serial_in(up, UART_MSR);\n \ndiff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c\nindex 6729d8e83c3c5..2f72cd62e2488 100644\n--- a/drivers/tty/serial/pch_uart.c\n+++ b/drivers/tty/serial/pch_uart.c\n@@ -1444,7 +1444,7 @@ static void wait_for_xmitr(struct eg20t_port *up, int bits)\n \t}\n \n \t/* Wait up to 1s for flow control if necessary */\n-\tif (up->port.flags & UPF_CONS_FLOW) {\n+\tif (uart_cons_flow_enabled(&up->port)) {\n \t\tunsigned int tmout;\n \t\tfor (tmout = 1000000; tmout; tmout--) {\n \t\t\tunsigned int msr = ioread8(up->membase + UART_MSR);\ndiff --git a/drivers/tty/serial/pxa.c b/drivers/tty/serial/pxa.c\nindex fea0255067ccd..10fc8990579b5 100644\n--- a/drivers/tty/serial/pxa.c\n+++ b/drivers/tty/serial/pxa.c\n@@ -573,7 +573,7 @@ static void wait_for_xmitr(struct uart_pxa_port *up)\n \t} while (!uart_lsr_tx_empty(status));\n \n \t/* Wait up to 1s for flow control if necessary */\n-\tif (up->port.flags & UPF_CONS_FLOW) {\n+\tif (uart_cons_flow_enabled(&up->port)) {\n \t\ttmout = 1000000;\n \t\twhile (--tmout &&\n \t\t ((serial_in(up, UART_MSR) & UART_MSR_CTS) == 0))\ndiff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c\nindex e27806bf2cf3e..2f94fc798cffb 100644\n--- a/drivers/tty/serial/samsung_tty.c\n+++ b/drivers/tty/serial/samsung_tty.c\n@@ -319,7 +319,7 @@ static void s3c24xx_serial_stop_tx(struct uart_port *port)\n \tourport->tx_enabled = 0;\n \tourport->tx_in_progress = 0;\n \n-\tif (port->flags & UPF_CONS_FLOW)\n+\tif (uart_cons_flow_enabled(port))\n \t\ts3c24xx_serial_rx_enable(port);\n \n \tourport->tx_mode = 0;\n@@ -493,7 +493,7 @@ static void s3c24xx_serial_start_tx(struct uart_port *port)\n \tstruct tty_port *tport = &port->state->port;\n \n \tif (!ourport->tx_enabled) {\n-\t\tif (port->flags & UPF_CONS_FLOW)\n+\t\tif (uart_cons_flow_enabled(port))\n \t\t\ts3c24xx_serial_rx_disable(port);\n \n \t\tourport->tx_enabled = 1;\n@@ -781,7 +781,7 @@ static void s3c24xx_serial_rx_drain_fifo(struct s3c24xx_uart_port *ourport)\n \t\tuerstat = rd_regl(port, S3C2410_UERSTAT);\n \t\tch = rd_reg(port, S3C2410_URXH);\n \n-\t\tif (port->flags & UPF_CONS_FLOW) {\n+\t\tif (uart_cons_flow_enabled(port)) {\n \t\t\tbool txe = s3c24xx_serial_txempty_nofifo(port);\n \n \t\t\tif (ourport->rx_enabled) {\n@@ -1830,7 +1830,7 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport,\n \n \tif (cfg->uart_flags & UPF_CONS_FLOW) {\n \t\tdev_dbg(port->dev, \"enabling flow control\\n\");\n-\t\tport->flags |= UPF_CONS_FLOW;\n+\t\tuart_set_cons_flow_enabled(port, true);\n \t}\n \n \t/* sort our the physical and virtual addresses for each UART */\ndiff --git a/drivers/tty/serial/serial_txx9.c b/drivers/tty/serial/serial_txx9.c\nindex 436a559234dfe..4ae9a45c8e3a3 100644\n--- a/drivers/tty/serial/serial_txx9.c\n+++ b/drivers/tty/serial/serial_txx9.c\n@@ -422,7 +422,7 @@ static void wait_for_xmitr(struct uart_port *up)\n \t\tudelay(1);\n \n \t/* Wait up to 1s for flow control if necessary */\n-\tif (up->flags & UPF_CONS_FLOW) {\n+\tif (uart_cons_flow_enabled(up)) {\n \t\ttmout = 1000000;\n \t\twhile (--tmout &&\n \t\t (sio_in(up, TXX9_SICISR) & TXX9_SICISR_CTSS))\n@@ -857,7 +857,7 @@ serial_txx9_console_write(struct console *co, const char *s, unsigned int count)\n \t *\tDisable flow-control if enabled (and unnecessary)\n \t */\n \tflcr = sio_in(up, TXX9_SIFLCR);\n-\tif (!(up->flags & UPF_CONS_FLOW) && (flcr & TXX9_SIFLCR_TES))\n+\tif (!uart_cons_flow_enabled(up) && (flcr & TXX9_SIFLCR_TES))\n \t\tsio_out(up, TXX9_SIFLCR, flcr & ~TXX9_SIFLCR_TES);\n \n \tuart_console_write(up, s, count, serial_txx9_console_putchar);\ndiff --git a/drivers/tty/serial/sunsu.c b/drivers/tty/serial/sunsu.c\nindex 6505a1930da9a..4ff3e5c41dab9 100644\n--- a/drivers/tty/serial/sunsu.c\n+++ b/drivers/tty/serial/sunsu.c\n@@ -1245,7 +1245,7 @@ static void wait_for_xmitr(struct uart_sunsu_port *up)\n \t} while (!uart_lsr_tx_empty(status));\n \n \t/* Wait up to 1s for flow control if necessary */\n-\tif (up->port.flags & UPF_CONS_FLOW) {\n+\tif (uart_cons_flow_enabled(&up->port)) {\n \t\ttmout = 1000000;\n \t\twhile (--tmout &&\n \t\t ((serial_in(up, UART_MSR) & UART_MSR_CTS) == 0))\n", "prefixes": [ "tty", "v4", "2/6" ] }