Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2233229/?format=api
{ "id": 2233229, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2233229/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505202640.1011006-23-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260505202640.1011006-23-peterx@redhat.com>", "date": "2026-05-05T20:26:39", "name": "[PULL,22/23] system/memory: assert on invalid MemoryRegionOps .unaligned combo", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3d34a649e743458fa26d0ec368303dabe65c1982", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/1.1/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505202640.1011006-23-peterx@redhat.com/mbox/", "series": [ { "id": 502897, "url": "http://patchwork.ozlabs.org/api/1.1/series/502897/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502897", "date": "2026-05-05T20:26:17", "name": "[PULL,01/23] migration: Fix blocking in POSTCOPY_DEVICE during package load", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502897/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2233229/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2233229/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=TsEi5XDO;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=WzkNo6eW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g999n6h0fz1yJV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 06:30:05 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKMMO-0004c7-5K; Tue, 05 May 2026 16:27:16 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1wKMMM-0004bI-RV\n for qemu-devel@nongnu.org; Tue, 05 May 2026 16:27:15 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1wKMML-0002ft-32\n for qemu-devel@nongnu.org; Tue, 05 May 2026 16:27:14 -0400", "from mail-qk1-f197.google.com (mail-qk1-f197.google.com\n [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-402-cEsicOsgNryq82rIoSbxhA-1; Tue, 05 May 2026 16:27:10 -0400", "by mail-qk1-f197.google.com with SMTP id\n af79cd13be357-8eb04352924so815313085a.1\n for <qemu-devel@nongnu.org>; Tue, 05 May 2026 13:27:10 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b53c6b8123sm155283806d6.35.2026.05.05.13.27.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 May 2026 13:27:08 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1778012831;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Dyb96gHjBVyrb1hhDEwJgJ8h7wgrV0AQCUFZ7NVQicg=;\n b=TsEi5XDOGopZC7vkTqBl7NmTsFM6NeRcdKKSoV9M/3YimwwLZ/XKBPrqGr5hlajr3TF6+R\n 2ahwGRrI/R+nHct1G4yq9q36lWHyjXDCoacKwrbSQxoIruhy6bejlfMr3DYCVlfiNHbip+\n yWyEqomA+jLXJdOas+V/+3Jy2jDipwk=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1778012830; x=1778617630; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Dyb96gHjBVyrb1hhDEwJgJ8h7wgrV0AQCUFZ7NVQicg=;\n b=WzkNo6eWmEkArALze6qYwMFf/l+CZaA+KOgP6mDS+cJJPU8I/xEB2FIZi82ghLQRdS\n e9Ei1GpFn/YHb6EWzBnO9ylfCm6xydmnnitoMA4tvH2GpHKCOAon6Sh0AoV3oMLbcwTz\n k7M0GM/txAt8mDEA3b7Av05EXJW009chSbl5s9FRvnXh30dIUTFhonWoHxD6P8cj732S\n h4ytZYWqU9jjUOs7qSMo++uiu2M29KhmvVU5Qmi6hdzMdaisdwt8HhEgu5Go4yJuc+O6\n X+WZ379JDHW/O+9lh4r2fB2J6b2r9W8yR5WZ/iqy2gXhv3UkeVHW6zuAEksr+gRjvSuk\n as4w==" ], "X-MC-Unique": "cEsicOsgNryq82rIoSbxhA-1", "X-Mimecast-MFC-AGG-ID": "cEsicOsgNryq82rIoSbxhA_1778012830", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778012830; x=1778617630;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Dyb96gHjBVyrb1hhDEwJgJ8h7wgrV0AQCUFZ7NVQicg=;\n b=IDuZWkGF1dNxVoRTmJOqS5U1MjMGGGXp91CLxgcqjCetyy8F9NZhF8QM5IL5f+ENqa\n FLuEbgY+ZVzV4d/2ZYiBOjF/kiozAHc/8FXjC5yEjB5+iWarRRd2oMGS4W+mioKY3KFp\n irX+63aj7ojRwWpXugOtMJbMP9er24TewNkNqJe2un4xveFBs0ojo904bCFCby34iJSu\n jSykx+inhIZgLTpEwrdPTsmQrXA53WXFAwVJat9fLRC3Alea/x2FncwedIk9oFbSh8XS\n kGzz7yAN976YcE0p8jJMKevvwqKp4D0iBEodJ6wBPHlQZdL2vpAo8aS1pxnXk42UqtYX\n oRdQ==", "X-Gm-Message-State": "AOJu0YwM3IydTf+UasrAmSD5hDtmH9kTRGaoIC1O6GNX5AtbVumG1QRK\n sMXYxpyfCOSpuc7s2t2xYD9F6NTu6wbtSklAbtZrGFN2lJXU96kBnklxlCpS45q0FOl21ke5Tho\n 7Sb8SFS9O5gpBedGMovRyXIQbKZNy8zMoN3PllPI/c8+yF7wKRyC6TMIUZtu+eczymfcql5k6o0\n ouGkbPTJql+joBcgxB2sL1e1PMRgSe3bWZNeQ44g==", "X-Gm-Gg": "AeBDiev58QDCyZpWQ474KSrTQkck/ppus2ayHxCWzNgyVfRhRzvQHKyd/dVM49DDrt+\n pLzqH2dYO8azw6u3BbPYJKUpevQGnNM4ns5n7xZWBwMV9MG0Wfd3sfTDH/WtdYLncPnQaQ8j24T\n ukNBhdwLP6ZYVyrhg2Ffi1Ux0lS+BzGi0DN/Q3mus44bwn2CN3A7JClWhzEa2AhjOo8vee25pGi\n AD7t2ulTCPpZ36A+UbtF75pgu66DhY7hXqXT4IBMl2n+QDrMwzB8+yfc2NlC6T4BgsMhFFqgfEo\n MWSOQbmVtbbbX/qP3j2RvAQfM9/g5/5SihveBL70sVRIf5tIpvyappVQVFsyHZmT8Z7aTwMO40g\n XlIdzbvBMaBnHavWNyLEfwisLfmsuN/u6v+0o2ihb7NDk1YWf12pjXmk=", "X-Received": [ "by 2002:a05:620a:2804:b0:8e8:bedd:14b2 with SMTP id\n af79cd13be357-904d69d8de7mr101666985a.43.1778012829880;\n Tue, 05 May 2026 13:27:09 -0700 (PDT)", "by 2002:a05:620a:2804:b0:8e8:bedd:14b2 with SMTP id\n af79cd13be357-904d69d8de7mr101658685a.43.1778012829095;\n Tue, 05 May 2026 13:27:09 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Fabiano Rosas <farosas@suse.de>, Paolo Bonzini <pbonzini@redhat.com>,\n Peter Xu <peterx@redhat.com>, CJ Chen <cjchen@igel.co.jp>,\n Tomoyuki Hirose <hrstmyk811m@gmail.com>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>", "Subject": "[PULL 22/23] system/memory: assert on invalid MemoryRegionOps\n .unaligned combo", "Date": "Tue, 5 May 2026 16:26:39 -0400", "Message-ID": "<20260505202640.1011006-23-peterx@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260505202640.1011006-1-peterx@redhat.com>", "References": "<20260505202640.1011006-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-24", "X-Spam_score": "-2.5", "X-Spam_bar": "--", "X-Spam_report": "(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.443,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: CJ Chen <cjchen@igel.co.jp>\n\nWhen it comes to this pattern: .valid.unaligned = false and\nimpl.unaligned = true, is effectlvely contradictory. The .valid\nstructure indicates that unaligned access should be rejected at\nthe access validation phase, yet .impl suggests the underlying\ndevice implementation can handle unaligned operations. As a result,\nthe upper-layer code will never even reach the .impl logic.\n\nAdd an assertion that the MemoryRegionOps doesn't specify\nthis invalid combination.\n\nSigned-off-by: CJ Chen <cjchen@igel.co.jp>\nTested-by: CJ Chen <cjchen@igel.co.jp>\nSuggested-by: Peter Xu <peterx@redhat.com>\nAcked-by: Tomoyuki Hirose <hrstmyk811m@gmail.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n[PMM: tweaked commit message]\nReviewed-by: Peter Maydell <peter.maydell@linaro.org>\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\nLink: https://lore.kernel.org/r/20260428093339.2087081-5-peter.maydell@linaro.org\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n system/memory.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/system/memory.c b/system/memory.c\nindex 225bbe38c3..739ba11da6 100644\n--- a/system/memory.c\n+++ b/system/memory.c\n@@ -1573,6 +1573,7 @@ void memory_region_init_io(MemoryRegion *mr, Object *owner,\n const MemoryRegionOps *ops, void *opaque,\n const char *name, uint64_t size)\n {\n+ g_assert(!ops || !(ops->impl.unaligned && !ops->valid.unaligned));\n memory_region_init(mr, owner, name, size);\n memory_region_set_ops(mr, ops, opaque);\n }\n", "prefixes": [ "PULL", "22/23" ] }