Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2233208/?format=api
{ "id": 2233208, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2233208/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505202640.1011006-5-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260505202640.1011006-5-peterx@redhat.com>", "date": "2026-05-05T20:26:21", "name": "[PULL,04/23] migration: Fix low possibility downtime violation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3487255c578961d1c45154bdc79e5ae3a9b459bf", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/1.1/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505202640.1011006-5-peterx@redhat.com/mbox/", "series": [ { "id": 502897, "url": "http://patchwork.ozlabs.org/api/1.1/series/502897/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502897", "date": "2026-05-05T20:26:17", "name": "[PULL,01/23] migration: Fix blocking in POSTCOPY_DEVICE during package load", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502897/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2233208/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2233208/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=aZsMaKQ8;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=mmED+GT6;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g99744BqVz1yJV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 06:27:44 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKMM9-0004Qg-2B; Tue, 05 May 2026 16:27:01 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1wKMM2-0004NS-6V\n for qemu-devel@nongnu.org; Tue, 05 May 2026 16:26:55 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1wKMM0-0002aa-Fg\n for qemu-devel@nongnu.org; Tue, 05 May 2026 16:26:53 -0400", "from mail-qv1-f70.google.com (mail-qv1-f70.google.com\n [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-654-2P-krHfOOAKJzVrno4yVGg-1; Tue, 05 May 2026 16:26:50 -0400", "by mail-qv1-f70.google.com with SMTP id\n 6a1803df08f44-8acb26fbbb2so90523556d6.2\n for <qemu-devel@nongnu.org>; Tue, 05 May 2026 13:26:50 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b53c6b8123sm155283806d6.35.2026.05.05.13.26.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 May 2026 13:26:48 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1778012811;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=MrH4nxdY2z2cb6i8OQLnpO0ege44PFcIyn690wvAT/8=;\n b=aZsMaKQ8VwV7xKqJvn4vCCfK38JdDPhN1qsxEixvQj7FG1rvT1KuQWk6PfxY9+qLpkAvXP\n q3/dASt9O63NabAWbszxokxzgMZ65hnW50erNUcWgirl7ut3zgYQVRHPV6XPguWpsrjoy7\n ssl9nhTaQDx2+MejICWpmyv3z1jJ3DI=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1778012809; x=1778617609; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=MrH4nxdY2z2cb6i8OQLnpO0ege44PFcIyn690wvAT/8=;\n b=mmED+GT6omG/CJegGd3EmBC7ZSs+4TV5hGeD5aOiqpi9q8I/znhJcXeFIV6DomJN1r\n Hkr+gXV9+Hy/vK0bKJ0zP5S8sKK4/1R5PYmi+/VgtMc7n238VJU01qSoohNrPUttCamT\n MlUCfzvBULh8CoPtSn6mke/pZy0JoSsSZs9BK98cVi/gI98wIrJmp0/7oODdFMIB2YT2\n EhnOblfJaxR6DBQaO/glJlhPGA5FXExca3ewn+cCYtC6IAR9IScNLR2FvzyuCa+xqdWk\n nOq1DP//rXlBy30gu9gR033Mdlc2nydMKwyJh/Z/NhYEAmGsp5Mf508+6bS+6ryrow4Q\n ousw==" ], "X-MC-Unique": "2P-krHfOOAKJzVrno4yVGg-1", "X-Mimecast-MFC-AGG-ID": "2P-krHfOOAKJzVrno4yVGg_1778012810", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778012809; x=1778617609;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=MrH4nxdY2z2cb6i8OQLnpO0ege44PFcIyn690wvAT/8=;\n b=P7tlNNlhn1L7NnZihByL6XRo1VLCfYS6dfBuKZawE0VaJPl65D+5A2Y9N2QZeNHnyW\n xVCWjdBtTVzQ8urmqeQidUuEaHPI/FCDuNGeQkkTFXfFtyBB+HxRcwGrt+OvNZplxv1u\n AnC7eDtrbDAgMZvHG7/9wbb0BEv1SuuJKIR9bhIbvAwJBGUCBphBqVJ6VmqIg1nEPkJt\n MAtrpG51cZjMTZ3Oz22SMLqKvs+XSKGFDoDWYOb7WL+ClHuHj/beHEKitb0v5IQ3ztNB\n 9qOomILu3J+vIg/pe6VShBTT6rlaQnX6noG/U8uk6V8ycbMX97DVnieHG0VfczGSy42n\n Y6Mg==", "X-Gm-Message-State": "AOJu0YwrnUnR+rX8kWWFC5x5WdA1YsOSGOcN1+MAC+mZ6UDhA6xR2fjq\n Y8w1U+AAc87e/H3EpmENtNHCa6k17QWsM2apwJHv5fgB2ooQF2aUufwwwD8cELKDR+zGeWDERg1\n QcOTVTNvrrc3o84LOEDua0xnuEKOsv/Kqq73t8CVNEJrbfgOvKK30fOknopk0Ei8ebGnVWD07tf\n ZhbViSBLMvAvSjMRbu3mnfg/yGwJ7vh3a1yH75Dg==", "X-Gm-Gg": "AeBDieuM8XJ+OHELJZLWySf7N7XU4RmD7C/WSzjmpjK5+5uYpTFh75rGYqFHS7tIFJ0\n i5WnFzGm14EjKoLeaW+CQ55s5PYCyG6PFTeCqnmVsyRNQsmaGqoVjlq7k2Nj3nacgnd00L0Ya0T\n /zFC+rAb5aKZq5+KsnLKb/Gjvgdmt+0S46pRWsDh7z3N8fc9ZcOaY9U2JlehflVr+h4glo7Smpa\n QqNCQTM0JkomSAvPOxQ28m5xncft3duAjxKfDjpA3jYC+r10kFPGYQUlI/dbLkN9xqOLsB39b9S\n mD69Xy1qft6V7hAnHbU/rMrB+YN2oMe87/ri0uc54gYBighESQc5yX7b+ncQOqWG5LNHeETjXEZ\n ++v1Pa8Szyl3ElJb6uky8MzNfSQ3KbmTAg9kb+G7bN/edeNZ6q5IYMhQ=", "X-Received": [ "by 2002:a05:6214:468d:b0:89c:ede4:ea35 with SMTP id\n 6a1803df08f44-8bc449aff84mr4877976d6.24.1778012809254;\n Tue, 05 May 2026 13:26:49 -0700 (PDT)", "by 2002:a05:6214:468d:b0:89c:ede4:ea35 with SMTP id\n 6a1803df08f44-8bc449aff84mr4877256d6.24.1778012808652;\n Tue, 05 May 2026 13:26:48 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Fabiano Rosas <farosas@suse.de>, Paolo Bonzini <pbonzini@redhat.com>,\n Peter Xu <peterx@redhat.com>, qemu-stable@nongnu.org,\n Juraj Marcin <jmarcin@redhat.com>", "Subject": "[PULL 04/23] migration: Fix low possibility downtime violation", "Date": "Tue, 5 May 2026 16:26:21 -0400", "Message-ID": "<20260505202640.1011006-5-peterx@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260505202640.1011006-1-peterx@redhat.com>", "References": "<20260505202640.1011006-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-24", "X-Spam_score": "-2.5", "X-Spam_bar": "--", "X-Spam_report": "(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.443,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "When QEMU queried the estimated version of pending data and thinks it's\nready to converge, it'll send another accurate query to make sure of it.\nIt is needed to make sure we collect the latest reports and that equation\nstill holds true.\n\nHowever we missed one tiny little difference here on \"<\" v.s. \"<=\" when\ncomparing pending_size (A) to threshold_size (B)..\n\nQEMU src only re-query if A<B, but will kickoff switchover if A<=B.\n\nI think it means it is possible to happen if A (as an estimate only so far)\naccidentally equals to B, then re-query won't happen and switchover will\nproceed without considering new dirtied data.\n\nIt turns out it was an accident in my commit 7aaa1fc072 when refactoring\nthe code around. Fix this by using the same equation in both places.\n\nFixes: 7aaa1fc072 (\"migration: Rewrite the migration complete detect logic\")\nCc: qemu-stable@nongnu.org\nReviewed-by: Juraj Marcin <jmarcin@redhat.com>\nLink: https://lore.kernel.org/r/20260421202110.306051-3-peterx@redhat.com\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n migration/migration.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/migration/migration.c b/migration/migration.c\nindex 6e4988a590..5f4efb1fe5 100644\n--- a/migration/migration.c\n+++ b/migration/migration.c\n@@ -3258,7 +3258,7 @@ static MigIterateState migration_iteration_run(MigrationState *s)\n * postcopy started, so ESTIMATE should always match with EXACT\n * during postcopy phase.\n */\n- if (pending_size < s->threshold_size) {\n+ if (pending_size <= s->threshold_size) {\n qemu_savevm_state_pending_exact(&must_precopy, &can_postcopy);\n pending_size = must_precopy + can_postcopy;\n trace_migrate_pending_exact(pending_size, must_precopy,\n", "prefixes": [ "PULL", "04/23" ] }