Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2232536/?format=api
{ "id": 2232536, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2232536/?format=api", "web_url": "http://patchwork.ozlabs.org/project/opensbi/patch/20260504171342.1655882-2-raymondmaoca@gmail.com/", "project": { "id": 67, "url": "http://patchwork.ozlabs.org/api/1.1/projects/67/?format=api", "name": "OpenSBI development", "link_name": "opensbi", "list_id": "opensbi.lists.infradead.org", "list_email": "opensbi@lists.infradead.org", "web_url": "https://github.com/riscv/opensbi", "scm_url": "", "webscm_url": "" }, "msgid": "<20260504171342.1655882-2-raymondmaoca@gmail.com>", "date": "2026-05-04T17:13:41", "name": "[v2,2/3,NOT-FOR-UPSTREAM] lib: utils: irqchip: add QEMU virt test for APLIC wired IRQs", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ac7247800e8be62290d0bb06cd32bbe6f721b1db", "submitter": { "id": 91989, "url": "http://patchwork.ozlabs.org/api/1.1/people/91989/?format=api", "name": "Raymond Mao", "email": "raymondmaoca@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/opensbi/patch/20260504171342.1655882-2-raymondmaoca@gmail.com/mbox/", "series": [ { "id": 502701, "url": "http://patchwork.ozlabs.org/api/1.1/series/502701/?format=api", "web_url": "http://patchwork.ozlabs.org/project/opensbi/list/?series=502701", "date": "2026-05-04T17:13:40", "name": "[v2,1/3] lib: utils: irqchip: implement APLIC hwirq operation hooks", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502701/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232536/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232536/checks/", "tags": {}, "headers": { "Return-Path": "\n <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=45DSamSa;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Thv+djct;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8St03fq4z1yKC\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 05 May 2026 03:14:00 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wJwrn-0000000Do1C-0sqb;\n\tMon, 04 May 2026 17:13:59 +0000", "from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wJwrk-0000000Do0P-0vNL\n\tfor opensbi@lists.infradead.org;\n\tMon, 04 May 2026 17:13:57 +0000", "by mail-qt1-x830.google.com with SMTP id\n d75a77b69052e-506a6cf8242so31542781cf.1\n for <opensbi@lists.infradead.org>;\n Mon, 04 May 2026 10:13:55 -0700 (PDT)", "from ubuntu.localdomain (172-97-209-197.cpe.distributel.net.\n [172.97.209.197])\n by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-51040927789sm102332871cf.11.2026.05.04.10.13.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 May 2026 10:13:54 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=kWh+jPLDo1C8OO+ZnKOOeXqj1yuTNKfEZyduju22OV4=; b=45DSamSapJJLc8\n\tg+XXbF+6NYvqS7XFE6w4d6uTcWqoko+w5j+EFzBSjVzUbDbnafZVbCpJVrDaVKrO7vkqsl22FsBPr\n\tw7Ocbgyl97ljEftIT/8JFjZxgf5TBgwrdKk1Em9OTxOtX00+XGGewB2+JOpkMOReyw6f65yIPVu3i\n\twu5fvtzOqiZu8xn7bbTghfVCowsZ+pq280ToAJ078fIYh3MHS0q3CFuuzGtHs7hOMmHRl3E/40ebG\n\t0v82B4NuIjr15tWis9qzAQlMh6v7i4ruG+63ctpqv11glfUgVWwTDvQ1rCAtrVF8n9c387hJlWLjY\n\tVMspUhLV9Ec8QbHECFWg==;", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777914835; x=1778519635;\n darn=lists.infradead.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=RFaMmgwjrsy5U8HvY0ktvxMU7qArSdQGKJmR+y2FugY=;\n b=Thv+djctHCtEzR5SpMI5W+4DXCD/WqYOcml+OYm1HXVUWVzOP8CAZZUWy7Tve3Bk4t\n zZx/IwG9npdtOVKKxtNGLSNY0N/14RzfeYTMf6y9viH6uUsFpdJgcGUQsRf8dj374muX\n GZXo9X7tfzVNCkkz5crmfMtoOK7LdhjhXIiiNuJ+/pgqcTX7EkcNJ+gsv0kqDCLgoUqx\n sAEwqkGjbGA9WKjwuaG8EiB1ASdQUT2nCPUZpXGM0oLGulZK0WbVhZ9dG2pnWFgY2Ura\n O7Fx51RC/dtS7YfvJe745Me73phsFS3okijt5+4Q5d7qiylhtMmooIm49MWzE8JFIw2f\n e0jw==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777914835; x=1778519635;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=RFaMmgwjrsy5U8HvY0ktvxMU7qArSdQGKJmR+y2FugY=;\n b=gZQPDPOLzHOTOs0bLSTBlGXWCi83sKLswnwLufJjApLJDA86RxZ+p0YSq9cdr50tPP\n rLqmHHHwiBROnZA2hcyn5ZySdimAD2jTY6qIfaG1XYKR0ywkmR6ggpTb2r74c0ezvdtV\n 30MJj6UYZwzN0cFkgu4gIsReDEdeQFXUhVbluL3YEeBY87XWqPZpe0pQOPHoyBq+xk77\n 30AiIJsK3XILvrZNAnJRRy6EkliWoSBEGzhSoAlCbXaRh9CJ3rNOob+iVscnxLbj1t3c\n YK08jNC9OgBuAJc6ieq6P3Zzhn3KBnDMTqKMDj4HN0zlk1YK4K9MW3Wn0kjC0vGpde+P\n T7OA==", "X-Gm-Message-State": "AOJu0YyWrMdbDGtoezNuNL7F/D8ys/m4cujIHYljv95ForVHCNgbA1RC\n\t4dI31jjMpAjUlpcyTAwe/OwkGUoogSi5vRYRmKfdueNey82unZXVMDiaDpsqMkRJ", "X-Gm-Gg": "AeBDievG5+T8DkRBp8MmkXuIvy6A8A4MjxwAAFOcakSiXEjlNv0rVMsc58VZY0pxZih\n\t6eqvSTxlqJFbjBD7OfGtP55Ix64kBmDHz8kC7rG4tAoP4oijZgXyUNjnCjOY9H2YU7WC20vIB/b\n\t1BAdkFsB2lA1kWueH/kilhy/Vw4Igg6F5o7V76M5eQxsJwu+AKmxuflybHTfCnvbpZKQYfqLtJK\n\t5y+/O/ZpjfkYV5yiKzXVR3JnJLDf8n8JJnuFfOcAZXz4DysYWm4ohfNQt0W5dKGOclM+rOoJFP4\n\tn5KKewfJYbzXdxC8nwTX8rm/WLAS5zAeDMxP9SyPM3V3zwrTHUFscd2nP22f0y5wvl+e8Kbw6Nr\n\tRA8OurZ/tLuAlaBxKAaQkFBlnwUshdil7SKhoTnbN/cC8QVWs7npAi1nWGHgQ9tBwDeW8gRj8e6\n\tkPvFkGuB871SLsHnHyXFidzdEAvGKHVv7729HCEojA1kyn4QuXYJsB1GbP46qLgP47MGWBdfzQE\n\tnjA7t4O6XrtviwUxsBP0A==", "X-Received": "by 2002:a05:622a:2608:b0:50e:2b1e:9d14 with SMTP id\n d75a77b69052e-5104bf0a3d3mr158482811cf.29.1777914834669;\n Mon, 04 May 2026 10:13:54 -0700 (PDT)", "From": "Raymond Mao <raymondmaoca@gmail.com>", "To": "opensbi@lists.infradead.org", "Cc": "scott@riscstar.com,\n\tdave.patel@riscstar.com,\n\traymond.mao@riscstar.com,\n\trobin.randhawa@sifive.com,\n\tsamuel.holland@sifive.com,\n\tanup.patel@qti.qualcomm.com,\n\tanuppate@qti.qualcomm.com,\n\tanup@brainfault.org,\n\tdhaval@rivosinc.com,\n\tpeter.lin@sifive.com", "Subject": "[PATCH v2 2/3] [NOT-FOR-UPSTREAM] lib: utils: irqchip: add QEMU virt\n test for APLIC wired IRQs", "Date": "Mon, 4 May 2026 13:13:41 -0400", "Message-Id": "<20260504171342.1655882-2-raymondmaoca@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20260504171342.1655882-1-raymondmaoca@gmail.com>", "References": "<20260504171342.1655882-1-raymondmaoca@gmail.com>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260504_101356_285408_4B6DD05C ", "X-CRM114-Status": "GOOD ( 16.35 )", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Raymond Mao Add a QEMU virt specific test hook for\n validating\n APLIC wired external interrupt handling. When APLIC_QEMU_WIRED_TEST is\n enabled,\n keep the test path limited to hwirq 10 and only register it when the\n current\n APLIC instance is the M-mode direct-mode provider and that interrupt is\n not\n delegate [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no\n trust\n [2607:f8b0:4864:20:0:0:0:830 listed in]\n [list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n provider\n [raymondmaoca(at)gmail.com]", "X-BeenThere": "opensbi@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<opensbi.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/opensbi>,\n <mailto:opensbi-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/opensbi/>", "List-Post": "<mailto:opensbi@lists.infradead.org>", "List-Help": "<mailto:opensbi-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/opensbi>,\n <mailto:opensbi-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"opensbi\" <opensbi-bounces@lists.infradead.org>", "Errors-To": "opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Raymond Mao <raymond.mao@riscstar.com>\n\nAdd a QEMU virt specific test hook for validating APLIC wired external\ninterrupt handling.\n\nWhen APLIC_QEMU_WIRED_TEST is enabled, keep the test path limited to\nhwirq 10 and only register it when the current APLIC instance is the\nM-mode direct-mode provider and that interrupt is not delegated to a\nchild domain.\nThis keeps the test path compatible with the generic APLIC changes\nwhile still allowing a DT overlay to expose an M-mode wired IRQ on\nQEMU virt.\n\nSigned-off-by: Raymond Mao <raymond.mao@riscstar.com>\n---\n Makefile | 3 ++\n lib/utils/irqchip/aplic.c | 62 +++++++++++++++++++++++++++++++++++++++\n 2 files changed, 65 insertions(+)", "diff": "diff --git a/Makefile b/Makefile\nindex 46541063..418ee1aa 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -399,6 +399,9 @@ CFLAGS\t\t+=\t$(GENFLAGS)\n CFLAGS\t\t+=\t$(platform-cflags-y)\n CFLAGS\t\t+=\t-fPIE -pie\n CFLAGS\t\t+=\t$(firmware-cflags-y)\n+ifeq ($(APLIC_QEMU_WIRED_TEST),y)\n+CFLAGS\t\t+=\t-DAPLIC_QEMU_WIRED_TEST\n+endif\n \n CPPFLAGS\t+=\t$(GENFLAGS)\n CPPFLAGS\t+=\t$(platform-cppflags-y)\ndiff --git a/lib/utils/irqchip/aplic.c b/lib/utils/irqchip/aplic.c\nindex 3f4991b5..82efdb71 100644\n--- a/lib/utils/irqchip/aplic.c\n+++ b/lib/utils/irqchip/aplic.c\n@@ -112,6 +112,7 @@\n #define APLIC_DEFAULT_PRIORITY\t\t1\n #define APLIC_DISABLE_IDELIVERY\t\t0\n #define APLIC_ENABLE_IDELIVERY\t\t1\n+#define APLIC_QEMU_TEST_HWIRQ\t\t10\n #define APLIC_DISABLE_ITHRESHOLD\t1\n #define APLIC_ENABLE_ITHRESHOLD\t\t0\n \n@@ -119,6 +120,41 @@ static SBI_LIST_HEAD(aplic_list);\n static void aplic_writel_msicfg(struct aplic_msicfg_data *msicfg,\n \t\t\t\tvoid *msicfgaddr, void *msicfgaddrH);\n \n+#ifdef APLIC_QEMU_WIRED_TEST\n+\n+#define UART_QEMU_MMIO 0x10000000UL\n+\n+static void aplic_test_uart_handler(void)\n+{\n+\tvolatile u8 *uart = (volatile u8 *)UART_QEMU_MMIO;\n+\n+\t/* Drain RX FIFO to clear the interrupt source */\n+\twhile (uart[0x05] & 0x01) { /* LSR.DR */\n+\t\tu8 ch = uart[0x00]; /* RBR */\n+\n+\t\tsbi_printf(\"[APLIC TEST] UART got '%c'(0x%02x)\\n\",\n+\t\t\t (ch >= 32 && ch < 127) ? ch : '.', ch);\n+\t}\n+\n+\t/* (Optional) read IIR to acknowledge on some models */\n+\t(void)uart[0x02]; /* IIR is at offset 2 when DLAB=0; */\n+}\n+\n+static void aplic_hwirq_test_run(unsigned long aplic_addr)\n+{\n+\tvolatile u8 *uart = (volatile u8 *)UART_QEMU_MMIO;\n+\n+\t/* UART: enable RX interrupt */\n+\tuart[0x02] = 0x07; /* FCR enable+clear */\n+\tuart[0x04] |= (1 << 3); /* MCR.OUT2 */\n+\tuart[0x01] |= 0x01; /* IER.ERBFI */\n+\twhile (uart[0x05] & 0x01) /* drain */\n+\t\t(void)uart[0x00];\n+\n+\tsbi_printf(\"[APLIC TEST] Setup done. Type keys now.\\n\");\n+}\n+#endif\n+\n static void aplic_init(struct aplic_data *aplic)\n {\n \tstruct aplic_delegate_data *deleg;\n@@ -245,6 +281,20 @@ static int aplic_check_msicfg(struct aplic_msicfg_data *msicfg)\n \treturn 0;\n }\n \n+#ifdef APLIC_QEMU_WIRED_TEST\n+static int aplic_hwirq_handler(u32 hwirq, void *opaque)\n+{\n+\t(void)opaque;\n+\n+\tsbi_printf(\"[APLIC] Enter registered hwirq %u raw handler callback\\n\",\n+\t\t hwirq);\n+\n+\tif (hwirq == 10)\n+\t\taplic_test_uart_handler();\n+\n+\treturn SBI_OK;\n+}\n+#endif\n static inline void *aplic_idc_base(unsigned long aplic_addr, u32 idc_index)\n {\n \treturn (void *)(aplic_addr + APLIC_IDC_BASE +\n@@ -541,6 +591,18 @@ int aplic_cold_irqchip_init(struct aplic_data *aplic)\n \n \t/* Attach to the aplic list */\n \tsbi_list_add_tail(&aplic->node, &aplic_list);\n+#ifdef APLIC_QEMU_WIRED_TEST\n+\tif (aplic_mmode_direct(aplic) &&\n+\t !aplic_hwirq_delegated(aplic, APLIC_QEMU_TEST_HWIRQ)) {\n+\t\trc = sbi_irqchip_register_handler(&aplic->irqchip,\n+\t\t\t\t\t\t APLIC_QEMU_TEST_HWIRQ, 1,\n+\t\t\t\t\t\t aplic_hwirq_handler, NULL);\n+\t\tif (rc)\n+\t\t\treturn rc;\n \n+\t\t/* Enable test in M-mode before jumping to any payload */\n+\t\taplic_hwirq_test_run(aplic->addr);\n+\t}\n+#endif\n \treturn 0;\n }\n", "prefixes": [ "v2", "2/3", "NOT-FOR-UPSTREAM" ] }