Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2232526/?format=api
{ "id": 2232526, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2232526/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260504163448.1063474-1-longman@redhat.com/", "project": { "id": 21, "url": "http://patchwork.ozlabs.org/api/1.1/projects/21/?format=api", "name": "Linux Tegra Development", "link_name": "linux-tegra", "list_id": "linux-tegra.vger.kernel.org", "list_email": "linux-tegra@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260504163448.1063474-1-longman@redhat.com>", "date": "2026-05-04T16:34:48", "name": "firmware: tegra: bpmp: Make atomic_tx_lock a raw_spinlock", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2d66acd7bd07da7aa986c21e77acbae1be40400a", "submitter": { "id": 71281, "url": "http://patchwork.ozlabs.org/api/1.1/people/71281/?format=api", "name": "Waiman Long", "email": "longman@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260504163448.1063474-1-longman@redhat.com/mbox/", "series": [ { "id": 502696, "url": "http://patchwork.ozlabs.org/api/1.1/series/502696/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/list/?series=502696", "date": "2026-05-04T16:34:48", "name": "firmware: tegra: bpmp: Make atomic_tx_lock a raw_spinlock", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502696/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232526/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232526/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-tegra+bounces-14154-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-tegra@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=C3oglvce;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14154-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"C3oglvce\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124", "smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8S5k68w6z1yJ0\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 05 May 2026 02:39:06 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id D982D301FA9F\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 4 May 2026 16:35:19 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8F4E33D3D05;\n\tMon, 4 May 2026 16:35:19 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E7D713A7F4D\n\tfor <linux-tegra@vger.kernel.org>; Mon, 4 May 2026 16:35:16 +0000 (UTC)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-AE3on9EYNqKaeRjvsL30WQ-1; Mon,\n 04 May 2026 12:35:12 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 0D2061800578;\n\tMon, 4 May 2026 16:35:11 +0000 (UTC)", "from llong-thinkpadp16vgen1.westford.csb (unknown [10.2.16.173])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 163731944CED;\n\tMon, 4 May 2026 16:35:07 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777912519; cv=none;\n b=ClUlN4jwfr3UbzMJqgrO3mchdm87E8Ff9guMpxILLogatwO8/46Qlir+LgDfRMwnoyivG+fzaHzd6wRXdr6C79srObxky6tRbXbdv0BucTzzaBQSHRml7xb0iZAO8tfvDmtU24FW4mPCUFClF1n5ZzddGsL9HhE8ZSdtEtUV8EQ=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777912519; c=relaxed/simple;\n\tbh=RMF2wbDO7Cu7Ode2EIeZxKPPw0UUdDh35IH+0ozJRxE=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=O960MGhF8LBo8AxOpVFtqZmUyADvd8gR0yoHEkav+29wpuaOYOXJIlgC0FgqqgT7jpvCJqIdeV8GGnyJmuNsiBY8z5Ub0LloArcB+ANeGmq+dlZBVWA9gbn8pUg0DNTWmd99b3CpsOfP0X3aeBXKfk2Hio3wspGbSyY/Qo0UORI=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=C3oglvce; arc=none smtp.client-ip=170.10.133.124", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777912516;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding;\n\tbh=IOVlEIey1KL6W7eekEzWzNHwKHVr2WijrrD98LUvP0s=;\n\tb=C3oglvcecBN0z7lwfDcPEamk1nvsAbTa3eogfp6jCIKEt7+OKjdggG/ozeWdcQY8MCOIoU\n\tukq17md7M2Z4ZwYlIMR0xiRlCm+FVfznozKj/L/e2d51UnTLW46jJyMli65hQzwqHpqo9O\n\taAjoZlKxSHbkNvNYnVAmL/fV5ewacMM=", "X-MC-Unique": "AE3on9EYNqKaeRjvsL30WQ-1", "X-Mimecast-MFC-AGG-ID": "AE3on9EYNqKaeRjvsL30WQ_1777912511", "From": "Waiman Long <longman@redhat.com>", "To": "Thierry Reding <thierry.reding@kernel.org>,\n\tJonathan Hunter <jonathanh@nvidia.com>,\n\tSebastian Andrzej Siewior <bigeasy@linutronix.de>,\n\tClark Williams <clrkwllms@kernel.org>,\n\tSteven Rostedt <rostedt@goodmis.org>", "Cc": "linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-rt-devel@lists.linux.dev,\n\tjberring@redhat.com,\n\tWaiman Long <longman@redhat.com>", "Subject": "[PATCH] firmware: tegra: bpmp: Make atomic_tx_lock a raw_spinlock", "Date": "Mon, 4 May 2026 12:34:48 -0400", "Message-ID": "<20260504163448.1063474-1-longman@redhat.com>", "Precedence": "bulk", "X-Mailing-List": "linux-tegra@vger.kernel.org", "List-Id": "<linux-tegra.vger.kernel.org>", "List-Subscribe": "<mailto:linux-tegra+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-tegra+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17" }, "content": "The atomic_tx_lock was first introduced by commit 1abb081e41a7\n(\"firmware: tegra: Simplify channel management\") as a spinlock_t. It\nis used only in tegra_bpmp_transfer_atomic() to ensure mutual exclusion.\n\nSince the merging of PREEMPT_RT support into mainline Linux kernel\nin v6.12, a spinlock becomes a sleeping lock when CONFIG_PREEMPT_RT\nis enabled. As tegra_bpmp_transfer_atomic() is called with interrupt\ndisabled, acquiring a sleeping lock will lead to the following bug\nreport when booting up a PREEMPT_RT kernel on an tegra based arm64\nsystem with Boot and Power Management Processor (BPMP).\n\n BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48\n in_atomic(): 0, irqs_disabled(): 1, non_block: 0, pid: 1, name: swapper/0\n preempt_count: 0, expected: 0\n RCU nest depth: 0, expected: 0\n 2 locks held by swapper/0/1:\n #0: ffff42bda2d5b0f0 (&dev->mutex){....}-{3:3}, at: __driver_attach+0x110/0x2c0\n #1: ffff42bda4da5138 (&bpmp->atomic_tx_lock){....}-{2:2}, at: tegra_bpmp_transfer_atomic+0x118/0x3c0\n\nFix it by changing the type of atomic_tx_lock in the tegra_bpmp structure\nto raw_spinlock_t and use raw_spinlock APIs to access it.\n\nSigned-off-by: Waiman Long <longman@redhat.com>\n---\n drivers/firmware/tegra/bpmp.c | 8 ++++----\n include/soc/tegra/bpmp.h | 2 +-\n 2 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c\nindex 753472b53bd8..1a82ce7d340d 100644\n--- a/drivers/firmware/tegra/bpmp.c\n+++ b/drivers/firmware/tegra/bpmp.c\n@@ -365,16 +365,16 @@ int tegra_bpmp_transfer_atomic(struct tegra_bpmp *bpmp,\n \n \tchannel = bpmp->tx_channel;\n \n-\tspin_lock(&bpmp->atomic_tx_lock);\n+\traw_spin_lock(&bpmp->atomic_tx_lock);\n \n \terr = tegra_bpmp_channel_write(channel, msg->mrq, MSG_ACK,\n \t\t\t\t msg->tx.data, msg->tx.size);\n \tif (err < 0) {\n-\t\tspin_unlock(&bpmp->atomic_tx_lock);\n+\t\traw_spin_unlock(&bpmp->atomic_tx_lock);\n \t\treturn err;\n \t}\n \n-\tspin_unlock(&bpmp->atomic_tx_lock);\n+\traw_spin_unlock(&bpmp->atomic_tx_lock);\n \n \terr = tegra_bpmp_ring_doorbell(bpmp);\n \tif (err < 0)\n@@ -763,7 +763,7 @@ static int tegra_bpmp_probe(struct platform_device *pdev)\n \tif (!bpmp->threaded.busy)\n \t\treturn -ENOMEM;\n \n-\tspin_lock_init(&bpmp->atomic_tx_lock);\n+\traw_spin_lock_init(&bpmp->atomic_tx_lock);\n \tbpmp->tx_channel = devm_kzalloc(&pdev->dev, sizeof(*bpmp->tx_channel),\n \t\t\t\t\tGFP_KERNEL);\n \tif (!bpmp->tx_channel)\ndiff --git a/include/soc/tegra/bpmp.h b/include/soc/tegra/bpmp.h\nindex a33582590a3b..fdd8739715dc 100644\n--- a/include/soc/tegra/bpmp.h\n+++ b/include/soc/tegra/bpmp.h\n@@ -79,7 +79,7 @@ struct tegra_bpmp {\n \t\tstruct mbox_chan *channel;\n \t} mbox;\n \n-\tspinlock_t atomic_tx_lock;\n+\traw_spinlock_t atomic_tx_lock;\n \tstruct tegra_bpmp_channel *tx_channel, *rx_channel, *threaded_channels;\n \n \tstruct {\n", "prefixes": [] }