Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2232518/?format=api
{ "id": 2232518, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2232518/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-feat-mte4-v5-8-232a648e63c6@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260504-feat-mte4-v5-8-232a648e63c6@gmail.com>", "date": "2026-05-04T15:50:41", "name": "[v5,08/15] target/arm: add canonical MTE check logic", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0bf329868e9e24a7a24bbb21b49f1b3e09520316", "submitter": { "id": 91863, "url": "http://patchwork.ozlabs.org/api/1.1/people/91863/?format=api", "name": "Gabriel Brookman", "email": "brookmangabriel@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-feat-mte4-v5-8-232a648e63c6@gmail.com/mbox/", "series": [ { "id": 502688, "url": "http://patchwork.ozlabs.org/api/1.1/series/502688/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502688", "date": "2026-05-04T15:50:33", "name": "target/arm: add support for MTE4", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/502688/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232518/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232518/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Qhfm84CA;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8R5n73Tfz1yJ0\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 05 May 2026 01:54:05 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJvZu-0000zI-JZ; Mon, 04 May 2026 11:51:26 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brookmangabriel@gmail.com>)\n id 1wJvZr-0000xc-Gp\n for qemu-devel@nongnu.org; Mon, 04 May 2026 11:51:23 -0400", "from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <brookmangabriel@gmail.com>)\n id 1wJvZp-0006De-VD\n for qemu-devel@nongnu.org; Mon, 04 May 2026 11:51:23 -0400", "by mail-qk1-x72e.google.com with SMTP id\n af79cd13be357-8d68f702851so480511285a.0\n for <qemu-devel@nongnu.org>; Mon, 04 May 2026 08:51:21 -0700 (PDT)", "from [192.168.1.164] ([2600:1009:a021:c665:5296:905f:3e4a:eb90])\n by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-51040931552sm99599011cf.12.2026.05.04.08.51.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 May 2026 08:51:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777909881; x=1778514681; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=seR931FbrhAdb+NYhAMGgy6RPmH0udBjx5jaRmN1ITA=;\n b=Qhfm84CAQWS9N7Loi2NByK6AG3ZtcNFUfIeK9omwsWMKRn3RvJbdWfgFSbps9+xxxJ\n p4IVbNePAKXQews+v7Yg3ZFhuEmf5QD+ekfNvltBQwHIRyyLYgxTeeHJgNJ7qMeF7aqB\n JKknViiUBObau8em6Kl5FdqPNKYvChpLLWDIilb62DfloTVBcAw77639PD3FKV+P5iZK\n 0bH9YCqIVUOafQZlCUVOQV1eIclNu0zJS3FJ9nYrcy7OOQ+HQ/vts6ZGp0NhjcJHyRBT\n 9WTqFcoKsQDb3jbDecPuw/a9NDD/qLz4MvO7x2bdJxmMmuYv/4qkStKM58tD3lb0Ma5M\n wf1A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777909881; x=1778514681;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=seR931FbrhAdb+NYhAMGgy6RPmH0udBjx5jaRmN1ITA=;\n b=tMTWAVhHRkB+ueZgIfdpD//beXxgzjhy6dLBMzYuyDu5tqUyDhD19moiQkMMswkMUI\n NQxwJrAVnrWhxt9F4rDYZFkJo5CIN15Rt9SXI0o65fa8wuRilu0rvD6PMnnbLfIcSl0w\n /HG+qH9Td/E3di72uasHpbadUyWibSvatdpPsfplDaHAH2+bYGeqMiTuWP5BxgoGdeOM\n RcXc5PRnqMFW7WkCFOXjDEHWj2Gu31D2DN+7DbYFRbn63jyd6dzr/TqdCm9mqf4+uZOs\n aueeUJunYXEzx1gxqUhm3x2cn4g3F3MPYotX5xO/pYU8wonkJD+MOmQWKByY4Y7BLEo2\n Kk6A==", "X-Gm-Message-State": "AOJu0YxG6DG5dn4TAvNy59MOehm3Lm+qNa7K0Hx2EiPWLM6GjVpy77bj\n UUYzr6E0Y3dhH4er2XJEy+Yl6Bs4mnR8Jby49ZAPqI0g85Z0ZI6p1ZC4", "X-Gm-Gg": "AeBDiev1CuZAd5BZnLMwQAhZh5e8M+xxvWIHMv3XOdsvxIFUyVCbwLePgAcTwwPmey7\n FfEzldr0P59agmyoT5qbn6BfVNfRW94yBV9wI+K/cR7EmrUxREImb91dnBeMZCap6LlAxaHrM9n\n jiC3AgkM4Ld1eW9E//6mPbkTIn2HNGJBS3tssNddSQIC22iiLgrstVrRDeKnB5zRc2xaPDvzwBl\n MjdBLvtPSuWRCwuxL/okz2KgQNOqgOIFeMoW+uFwYhnIxgdq5snBI2AFAVV46YjTHmCV99jppbC\n dYe1is6ZJVXAsIrH+XlU3sHmI//FX5T0uR+S6P37IPCOoOQomiwA2aGwP+p5vpQRmRDtppPmwop\n F+YIg1jU36TSrV3f4pVxOcBWh4hXOBWoOrGqpfgIMypMAdv8aFekzV0HNqJ9EXqXya3IzvqU86U\n AqvN2rFug+MQYnsyjmAOoNV7Dw9KpnX59Fc5lAS0M8yZHWWMtdJAw=", "X-Received": "by 2002:a05:622a:54e:b0:50f:be4f:465d with SMTP id\n d75a77b69052e-5104bf50838mr143748111cf.46.1777909880546;\n Mon, 04 May 2026 08:51:20 -0700 (PDT)", "From": "Gabriel Brookman <brookmangabriel@gmail.com>", "Date": "Mon, 04 May 2026 11:50:41 -0400", "Subject": "[PATCH v5 08/15] target/arm: add canonical MTE check logic", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260504-feat-mte4-v5-8-232a648e63c6@gmail.com>", "References": "<20260504-feat-mte4-v5-0-232a648e63c6@gmail.com>", "In-Reply-To": "<20260504-feat-mte4-v5-0-232a648e63c6@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "Peter Maydell <peter.maydell@linaro.org>,\n Gustavo Romero <gustavo.romero@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>, qemu-arm@nongnu.org,\n Laurent Vivier <laurent@vivier.eu>,\n Gabriel Brookman <brookmangabriel@gmail.com>, Helge Deller <deller@gmx.de>,\n Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,\n Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>", "X-Mailer": "b4 0.15.2", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1777909867; l=3050;\n i=brookmangabriel@gmail.com; s=20251009; h=from:subject:message-id;\n bh=taM0bnxg3Adu1LAuHiTNsQ5a1pkgBVcVSoxgQ7RpzL8=;\n b=PXd9SOLs+rn6qhmUWlWvmWQWAVLFXXbh9o9n60RMRL4bdcbQfcALc5MMOxfMDTMctJ4H5y8ei\n ExvE4fUmm9aCFso3sEwdLDg4d+v+1Xc/dWwrfr/AbUj31gMayUIFC/u", "X-Developer-Key": "i=brookmangabriel@gmail.com; a=ed25519;\n pk=m9TtPDal6WzoHNnQiHHKf8dTrv3DUCPUUTujuo8vNrw=", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::72e;\n envelope-from=brookmangabriel@gmail.com; helo=mail-qk1-x72e.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "With MTX active, address tag bits are checked for canonicity if the\ncorresponding memory regions are not allocation tagged. See\nAArch64_CheckTag.\n\nSigned-off-by: Gabriel Brookman <brookmangabriel@gmail.com>\n---\n target/arm/tcg/mte_helper.c | 30 ++++++++++++++++++++++++++----\n 1 file changed, 26 insertions(+), 4 deletions(-)", "diff": "diff --git a/target/arm/tcg/mte_helper.c b/target/arm/tcg/mte_helper.c\nindex 61cdf92c54..d35e3ef04d 100644\n--- a/target/arm/tcg/mte_helper.c\n+++ b/target/arm/tcg/mte_helper.c\n@@ -858,6 +858,14 @@ static int mte_probe_int(CPUARMState *env, uint32_t desc, uint64_t ptr,\n mem1 = allocation_tag_mem(env, mmu_idx, ptr, type, sizem1 + 1,\n MMU_DATA_LOAD, ra);\n if (!mem1) {\n+ /*\n+ * If mtx is enabled, then the access is MemTag_CanonicallyTagged,\n+ * otherwise it is Untagged. See AArch64.S1DecodeMemAttrs and\n+ * AArch64.S1DisabledOutput.\n+ */\n+ if (mtx_check(desc, bit55)) {\n+ return tag_is_canonical(ptr_tag, bit55);\n+ }\n return 1;\n }\n /* Perform all of the comparisons. */\n@@ -873,18 +881,24 @@ static int mte_probe_int(CPUARMState *env, uint32_t desc, uint64_t ptr,\n \n /*\n * Perform all of the comparisons.\n- * Note the possible but unlikely case of the operation spanning\n- * two pages that do not both have tagging enabled.\n+ * Note the possible but unlikely case of the operation spanning two\n+ * pages that do not both have allocation tagging enabled. This can\n+ * happen with or without mtx (canonical tagging) enabled.\n */\n n = c = (next_page - tag_first) / TAG_GRANULE;\n if (mem1) {\n n = checkN(mem1, ptr & TAG_GRANULE, ptr_tag, c);\n+ } else if (mtx_check(desc, bit55) &&\n+ !tag_is_canonical(ptr_tag, bit55)) {\n+ return 0;\n }\n if (n == c) {\n- if (!mem2) {\n+ if (mem2) {\n+ n += checkN(mem2, 0, ptr_tag, tag_count - c);\n+ } else if (!mtx_check(desc, bit55) ||\n+ tag_is_canonical(ptr_tag, bit55)) {\n return 1;\n }\n- n += checkN(mem2, 0, ptr_tag, tag_count - c);\n }\n }\n \n@@ -999,6 +1013,14 @@ uint64_t HELPER(mte_check_zva)(CPUARMState *env, uint32_t desc, uint64_t ptr)\n mem = allocation_tag_mem(env, mmu_idx, align_ptr, MMU_DATA_STORE,\n dcz_bytes, MMU_DATA_LOAD, ra);\n if (!mem) {\n+ /*\n+ * If mtx is enabled, then the access is MemTag_CanonicallyTagged,\n+ * otherwise it is Untagged. See AArch64.S1DecodeMemAttrs and\n+ * AArch64.S1DisabledOutput.\n+ */\n+ if (mtx_check(desc, bit55) && !tag_is_canonical(ptr_tag, bit55)) {\n+ mte_check_fail(env, desc, ptr, ra);\n+ }\n goto done;\n }\n \n", "prefixes": [ "v5", "08/15" ] }