Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2232373/?format=api
{ "id": 2232373, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2232373/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-44-ef7e3dc94f7a@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260504-qom-tests-v2-44-ef7e3dc94f7a@redhat.com>", "date": "2026-05-04T11:35:32", "name": "[v2,44/46] hw/riscv/virt: free flash devices and OEM strings on finalization", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "70ff307fe36c71253e1cbe714160de16a66b0c9f", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-44-ef7e3dc94f7a@redhat.com/mbox/", "series": [ { "id": 502649, "url": "http://patchwork.ozlabs.org/api/1.1/series/502649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649", "date": "2026-05-04T11:34:48", "name": "Fix various QOM object life-cycle issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232373/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232373/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=AEr5Pno4;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KTm4R2lz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:41:00 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJreR-0002LM-U8; Mon, 04 May 2026 07:39:51 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJreB-0001Rw-UN\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:42 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJreA-0001Vh-D4\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:35 -0400", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-sv7wAvg0PU28B5cmbu4PfQ-1; Mon,\n 04 May 2026 07:39:30 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B2047195608F; Mon, 4 May 2026 11:39:29 +0000 (UTC)", "from localhost (unknown [10.44.24.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7F2CB19560B6; Mon, 4 May 2026 11:39:27 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894773;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=0AAWAtCladMOl9qwPLP2iDIrISuEXK2bC2mKMxeA798=;\n b=AEr5Pno4+ZlDJnf0vu1JNH+HLZ5J1NpxFRAEN+TrNh49XoSZZIyEmKobjqbAKn3RFF6cps\n xbbN/6pZly/pXufunm5In4GpgfOeoCkv0tx7V8TPR7YN1rTwfg9ULT5VwMMSJcTJvx/qDt\n oWT0FeIBw4jQILAwvL6UGMy1MM4AV8I=", "X-MC-Unique": "sv7wAvg0PU28B5cmbu4PfQ-1", "X-Mimecast-MFC-AGG-ID": "sv7wAvg0PU28B5cmbu4PfQ_1777894769", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 04 May 2026 15:35:32 +0400", "Subject": "[PATCH v2 44/46] hw/riscv/virt: free flash devices and OEM strings\n on finalization", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260504-qom-tests-v2-44-ef7e3dc94f7a@redhat.com>", "References": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "In-Reply-To": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Alistair Francis <alistair.francis@wdc.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1650;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=/h+ea/YAa+zMZaaz+w77We67RHGhjm3ilp8FFp4bR8s=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRu7Cb7PLVUHTSESuurD/2/2vJ1Gom2XrysP\n 9DCSV09gWWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbgAKCRDa6OEJdZac\n 5c7mD/4kkJGzwQA+qeasTaVIf+Cbvsj1vjH8ZnEvNKa7xhDGlup63W8UVIVJFMCUmmYk3dhrVV0\n 4KA4OWilDH5ErPbvgYI6X0CnmpupEodQO9OEsgo9pS681V3tfIoyjUGzFu3dxTg+p7QPQwNBk6+\n lizsPgPLyi4xOH313/5H+rAyehaFjGwyWPC+/SWeKzhG1FDBv2/6M5zvGBmivaW95RNth9Rt0xi\n WnG+vnRk0o34tMf6Ottln0DJKJtVsXURM9sBDANOqbsJkVIvu/DddOdUoSjWdUMrBjgyXs9Jevi\n qUMiCM13dju8JLVJT7/ge9cU7/zXiJwCx8YfjGa1vE/niAYPeGEJeZRgSEbYNP/A4G8qOuOOAym\n dvIpetQiQdWdfyBKallJCotmORyQ0Z0Y9dxmDtMFaoenXAT+e9Mw54JkxKjXIYubVo02KKo34GN\n pWxEJzxWyjUywGbJEakzQxxAB+8u4PyakKfrTn+KZGjwTM4Kbgb1mjV/UNxQCP49ZUyT/0X2rMf\n mqe+IzMcB6kTL9I73TuKSR48Hw95Q/WDzoeoxpVBGne+RY3jn6FlWgm+YG4cgOaN7cSNa4qiAoP\n BgQcc+npdNg+u6wHQ+agPPz34Irkuqlr1/JdcZWEyEix+xpYCs46TwS8dL4+uHTvMKI74q0KGS8\n fgF1iMr5kEcBOkg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "8", "X-Spam_score": "0.8", "X-Spam_bar": "/", "X-Spam_report": "(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add instance_finalize to free the two pflash devices (when unrealized)\nand the OEM ID strings allocated during instance_init. Fixes leaks\nfound by ASan.\n\nFixes: 71eb522c4063 (\"riscv/virt: Add the PFlash CFI01 device\")\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Alistair Francis <alistair.francis@wdc.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/riscv/virt.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c\nindex a1c323e66df..315049bc86c 100644\n--- a/hw/riscv/virt.c\n+++ b/hw/riscv/virt.c\n@@ -1745,6 +1745,19 @@ static void virt_machine_init(MachineState *machine)\n qemu_add_machine_init_done_notifier(&s->machine_done);\n }\n \n+static void virt_machine_instance_finalize(Object *obj)\n+{\n+ RISCVVirtState *s = RISCV_VIRT_MACHINE(obj);\n+\n+ for (int i = 0; i < ARRAY_SIZE(s->flash); i++) {\n+ if (s->flash[i] && !qdev_is_realized(DEVICE(s->flash[i]))) {\n+ object_unref(OBJECT(s->flash[i]));\n+ }\n+ }\n+ g_free(s->oem_id);\n+ g_free(s->oem_table_id);\n+}\n+\n static void virt_machine_instance_init(Object *obj)\n {\n RISCVVirtState *s = RISCV_VIRT_MACHINE(obj);\n@@ -1984,6 +1997,7 @@ static const TypeInfo virt_machine_typeinfo = {\n .parent = TYPE_MACHINE,\n .class_init = virt_machine_class_init,\n .instance_init = virt_machine_instance_init,\n+ .instance_finalize = virt_machine_instance_finalize,\n .instance_size = sizeof(RISCVVirtState),\n .interfaces = (const InterfaceInfo[]) {\n { TYPE_HOTPLUG_HANDLER },\n", "prefixes": [ "v2", "44/46" ] }