Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2232371/?format=api
{ "id": 2232371, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2232371/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-46-ef7e3dc94f7a@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260504-qom-tests-v2-46-ef7e3dc94f7a@redhat.com>", "date": "2026-05-04T11:35:34", "name": "[v2,46/46] qtest: add \"qom-tests\" command", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bef8cec89ce98338dacbf507de5b1e9f9ecb6730", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-46-ef7e3dc94f7a@redhat.com/mbox/", "series": [ { "id": 502649, "url": "http://patchwork.ozlabs.org/api/1.1/series/502649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649", "date": "2026-05-04T11:34:48", "name": "Fix various QOM object life-cycle issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232371/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232371/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=hnR/fSlg;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KTf5KGxz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:40:54 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJreS-0002Q9-E4; Mon, 04 May 2026 07:39:52 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJreL-0001a0-Js\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:46 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJreK-0001WJ-2F\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:45 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-XtjKbE28NnWnxmF-LCI41A-1; Mon,\n 04 May 2026 07:39:42 -0400", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 619D2195609F\n for <qemu-devel@nongnu.org>; Mon, 4 May 2026 11:39:41 +0000 (UTC)", "from localhost (unknown [10.44.24.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 01CB91800480; Mon, 4 May 2026 11:39:39 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894783;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=OR1htZtPy9/ewnuvz0qTtYpMlOdlZO7yT3IR5sS3quc=;\n b=hnR/fSlg9C+LQDwFrLraBI1nOUOAkTSGN/Cy41RfthbbI2Km3RAjhc8FZlGLD+xrYPEs8X\n 3uLfxcYwcYajcsuzdOyiXChhfr4zp68qbBn4EfBKE5OLHZDgscpUUUPdHAGQ/pNa7Vu1zC\n AZmZck0Aun5lkVI3HMOJp60wdS/Hxoo=", "X-MC-Unique": "XtjKbE28NnWnxmF-LCI41A-1", "X-Mimecast-MFC-AGG-ID": "XtjKbE28NnWnxmF-LCI41A_1777894781", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 04 May 2026 15:35:34 +0400", "Subject": "[PATCH v2 46/46] qtest: add \"qom-tests\" command", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260504-qom-tests-v2-46-ef7e3dc94f7a@redhat.com>", "References": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "In-Reply-To": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=4927;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=E9TpC9GWV8bqxBoLpoxzMTuPROZJrQcouJvw3SoAg8M=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRuaF0a9jmoWRbNyjGaxuhLUmB4IG74V+4C6\n enXj/Iu1EeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbgAKCRDa6OEJdZac\n 5bUmD/0fsu4AwWUA/xzLySW6gtXHT2lYcJtT1dGUy00pPv43BP3Zy+8hqF71RwUQ0kdq+BfMciV\n 39OO+Y0hUUl8vjtfO//FsVklsl0pIIHjtSFHEqPBEvsCKz/lXfPSNDtpCpy9S0yRt9r5Qvxe5Td\n 0irJWDhspBACxtg6rIwQgs4mW1Ow0KHEOJaUQNj5s947+VYXoqTATNvmLxBLd6GMq49dSpoFCr2\n qyCNfMNdwMZ24QIccLepfGgDmyMmPdypn0R97IuGxN0F0cIo0qmI17croDoNCk2bijXBo7YL4eT\n o9pRRI8uQHzuR4LhuzzEPFamOPhb42cd5HJAzFtW9HBo9gIhqcYe2sAfRW2RTITrFGdGinz+uXe\n 5F7h+lDGENiuEHzsYHVAZgkw8TIGn7kQgmkVmr7nuCpoRto5RvyM2TT3IVUsYwWteT30CZV8Q9y\n JtBaBYqDBrpb3U84FnpIj5WSuIVB3T1EVnxidj1ylovGIytWW400b+nO3dZ7/pAlT587wH3KzSG\n kccOTafecCAwZ36+wI80sWikGPo9BMiaifHQehW/2os0LhWoT35VHuPyYxpF9uV1OrKYHE5foB7\n CkVzsCDgQ5pBc1BQXjvgze11jyd74yZJg5On/T1+t6K8y/TqlaLoQNR/UdT8boqOd7VlFLAuk7A\n wgV7IL/rKK9JpLg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "8", "X-Spam_score": "0.8", "X-Spam_bar": "/", "X-Spam_report": "(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add a new \"qom-tests\" to exercise basic object lifecycle. Instantiate\nall non-abstract objects, get and set properties and unref.\n\nThis should quickly find leaks and other related issues that are\neventually triggerable at run-time with QMP qom commands.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n tests/qtest/libqtest.h | 8 ++++++++\n system/qtest.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++\n tests/qtest/libqtest.c | 6 ++++++\n tests/qtest/qom-test.c | 12 ++++++++++++\n 4 files changed, 72 insertions(+)", "diff": "diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h\nindex 9c118c89ca0..02d65ecb65d 100644\n--- a/tests/qtest/libqtest.h\n+++ b/tests/qtest/libqtest.h\n@@ -426,6 +426,14 @@ char *qtest_vhmp(QTestState *s, const char *fmt, va_list ap)\n \n void qtest_module_load(QTestState *s, const char *prefix, const char *libname);\n \n+/**\n+ * qtest_qom_tests:\n+ * @s: #QTestState instance to operate on.\n+ *\n+ * Run QOM property get/set round-trip tests on all non-abstract types.\n+ */\n+void qtest_qom_tests(QTestState *s);\n+\n /**\n * qtest_get_irq:\n * @s: #QTestState instance to operate on.\ndiff --git a/system/qtest.c b/system/qtest.c\nindex a79d10d1361..a44a581a518 100644\n--- a/system/qtest.c\n+++ b/system/qtest.c\n@@ -31,6 +31,8 @@\n #include \"qemu/cutils.h\"\n #include \"qemu/target-info.h\"\n #include \"qom/object_interfaces.h\"\n+#include \"qom/qom-qobject.h\"\n+#include \"qobject/qobject.h\"\n \n #define MAX_IRQ 256\n \n@@ -754,6 +756,50 @@ static void qtest_process_command(CharFrontend *chr, gchar **words)\n new_ns = qemu_clock_advance_virtual_time(ns);\n qtest_sendf(chr, \"%s %\"PRIi64\"\\n\",\n new_ns == ns ? \"OK\" : \"FAIL\", new_ns);\n+ } else if (strcmp(words[0], \"qom-tests\") == 0) {\n+ GSList *list, *l;\n+\n+ list = object_class_get_list(NULL, false);\n+ for (l = list; l; l = l->next) {\n+ ObjectClass *klass = l->data;\n+ const char *type_name = object_class_get_name(klass);\n+ Object *obj;\n+ ObjectPropertyIterator iter;\n+ ObjectProperty *prop;\n+\n+ obj = object_new_with_class(klass);\n+ object_property_iter_init(&iter, obj);\n+ while ((prop = object_property_iter_next(&iter))) {\n+ QObject *value;\n+ Error *local_err = NULL;\n+\n+ value = object_property_get_qobject(obj, prop->name,\n+ &local_err);\n+ if (local_err) {\n+ error_report(\"qom-tests: %s.%s: get failed: %s\",\n+ type_name, prop->name,\n+ error_get_pretty(local_err));\n+ error_free(local_err);\n+ continue;\n+ }\n+\n+ if (prop->set) {\n+ if (!object_property_set_qobject(obj, prop->name, value,\n+ &local_err)) {\n+ error_report(\"qom-tests: %s.%s: set failed: %s\",\n+ type_name, prop->name,\n+ error_get_pretty(local_err));\n+ error_free(local_err);\n+ }\n+ }\n+\n+ qobject_unref(value);\n+ }\n+\n+ object_unref(obj);\n+ }\n+ g_slist_free(list);\n+ qtest_send(chr, \"OK\\n\");\n } else if (process_command_cb && process_command_cb(chr, words)) {\n /* Command got consumed by the callback handler */\n } else {\ndiff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c\nindex 116a8a32583..1d77d003112 100644\n--- a/tests/qtest/libqtest.c\n+++ b/tests/qtest/libqtest.c\n@@ -1138,6 +1138,12 @@ void qtest_module_load(QTestState *s, const char *prefix, const char *libname)\n qtest_rsp(s);\n }\n \n+void qtest_qom_tests(QTestState *s)\n+{\n+ qtest_sendf(s, \"qom-tests\\n\");\n+ qtest_rsp(s);\n+}\n+\n static int64_t qtest_clock_rsp(QTestState *s)\n {\n gchar **words;\ndiff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c\nindex 6421f2d9d9f..cf4c6b5add5 100644\n--- a/tests/qtest/qom-test.c\n+++ b/tests/qtest/qom-test.c\n@@ -227,6 +227,17 @@ static void add_machine_test_case(const char *mname)\n g_free(path);\n }\n \n+static void test_qom_qtests(void)\n+{\n+ QTestState *qts;\n+\n+ qts = qtest_initf(\"-machine none\");\n+\n+ qtest_qom_tests(qts);\n+\n+ qtest_quit(qts);\n+}\n+\n int main(int argc, char **argv)\n {\n char *v_env = getenv(\"V\");\n@@ -238,6 +249,7 @@ int main(int argc, char **argv)\n g_test_init(&argc, &argv, NULL);\n \n qtest_cb_for_every_machine(add_machine_test_case, g_test_quick());\n+ qtest_add_func(\"qom/qom-qtests\", test_qom_qtests);\n \n return g_test_run();\n }\n", "prefixes": [ "v2", "46/46" ] }