Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2232332/?format=api
{ "id": 2232332, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2232332/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-11-ef7e3dc94f7a@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260504-qom-tests-v2-11-ef7e3dc94f7a@redhat.com>", "date": "2026-05-04T11:34:59", "name": "[v2,11/46] hw/remote: guard listener unregister in finalize", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "04c225de24b951a29e62f7ad3e6707a351e81cf0", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-11-ef7e3dc94f7a@redhat.com/mbox/", "series": [ { "id": 502649, "url": "http://patchwork.ozlabs.org/api/1.1/series/502649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649", "date": "2026-05-04T11:34:48", "name": "Fix various QOM object life-cycle issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232332/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232332/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=e40d0bgq;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KNn5Gfrz1yJV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:36:41 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJrbF-0008DB-Cm; Mon, 04 May 2026 07:36:34 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrb6-0007t2-Rf\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:25 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrb4-0000vH-V4\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:24 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-39-uMSpoYnrNdifZxl2Vf2cXA-1; Mon,\n 04 May 2026 07:36:18 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id ACA28195608B; Mon, 4 May 2026 11:36:17 +0000 (UTC)", "from localhost (unknown [10.44.24.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id B0A6F18001ED; Mon, 4 May 2026 11:36:16 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894582;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=V9+ErlHfhLuXXJDocSDtTnxTzm8IYph61vLIhuadgv4=;\n b=e40d0bgqZYGGl0yd0cH6qtpbHecQfpb07bEehZTZcygroUijeZGBfnGlAaUaPWYNzaEtrn\n jOMnaU5Gfe4JTYF9OfDQB7UBajDewIlclbMZmE+R/YUCn67KWgyVWoHk35xL8F7C6yXfln\n s6sSLBnilhAEioa+jICa+2soYSwe9Ho=", "X-MC-Unique": "uMSpoYnrNdifZxl2Vf2cXA-1", "X-Mimecast-MFC-AGG-ID": "uMSpoYnrNdifZxl2Vf2cXA_1777894577", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 04 May 2026 15:34:59 +0400", "Subject": "[PATCH v2 11/46] hw/remote: guard listener unregister in finalize", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260504-qom-tests-v2-11-ef7e3dc94f7a@redhat.com>", "References": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "In-Reply-To": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n jag.raman@oracle.com", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1108;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=cDsvGetIC+t+iBzuuM/zUrAZ/YOiA8vpcWaT/aLjS2w=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsHm81Ro8UxB2SLtloX7GzTzB2sutTEZhOf\n 6Xo1T/vbbeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac\n 5YRZEAC0UprmduhQmKs2IhVE1Xw7i/4D2Izj1nu5UqC4I7Q71XF1J0vbU0g5YCu2YOtK3n2zZeV\n iwXjR1UV/YSGHllxZohyF0Begoli3oeBJ7SXhqfjEXnEuLm7zmujalQQPBnkgLQDPUA1v4+Kwa2\n R6ac72rq/rk7XQEGHu51atJ7IjYE1cFPWMWcs+ThpKdXZyrhszcH20GDngjtGhKJ6atQ89ynUsA\n 99REwWmi3q1TU3/oM5PEppV3nsgYs/W4cudCfsWTUPafDWVCXkkb7K9cuvU8HHSlpT6O8FIlr3M\n 54E1qcNjrePvxsdEH6jBbMmY/iHCBrb8rdKOvC/8Pxmw8jeKWEqEcXDA04VtdIrtykaeBFHk82Y\n ofAfkc/gz+inT2lJh3/2rO4lpAygAqy5KMc9ZLG/sbMAEn7uMdF4nqTAKx9ZEep+QRuBzkPC9gf\n pfGHTnBMc5khuZ22FdRIyWHXzelkE0XOe3gfqdiJgtSt3IhYs4rurymrjl6D+hsuVTLQiBjOgTW\n loUm6eTBXRYdLUZBGNacW6Z1gFbTzv9zSIMDfsX9KUDeJ62vMxJ1eK+bzIZ6vVHiuXrH4f1m+wW\n R/puMpOqUNU2tNgmgg68W4nPkmZV6ssaoqc7WirA/i9tfV/dB5oS+extr5xAc8TvxbOzy0EzqOE\n Lr0DIOj9gJDWZYg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "8", "X-Spam_score": "0.8", "X-Spam_bar": "/", "X-Spam_report": "(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Guard the unregister by checking whether the listener callback was\nset, which only happens right before registration.\n\nThis is probably better addressed by \"[PATCH] qdev: test if DeviceListener\nis in use\". Just adding this patch for completeness.\n\nCc: jag.raman@oracle.com\nFixes: c7d80c7c1d9 (\"multi-process: Associate fd of a PCIDevice with its object\")\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/remote/remote-obj.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/remote/remote-obj.c b/hw/remote/remote-obj.c\nindex 86192dc8dad..4e74ae76158 100644\n--- a/hw/remote/remote-obj.c\n+++ b/hw/remote/remote-obj.c\n@@ -154,7 +154,9 @@ static void remote_object_finalize(Object *obj)\n RemoteObjectClass *k = REMOTE_OBJECT_GET_CLASS(obj);\n RemoteObject *o = REMOTE_OBJECT(obj);\n \n- device_listener_unregister(&o->listener);\n+ if (o->listener.unrealize) {\n+ device_listener_unregister(&o->listener);\n+ }\n \n if (o->ioc) {\n qio_channel_shutdown(o->ioc, QIO_CHANNEL_SHUTDOWN_BOTH, NULL);\n", "prefixes": [ "v2", "11/46" ] }