Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2232331/?format=api
{ "id": 2232331, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2232331/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-6-ef7e3dc94f7a@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260504-qom-tests-v2-6-ef7e3dc94f7a@redhat.com>", "date": "2026-05-04T11:34:54", "name": "[v2,06/46] hw/remote: check visit return in vfu_object_set_socket", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d725851bbb8f02eb068104b44638e1fe9ad24901", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-6-ef7e3dc94f7a@redhat.com/mbox/", "series": [ { "id": 502649, "url": "http://patchwork.ozlabs.org/api/1.1/series/502649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649", "date": "2026-05-04T11:34:48", "name": "Fix various QOM object life-cycle issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232331/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232331/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cJ5YWN/u;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KNX63QKz1yJV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:36:28 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJrag-0007Za-2v; Mon, 04 May 2026 07:35:58 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrab-0007Z2-Pw\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:53 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJraa-0000oh-Ea\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:53 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-pXubjQhIOfuLO3lkGMdDaw-1; Mon,\n 04 May 2026 07:35:50 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 89B701956095; Mon, 4 May 2026 11:35:49 +0000 (UTC)", "from localhost (unknown [10.44.24.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 3C36E30001A1; Mon, 4 May 2026 11:35:47 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894551;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=twbR98+azl1FkvcOd/wUh0yeF3jLiWAv75fxdQ2s+E0=;\n b=cJ5YWN/uv/NDTE902JpusIHpB86pGDVhr/IeqCf6noUxQnEhIBruKvOIvcoAGniCzFZKyF\n GhQ/11jkdRAm25zlDJD3wEqj9CHjEb2DDGqYJUIt6OFBjw+S+lCuDkNMoQXDu1AqVVNc3F\n TxGq94Czwx1n7WAe1WR+0T1I3w89NWE=", "X-MC-Unique": "pXubjQhIOfuLO3lkGMdDaw-1", "X-Mimecast-MFC-AGG-ID": "pXubjQhIOfuLO3lkGMdDaw_1777894549", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 04 May 2026 15:34:54 +0400", "Subject": "[PATCH v2 06/46] hw/remote: check visit return in\n vfu_object_set_socket", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260504-qom-tests-v2-6-ef7e3dc94f7a@redhat.com>", "References": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "In-Reply-To": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Jagannathan Raman <jag.raman@oracle.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1072;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=L2BEfE5R8VEhm76+lymFWMxq2H9P0VB/u9ntt4F1tss=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsLkMZf8r3xhP0bfbc05+BzOHRnHn7t3ZXL\n FmhOPNUK2+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac\n 5ZQRD/9Lo+ATGQUt2vIinMLlnZOTrsTKCzFMPUY77jtpgij+dOTK4WyVHbcPm79ZfOzQtRVHKwH\n 4ZxDjjfiFWYi2yBvdea80HLx8vuWEMumK6jYXSU962t95jANkcRGJKNAiYyGH8YkHOSRGRsWl7X\n 5yjAoX8N75x6kXob8u3j97zRv49V1T9b2B/F1C09Z+QPsNNg2CE1M5b0vzvqe+ynvOg5sjUtDa5\n Dko6N8hlY7f2K2UL7dOi+jpyGjSHzeOGg3PIA7+QC/Aj29O+eQo2FwavDMMaUPiCj0v+3AKHiE/\n j4QjN5DFwCUwYPA2b65+u66yY1q0r/lVAtb//ORabmUoyHtWg/vg9HF+ZjxDFZHdmShqUjHZ0QB\n jzU9BokxziTmfsD9fcTIkoBkhKwE0zmbIQrUcsU8HPGwMAreaWMPH1K9DBczcBPKU/tK+GCu9zS\n I4oKogWt4HvgI0zTmWBm5OFvouffr+lASENQMrSawmHZu3St3gxmae9lg7BjMOHIU9+4G4mVvP1\n ZWH1ImuElCodouNQqQj7rS12jqyN2qaa9DjZjB3DJRJ0DZnNHphGaQLQxtXOSbxyO3VxvL5fvg1\n R4v7WOqgni3+mcNzcvoYrJz3vVRDTUPHNG4SJzY7NLYa4pKPPM+WOw4IAF2QFzOHC6TU3xZ5EaC\n A67h4NLf98aFlJQ==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "8", "X-Spam_score": "0.8", "X-Spam_bar": "/", "X-Spam_report": "(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "vfu_object_set_socket() dereferences o->socket without checking if\nvisit_type_SocketAddress() succeeded. On failure, o->socket remains\nNULL, leading to a NULL dereference. Check the return value.\n\nFixes: 8f9a9259d32c (\"vfio-user: define vfio-user-server object\")\nReviewed-by: Jagannathan Raman <jag.raman@oracle.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/remote/vfio-user-obj.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c\nindex 12ecdab6dea..49bf5ecae0c 100644\n--- a/hw/remote/vfio-user-obj.c\n+++ b/hw/remote/vfio-user-obj.c\n@@ -161,7 +161,9 @@ static void vfu_object_set_socket(Object *obj, Visitor *v, const char *name,\n \n o->socket = NULL;\n \n- visit_type_SocketAddress(v, name, &o->socket, errp);\n+ if (!visit_type_SocketAddress(v, name, &o->socket, errp)) {\n+ return;\n+ }\n \n if (o->socket->type != SOCKET_ADDRESS_TYPE_UNIX) {\n error_setg(errp, \"vfu: Unsupported socket type - %s\",\n", "prefixes": [ "v2", "06/46" ] }