Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2232330/?format=api
{ "id": 2232330, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2232330/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-7-ef7e3dc94f7a@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260504-qom-tests-v2-7-ef7e3dc94f7a@redhat.com>", "date": "2026-05-04T11:34:55", "name": "[v2,07/46] hw/ipmi: reject NULL 'bmc' property rather than crash", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1c843d636b1db95d35a25f47c38f185697b9f700", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-7-ef7e3dc94f7a@redhat.com/mbox/", "series": [ { "id": 502649, "url": "http://patchwork.ozlabs.org/api/1.1/series/502649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649", "date": "2026-05-04T11:34:48", "name": "Fix various QOM object life-cycle issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232330/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232330/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=DB7IM9bd;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KNV3ZNYz1yJV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:36:26 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJraj-0007lJ-Aj; Mon, 04 May 2026 07:36:01 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrai-0007h2-2l\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:00 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrag-0000qJ-Km\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:59 -0400", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-tRbopzuzN3enjrmC0QXifA-1; Mon,\n 04 May 2026 07:35:56 -0400", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 591851956071\n for <qemu-devel@nongnu.org>; Mon, 4 May 2026 11:35:55 +0000 (UTC)", "from localhost (unknown [10.44.24.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D3B741800480; Mon, 4 May 2026 11:35:53 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894557;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Vk6EPK8YN6D3adylJlyTRAZVvpCyDA9Qp3WjzVTfNyY=;\n b=DB7IM9bdQdWZAZCEUDrgSqUviHsXKUBGuVKswUUkUP9mL9AapUyJsAOpnJOOeGT4q1049i\n 7RDbOUp9+U1aNk8t4fFtCLVUETo857U8WXljypZ37ARcUKHD0cx13FGlQSoTjd2EhKm1NC\n k/uIwq3GsuAM2Ws4LS2hz02fvAk7s1o=", "X-MC-Unique": "tRbopzuzN3enjrmC0QXifA-1", "X-Mimecast-MFC-AGG-ID": "tRbopzuzN3enjrmC0QXifA_1777894555", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 04 May 2026 15:34:55 +0400", "Subject": "[PATCH v2 07/46] hw/ipmi: reject NULL 'bmc' property rather than\n crash", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260504-qom-tests-v2-7-ef7e3dc94f7a@redhat.com>", "References": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "In-Reply-To": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=845;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=IaYWXas6d6Tx+GiU2CWhWCCTpxN6xrywSSwek/zs5Bg=;\n b=kA0DAAoB2ujhCXWWnOUByyZiAGn4hGyiWY+f0R5WzkO9IDcoS0Rg+wsAzRMdGV8Wy3/uM+JED\n 4kCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJp+IRsAAoJENro4Ql1lpzlUFAQAJDz\n Arx42qH/TZri8CDSArjgwM6MsZuAEG4p1MKyOqTlGJINSGl3FGKPH1D7mFB1OsZLX4Ng0631L09\n pXZnEOkjPgsAaA2UnjDzkdJlPItsvnUEBiqNqKnOEdNilz1A0WIdBI0EiRH7X6qsf6B25tnT3v1\n kW3yoJ4TIcdFjjfqd/juGta7jtySvCbo8DUtmzhvP37OrAnrXcsPALrn9bpQdg4uy0z0GlRBs5T\n WrF57NrV/axijvDMUjA4WQ/nQ+saSEsvgQ7IxtXnMzVGsydnc44j1QOCdQcjCVbhQEVQLkKSJnm\n TtI8KQk6CXbv2052hdYhwHUuexqpiQlTTW4Kp722C8mhbZWW3JxbbAekFqhcA1aoICvrzKF32hJ\n 5LMpkeVYYlcomtAPZlvaNLvq0wfKL8zU6NpB2eVebtu2gl8bJozmRCbfsXAkcHQNtN2/OghJMhP\n FV3rvXukv2W61KrXAl3oSJrlrw4H8/8chKke+Vl4Hlxvhu6Vik2O4wGCjH5aueAPTniz3J1/jCw\n Ac1EcZgr4ny79azUwvKajn07sdmD9bvVnfmejGo1R3mMsNMqhAZjrXtAMtgOj2qubOaP7eqJobn\n /xLlef6JW3EY0bII+4FGs6yd8XHpxCZHedxc7SyNq1Ply5WUaQl1jeG5RR84RZs9E9Vnn9x4x35\n gbuNw", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "8", "X-Spam_score": "0.8", "X-Spam_bar": "/", "X-Spam_report": "(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The type-checking macros (IPMI_BMC(val)) which crash on NULL.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/ipmi/ipmi.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c\nindex b49affaccec..d532d38e556 100644\n--- a/hw/ipmi/ipmi.c\n+++ b/hw/ipmi/ipmi.c\n@@ -95,7 +95,14 @@ static const TypeInfo ipmi_interface_type_info = {\n static void isa_ipmi_bmc_check(const Object *obj, const char *name,\n Object *val, Error **errp)\n {\n- IPMIBmc *bmc = IPMI_BMC(val);\n+ IPMIBmc *bmc;\n+\n+ if (!val) {\n+ error_setg(errp, \"%s cannot be set to NULL\", name);\n+ return;\n+ }\n+\n+ bmc = IPMI_BMC(val);\n \n if (bmc->intf)\n error_setg(errp, \"BMC object is already in use\");\n", "prefixes": [ "v2", "07/46" ] }