Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2232329/?format=api
{ "id": 2232329, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2232329/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-2-ef7e3dc94f7a@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260504-qom-tests-v2-2-ef7e3dc94f7a@redhat.com>", "date": "2026-05-04T11:34:50", "name": "[v2,02/46] chardev/char-socket: handle NULL addr in char_socket_get_addr", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "81f5e833beb7008b112340fd74bc174fd4a449fd", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-2-ef7e3dc94f7a@redhat.com/mbox/", "series": [ { "id": 502649, "url": "http://patchwork.ozlabs.org/api/1.1/series/502649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649", "date": "2026-05-04T11:34:48", "name": "Fix various QOM object life-cycle issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232329/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232329/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=e62bol9j;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KN33LjZz1yJV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:36:01 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJraH-0007Vb-Sl; Mon, 04 May 2026 07:35:33 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJraG-0007VF-6Y\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:32 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJraE-0000mW-K7\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:31 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-LF_L3OPCMDi3m07flGrlDw-1; Mon,\n 04 May 2026 07:35:27 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 2D18418004AD\n for <qemu-devel@nongnu.org>; Mon, 4 May 2026 11:35:27 +0000 (UTC)", "from localhost (unknown [10.44.24.4])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D76311955D84; Mon, 4 May 2026 11:35:25 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894529;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=iO87o/0YYcEWxdVsD3TnBacBB5QSuCWhHLZQkTvzHEc=;\n b=e62bol9j2kbUVOxGSNL30w5xgVHIQaB1gEzSlPh2vRy/w+oBiGaDB1GqKq8Mn0pzTA0bYm\n TbxZ0GlB+fO77SyJ8mI/hzd1iQmfC4enzr+Y37XF0rdkyeMCUvRmvkuqfyrGcN/UyS4IZb\n zeJzGUHjMpi9KtHOmxdlFV+V43CPoXc=", "X-MC-Unique": "LF_L3OPCMDi3m07flGrlDw-1", "X-Mimecast-MFC-AGG-ID": "LF_L3OPCMDi3m07flGrlDw_1777894527", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 04 May 2026 15:34:50 +0400", "Subject": "[PATCH v2 02/46] chardev/char-socket: handle NULL addr in\n char_socket_get_addr", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260504-qom-tests-v2-2-ef7e3dc94f7a@redhat.com>", "References": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "In-Reply-To": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=807;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=ec79R6dwgSUru8iZAGVoGIdElFOC+Hue6wBEH561cpo=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRrp5dZG6laMv5/TNbO9JcdzAICs28J0fUZR\n I5MBj3QHtGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEawAKCRDa6OEJdZac\n 5VrwEACLlYtxn40bBXyv/V2Z4ofbnVwaij0izQ2Y0cMi9QVZYaG1g80HttN/R5lsZ8igFpVevV9\n 5r7fQrL67GGz7q3PobcbjTvAA1IacujG1+LTfUoH+w1kuXyB0uTXnft2z8+tc78PZwgc5Z+cEix\n DuVzqZ0z8GsrvrIfcmoKNwEaFBKa5nMeTw0FPlD0/6OaWIOvzlpYGdIoTHcQCtTqNTtrZe9I8o9\n h1Hc6zP/u+2x3GiwQaefcy85pETtwLzSsPjCJdrf2t1unZxadu83TYVu8P1WHgiwoOMDYccxjkk\n PbwiFJQwFHSJ+mBuIu93Z943Jm/L6B07nN0yaL6fT7LQDQUXj/6XUnnsx/A0NHLlWur5uO6DwVn\n yk3KfoVI9yw6Zo0GXmz9XyG1D8kYNcEQSfpESTKjFosO93dr+9fREEYCqw87P72IJmOONqJvNJP\n dzJWn7CYiA0kueS2RTaNnn0vRi/sZ6JnDrRzZzTHuYm+xt/XLIcwzRJSMM/98P0/FVhV6eRXp8m\n OtkyQPDlgaQnnrYOWGDB4CcM75v9OU1iFN6/l14SNxJJtgw52VgimzA3yZTFF/H34mmH8zE1cXE\n MojndqGq+mB7c30ZhQluRHllN3yjNhgi2lc3y8C7bkHcCAnp5xJPRs/F3ptA364JW2fIi6TkQwQ\n B8PZ5UPKVpN0ZOg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-24", "X-Spam_score": "-2.5", "X-Spam_bar": "--", "X-Spam_report": "(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "When called on an unrealized chardev (e.g. from\nqmp_qom_list_properties), s->addr is NULL. Return an error instead of\nassert().\n\nFixes: 123676e9894f (\"char-socket: add 'addr' property\")\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n chardev/char-socket.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/chardev/char-socket.c b/chardev/char-socket.c\nindex e064b105c50..b629575fcf8 100644\n--- a/chardev/char-socket.c\n+++ b/chardev/char-socket.c\n@@ -1529,6 +1529,10 @@ char_socket_get_addr(Object *obj, Visitor *v, const char *name,\n {\n SocketChardev *s = SOCKET_CHARDEV(obj);\n \n+ if (!s->addr) {\n+ error_setg(errp, \"socket not connected\");\n+ return;\n+ }\n visit_type_SocketAddress(v, name, &s->addr, errp);\n }\n \n", "prefixes": [ "v2", "02/46" ] }