Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2231998/?format=api
{ "id": 2231998, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2231998/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260501225152.90136-2-kai.aizen.dev@gmail.com/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/1.1/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260501225152.90136-2-kai.aizen.dev@gmail.com>", "date": "2026-05-01T22:51:51", "name": "[6.1.y] ksmbd: add chann_lock to protect ksmbd_chann_list xarray", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4361dd671436657dab4f503f2cc62a351501175b", "submitter": { "id": 93301, "url": "http://patchwork.ozlabs.org/api/1.1/people/93301/?format=api", "name": "Kai Aizen", "email": "kai.aizen.dev@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260501225152.90136-2-kai.aizen.dev@gmail.com/mbox/", "series": [ { "id": 502503, "url": "http://patchwork.ozlabs.org/api/1.1/series/502503/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=502503", "date": "2026-05-01T22:51:51", "name": "[6.1.y] ksmbd: add chann_lock to protect ksmbd_chann_list xarray", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502503/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231998/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231998/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-cifs+bounces-11348-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=BcaDPRqA;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11348-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"BcaDPRqA\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.50", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6mWQ3MYfz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 02 May 2026 08:52:02 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 0D15D300FFBA\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 1 May 2026 22:52:00 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CCD4B37D10C;\n\tFri, 1 May 2026 22:51:59 +0000 (UTC)", "from mail-wm1-f50.google.com (mail-wm1-f50.google.com\n [209.85.128.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 371C037C917\n\tfor <linux-cifs@vger.kernel.org>; Fri, 1 May 2026 22:51:58 +0000 (UTC)", "by mail-wm1-f50.google.com with SMTP id\n 5b1f17b1804b1-488b0e1b870so37133575e9.2\n for <linux-cifs@vger.kernel.org>;\n Fri, 01 May 2026 15:51:58 -0700 (PDT)", "from localhost.localdomain ([77.124.36.154])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-44a98b76fd0sm8040341f8f.35.2026.05.01.15.51.55\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 01 May 2026 15:51:56 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777675919; cv=none;\n b=IVdvzx9u2TJxvfawOSRNwpHIdmen4RlC7Mcl9iwMFGVo5S7X/iSEnt4P0Eg++KEDIbU76U4ELG7f2Objbs5aNqstuOQ3gJSlyc8p8Y9uelRYLP28YHPE8GSrsRlsZLTJZ3ez4yAY5TdDMSAEuEHey4pV6oCkwtRjV+EYFwVH9PI=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777675919; c=relaxed/simple;\n\tbh=sj+0TveqgFbria1WecUz8+lNLyXt3YQquh2jnrnlr9w=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=TV2h6lYJTCCqZnICj94PbJnKuWujsroK1xuEBA88uE8F+uxiQ0f+xMpFHqoAQM7O7KKx9mqhW6PtgMakyDyZ8Q5rCoQH6eqPPjZ+4JJFPxOTVuN2CaVrx/5Qtjl9wFtBypMPDwYcSzJJEt57QX704VGc9eE3B24uplq0WeNNiqg=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=BcaDPRqA; arc=none smtp.client-ip=209.85.128.50", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777675917; x=1778280717;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=gwNDW+V2ZInjYz2679mwWIRItMIlkpJfBjr27qXLa8Y=;\n b=BcaDPRqAJprjabvBPa/5BvjjlFoy/dYedfKc7LRO7Wy3ok0CDJPqvZ7z7Wu97uVRUs\n DUAznbWzZ+VCo6032MIFtSi7ekTkYliIeb7FWGHKr9E8TDyj3XNg3FXE9u44AjFuGURI\n R90PmCWFtTYM5Q3ptKQWxxt9k6TXu0hwfCz3AzvR86mKds+3lCacZXWovfxfOHwLObQ2\n UqjkIO+PYAwFsxcTYWpvkEwKXsJoBAyddscHkVEIWx95+k9vWvw4Oi9ubAa2PYJLAXmd\n 1dnowyhq3EztmjmKWm6c9lA3fWNE8Y2OdbjfZHtrFRCAX+7aK/b5wDwsToskcqGavj3j\n w4wg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777675917; x=1778280717;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=gwNDW+V2ZInjYz2679mwWIRItMIlkpJfBjr27qXLa8Y=;\n b=FsxY8Isa2AUr0o+8YrCM3/vgF6825J9OEYkZUgQstdA61OOeru8GatfWiQHPZSdOZG\n IiJ7A1vj6HWMOJv+VuxSzzqqiLuQuZaBN9B8IKgc89zG9nZ2l7nXnpvdo0mUjhbm+zID\n c0lzVjisNuggdI3vpoOburga7qLKrEZNB0X9RTlT2YgCaogBb7kVdVlXAOQR+xjQpO3C\n d2Yov2xsrsZ0FWY74QOXG/TW0lZHM9XOM5IP+WnS4QJ3plMcGbE5hBtKSJfTvFsbKIiv\n 1sVTl1ltUzBqRglPBY9Z205fD8jUOF0mvFJom9jI9PKXN8DEJIoeeiDhJchWetUaQUBT\n tL1A==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ+SQnXfG48/AeIeI68XyW0v9SARtFckK84iffk/QmIWVMd+hXADfMs+kQod/vXzBrHW+0HEW2jKeOBv@vger.kernel.org", "X-Gm-Message-State": "AOJu0YzXvPJsM5n/Q2+qDoj25nRRoxrO1HRwiF0FDdO9JM0CSGlmufqX\n\tz9KAgk+YhrOTXAi6v/2auOefmLb6ArusZUTT3qxdUD42At8HpEpDJUZE", "X-Gm-Gg": "AeBDievjkyILPWsRdAi4YspDkemKK3NdoIe+SlwevPgU30mcoj1reXWXLOsUX/A+Iv2\n\tdBrnGYZoYQib24umdDCrAz44TGfCtM+S7s+XGt2qucdhJ4FsPvrRwafGRdJqdUonPvLknoYjji8\n\tnwAQxz0h670/zq+GnifrtLHd8nJtZt01aC14bcjPZ6Xg4Ee4thj3zUCMYhhPplD8DGgFLS5waod\n\t7TOnvsXx9wT/lnMdrAMzmDw7fUyxjoajrSWnYH7DfJRCIcizaBWsvJHQPcTqFVAi4SBlipmlrxA\n\tKpnJTy2KcPly/jtyvris5odBBxd+h/RefCN8TNGdjWfeqENtxw3O6fv/jAZIG8UD6PUH94X+D8L\n\t/F3o2rW4qecc/erGhgR6xSVIhhwXc+TvWdBhVs4sI8lq6yljylMWldztxL/JF7V8W7zH9Dsg8nn\n\txnHdzSVwn3oqqIIbnyZId7U/j8qOBPbAqFGdu1k3Vw27ZzyFx8zbYbQhdPMBcxG8lz2OgS1rUxB\n\togjzu5RQ3Giol8Zj+1t0u7SxA==", "X-Received": "by 2002:a05:6000:40c7:b0:43d:6787:992f with SMTP id\n ffacd0b85a97d-44bb37c7fabmr1783295f8f.10.1777675916470;\n Fri, 01 May 2026 15:51:56 -0700 (PDT)", "From": "Kai Aizen <kai.aizen.dev@gmail.com>", "To": "stable@vger.kernel.org", "Cc": "gregkh@linuxfoundation.org,\n\tlinkinjeon@kernel.org,\n\tlinux-cifs@vger.kernel.org,\n\tsamba-technical@lists.samba.org", "Subject": "[PATCH 6.1.y] ksmbd: add chann_lock to protect ksmbd_chann_list\n xarray", "Date": "Sat, 2 May 2026 01:51:51 +0300", "Message-ID": "<20260501225152.90136-2-kai.aizen.dev@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260501225152.90136-1-kai.aizen.dev@gmail.com>", "References": "<20260501225152.90136-1-kai.aizen.dev@gmail.com>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "From: Namjae Jeon <linkinjeon@kernel.org>\n\n[ Upstream commit 4f3a06cc57976cafa8c6f716646be6c79a99e485 ]\n\nksmbd_chann_list xarray lacks synchronization, allowing use-after-free in\nmulti-channel sessions (between lookup_chann_list() and ksmbd_chann_del).\n\nAdds rw_semaphore chann_lock to struct ksmbd_session and protects\nall xa_load/xa_store/xa_erase accesses.\n\nBackport notes for linux-6.1.y:\n - The smb client/server consolidation has already happened by 6.1.y;\n file paths are fs/smb/server/, identical to mainline.\n - The xa_store call sites use the older form\n `xa_store(..., GFP_KERNEL)` with no captured `old`, but the\n surrounding context for the lock-wrap is identical.\n\nCVE: CVE-2026-23226\nCc: stable@vger.kernel.org # 6.1.y\nReported-by: Igor Stepansky <igor.stepansky@orca.security>\nSigned-off-by: Namjae Jeon <linkinjeon@kernel.org>\nSigned-off-by: Steve French <stfrench@microsoft.com>\n[backport for linux-6.1.y, verified 2026-05-01]\n---\n fs/smb/server/mgmt/user_session.c | 5 +++++\n fs/smb/server/mgmt/user_session.h | 1 +\n fs/smb/server/smb2pdu.c | 12 +++++++++++-\n 3 files changed, 17 insertions(+), 1 deletion(-)\n\n--\n2.43.0", "diff": "diff --git a/fs/smb/server/mgmt/user_session.c b/fs/smb/server/mgmt/user_session.c\n--- a/fs/smb/server/mgmt/user_session.c\n+++ b/fs/smb/server/mgmt/user_session.c\n@@ -30,12 +30,14 @@ static void free_channel_list(struct ksmbd_session *sess)\n \tstruct channel *chann;\n \tunsigned long index;\n\n+\tdown_write(&sess->chann_lock);\n \txa_for_each(&sess->ksmbd_chann_list, index, chann) {\n \t\txa_erase(&sess->ksmbd_chann_list, index);\n \t\tkfree(chann);\n \t}\n\n \txa_destroy(&sess->ksmbd_chann_list);\n+\tup_write(&sess->chann_lock);\n }\n\n static void __session_rpc_close(struct ksmbd_session *sess,\n@@ -218,7 +220,9 @@ static int ksmbd_chann_del(struct ksmbd_conn *conn, struct ksmbd_session *sess)\n {\n \tstruct channel *chann;\n\n+\tdown_write(&sess->chann_lock);\n \tchann = xa_erase(&sess->ksmbd_chann_list, (long)conn);\n+\tup_write(&sess->chann_lock);\n \tif (!chann)\n \t\treturn -ENOENT;\n\n@@ -417,6 +421,7 @@ static struct ksmbd_session *__session_create(int protocol)\n \trwlock_init(&sess->tree_conns_lock);\n \tatomic_set(&sess->refcnt, 2);\n \tinit_rwsem(&sess->rpc_lock);\n+\tinit_rwsem(&sess->chann_lock);\n\n \tret = __init_smb2_session(sess);\n \tif (ret)\ndiff --git a/fs/smb/server/mgmt/user_session.h b/fs/smb/server/mgmt/user_session.h\n--- a/fs/smb/server/mgmt/user_session.h\n+++ b/fs/smb/server/mgmt/user_session.h\n@@ -48,6 +48,7 @@ struct ksmbd_session {\n \tchar\t\t\t\tsess_key[CIFS_KEY_SIZE];\n\n \tstruct hlist_node\t\thlist;\n+\tstruct rw_semaphore\t\tchann_lock;\n \tstruct xarray\t\t\tksmbd_chann_list;\n \tstruct xarray\t\t\ttree_conns;\n \tstruct ida\t\t\ttree_conn_ida;\ndiff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c\n--- a/fs/smb/server/smb2pdu.c\n+++ b/fs/smb/server/smb2pdu.c\n@@ -79,7 +79,13 @@ static inline bool check_session_id(struct ksmbd_conn *conn, u64 id)\n\n struct channel *lookup_chann_list(struct ksmbd_session *sess, struct ksmbd_conn *conn)\n {\n-\treturn xa_load(&sess->ksmbd_chann_list, (long)conn);\n+\tstruct channel *chann;\n+\n+\tdown_read(&sess->chann_lock);\n+\tchann = xa_load(&sess->ksmbd_chann_list, (long)conn);\n+\tup_read(&sess->chann_lock);\n+\n+\treturn chann;\n }\n\n /**\n@@ -1567,7 +1573,9 @@ static int ntlm_authenticate(struct ksmbd_work *work,\n \t\t\t\treturn -ENOMEM;\n\n \t\t\tchann->conn = conn;\n+\t\t\tdown_write(&sess->chann_lock);\n \t\t\txa_store(&sess->ksmbd_chann_list, (long)conn, chann, GFP_KERNEL);\n+\t\t\tup_write(&sess->chann_lock);\n \t\t}\n \t}\n\n@@ -1660,7 +1668,9 @@ static int krb5_authenticate(struct ksmbd_work *work,\n \t\t\t\treturn -ENOMEM;\n\n \t\t\tchann->conn = conn;\n+\t\t\tdown_write(&sess->chann_lock);\n \t\t\txa_store(&sess->ksmbd_chann_list, (long)conn, chann, GFP_KERNEL);\n+\t\t\tup_write(&sess->chann_lock);\n \t\t}\n \t}\n\n", "prefixes": [ "6.1.y" ] }