Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2231955/?format=api
{ "id": 2231955, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2231955/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260501162634.4092394-1-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260501162634.4092394-1-peter.maydell@linaro.org>", "date": "2026-05-01T16:26:34", "name": "hw/i2c/microbit_i2c: Don't index off end of twi_read_sequence[]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c17a3bc03b37cbf3c57e7c7e7b21abe8f1035dcd", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/1.1/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260501162634.4092394-1-peter.maydell@linaro.org/mbox/", "series": [ { "id": 502481, "url": "http://patchwork.ozlabs.org/api/1.1/series/502481/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502481", "date": "2026-05-01T16:26:34", "name": "hw/i2c/microbit_i2c: Don't index off end of twi_read_sequence[]", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502481/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231955/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231955/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=kf3+wbzT;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6bzB4WTSz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 02 May 2026 02:27:02 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIqhM-0007Vx-Tk; Fri, 01 May 2026 12:26:40 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wIqhL-0007VY-1P\n for qemu-devel@nongnu.org; Fri, 01 May 2026 12:26:39 -0400", "from mail-wm1-x335.google.com ([2a00:1450:4864:20::335])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wIqhJ-00081Z-EZ\n for qemu-devel@nongnu.org; Fri, 01 May 2026 12:26:38 -0400", "by mail-wm1-x335.google.com with SMTP id\n 5b1f17b1804b1-48a563e4ef7so20025815e9.0\n for <qemu-devel@nongnu.org>; Fri, 01 May 2026 09:26:37 -0700 (PDT)", "from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a820c865esm129172755e9.5.2026.05.01.09.26.34\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 May 2026 09:26:35 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777652796; x=1778257596; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=mmiMA9qK8lid2+4XBA9PvoBX50ox7NRv+ljhQLzau9w=;\n b=kf3+wbzTdaTIX4D2Jgr8+fL4IgHqUrqgt7CGQv2+FwtOYRtA8Ksmj4ZNVebAtsrHs8\n S3qB2zUBiV9kxIs/t7V+6nUz2QH/vWSBnqfZTDSzapfdPlcqB6b7PnXFjcZDDuuSpsaI\n R1dTkc9h5P2gMnbeYC+4qK0D/XKDpitAEilUNHMPqBCgsaII0cA3iwBahswC/XFNjeyU\n /qayJJAR+MlSMirvPuv9pNQ7/OrOXS3DavinsM98BxFs76CkDoeOer0RU6ncl2504rNx\n DhXTw4QN593I0eXqJg1Nt9I64KgyzYGDXuI0EUm0RyGhlbZ/1hfG5FiYqJ7aAaayhU7W\n pJgw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777652796; x=1778257596;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=mmiMA9qK8lid2+4XBA9PvoBX50ox7NRv+ljhQLzau9w=;\n b=kPtuIIpxip2FccMY5Po7IK7u/u6CRothEO+ZxTCtG7Km7OwOkCfKGo9URWbHT2oEnx\n AxjKanGslz2HkYz86qemjpgN+pQ1SLOtGs8HQkOAn5V3TS68FwG9ZFvKqdwQLEs38AJ8\n dsl7LPyNI2OANr/JrReQGZWfsTMDPQdfjo7Yp6RzANLqPn61ZmH7JZ7kUG86T6IPKtGB\n nuaZsksvpS5VwgVqXn7AlEP75UuCY++CYngrWwF5ydAFzrC6RUGVYcPJl9yR9bymCbJ3\n yzeH0f6TI0DgVdW5HaMKc8uOUHdQQZ6+IneE5mdQ8p5TPgwCXIbTufRfpYJmUQ9E0rRC\n +njA==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ/Ye7rWE7qbvpuFKI3mpdbtuB1CUW9N6Qe7gTBp5wN08ma6eX1nEVLYnhF9U1PIrfT0lM6HLvy9GEoj@nongnu.org", "X-Gm-Message-State": "AOJu0YyP5mFyCcl9kl+xDy2yHV4xzQ20UKkCpgQIsO6RB5sSwT3nbM2p\n xOKMysGxEocsrE7V4mFVPAh9GFlshRfGAZf3cr1WCrDrvUY0iG/jRbGbxGLlC+biS7k=", "X-Gm-Gg": "AeBDievyfDrfmaPCIoeQNsKqzaFXKySRLFlKBIjiXWTtSko9OoZ5bn1ZmygzLJm4THu\n qTY+EBzGHcXLhS8eSs6rvAygPvKep/7EfbloioliWtqZ97SF0MMChM1R3Th2ortb/NrkIXcgqO4\n YMUqkY+KfzUbiJK3ykHzDxGbI0sRc5Ybp6PajutNduI4udSwkSA97GFYEAfy4vDJP45Q7bG8rWg\n ojRX6Yy3s3bSl+XsGhzN5dohImsgEuncuA9EqgB8A8TdDjs91q2HEqPYCH17DJgvC8AOdcpdhx7\n 98lIJ2DMCRoaQLyOScA/BvqQlXpW9dm83Lg+hM89oAHIADg0nxscs9v+HFaV4IpWEagEj7IlOjC\n dqncd5Ga7hQilAwl4aoBpQic5ctv0zv/ZryUGbbAmm0AmbIqD7lT2qPABYniZCZEkpnluHc2oJq\n /1BmhsehVZySjmJabhpV0/juJxa22SipMR8tTt4x1eAqJb57/hg2NkdctSYXXRz62OqdaoDKIkr\n GebPcko2vQtTBdCT6nHbDkDn2D6WIisMqp8v4tmJg==", "X-Received": "by 2002:a05:600c:6285:b0:488:a797:f0ac with SMTP id\n 5b1f17b1804b1-48a84485623mr137002515e9.28.1777652795666;\n Fri, 01 May 2026 09:26:35 -0700 (PDT)", "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org", "Cc": "Joel Stanley <joel@jms.id.au>", "Subject": "[PATCH] hw/i2c/microbit_i2c: Don't index off end of\n twi_read_sequence[]", "Date": "Fri, 1 May 2026 17:26:34 +0100", "Message-ID": "<20260501162634.4092394-1-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::335;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x335.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "If the guest tries to read more bytes from our fake stub I2C device\nthan we have provided, we incorrectly read one byte beyond the end of\nthis array. Avoid this, and instead keep reporting the RXD register\nas containing the last byte of the \"data transfer\".\n\nCc: qemu-stable@nongnu.org\nFixes: 9d68bf564ec (\"arm: Stub out NRF51 TWI magnetometer/accelerometer detection\")\nResolves: https://gitlab.com/qemu-project/qemu/-/work_items/3408\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\n hw/i2c/microbit_i2c.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/i2c/microbit_i2c.c b/hw/i2c/microbit_i2c.c\nindex 2291d6370e..d9689b6f1a 100644\n--- a/hw/i2c/microbit_i2c.c\n+++ b/hw/i2c/microbit_i2c.c\n@@ -41,8 +41,13 @@ static uint64_t microbit_i2c_read(void *opaque, hwaddr addr, unsigned int size)\n data = 0x01;\n break;\n case NRF51_TWI_REG_RXD:\n+ /*\n+ * Return the next byte from our fake data sequence. If\n+ * the guest keeps reading the register after that, keep\n+ * returning the same last byte value.\n+ */\n data = twi_read_sequence[s->read_idx];\n- if (s->read_idx < G_N_ELEMENTS(twi_read_sequence)) {\n+ if (s->read_idx + 1 < G_N_ELEMENTS(twi_read_sequence)) {\n s->read_idx++;\n }\n break;\n", "prefixes": [] }