Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2231907/?format=api
{ "id": 2231907, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2231907/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260501150550.228937-1-heinrich.schuchardt@canonical.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.1/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260501150550.228937-1-heinrich.schuchardt@canonical.com>", "date": "2026-05-01T15:05:50", "name": "[1/1] efi_loader: set correct frame buffer address", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fd07640e68c1e289f9dd074fe111931593177963", "submitter": { "id": 82181, "url": "http://patchwork.ozlabs.org/api/1.1/people/82181/?format=api", "name": "Heinrich Schuchardt", "email": "heinrich.schuchardt@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260501150550.228937-1-heinrich.schuchardt@canonical.com/mbox/", "series": [ { "id": 502472, "url": "http://patchwork.ozlabs.org/api/1.1/series/502472/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=502472", "date": "2026-05-01T15:05:50", "name": "[1/1] efi_loader: set correct frame buffer address", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502472/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231907/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231907/checks/", "tags": {}, "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=lsKmx1qL;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=canonical.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.b=\"lsKmx1qL\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=canonical.com", "phobos.denx.de; spf=pass\n smtp.mailfrom=heinrich.schuchardt@canonical.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6Z9k0ndvz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 02 May 2026 01:06:01 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A8DD8803C6;\n\tFri, 1 May 2026 17:05:58 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 2A2B680F0E; Fri, 1 May 2026 17:05:58 +0200 (CEST)", "from smtp-relay-canonical-0.canonical.com\n (smtp-relay-canonical-0.canonical.com [185.125.188.120])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2A3CF80086\n for <u-boot@lists.denx.de>; Fri, 1 May 2026 17:05:56 +0200 (CEST)", "from LT03 (1.general.zfsdt.uk.vpn [10.172.194.136])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 494253F043;\n Fri, 1 May 2026 15:05:55 +0000 (UTC)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1777647955;\n bh=k1/2UwV7je0oy3tY5VHVZFHU9ASS2ild4YFsSfxWQbw=;\n h=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=lsKmx1qLcb3dbrdPABwN5NWzQbqhLnBlZeKWoP9RrBPDQvjGLMebIpXglDy3Eq4ii\n lkFKwzCu2U2NooGEBs/QPq23SMIZb1qNn1VaFMe7ZGG40h/ei854vuF/z4FaPlVDVD\n cbimfFbsr40bfcRQF9YUhnvJzRsbPUyv2udKUOq2sroPrRM9lPYOGwcqO2dbmn5q6W\n TPxc4WHQ9Lxl78CXWkPvmPBc4dUB9WXrfHplG3X+jE84gAMXkjQLcid21+T/o9+/yq\n ZbWhMLfVfXXPwFvrR7Mp0Rkri+MUgvDodDM2z0kW6j7frNTW/Nu9kj8PIPIjY7LSwk\n wp7Yp/vrrFJcNmA8c03MWesHDQiGCySmXVrXdbnkpDfFf0zCRtClfX1PK2jH056WMq\n /B/PPUXS/4p6sIDtkpQLM0yB959ouwIDES0sOvEd/coBu/p9JRl9hHRyE0pj7xp+Uz\n w21xNmZwEwHKq41wsWE2vxDL35m93UjkO9/IQKV552DKWKqwLLUcJLOm97IzJOQz9D\n MjsHe+/2NXjhMSjInSjQi2DWOuLfsL75BQ2oLeKAy9MF16yVXD/GjMZIS6lc3CdTMG\n nLa7M4q2r3J9JG2NTqbZ0snUJONJdQF7s4aip049wJrFQk4zJkwUJg8SJXCpD4wXl/\n BEUHKwMYnN7wHWOpj1M9IiMQ=", "From": "Heinrich Schuchardt <heinrich.schuchardt@canonical.com>", "To": "Ilias Apalodimas <ilias.apalodimas@linaro.org>", "Cc": "Tom Rini <trini@konsulko.com>, Peng Fan <peng.fan@nxp.com>,\n Patrice Chotard <patrice.chotard@foss.st.com>, Yao Zi <me@ziyao.cc>,\n Simon Glass <sjg@chromium.org>, Bin Meng <bmeng.cn@gmail.com>,\n u-boot@lists.denx.de,\n Heinrich Schuchardt <heinrich.schuchardt@canonical.com>", "Subject": "[PATCH 1/1] efi_loader: set correct frame buffer address", "Date": "Fri, 1 May 2026 17:05:50 +0200", "Message-ID": "<20260501150550.228937-1-heinrich.schuchardt@canonical.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "If we use video copy, bit image transfers need to write to the in memory\ncopy of the physical frame buffer. Damage control will sync the changes\nto the physical frame buffer.\n\nCyclic video copy will catch all changes done by EFI applications directly\naccessing the frame buffer copy.\n\ngopobj->mode.fb_base must be a valid pointer to memory and not a virtual\nsandbox address.\n\nWith this change the block image transfer test works again on the sandbox.\n\n setenv efi_selftest block image transfer\n bootefi selftest\n\nFixes: a75cf70d23ac (\"efi: Correct handling of frame buffer\")\nSigned-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>\n---\n lib/efi_loader/efi_gop.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c\nindex 9403e09691e..ae44d140289 100644\n--- a/lib/efi_loader/efi_gop.c\n+++ b/lib/efi_loader/efi_gop.c\n@@ -471,7 +471,7 @@ efi_status_t efi_gop_register(void)\n {\n \tstruct efi_gop_obj *gopobj;\n \tu32 bpix, format, col, row;\n-\tu64 fb_base, fb_size;\n+\tu64 fb_size;\n \tefi_status_t ret;\n \tstruct udevice *vdev;\n \tstruct video_priv *priv;\n@@ -490,7 +490,6 @@ efi_status_t efi_gop_register(void)\n \trow = video_get_ysize(vdev);\n \n \tplat = dev_get_uclass_plat(vdev);\n-\tfb_base = IS_ENABLED(CONFIG_VIDEO_COPY) ? plat->copy_base : plat->base;\n \tfb_size = plat->size;\n \n \tswitch (bpix) {\n@@ -528,7 +527,7 @@ efi_status_t efi_gop_register(void)\n \tgopobj->mode.info = &gopobj->info;\n \tgopobj->mode.info_size = sizeof(gopobj->info);\n \n-\tgopobj->mode.fb_base = fb_base;\n+\tgopobj->mode.fb_base = (uintptr_t)priv->fb;\n \tgopobj->mode.fb_size = fb_size;\n \n \tgopobj->info.version = 0;\n@@ -553,7 +552,7 @@ efi_status_t efi_gop_register(void)\n \t}\n \tgopobj->info.pixels_per_scanline = col;\n \tgopobj->bpix = bpix;\n-\tgopobj->fb = map_sysmem(fb_base, fb_size);\n+\tgopobj->fb = priv->fb;\n \tgopobj->vdev = vdev;\n \n \treturn EFI_SUCCESS;\n", "prefixes": [ "1/1" ] }