Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2231901/?format=api
{ "id": 2231901, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2231901/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260501143850.2714779-1-bdklingerman@gmail.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.1/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260501143850.2714779-1-bdklingerman@gmail.com>", "date": "2026-05-01T14:38:50", "name": "Makefile: remove block from conv=block, sync in SPL alignment dd", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0f335d42147223f6bffd934aadd9bdf9bba84e35", "submitter": { "id": 93297, "url": "http://patchwork.ozlabs.org/api/1.1/people/93297/?format=api", "name": "Brad Klingerman", "email": "bdklingerman@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260501143850.2714779-1-bdklingerman@gmail.com/mbox/", "series": [ { "id": 502467, "url": "http://patchwork.ozlabs.org/api/1.1/series/502467/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=502467", "date": "2026-05-01T14:38:50", "name": "Makefile: remove block from conv=block, sync in SPL alignment dd", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502467/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231901/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231901/checks/", "tags": {}, "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gNNC8I+l;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=fail (p=none dis=none) header.from=gmail.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"gNNC8I+l\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=bdklingerman@gmail.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6YlX5nH4z1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 02 May 2026 00:46:48 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3D44C845E3;\n\tFri, 1 May 2026 16:46:24 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 6F52883E36; Fri, 1 May 2026 16:39:00 +0200 (CEST)", "from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com\n [IPv6:2607:f8b0:4864:20::32b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2B6CC80086\n for <u-boot@lists.denx.de>; Fri, 1 May 2026 16:38:58 +0200 (CEST)", "by mail-ot1-x32b.google.com with SMTP id\n 46e09a7af769-7dbccf6a23dso1759188a34.2\n for <u-boot@lists.denx.de>; Fri, 01 May 2026 07:38:58 -0700 (PDT)", "from xps ([97.86.254.41]) by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7deca7a5e6asm2332675a34.3.2026.05.01.07.38.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 May 2026 07:38:56 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777646337; x=1778251137; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=zfUpncIfzzuXgfETeePOpi86eUzr1jVAz91urQ+ue3Q=;\n b=gNNC8I+lBWkElb0jRo/zo1J8/CJdC/7h0TLTp8jXs8Qzfk45Jnie+JrIPYzUpM18pk\n zgzm+lRJIMGTgrJKF9BI9Q2BTLJqHgVPXAVoGVGd1pYeeB8p5N1KPkeJ0f1uwtlP1yuC\n wPjteAnduWEFIYPG2rVl/C+iuNk5qZt5vy/7Q57UECuH71m3+3EUVawpiV9Hs1ScFTdp\n h8Fj28xoHD5FRHa249VP+dt+kowAlG1z8yS5G24xgPWM/1kiXyB165ySUZALvMWz110M\n 64zloQSmo0k4Bj4yaVRjsbK90hBMgWbbTBdwKKZUm3IstDzee6P7w9Yz+6WwdU0ucu9X\n kWNg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777646337; x=1778251137;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zfUpncIfzzuXgfETeePOpi86eUzr1jVAz91urQ+ue3Q=;\n b=sxZ+XV1FeKB43XXV3k9ENLd7o9BuN8CwLgcV29FvFc8r3pjFTQF7LSbxoMhGM2ioR5\n eEeo6ZZ6BCVtVm1LLOBZLnIwiacAZ6+srnkP+NUo/0wyuew626nTfsAjM0/wnEu99Aoo\n Wl41/ICrPoM7PdVnoaeyxvoK8Oum9/iyW0Bmaj0BGsCwa89xsbfKDLMr75OjmhN/HZW6\n DgEr9cNwbvfWneU1yXlr8ZDgbJCkAqdZ3mNTs+jm4lXYoFjCyf1yQplodsiIlvOGqQyT\n z8aEwZTLr1J+q7bRFTTyFgRAD4zmqdwK8AQGQ1fEt8FdHKxNvDUeCPEw/f+JmewFo9tI\n 7owQ==", "X-Gm-Message-State": "AOJu0Ywr5QnbvjRZVztcDdjQlfFuCn1eAdnDuxMyyebjuSY22qKT+HBF\n iZ6WkQ3V8+uUSBmiBdO6bEgq8fPMX5bYIuTy5B5h6+Klt4CrI4imTIweO4JE4A==", "X-Gm-Gg": "AeBDieu7snJQHyTb/CwZ39qSZanUxEGpc0MnynBB30oXf3IKiTLUMtuKs4AEqHN89Um\n uCZy9ELoEdZ6IhFlmGEuFUaTWL2YJu2JBSLQFFwUibQM5i+4JhZVg8x+dCJvhdstz2Aw7URwKdE\n 7DeZ+lgcgO65nd5or1NrB//jMaj4BBamXNzSH59d8svJ2JixPn5KyscUpR0Tr8UbY56rPt9fAwe\n t7hjkNg0afZwHGLDgfb/8jcF+6X91BsKdCJLP9YuTC9g1QzxQhTyKe4ShmbhhUouRfacKtQIG1m\n hOlAFB9E0IXc/Vpl6Wz/Ot1D+hQbbCx6hIoYF70xU14IS+9LKIfw3LfazUPia7IX9+7tVpuc9aH\n N0iTrcYIZj2NF7onQyWVRSLNOoXoR7jqnmHvUqFqr4EHguI4LFgKDdEa5YvdvnZYXUnqXWAvy5w\n dKGt+D4jxgPw7CArCMnC6NdNqn", "X-Received": "by 2002:a05:6830:6b03:b0:7d9:71fa:3079 with SMTP id\n 46e09a7af769-7debdd624damr3920415a34.10.1777646336704;\n Fri, 01 May 2026 07:38:56 -0700 (PDT)", "From": "Brad Klingerman <bdklingerman@gmail.com>", "To": "Tom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH] Makefile: remove block from conv=block,\n sync in SPL alignment dd", "Date": "Fri, 1 May 2026 09:38:50 -0500", "Message-ID": "<20260501143850.2714779-1-bdklingerman@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 01 May 2026 16:46:21 +0200", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The line that produces $(SPL_BIN)-align.bin invokes dd with\nconv=block,sync but no cbs= operand. The result of dd conv=block\nwithout cbs= is unspecified. GNU coreutils outputs anyway, but\nuutils (default in Ubuntu 26.04 LTS) errors out for files with\nnewlines, including SPL binaries, producing:\n\n dd: conv=block or conv=ubnblock specified without cbs=N\n\nEither the block operand must be removed, or cbs=N must be added.\nconv=block is for converting newline-terminated variable-length\nrecords to fixed-length space-padded ones, which is meaningless\nfor a binary SPL image. The intent of the rule is 4-byte\nalignment, which conv=sync alone provides by padding the final\nblock to bs= bytes with NULs.\n\nDuring build, u-boot-spl-align.bin errors silently due to '@'.\n\nReproduced with uutils dd 0.8.0:\n\n $ dd if=/dev/urandom of=/tmp/in bs=1 count=10000\n $ dd if=/tmp/in of=/tmp/out conv=block,sync bs=4\n dd: conv=block or conv=unblock specified without cbs=N\n $ dd if=/tmp/in of=/tmp/out conv=sync bs=4\n [succeeds]\n\nOutput is byte-identical to GNU dd's output for binary input.\n\nSigned-off-by: Brad Klingerman <bdklingerman@gmail.com>\n---\n scripts/Makefile.xpl | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/scripts/Makefile.xpl b/scripts/Makefile.xpl\nindex 862a8e6f231..a3fd3e1375f 100644\n--- a/scripts/Makefile.xpl\n+++ b/scripts/Makefile.xpl\n@@ -257,7 +257,7 @@ MKIMAGEFLAGS_boot.bin = -T zynqmpimage -R $(srctree)/$(CONFIG_BOOT_INIT_FILE) \\\n endif\n \n $(obj)/$(SPL_BIN)-align.bin: $(obj)/$(SPL_BIN).bin\n-\t@dd if=$< of=$@ conv=block,sync bs=4 2>/dev/null;\n+\t@dd if=$< of=$@ conv=sync bs=4 2>/dev/null;\n \n spl/boot.bin: $(obj)/$(SPL_BIN)-align.bin FORCE\n \t$(call if_changed,mkimage)\n", "prefixes": [] }