Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2231832/?format=api
{ "id": 2231832, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2231832/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260501055112.3966757-1-aristo.chen@canonical.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.1/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260501055112.3966757-1-aristo.chen@canonical.com>", "date": "2026-05-01T05:51:04", "name": "[v2,1/1] test: fit: Use shared make_fname from fit_util", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "678fc3cbd7873416aa654704cdc0ecf85558e3dc", "submitter": { "id": 92721, "url": "http://patchwork.ozlabs.org/api/1.1/people/92721/?format=api", "name": "Aristo Chen", "email": "aristo.chen@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260501055112.3966757-1-aristo.chen@canonical.com/mbox/", "series": [ { "id": 502456, "url": "http://patchwork.ozlabs.org/api/1.1/series/502456/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=502456", "date": "2026-05-01T05:51:04", "name": "[v2,1/1] test: fit: Use shared make_fname from fit_util", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502456/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231832/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231832/checks/", "tags": {}, "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=eMt9z3/b;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=canonical.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.b=\"eMt9z3/b\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=canonical.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=aristo.chen@canonical.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6VvJ6yjDz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 01 May 2026 22:38:20 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3B5C880F0E;\n\tFri, 1 May 2026 14:38:18 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id C1E4B839D5; Fri, 1 May 2026 08:09:43 +0200 (CEST)", "from smtp-relay-internal-1.canonical.com\n (smtp-relay-internal-1.canonical.com [185.125.188.123])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2AA90803C6\n for <u-boot@lists.denx.de>; Fri, 1 May 2026 08:09:38 +0200 (CEST)", "from mail-pj1-f69.google.com (unknown [209.85.216.69])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 94EEC3FCFC\n for <u-boot@lists.denx.de>; Fri, 1 May 2026 05:59:24 +0000 (UTC)", "by mail-pj1-f69.google.com with SMTP id\n 98e67ed59e1d1-364f007d1f3so215357a91.1\n for <u-boot@lists.denx.de>; Thu, 30 Apr 2026 22:59:11 -0700 (PDT)", "from noble-uboot.tail872496.ts.net\n (124-218-37-86.cm.dynamic.apol.com.tw. [124.218.37.86])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364bdf2aa41sm6174538a91.4.2026.04.30.22.51.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 22:51:47 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1777615192;\n bh=vQrE8AynQ+lTEKI73hKiO2rDE0WillVbWGhlnIL6GTc=;\n h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n MIME-Version;\n b=eMt9z3/bGM1WuUrgrHYI7ediGrOtLrTbDtKL1sPOzoIxmKPxnIIkELblY0Fm7he5D\n Cf7JQPSewePGQ8wedRVydy/3PfjoPkdciGiYUZrQAwe/30PgumA4KPwLZJnMnKg34a\n 0FYiva5e293bYIII4YQXZXkZB2hAUixVOYhPI8knremVf5oBVh54kIhzx39brWsa07\n bykMHFFkKKjHVwbVt/qVQbI5kMpKqp2BZBZ4axBvhljW3n1k6kCmhL+exeJtwrFnI9\n 8xXPPoLOFJdenoqkjYaADPPFoKteaq7/KMfGW96Esut7AGBM8KpsFNFRj7QLxeWnT4\n RDIMStL6OCrfR5G8cSyCugRW9/20ap87O87AgszUG1eTk/YpZhRR2Y8AuRRVp9Nebg\n SZh+AB15d9E8VcscwAWBiKEfK5SbOr//a5MtTGWCkI+EKMuahxi4bUBl1OI7Ykx8F6\n nr70XrOgmsKljip9m+X8hVWtbsoeVwr6lG9s0QBf8AZujFWvSQv7s0gz9o1EFePAxy\n P2v+wKVIRfY/ZcUFaumB/F7wRCkeMQIu0c9d/hgtNJJ8SbpVDvWpNKpocorDkgQw6h\n UUT+OAkhhCF76/HpAw/209gdIizj3N/8NHGNcmJDQdgU5uYFo08MW+mmqHjKYgh7Fn\n dwNCNGZVYAyprkeNPnZfkilY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777614709; x=1778219509;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=vQrE8AynQ+lTEKI73hKiO2rDE0WillVbWGhlnIL6GTc=;\n b=SlUwAvUTqmMRw9KqzXYLuQiF1Lb3/pwipEGQ2AtrNfq+iLwdaVEbeGIRfzcfAgIQrE\n nAcgA16TYdrp8yRug2aDdHs0vPvCHlEZQIOZ23JP11o96nenvJwpB2nsX8pCnS07ulR1\n CmNQ0K2r/kjdWVtOZX53zY/XnUDuduFS555rxyv0ej9ATei6g87Mv+vVcDh2JCUXIUSl\n GgkLZl2Err6Vj5eZkcWrTknSNS6l2jd1y1kN1WhPPiC7G7zaGhcL4ZT2Hj0mCg9v5dfr\n HVbUfGiFXc98t00xcPaHbSiiX/NCIAmXxHOQD4uvPyMLtByEs6mPwbzB0qbaKLWURgsF\n TTzw==", "X-Gm-Message-State": "AOJu0YyFxwopVf2aKW+wducxQsUi9b4QgPQEL34yvXWwOfzl8JAkV6lY\n KqLh7sjQwEYBCgtgtFdve75+os5PRnE68HHVdmzJ0uKl6Y5WJv/pHfxoeoSVFiDCV6EoYqr91mB\n fV7IPlwOuC4A6FECJysoYppDqIftAlidojvcY80SXL5ZQZ2RNnw5kPqT/0ehTEBPqf9lp1/bkMd\n 9GHBg=", "X-Gm-Gg": "AeBDietpLXp3YNmmFPdt73nnvmDOtqBw0W3yBlderAhQIhdZt+kl8uCSqXAPvSKKlJ3\n KmqBFEquyyju51/h3BjuclwsA2zfXKqRvNa7wonskIfJt6TmvwnZSkNitMkG3bUQr+7e6x5Bh5x\n sJmAvlWNkARb8iEFFs6neUkHUzp7c6FEqjhbJ6HXv/QUdYsN1mH9cUO7Ne5MuW8y+JcjM3xkjzN\n hYpO3b4Aqni0NjomHMtI9WVNsAhN1vTQq3SxbQXEnb+qsN88gBTjxEZacpt8Vl9hQTURl9PlzXB\n vyu5nDeHZlu/jj4rd62qnPjyj/kyy6ipuyNNq4nzg20936uQtZpEQlcr/zzbkmpdJ5ND/TmuIpv\n 3U/wouzz2mJ8U1mDBzlgWrPN7Iax3nSCr/pq0C+e9TshQiqjpB2qkFjVAIU6EdGYpGYztvwLR04\n Pv1XLou4Be8VQk4F+JRKAem5DSkQ==", "X-Received": [ "by 2002:a17:90b:4e8b:b0:35c:195e:112f with SMTP id\n 98e67ed59e1d1-364c49ff8f4mr5466381a91.18.1777614708687;\n Thu, 30 Apr 2026 22:51:48 -0700 (PDT)", "by 2002:a17:90b:4e8b:b0:35c:195e:112f with SMTP id\n 98e67ed59e1d1-364c49ff8f4mr5466359a91.18.1777614708323;\n Thu, 30 Apr 2026 22:51:48 -0700 (PDT)" ], "From": "Aristo Chen <aristo.chen@canonical.com>", "To": "u-boot@lists.denx.de", "Cc": "Aristo Chen <aristo.chen@canonical.com>, Tom Rini <trini@konsulko.com>,\n Simon Glass <sjg@chromium.org>", "Subject": "[PATCH v2 1/1] test: fit: Use shared make_fname from fit_util", "Date": "Fri, 1 May 2026 05:51:04 +0000", "Message-ID": "<20260501055112.3966757-1-aristo.chen@canonical.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260420074827.3917463-1-aristo.chen@canonical.com>", "References": "<20260420074827.3917463-1-aristo.chen@canonical.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 01 May 2026 14:38:15 +0200", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "test_fit.py declares a local make_fname closure that is byte-identical\nto fit_util.make_fname. Drop the local copy and call the shared helper\nat all seven call sites so there is one definition to maintain.\n\nNo behavioural change. Both implementations return\nos.path.join(ubman.config.build_dir, basename).\n\nSigned-off-by: Aristo Chen <aristo.chen@canonical.com>\n---\n test/py/tests/test_fit.py | 26 +++++++-------------------\n 1 file changed, 7 insertions(+), 19 deletions(-)", "diff": "diff --git a/test/py/tests/test_fit.py b/test/py/tests/test_fit.py\nindex bcaaa6a5fc4..4f56a1421e1 100755\n--- a/test/py/tests/test_fit.py\n+++ b/test/py/tests/test_fit.py\n@@ -140,18 +140,6 @@ class TestFitImage:\n - run code coverage to make sure we are testing all the code\n \"\"\"\n \n- def make_fname(self, ubman, leaf):\n- \"\"\"Make a temporary filename\n-\n- Args:\n- ubman (ConsoleBase): U-Boot fixture\n- leaf (str): Leaf name of file to create (within temporary directory)\n-\n- Return:\n- str: Temporary filename\n- \"\"\"\n- return os.path.join(ubman.config.build_dir, leaf)\n-\n def filesize(self, fname):\n \"\"\"Get the size of a file\n \n@@ -181,7 +169,7 @@ class TestFitImage:\n Returns:\n str: Filename of ramdisk created\n \"\"\"\n- fname = self.make_fname(ubman, filename)\n+ fname = fit_util.make_fname(ubman, filename)\n data = ''\n for i in range(100):\n data += f'{text} {i} was seldom used in the middle ages\\n'\n@@ -278,33 +266,33 @@ class TestFitImage:\n 'fit_addr' : 0x1000,\n \n 'kernel' : kernel,\n- 'kernel_out' : self.make_fname(ubman, 'kernel-out.bin'),\n+ 'kernel_out' : fit_util.make_fname(ubman, 'kernel-out.bin'),\n 'kernel_addr' : 0x40000,\n 'kernel_size' : self.filesize(kernel),\n 'kernel_config' : 'kernel = \"kernel-1\";',\n \n 'fdt_data' : fdt_data,\n- 'fdt' : self.make_fname(ubman, 'u-boot.dtb'),\n- 'fdt_out' : self.make_fname(ubman, 'fdt-out.dtb'),\n+ 'fdt' : fit_util.make_fname(ubman, 'u-boot.dtb'),\n+ 'fdt_out' : fit_util.make_fname(ubman, 'fdt-out.dtb'),\n 'fdt_addr' : 0x80000,\n 'fdt_size' : self.filesize(fdt_data),\n 'fdt_load' : '',\n \n 'ramdisk' : ramdisk,\n- 'ramdisk_out' : self.make_fname(ubman, 'ramdisk-out.bin'),\n+ 'ramdisk_out' : fit_util.make_fname(ubman, 'ramdisk-out.bin'),\n 'ramdisk_addr' : 0xc0000,\n 'ramdisk_size' : self.filesize(ramdisk),\n 'ramdisk_load' : '',\n 'ramdisk_config' : '',\n \n 'loadables1' : loadables1,\n- 'loadables1_out' : self.make_fname(ubman, 'loadables1-out.bin'),\n+ 'loadables1_out' : fit_util.make_fname(ubman, 'loadables1-out.bin'),\n 'loadables1_addr' : 0x100000,\n 'loadables1_size' : self.filesize(loadables1),\n 'loadables1_load' : '',\n \n 'loadables2' : loadables2,\n- 'loadables2_out' : self.make_fname(ubman, 'loadables2-out.bin'),\n+ 'loadables2_out' : fit_util.make_fname(ubman, 'loadables2-out.bin'),\n 'loadables2_addr' : 0x140000,\n 'loadables2_size' : self.filesize(loadables2),\n 'loadables2_load' : '',\n", "prefixes": [ "v2", "1/1" ] }