Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2231816/?format=api
{ "id": 2231816, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2231816/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260501123235.2541613-3-jwakely@redhat.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.1/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260501123235.2541613-3-jwakely@redhat.com>", "date": "2026-05-01T12:32:03", "name": "[committed,3/3] libstdc++: Tweak Doxygen comments for experimental simd", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "aa6add56d2dc17e6e5beb75202140076d2f2871e", "submitter": { "id": 48004, "url": "http://patchwork.ozlabs.org/api/1.1/people/48004/?format=api", "name": "Jonathan Wakely", "email": "jwakely@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260501123235.2541613-3-jwakely@redhat.com/mbox/", "series": [ { "id": 502455, "url": "http://patchwork.ozlabs.org/api/1.1/series/502455/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=502455", "date": "2026-05-01T12:32:01", "name": "[committed,1/3] libstdc++: Improve Doxygen comments for <iterator> contents", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502455/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231816/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231816/checks/", "tags": {}, "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=e4/mghtU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=e4/mghtU", "sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "sourceware.org; spf=pass smtp.mailfrom=redhat.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.129.124" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6Vqv0ySGz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 01 May 2026 22:35:23 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 20B224374233\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 1 May 2026 12:35:21 +0000 (GMT)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by sourceware.org (Postfix) with ESMTP id CFC184374233\n for <gcc-patches@gcc.gnu.org>; Fri, 1 May 2026 12:32:45 +0000 (GMT)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-wW247UebPvO5Ng1ulb7fFw-1; Fri,\n 01 May 2026 08:32:42 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 854941956095; Fri, 1 May 2026 12:32:41 +0000 (UTC)", "from zen.kayari.org (unknown [10.44.50.237])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 2950A1953952; Fri, 1 May 2026 12:32:39 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 20B224374233", "OpenDKIM Filter v2.11.0 sourceware.org CFC184374233" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org CFC184374233", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org CFC184374233", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777638765; cv=none;\n b=FCRSYMFsZhyL5bVwem15spivkOUJGNYi+RyTwW8JcOzy4WS/SKKDVPdL7+1T4j7x114GwSW1U6j8CrfbDHoC7X3FrA0g4IuO3gGn/OP8pFkt/K/CEh3wC1jWkqS0bM5/bAkLZ5bivR+c1VlZubRU6iOZFMMEvaVu4axL1Bt+hug=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777638765; c=relaxed/simple;\n bh=8yrKqJj8K3IvR5Eb6PD7oppmkQ5wLdz/4g+oAlaIkqc=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=pYtQHJZoyDoyIcL9S/H1wwCqE/pOqwP4xcmhSFcdaWS1UN3UB+ny0eM+Vux4KZMP6mPWAQO4WX6YY9Hm0T1g44XdiFRVow1X6yTzuqX09zXKHbHUV7atG5psVx1dJhSGmlMJ0Xg529xA2OcCY/EJRRkjtwVE8nht6k2w6mOzjBc=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777638765;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=a38VSZzKDyorCN0TCYF8ZrNh9atmLx9hkZdR5pziTdY=;\n b=e4/mghtUF1Ia6fic3d8lQZQxqPa+PVcGCYZSmi5wJek/05G2XkZ9I6z3GGUjq8TJdytdMq\n r0/nUTme+9B/cxDvTrlnUe8NVVWa5vCtSN0ufqM3j7KWYU6dBgYot1+eKtOYnLc4QFk0Kl\n IapZESXffleEohw48OImcwgOa8nwNNE=", "X-MC-Unique": "wW247UebPvO5Ng1ulb7fFw-1", "X-Mimecast-MFC-AGG-ID": "wW247UebPvO5Ng1ulb7fFw_1777638761", "From": "Jonathan Wakely <jwakely@redhat.com>", "To": "gcc-patches@gcc.gnu.org,\n\tlibstdc++@gcc.gnu.org", "Subject": "[committed 3/3] libstdc++: Tweak Doxygen comments for experimental\n simd", "Date": "Fri, 1 May 2026 13:32:03 +0100", "Message-ID": "<20260501123235.2541613-3-jwakely@redhat.com>", "In-Reply-To": "<20260501123235.2541613-1-jwakely@redhat.com>", "References": "<20260501123235.2541613-1-jwakely@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "SfPNQDmqwIhzcTPa6a5_KfA3wYTt8xEtUyiRxzj4qOw_1777638761", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "I noticed that Doxygen was not documenting the contents of\n<experimental/simd> as part of namespace std, because it didn't know\nabout the _GLIBCXX_SIMD_BEGIN_NAMESPACE and _GLIBCXX_SIMD_END_NAMESPACE\nmacros which open and close namespace std::experimental::parallelism_v2.\n\nAfter defining those macros in the Doxygen config, the Doxygen comments\nin experimental/bits/simd.h were causing namespace std to be documented\nas part of the Parallelism TS v2. That's because the preprocessed code\nlooks like:\n\n/** @ingroup ts_simd\n * @{\n */\nnamespace std::experimental::inline parallelism_v2 {\n\nThis causes Doxygen to apply the @ingroup command to all three of\nnamespace std, namespace std::experimental, and namespace\nstd::experimental::parallelism_v2. I don't know if this is the intended\nbehaviour, but it doesn't seem useful so I've opened an issue about it:\nhttps://github.com/doxygen/doxygen/issues/12114\n\nTo workaround this, we can move the _GLIBCXX_SIMD_BEGIN_NAMESPACE macro\nbefore the @{ group and document it separately with a @namespace\ncomment. That makes the @ingroup only apply to the namespace named by\nthe @namespace command, not to its enclosing namespaces as well. Moving\nthe position of the BEGIN macro also fixes the nesting, as previously we\nhad @{ then BEGIN then @} then END. Now we have BEGIN @{ @} END which\nseems preferable.\n\nlibstdc++-v3/ChangeLog:\n\n\t* doc/doxygen/user.cfg.in (PREDEFINED): Add BEGIN/END macros for\n\tthe <experimental/simd> namespace.\n\t* include/experimental/bits/simd.h: Move BEGIN macro before\n\tDoxygen @{ group.\n---\n\nTested x86_64-linux. Pushed to trunk.\n\n libstdc++-v3/doc/doxygen/user.cfg.in | 2 ++\n libstdc++-v3/include/experimental/bits/simd.h | 6 +++++-\n 2 files changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/libstdc++-v3/doc/doxygen/user.cfg.in b/libstdc++-v3/doc/doxygen/user.cfg.in\nindex fc82debd1b4b..9393d5dfb437 100644\n--- a/libstdc++-v3/doc/doxygen/user.cfg.in\n+++ b/libstdc++-v3/doc/doxygen/user.cfg.in\n@@ -2912,6 +2912,8 @@ PREDEFINED = __cplusplus=202603L \\\n \t\t\t _GLIBCXX_HAVE_ICONV=1 \\\n \t\t\t \"_GLIBCXX_DOXYGEN_ONLY(X)=X \" \\\n \t\t\t __exception_ptr=__unspecified__ \\\n+\t\t\t \"_GLIBCXX_SIMD_BEGIN_NAMESPACE=namespace std::experimental::inline parallelism_v2 {\" \\\n+\t\t\t \"_GLIBCXX_SIMD_END_NAMESPACE=}\" \\\n \n \n # If the MACRO_EXPANSION and EXPAND_ONLY_PREDEF tags are set to YES then this\ndiff --git a/libstdc++-v3/include/experimental/bits/simd.h b/libstdc++-v3/include/experimental/bits/simd.h\nindex 8c30c8af2688..ce0867fd8eb8 100644\n--- a/libstdc++-v3/include/experimental/bits/simd.h\n+++ b/libstdc++-v3/include/experimental/bits/simd.h\n@@ -55,6 +55,11 @@\n #include <arm_sve.h>\n #endif\n \n+/** @namespace std::experimental::parallelism_v2\n+ * @ingroup ts_simd\n+ */\n+_GLIBCXX_SIMD_BEGIN_NAMESPACE\n+\n /** @ingroup ts_simd\n * @{\n */\n@@ -78,7 +83,6 @@\n * Variable names:\n * __k: mask object (vector- or bitmask)\n */\n-_GLIBCXX_SIMD_BEGIN_NAMESPACE\n \n #if !_GLIBCXX_SIMD_X86INTRIN\n using __m128 [[__gnu__::__vector_size__(16)]] = float;\n", "prefixes": [ "committed", "3/3" ] }