Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2231754/?format=api
{ "id": 2231754, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2231754/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260501112023.338005-4-sprasad@microsoft.com/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/1.1/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260501112023.338005-4-sprasad@microsoft.com>", "date": "2026-05-01T11:20:07", "name": "[v4,04/19] cifs: define variable sized buffer for querydir responses", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "aaaf955d39d88076fd07aaf7c310fa5f054b7da1", "submitter": { "id": 79368, "url": "http://patchwork.ozlabs.org/api/1.1/people/79368/?format=api", "name": "Shyam Prasad N", "email": "nspmangalore@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260501112023.338005-4-sprasad@microsoft.com/mbox/", "series": [ { "id": 502444, "url": "http://patchwork.ozlabs.org/api/1.1/series/502444/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=502444", "date": "2026-05-01T11:20:06", "name": "[v4,01/19] cifs: change_conf needs to be called for session setup", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/502444/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231754/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231754/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-cifs+bounces-11329-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mFoXoVK1;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11329-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"mFoXoVK1\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.175", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6TKZ32bMz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 01 May 2026 21:27:30 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id BCDE9304C7C4\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 1 May 2026 11:22:26 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 467CD3A6F07;\n\tFri, 1 May 2026 11:20:37 +0000 (UTC)", "from mail-pf1-f175.google.com (mail-pf1-f175.google.com\n [209.85.210.175])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E3383A6EF8\n\tfor <linux-cifs@vger.kernel.org>; Fri, 1 May 2026 11:20:35 +0000 (UTC)", "by mail-pf1-f175.google.com with SMTP id\n d2e1a72fcca58-82f69adeecbso825277b3a.2\n for <linux-cifs@vger.kernel.org>;\n Fri, 01 May 2026 04:20:35 -0700 (PDT)", "from sprasad-dev1.corp.microsoft.com ([167.220.110.216])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-8351587db67sm2331922b3a.13.2026.05.01.04.20.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 May 2026 04:20:34 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777634437; cv=none;\n b=Lm2hpGwEpWWKOw/D3bSOTxI0uE0vqkEVMkx5iaXZ5Ck8fGYZ0o0wjsmp7Gh/2U3l6pmcQSc+F+4H/qYQETALDeM5LqUdhpIoxrRP+bDrOLQBJkESkd1n1/kc6Fixupu5Pkk/V0b9TwK3oSGSPpNxUzBIB3Ge965tbltVeLoSo7U=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777634437; c=relaxed/simple;\n\tbh=7fs/qpQj7CViKJpl1xKhLVHakBiwsBbgCOkyBzjRtuo=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=CO946jlhKOq7PiNnpV31JcTPHpnrw/q3RZes5LBz64MnW2vRhuOMMK+uawqPoun1QT3ZVXTqfQBwUWlePXrKV5T1sCS7a4U+QQ5k8i6ygd9DgZ505PVUrF0UeuRcqsq8r/l73+OTOyflQb/6NY4FkG9WvCvjkQdqVgFYsdxAk+I=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=mFoXoVK1; arc=none smtp.client-ip=209.85.210.175", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777634434; x=1778239234;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4CeNnh5BjM1nRomeWQoA26EkMPBAyik+6iryoO/A02Y=;\n b=mFoXoVK1le5VkApKd/GCCWgOsscJcBtm+7xlnYfiLDTna8p7t0sw1a9B3mmyyV1KW2\n APZ5+6NFAbu6IBmQGmtDTh+70sXU/TUhFuakDoJqPBl2BjipTIIS3b0MPYuBXPHT7WVI\n fpKblj9uKdNsgVvG2/6E9qMF6eM+NnnUAz3V8suvuh5SLNeb6aDZmE5ZAwGZnQTsDn8j\n 04YXS3AfkXcryCFYbUYHCTPPqr7Dwt2BZv/g0CBdsdSt/dXLy8YvLakkMmJpB4O22tv8\n KZawT+3Ej91tP4zwXuH1N2RtaYE9lE0T9TiMwTYHV3Och5UnYN78I8GIy6DN/knfxmCe\n kXgw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777634434; x=1778239234;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=4CeNnh5BjM1nRomeWQoA26EkMPBAyik+6iryoO/A02Y=;\n b=D5cQbLf6hHPQevtcg/pvtRUoxzcdi2DHOa+pAdB1MNh/W+yfclUVZC5iiwL60LlJAR\n u9Cj85iRukz+jU+BDUWYlgpC6XFv9MtwtwNugWGBwBmnE+Tjn40Ju+bqrasmsn2saUvN\n te87Ykl8F3GW+Irtjz9F/8F3vIrTHXOHFg49nSUHyuQwPAXdzi9IEt4P4ABlqeFIFAgf\n yge39qco7W5Y9vPFmiWLTn2N84vwFk/YxtzXhPCmTpsZLkhNCO2BdYpWLogI2KIChxOm\n aGkmdxaGPSk33/HEn8FONbgzLTFSX2CvJ1wk/Gucq3P9IOQooFeBI0iBtaC+Q6FmWFJ8\n AcwQ==", "X-Gm-Message-State": "AOJu0YxhdGvYPJjT2b70+jlYvk/bAYpKxBhn4C8hIow8HpL3ool9wSHJ\n\tmF0DayMFwm9qUIBFjyfGyAoH+ijNYPQpP/0SXHjdmRMqfb+ngYoVPSoVi/pVHQMgFt4=", "X-Gm-Gg": "AeBDieun1DQXHKYQPp11KgVPNTtuFa8sV00upRYzhpXC/Rg7MLMVyON4gUIlXkExNRr\n\tLIUR3wObwjbe3ZWamMMdatKXGUNoELM5bxS6mck5+voCYKrLarLisAYwEmHVm6HbmfK0Yf1Lcx0\n\t9cGPVgOtj7+qOQFSBX3RqBuwaFzsFobUbq5C9XR6PNmCSND/Ea6OimfffdvVU2+xIFhS6GN97tU\n\tlKA6d2Y4Vsu6WIxldHHJ1zw81wGi+5+C0/w8K16S1fypXY0SmckPTA81W1W9BhcCWUXPzwUBnWE\n\ty7mPzVvVEqGEkn/mufKXJCaFIwkumel8EnHKJKgWof3NXQfc0wsyxTKHdaYQWxjO8N08xciuqGh\n\t0FPBdH6SZXDUJuBZcKSXLOOe83d/SSseC/BIi8n+0jzw/BzzRtiN0AXcm+QnMIoZ96Epmd02dBv\n\tBKGWB+0EfcFx7gJkLgozOir3ouytT+fsqiv24VlPQIPG+9qzGf3sAyUT5LSNlcwrA+", "X-Received": "by 2002:a05:6a00:408d:b0:82f:38:a5b2 with SMTP id\n d2e1a72fcca58-834fe237b41mr7807442b3a.40.1777634434492;\n Fri, 01 May 2026 04:20:34 -0700 (PDT)", "From": "nspmangalore@gmail.com", "X-Google-Original-From": "sprasad@microsoft.com", "To": "linux-cifs@vger.kernel.org,\n\tsmfrench@gmail.com,\n\tpc@manguebit.org,\n\tbharathsm@microsoft.com,\n\tdhowells@redhat.com,\n\thenrique.carvalho@suse.com,\n\tematsumiya@suse.de", "Cc": "Shyam Prasad N <sprasad@microsoft.com>", "Subject": "[PATCH v4 04/19] cifs: define variable sized buffer for querydir\n responses", "Date": "Fri, 1 May 2026 16:50:07 +0530", "Message-ID": "<20260501112023.338005-4-sprasad@microsoft.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260501112023.338005-1-sprasad@microsoft.com>", "References": "<20260501112023.338005-1-sprasad@microsoft.com>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "From: Shyam Prasad N <sprasad@microsoft.com>\n\nQueryDirectory responses today are stored in one of two fixed\nsized buffers: smallbuf (448 bytes) or bigbuf (16KB). These are\nborrowed from server struct and are not sufficient for large-sized\nquery dir operations.\n\nWith this change we will now define a new buffer type specifically\nfor cifs_search_info to hold variable sized responses. These will\nbe allocated by kmalloc and freed by kfree.\n\nSigned-off-by: Shyam Prasad N <sprasad@microsoft.com>\n---\n fs/smb/client/cifsglob.h | 2 ++\n fs/smb/client/file.c | 2 ++\n fs/smb/client/readdir.c | 2 ++\n fs/smb/client/smb2pdu.c | 14 +++++++++++---\n 4 files changed, 17 insertions(+), 3 deletions(-)", "diff": "diff --git a/fs/smb/client/cifsglob.h b/fs/smb/client/cifsglob.h\nindex 709e96e077916..8d089ba08e3e5 100644\n--- a/fs/smb/client/cifsglob.h\n+++ b/fs/smb/client/cifsglob.h\n@@ -1394,6 +1394,7 @@ struct cifs_search_info {\n \tbool emptyDir:1;\n \tbool unicode:1;\n \tbool smallBuf:1; /* so we know which buf_release function to call */\n+\tbool is_dynamic_buf:1; /* dynamically allocated buffer - can be variable size */\n };\n \n #define ACL_NO_MODE\t((umode_t)(-1))\n@@ -1907,6 +1908,7 @@ enum cifs_find_flags {\n #define CIFS_NO_BUFFER 0 /* Response buffer not returned */\n #define CIFS_SMALL_BUFFER 1\n #define CIFS_LARGE_BUFFER 2\n+#define CIFS_DYNAMIC_BUFFER 3 /* Dynamically allocated buffer */\n #define CIFS_IOVEC 4 /* array of response buffers */\n \n /* Type of Request to SendReceive2 */\ndiff --git a/fs/smb/client/file.c b/fs/smb/client/file.c\nindex a69e05f86d7e2..6a1419d59ed5a 100644\n--- a/fs/smb/client/file.c\n+++ b/fs/smb/client/file.c\n@@ -1546,6 +1546,8 @@ int cifs_closedir(struct inode *inode, struct file *file)\n \t\tcfile->srch_inf.ntwrk_buf_start = NULL;\n \t\tif (cfile->srch_inf.smallBuf)\n \t\t\tcifs_small_buf_release(buf);\n+\t\telse if (cfile->srch_inf.is_dynamic_buf)\n+\t\t\tkfree(buf);\n \t\telse\n \t\t\tcifs_buf_release(buf);\n \t}\ndiff --git a/fs/smb/client/readdir.c b/fs/smb/client/readdir.c\nindex be22bbc4a65a0..b50efd9b9e1d2 100644\n--- a/fs/smb/client/readdir.c\n+++ b/fs/smb/client/readdir.c\n@@ -732,6 +732,8 @@ find_cifs_entry(const unsigned int xid, struct cifs_tcon *tcon, loff_t pos,\n \t\t\tif (cfile->srch_inf.smallBuf)\n \t\t\t\tcifs_small_buf_release(cfile->srch_inf.\n \t\t\t\t\t\tntwrk_buf_start);\n+\t\t\telse if (cfile->srch_inf.is_dynamic_buf)\n+\t\t\t\tkfree(cfile->srch_inf.ntwrk_buf_start);\n \t\t\telse\n \t\t\t\tcifs_buf_release(cfile->srch_inf.\n \t\t\t\t\t\tntwrk_buf_start);\ndiff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c\nindex 5188218c25be4..49dca84b169e6 100644\n--- a/fs/smb/client/smb2pdu.c\n+++ b/fs/smb/client/smb2pdu.c\n@@ -5625,6 +5625,8 @@ smb2_parse_query_directory(struct cifs_tcon *tcon,\n \tif (srch_inf->ntwrk_buf_start) {\n \t\tif (srch_inf->smallBuf)\n \t\t\tcifs_small_buf_release(srch_inf->ntwrk_buf_start);\n+\t\telse if (srch_inf->is_dynamic_buf)\n+\t\t\tkfree(srch_inf->ntwrk_buf_start);\n \t\telse\n \t\t\tcifs_buf_release(srch_inf->ntwrk_buf_start);\n \t}\n@@ -5644,12 +5646,18 @@ smb2_parse_query_directory(struct cifs_tcon *tcon,\n \tcifs_dbg(FYI, \"num entries %d last_index %lld srch start %p srch end %p\\n\",\n \t\t srch_inf->entries_in_buffer, srch_inf->index_of_last_entry,\n \t\t srch_inf->srch_entries_start, srch_inf->last_entry);\n-\tif (resp_buftype == CIFS_LARGE_BUFFER)\n+\tif (resp_buftype == CIFS_LARGE_BUFFER) {\n \t\tsrch_inf->smallBuf = false;\n-\telse if (resp_buftype == CIFS_SMALL_BUFFER)\n+\t\tsrch_inf->is_dynamic_buf = false;\n+\t} else if (resp_buftype == CIFS_SMALL_BUFFER) {\n \t\tsrch_inf->smallBuf = true;\n-\telse\n+\t\tsrch_inf->is_dynamic_buf = false;\n+\t} else if (resp_buftype == CIFS_DYNAMIC_BUFFER) {\n+\t\tsrch_inf->smallBuf = false;\n+\t\tsrch_inf->is_dynamic_buf = true;\n+\t} else {\n \t\tcifs_tcon_dbg(VFS, \"Invalid search buffer type\\n\");\n+\t}\n \n \treturn 0;\n }\n", "prefixes": [ "v4", "04/19" ] }