Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2231737/?format=api
{ "id": 2231737, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2231737/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260501110246.50647-2-tristmd@gmail.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/1.1/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260501110246.50647-2-tristmd@gmail.com>", "date": "2026-05-01T11:02:45", "name": "[2/3] jffs2: clean up xattr refs in jffs2_del_ino_cache instead of BUG_ON", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fa3ecb5732274e8a9f9bc94ff3b42119458afad7", "submitter": { "id": 93179, "url": "http://patchwork.ozlabs.org/api/1.1/people/93179/?format=api", "name": "Tristan Madani", "email": "tristmd@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260501110246.50647-2-tristmd@gmail.com/mbox/", "series": [ { "id": 502440, "url": "http://patchwork.ozlabs.org/api/1.1/series/502440/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=502440", "date": "2026-05-01T11:02:45", "name": "[1/3] jffs2: always stop garbage collection thread on unmount", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502440/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231737/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231737/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=NZcFeYz8;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=BHhrFAsV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6SnX6Rl5z1yJv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 01 May 2026 21:03:09 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wIle1-00000006bjT-0Bwt;\n\tFri, 01 May 2026 11:02:53 +0000", "from mail-wm1-x330.google.com ([2a00:1450:4864:20::330])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wIldy-00000006biK-3syY\n\tfor linux-mtd@lists.infradead.org;\n\tFri, 01 May 2026 11:02:52 +0000", "by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-48334ee0aeaso15079845e9.1\n for <linux-mtd@lists.infradead.org>;\n Fri, 01 May 2026 04:02:50 -0700 (PDT)", "from debian.. ([2001:41d0:303:db6b::])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a8eb3427fsm79491905e9.0.2026.05.01.04.02.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 May 2026 04:02:48 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=s+geeU92jX1x+0PF4/z+aGFUE2PnklBrqOvkp2DsZDk=; b=NZcFeYz84B9JC1\n\tTL4pLqoNK82xhrCEcq4q39hUGjQAPlqdmVtY7MA31zU3QH7Uv/OjBspIK9/GYLseBAUPsXNeQLy5L\n\txOqSQS0/vEdOMBjt13F9Dg69gNar8C74GtxZT7bdODu+lWomKVq0K1IdXjgmw9Cx2RJlJaNN1v2Xf\n\tpkXCFqh3LqmTfNQjUYitI94uZERD7934lUqedQGGGyNTzrYN18kyViPvUdyokwqYCXnIxwlXNYMCp\n\tsA58NxQl2o+0XMt0pUQJKiLW5DOyHRcuYtJQWfxdoXgbCZiZHOD2u3PMS0mt/iKPOgD7DHtmR0amE\n\tAy7UgytloGtgowz6lBHA==;", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777633369; x=1778238169;\n darn=lists.infradead.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=z+uMPXd4v7RJUPJ6ng6R0zk6Hnw9jnnZw4S2klEd/5k=;\n b=BHhrFAsVIbQMFrTXZg0czCkSUdG67Kut+h45iAGToFvSlL3L2u6Qt/8Gi3w8e4ASIT\n IBWd6EAXFFqdoVeXfRBxO+rCCgTdTjf+ldC5h8cekEBUJNooZ9d73bWq9DcpLLn5bjvl\n 0iyhMMvn4tJ/Jg6oORBTFzBRsJLdHxR6ol7F+vc8wYQlkllprFCrfsHrVBY21kQTaUi2\n wRPVVQslbyZtw1bJq0ZAHjKcYsX5sdpeYw1CKXW3cmDj0z6jkXSscNzAtfxm/K0/lNqu\n u5izVePrCPPbnsISm6bsCzDnRlXPYPBOgOSclZTdZnchEytBSl5wcPRAejjlzjJtVbdc\n 9Orw==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777633369; x=1778238169;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=z+uMPXd4v7RJUPJ6ng6R0zk6Hnw9jnnZw4S2klEd/5k=;\n b=MaQsPDrVb1tazOOOsLIirPXWmP6kn8PSY11mD0GGhklVQPQ6cHTceDNmyJ3/ACshJu\n Dlx1L26oMrjzrzSTqZZLdSqbOrtKmQvipcZwtEDUH/taUtoFI6RkjpQEH3vLHTxYui+7\n FvUPxUcJsdUQAtkOl74jw9kVOz7QMyURS1oDQZwzHBTN4UY2KmcW8GaseTQuZNL7w2he\n j4FISygQLtVwT4DoJM9Z4TK4cuXumNYZdvWSek54iy4nQsH8BFs6DgFVUZZ+l4tBtGgZ\n zpK3wx4DuFG7l4a/T8h8wyr8wZJf5jAbiMrN8CS5EMHUFJNJlmTg6CQJ8I84vj6+oRX2\n AOQA==", "X-Gm-Message-State": "AOJu0YxGlsicKSpqgWWl2RA8QmH6unNUSWiiIGirse/wCOhwVjB5RLgF\n\tkREedYCliG7ccSC9OXWIS/nu6AscyG/5VCANzMn5gcK4SvJVpFTrphk=", "X-Gm-Gg": "AeBDieuG+m4KbrN50da1YWwLFvmIL9IZ0P/HKWAu5DDTbk/6ZEf7hzxTtjzCqW10wKb\n\tnlxeORCrCvO1TGUB8ben0mxu8A8cpmXgsTr882un8qAoAPEr2ftH34DuQmIRkLab12dHNkdpltw\n\tkhNlhOm5m5CUtxd22QwU5LQXhKXZp21FvfRSGLE7FG5VU7j7p2mUE6tYg/hwii7D6tKaJ85eAo6\n\tgycnxc3LRJ5Rl2zqfgnLnxSZRr/Ao7AFre1Z6xU/hY+FdWZFjvp+3CiH4EQIvJliWvqWSWjGnCn\n\t0m3HbvhR8pEla97mQF5VOBsrldtHMe7ZSisr/GQw7VUTEY8UU/DMsXctTum8gczw7tUmrUAw80k\n\tH2k4FHua8HhK3HZ3p2M6nG8PcKPPNHI/HX4lKrSMaEnkUqwgc8kLMIW8cXXFj8tq6dN4d/uFQP/\n\t9U1+I=", "X-Received": "by 2002:a05:600c:4f48:b0:487:59c:2bb8 with SMTP id\n 5b1f17b1804b1-48a84465c97mr118813595e9.27.1777633368690;\n Fri, 01 May 2026 04:02:48 -0700 (PDT)", "From": "Tristan Madani <tristmd@gmail.com>", "To": "David Woodhouse <dwmw2@infradead.org>,\n\tRichard Weinberger <richard@nod.at>", "Cc": "linux-mtd@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org,\n\tstable@vger.kernel.org,\n\tTristan Madani <tristan@talencesecurity.com>,\n\tsyzbot+44664704c1494ad5f7a0@syzkaller.appspotmail.com", "Subject": "[PATCH 2/3] jffs2: clean up xattr refs in jffs2_del_ino_cache instead\n of BUG_ON", "Date": "Fri, 1 May 2026 11:02:45 +0000", "Message-ID": "<20260501110246.50647-2-tristmd@gmail.com>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260501110246.50647-1-tristmd@gmail.com>", "References": "<20260501110246.50647-1-tristmd@gmail.com>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260501_040250_979383_CE21E928 ", "X-CRM114-Status": "GOOD ( 13.15 )", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Tristan Madani jffs2_del_ino_cache() triggers\n BUG_ON(old->xref)\n when an inode cache entry still has xattr references. This can happen\n during\n unmount: generic_shutdown_super() calls evict_inodes() before put_super(),\n [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no\n trust\n [2a00:1450:4864:20:0:0:0:330 listed in]\n [list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n provider\n [tristmd(at)gmail.com]", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Tristan Madani <tristan@talencesecurity.com>\n\njffs2_del_ino_cache() triggers BUG_ON(old->xref) when an inode cache\nentry still has xattr references. This can happen during unmount:\ngeneric_shutdown_super() calls evict_inodes() before put_super(), but\njffs2_evict_inode -> jffs2_do_clear_inode -> jffs2_xattr_delete_inode\nonly clears xrefs when pino_nlink == 0. For inodes with nlink > 0\nat unmount time, xrefs survive past eviction, and the subsequent\njffs2_del_ino_cache() hits the BUG_ON.\n\nReplace the BUG_ON with a call to jffs2_xattr_free_inode(), which\nwalks the xref list and frees each entry without writing delete markers\nto flash. This is appropriate during unmount since the flash state\nwill be reconstructed by the next mount scan anyway.\n\njffs2_xattr_free_inode() already exists for this purpose and is used\nby jffs2_clear_xattr_subsystem() in the put_super path, but that\nruns too late -- after jffs2_del_ino_cache has already been called\nfrom evict_inode.\n\nReported-by: syzbot+44664704c1494ad5f7a0@syzkaller.appspotmail.com\nCloses: https://syzkaller.appspot.com/bug?extid=44664704c1494ad5f7a0\nFixes: aa98d7cf59b5 (\"[JFFS2][XATTR] XATTR support on JFFS2 (version 5)\")\nCc: stable@vger.kernel.org\nSigned-off-by: Tristan Madani <tristan@talencesecurity.com>\n---\n fs/jffs2/nodelist.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/fs/jffs2/nodelist.c b/fs/jffs2/nodelist.c\nindex b86c78d178c60..9af269b78b241 100644\n--- a/fs/jffs2/nodelist.c\n+++ b/fs/jffs2/nodelist.c\n@@ -459,7 +459,8 @@ void jffs2_del_ino_cache(struct jffs2_sb_info *c, struct jffs2_inode_cache *old)\n \tstruct jffs2_inode_cache **prev;\n \n #ifdef CONFIG_JFFS2_FS_XATTR\n-\tBUG_ON(old->xref);\n+\tif (old->xref)\n+\t\tjffs2_xattr_free_inode(c, old);\n #endif\n \tdbg_inocache(\"del %p (ino #%u)\\n\", old, old->ino);\n \tspin_lock(&c->inocache_lock);\n", "prefixes": [ "2/3" ] }