Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2231699/?format=api
{ "id": 2231699, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2231699/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/afRMyi71UFdCTt4h@tucnak/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.1/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<afRMyi71UFdCTt4h@tucnak>", "date": "2026-05-01T06:48:42", "name": "strlen: Adjust objsz arg in __strcat_chk -> __stpcpy_chk transformation [PR125079]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bfdfc988105438ea3e34515645a21b753f3662eb", "submitter": { "id": 671, "url": "http://patchwork.ozlabs.org/api/1.1/people/671/?format=api", "name": "Jakub Jelinek", "email": "jakub@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/afRMyi71UFdCTt4h@tucnak/mbox/", "series": [ { "id": 502428, "url": "http://patchwork.ozlabs.org/api/1.1/series/502428/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=502428", "date": "2026-05-01T06:48:42", "name": "strlen: Adjust objsz arg in __strcat_chk -> __stpcpy_chk transformation [PR125079]", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502428/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231699/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231699/checks/", "tags": {}, "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=XDRWkfd8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=XDRWkfd8", "sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "sourceware.org; spf=pass smtp.mailfrom=redhat.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.133.124" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6M8d03gZz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 01 May 2026 16:49:19 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id A051E43B5530\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 1 May 2026 06:49:17 +0000 (GMT)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by sourceware.org (Postfix) with ESMTP id D761A4A9A8A0\n for <gcc-patches@gcc.gnu.org>; Fri, 1 May 2026 06:48:48 +0000 (GMT)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-uJcxnw7yMIq_2JS1TmahpA-1; Fri,\n 01 May 2026 02:48:47 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 169B2195608A; Fri, 1 May 2026 06:48:46 +0000 (UTC)", "from tucnak.zalov.cz (unknown [10.44.34.21])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 7F6B5300019F; Fri, 1 May 2026 06:48:45 +0000 (UTC)", "from tucnak.zalov.cz (localhost [127.0.0.1])\n by tucnak.zalov.cz (8.18.1/8.18.1) with ESMTPS id 6416mgm92663851\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);\n Fri, 1 May 2026 08:48:42 +0200", "(from jakub@localhost)\n by tucnak.zalov.cz (8.18.1/8.18.1/Submit) id 6416mgRv2663850;\n Fri, 1 May 2026 08:48:42 +0200" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org A051E43B5530", "OpenDKIM Filter v2.11.0 sourceware.org D761A4A9A8A0" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org D761A4A9A8A0", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org D761A4A9A8A0", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777618129; cv=none;\n b=tNMeFxA5elk4BUFYg5Nqd80k94ldTZZxhCfc4E/qzUeniwuYvjC6UQqirZJM23aPMHbBvzUbkKOxHSjRymr0f3z9B84xnSxfm5ltWupGo/H9DxsfqPfIyC7v/roLn7jFcFEXifbaSpPGr5lEZp+7r+1Iir7Im1xmz7zPu3WfJNs=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777618129; c=relaxed/simple;\n bh=Gws7lk8cN5KuvNgvh3Q3ygibn5PQsQBDMU4BeVhlwAE=;\n h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version;\n b=UQk+KXyETQug/9ibMQpBU9kwx4cSwcw0r9PSlapdLJNtQPNF40GY+71o0zF9xSqoXW8T6eY5w9iGN0Noq4tCPs09AGP8OLLoF0uNScEYZykP2IA4FEXPaV3EdTp+TsrMetwCokdml2DWdaM+GssE1P1LxvD/u2eEY6G4vMJofbI=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777618128;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type; bh=hds0Ah07fIm1TFhHT8wdOqCpNpQacAFb8L4gkgW5fBw=;\n b=XDRWkfd8iS44cUkr89mP+Df6fZmpOcYP/pGaVxbi7TsGge1zdBcSrhkUolJfRCDZWqkYre\n 5ueHeQjtxEkGKzjZCQC+LKyHQcfh1CjERdbg0XuwfBXFFgYuSJc2gBiM56EKup05OPJBDc\n UXkznS4U7gI+iA7XXAspqK4vbJjdWcM=", "X-MC-Unique": "uJcxnw7yMIq_2JS1TmahpA-1", "X-Mimecast-MFC-AGG-ID": "uJcxnw7yMIq_2JS1TmahpA_1777618126", "Date": "Fri, 1 May 2026 08:48:42 +0200", "From": "Jakub Jelinek <jakub@redhat.com>", "To": "Richard Biener <rguenther@suse.de>", "Cc": "gcc-patches@gcc.gnu.org", "Subject": "[PATCH] strlen: Adjust objsz arg in __strcat_chk -> __stpcpy_chk\n transformation [PR125079]", "Message-ID": "<afRMyi71UFdCTt4h@tucnak>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "LUA_jtYpuB-0kIWTftkFBPAoNPeH1DjF9YSeaWCWK6Q_1777618126", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Reply-To": "Jakub Jelinek <jakub@redhat.com>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Hi!\n\nAs the following testcase shows, we have two different transformations\nof __strcat_chk. One done in strlen_pass::handle_builtin_strcat,\nwhich transforms __strcat_chk (x, y, z) if we know beforehand strlen (x),\nso something like:\n l = strlen (x);\n __strcat_chk (x, y, z);\nand since PR87672 we change that to\n l = strlen (x);\n __strcpy_chk (x + l, y, z - l);\ni.e. decrease the objsz in\n if (objsz)\n {\n objsz = fold_build2_loc (loc, MINUS_EXPR, TREE_TYPE (objsz), objsz,\n fold_convert_loc (loc, TREE_TYPE (objsz),\n unshare_expr (dstlen)));\n objsz = force_gimple_operand_gsi (&m_gsi, objsz, true, NULL_TREE, true,\n GSI_SAME_STMT);\n }\nAnd another transformation is when we have earlier __strcat_chk (x, y, z)\ncall and want to compute strlen (x) after that. In that case\nget_string_length transforms\n __strcat_chk (x, y, z);\nto\n t = strlen (x);\n l = __stpcpy_chk (x + t, y, z) - x;\nwhere l is the len we are looking for. This patch changes it similarly to\nthe PR87672 to\n t = strlen (x);\n l = __stpcpy_chk (x + t, y, z - t) - x;\ninstead.\n\nBootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/16.2?\n\n2026-05-01 Jakub Jelinek <jakub@redhat.com>\n\n\tPR tree-optimization/125079\n\t* tree-ssa-strlen.cc (get_string_length): Transform\n\t__strcat_chk (x, y, z) when we need strlen (x) afterwards into\n\tl1 = strlen (x); l = __stpcpy_chk (x + l1, y, z - l1) - x;\n\twhere l is the strlen (x), instead of using z as last __stpcpy_chk\n\targument.\n\n\t* gcc.dg/strlenopt-97.c: New test.\n\n\n\tJakub", "diff": "--- gcc/tree-ssa-strlen.cc.jj\t2026-04-27 09:53:40.000000000 +0200\n+++ gcc/tree-ssa-strlen.cc\t2026-04-30 15:30:48.827666196 +0200\n@@ -848,7 +848,7 @@ get_string_length (strinfo *si)\n attempt to compute the length from the call statement. */\n if (si->stmt)\n {\n- gimple *stmt = si->stmt, *lenstmt;\n+ gimple *stmt = si->stmt, *lenstmt = NULL;\n tree callee, lhs, fn, tem;\n location_t loc;\n gimple_stmt_iterator gsi;\n@@ -902,6 +902,17 @@ get_string_length (strinfo *si)\n \t gimple_call_set_fndecl (stmt, fn);\n \t lhs = make_ssa_name (TREE_TYPE (TREE_TYPE (fn)), stmt);\n \t gimple_call_set_lhs (stmt, lhs);\n+\t if (DECL_FUNCTION_CODE (callee) == BUILT_IN_STRCAT_CHK)\n+\t {\n+\t tree objsz = gimple_call_lhs (lenstmt);\n+\t gimple *g\n+\t\t= gimple_build_assign (make_ssa_name (TREE_TYPE (objsz)),\n+\t\t\t\t MINUS_EXPR, gimple_call_arg (stmt, 2),\n+\t\t\t\t objsz);\n+\t gimple_set_location (g, gimple_location (stmt));\n+\t gsi_insert_before (&gsi, g, GSI_SAME_STMT);\n+\t gimple_call_set_arg (stmt, 2, gimple_assign_lhs (g));\n+\t }\n \t update_stmt (stmt);\n \t if (dump_file && (dump_flags & TDF_DETAILS) != 0)\n \t {\n--- gcc/testsuite/gcc.dg/strlenopt-97.c.jj\t2026-04-30 16:34:55.930209569 +0200\n+++ gcc/testsuite/gcc.dg/strlenopt-97.c\t2026-04-30 16:34:52.050276667 +0200\n@@ -0,0 +1,33 @@\n+/* PR tree-optimization/125079 */\n+/* { dg-do compile } */\n+/* { dg-options \"-O2 -fdump-tree-strlen1\" } */\n+/* { dg-final { scan-tree-dump-times \"__builtin___strcpy_chk \\\\\\(\" 1 \"strlen1\" } } */\n+/* { dg-final { scan-tree-dump-not \"__builtin___strcpy_chk \\\\\\(\\[^\\n\\r]*, 64\\\\\\)\" \"strlen1\" } } */\n+/* { dg-final { scan-tree-dump-times \"__builtin___stpcpy_chk \\\\\\(\" 1 \"strlen1\" } } */\n+/* { dg-final { scan-tree-dump-not \"__builtin___stpcpy_chk \\\\\\(\\[^\\n\\r]*, 128\\\\\\)\" \"strlen1\" } } */\n+\n+typedef __SIZE_TYPE__ size_t;\n+void foo (char *, int);\n+char *stpcpy (char *, const char *);\n+\n+size_t\n+bar (char *r)\n+{\n+ char buf[64];\n+ foo (buf, 0);\n+ size_t ret = __builtin_strlen (buf);\n+ __builtin___strcat_chk (buf, r, 64);\n+ foo (buf, 1);\n+ return ret;\n+}\n+\n+size_t\n+baz (char *r)\n+{\n+ char buf[128];\n+ foo (buf, 2);\n+ __builtin___strcat_chk (buf, r, 128);\n+ size_t ret = __builtin_strlen (buf);\n+ foo (buf, 3);\n+ return ret;\n+}\n", "prefixes": [] }