Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2231086/?format=api
{ "id": 2231086, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2231086/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430104434.1482407-4-alex.bennee@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260430104434.1482407-4-alex.bennee@linaro.org>", "date": "2026-04-30T10:44:30", "name": "[v4,3/7] target/arm: ensure aarch64 DISAS_WFE will exit", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bb03decc505980d32e9af1f14bd46c57f35650fb", "submitter": { "id": 39532, "url": "http://patchwork.ozlabs.org/api/1.1/people/39532/?format=api", "name": "Alex Bennée", "email": "alex.bennee@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430104434.1482407-4-alex.bennee@linaro.org/mbox/", "series": [ { "id": 502271, "url": "http://patchwork.ozlabs.org/api/1.1/series/502271/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502271", "date": "2026-04-30T10:44:31", "name": "target/arm: fully model WFxT instructions for A-profile", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/502271/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231086/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231086/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=opQ0Qhr8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5rSL5sm7z1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 20:46:10 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIOt6-0008LS-FE; Thu, 30 Apr 2026 06:44:56 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <alex.bennee@linaro.org>)\n id 1wIOsz-0008Gn-2A\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 06:44:49 -0400", "from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <alex.bennee@linaro.org>)\n id 1wIOsu-0005Kc-FP\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 06:44:48 -0400", "by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-4891f625344so8408665e9.0\n for <qemu-devel@nongnu.org>; Thu, 30 Apr 2026 03:44:40 -0700 (PDT)", "from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a7c32afb0sm38448105e9.35.2026.04.30.03.44.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 03:44:37 -0700 (PDT)", "from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 127B05F936;\n Thu, 30 Apr 2026 11:44:35 +0100 (BST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777545880; x=1778150680; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=SJ3nvH0CdgnQGuiZq72mX6EJh1rauF0iDM3crLBhnzQ=;\n b=opQ0Qhr8U7i0zeF5HOBl/YX5tgVYLyyzcu4C0IZMkx9KSFP3VI90sHq53DxOXIFbmC\n MGkeuF8o3q29iYKyVQo/feoznCkuKyKspX2OIowe+GvgyY5wAPELSFjAF8fG1rep8szO\n CaeHTwmA8Pu1Qs+BmCaqbIEjTJbVFR+HIx/XUMCKogaDfMoar0PoIF94/zv7tQmeR6FU\n mZWe0lEQSD3XF4c6Bo9Dyd6Jl4l9QovAf48BSXg3VchXK+w5H1edBG75K0nklRPZMrhF\n 4+88nekxPbaw2ugnUHI2qR5GdHA9m6fyf+jxK1blsV/NfpRcK6KhUpDweGyhL6MpUj7h\n qViQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777545880; x=1778150680;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=SJ3nvH0CdgnQGuiZq72mX6EJh1rauF0iDM3crLBhnzQ=;\n b=VoseQZlPkZM9VXFjXzHdl5xwG+m89ng3JM6nXRlpWG79CRhvv0f6KJD1g/zOmXKtWJ\n kSox80YHs7FroKR7EXUSzazzpUXxCsYCCJ6wGKiQN/dZ+OUQm1bqwGAJcXdv08r/orsf\n 1vJgVmdk1VDwQSbHgaSbz9OML+TJODVCQ1qjq2Jki2U9316xQ/7Hv3NVBeURTiPFC7HE\n hVq3zzGziWltJ0vvOvMw7qtECq/YmptulNlBE5tIghz8ePg8xmTqFebkt5FYayULa9Sx\n tsQ3zAPW3ohOyfW2yViFqW5lkFBP1g9r2ZLpL6HIUarAsJbiC69mEJc/uNy7ELUEvNk+\n kp+g==", "X-Gm-Message-State": "AOJu0YwGRp3yBLm01pajG9Z0BS6D9G2xtJUeot+DFwOI2xXDiaEVw3bC\n 9NNoiw5k3v55e+79+Eb9RXDp6Rf5qPRivM662cVSZ0JACQ/gsbUUDiNdz382lnereKo=", "X-Gm-Gg": "AeBDieuzFalv2xzrh9uO1hlWBNVMfTT7hyR/s7qk2YviZzEu4cVFN7QMFCRgEMV+3gO\n jhIjXmxmSZrzH3GID1rtEoyabKBBVuanPQMCF8tMj/LNJFZrypAvbN/TCmiEiX40Xf4Cj2AXkK1\n 065FCfB4NOMsHFVc1V8q6vauTltrr4kRTGod8JNRl1ww2Dhn6H/lt5FKw5Hv3FP8+0kfjlyTlkO\n WdyyrRFR7/YEETRTHauxmg6npqhgK9+ma5e+lOB22dStU+zAUWydopicP60tOBdZBO9wMfx/Llx\n N6YV7t+nbhKcdSPCMEmvvNPl0Z5RJEgEMQyslNUeHlk65tWM72fluu+vE1Yky9a6GNEqh4cFZZH\n DklY/2Xje5HkyGxQUXGTCnkb/SNcJVaomhwsC65Sth/HaRpcaKBBhMUI2msnIlzqgBZOLQuMC0w\n HkcokRuvKf2RdzLhxPS/asNY4Vs8IhnHtLng==", "X-Received": "by 2002:a05:600c:8707:b0:489:1baf:8c03 with SMTP id\n 5b1f17b1804b1-48a86084573mr36555495e9.11.1777545879496;\n Thu, 30 Apr 2026 03:44:39 -0700 (PDT)", "From": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Mohamed Mediouni <mohamed@unpredictable.fr>, qemu-arm@nongnu.org,\n Pedro Barbuda <pbarbuda@microsoft.com>,\n Peter Maydell <peter.maydell@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,\n Alexander Graf <agraf@csgraf.de>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>", "Subject": "[PATCH v4 3/7] target/arm: ensure aarch64 DISAS_WFE will exit", "Date": "Thu, 30 Apr 2026 11:44:30 +0100", "Message-ID": "<20260430104434.1482407-4-alex.bennee@linaro.org>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260430104434.1482407-1-alex.bennee@linaro.org>", "References": "<20260430104434.1482407-1-alex.bennee@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::334;\n envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x334.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This mirrors the logic for DISAS_WFE in 32 bit world. As the WFE/WFI\nhave similar behaviours shuffle the case statements around a little\nand update the commentary to cover both.\n\nFixes: 252ec405768 (target-arm: implement WFE/YIELD as a yield for AArch64)\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Alex Bennée <alex.bennee@linaro.org>\n\n---\nv4\n - shuffle case statements, unify the comments.\n---\n target/arm/tcg/translate-a64.c | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c\nindex 9a27c4c6ec7..25f0a806512 100644\n--- a/target/arm/tcg/translate-a64.c\n+++ b/target/arm/tcg/translate-a64.c\n@@ -10916,25 +10916,25 @@ static void aarch64_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu)\n case DISAS_NORETURN:\n case DISAS_SWI:\n break;\n- case DISAS_WFE:\n- gen_a64_update_pc(dc, 4);\n- gen_helper_wfe(tcg_env);\n- break;\n case DISAS_YIELD:\n gen_a64_update_pc(dc, 4);\n gen_helper_yield(tcg_env);\n break;\n+ /*\n+ * Both WFE/WFI can cause exceptions or exit the loop to\n+ * halt so we have to make sure we have rectified the PC.\n+ * However they can also return directly if they don't\n+ * enter a wait state so we must add an exit block so we exit\n+ * the loop and check for interrupts.\n+ */\n+ case DISAS_WFE:\n+ gen_a64_update_pc(dc, 4);\n+ gen_helper_wfe(tcg_env);\n+ tcg_gen_exit_tb(NULL, 0);\n+ break;\n case DISAS_WFI:\n- /*\n- * This is a special case because we don't want to just halt\n- * the CPU if trying to debug across a WFI.\n- */\n gen_a64_update_pc(dc, 4);\n gen_helper_wfi(tcg_env, tcg_constant_i32(4));\n- /*\n- * The helper doesn't necessarily throw an exception, but we\n- * must go back to the main loop to check for interrupts anyway.\n- */\n tcg_gen_exit_tb(NULL, 0);\n break;\n }\n", "prefixes": [ "v4", "3/7" ] }