Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230960/?format=api
{ "id": 2230960, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230960/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430090534.841894-9-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260430090534.841894-9-pbonzini@redhat.com>", "date": "2026-04-30T09:05:29", "name": "[08/13] minikconf: modernize handling of include chain", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "74de2d090ad5484799a129e5d919abfab29f5021", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/1.1/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430090534.841894-9-pbonzini@redhat.com/mbox/", "series": [ { "id": 502245, "url": "http://patchwork.ozlabs.org/api/1.1/series/502245/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502245", "date": "2026-04-30T09:05:25", "name": "kconfig cleanups and mypy annotations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502245/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230960/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230960/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=gabKHb/S;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=JBu81qUt;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5pFD6pNgz1yGq\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 19:06:24 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wINLN-0007zi-O2; Thu, 30 Apr 2026 05:06:01 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1wINLK-0007ys-2A\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 05:05:58 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1wINLI-00038n-CL\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 05:05:57 -0400", "from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-327-zCYeDxwAN0mNICdlYZdfFw-1; Thu, 30 Apr 2026 05:05:53 -0400", "by mail-wm1-f70.google.com with SMTP id\n 5b1f17b1804b1-488c0fcc6deso5134915e9.2\n for <qemu-devel@nongnu.org>; Thu, 30 Apr 2026 02:05:53 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a7b9219f3sm44778695e9.9.2026.04.30.02.05.49\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 02:05:49 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777539955;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=KDJRYPPLDzkY3EK1Q+ay5cnp96vxNf8VANGXo/2TzNc=;\n b=gabKHb/SeWpeR/s7yVL4q5G2hKi+ordy7JVKRdhImCy+gttP1FYjW3GgpbuHXETTkmBFht\n yJfz9OYiFiYmIqW2CmhrYIXWg9QFcSqPNep9RnZ6TPXuj95KY6+w30HNOZ89OVU8flICtF\n 6ttmlWMhKOCXgR9JheV4b4OtIk08iok=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777539951; x=1778144751; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=KDJRYPPLDzkY3EK1Q+ay5cnp96vxNf8VANGXo/2TzNc=;\n b=JBu81qUtHoi7Bwmd6Rrqs+myobzQ4YOoK2I+v6c+Wj4bHDESeBGT/osY7JspwED/Vb\n lZkJNw5SdxceM6DgPdMhUBWXqy0k9KNmnZlyO+Y+4+GlCEOI4BTvgvLkb3DlfFXtEcaB\n EReSSC5S1IfeaREiXs6WlaAUnpqsJmY4uqNKXLs01EfkO5QmVC0QIFNk9fPpC+2coMIB\n 3IYElJcmJRy4j7HjFK69Y320nO5rXpt/JGVYEWi6R/EXl4rEOceWkwda8DYp90WFoNUH\n yzmscuS0UZuHeJ1prCmo8WQejcGeW9MHzJSTD3AN88nDCbJuo99740dm+XPFPOQDuIJy\n KB9A==" ], "X-MC-Unique": "zCYeDxwAN0mNICdlYZdfFw-1", "X-Mimecast-MFC-AGG-ID": "zCYeDxwAN0mNICdlYZdfFw_1777539952", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777539951; x=1778144751;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=KDJRYPPLDzkY3EK1Q+ay5cnp96vxNf8VANGXo/2TzNc=;\n b=ot45jGyaomRRWdUXCoVwI8zWMGD5V/n1SX6Zmsjt5GIAD4nq1Uvm354WqSxTxJezAK\n uyBCOv5m5FwCp2hZi8Hvm3S83kTkiOE5Zk5seCLfK7uDYqBcsX5jFlmb1Sfk6gPi1iA+\n KNq2Z5ZZrhUTu1B/iHhCPk1oQZN06o0kCOUPogYF38nnJP5idAzCV/QUYa/zMkfyl+3b\n 8mw4pfQq1E5nygGDTEPqgJrLa3octsDMetvpVg96Lqf7svGEcX3Cb2ozkpALD29pVAl2\n FfQKqxdTiFZFxu89jicMyy4Y5JfzEnUs6j+jCPvv/I5O8/yKUdEFP/JG2rJq7/7w1UF/\n 9s5w==", "X-Gm-Message-State": "AOJu0YxisQU2FjIQZ1V3xThsE6AuJPlRV7p5SnqPJ6KfVC7+hIJ+p5BK\n A/4NW4HaXJJXAW0penkdADtxlRsLeEEgait5ccYEkWa07iBQuXiSwucmo4pAD4959reqaCyQf03\n 1a60Lru2Mu9ccIz9fajBCl7x4CaN6LBEeBvYyC7adqm77issNfgpnCzCgPFk6ZNbP6vSyObO/Ih\n 598dy+WdAypOO5opIqkRcrLzelTbLiMddMt5Yd9a56", "X-Gm-Gg": "AeBDieu0yQRLCQudQfHed6LkH7d/jGOK8PaSMKcN2pVcFWDAamOdhQ1JQBq4kamj+89\n D9bLO+cXMBRDt5b/VRxFxnfDaXTGOD+VrZSIhBvwkInIWUjChPhfaxZM1IM6eONLgDDMLcYeOpm\n g9YTrQZiLZ2If7KX7LJz3YAma/WxmZIS4a6JmiamkPAbf6hl6jvdY+EO7kbYxpKsFEcqpc/yaUZ\n YU0pEOGmEhVGnrKLKp5KwsCXHbPl7OyNIfqwF/xLG7u8w5uyVATE92U5DtHyXQyjhy9bmhk4uN7\n 6jPZXjqmF7igpCV4qxZRDFOkSqRgDHsDPUeqMIH9MAUJG91oRrSfq1RqgHHZQ+ZmQkLHGRjM6ee\n 6VGf48tpVN0xerLzsKYf9gjMWsqGzU9oh6LHt6mp2HotKLekr2WMGJxM19AFtkr46+YY5iL+/OR\n rzcWhS5j9M5HIHd983ihdgkzaXPW6t/dpVzrU=", "X-Received": [ "by 2002:a05:600c:a14:b0:489:ecee:c4ef with SMTP id\n 5b1f17b1804b1-48a84451b9fmr31196975e9.13.1777539951344;\n Thu, 30 Apr 2026 02:05:51 -0700 (PDT)", "by 2002:a05:600c:a14:b0:489:ecee:c4ef with SMTP id\n 5b1f17b1804b1-48a84451b9fmr31196365e9.13.1777539950735;\n Thu, 30 Apr 2026 02:05:50 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 08/13] minikconf: modernize handling of include chain", "Date": "Thu, 30 Apr 2026 11:05:29 +0200", "Message-ID": "<20260430090534.841894-9-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260430090534.841894-1-pbonzini@redhat.com>", "References": "<20260430090534.841894-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Use a dataclass, and store it in the parser to avoid having to\nsave and restore it.\n\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n scripts/minikconf.py | 66 +++++++++++++++++++++++++-------------------\n 1 file changed, 37 insertions(+), 29 deletions(-)", "diff": "diff --git a/scripts/minikconf.py b/scripts/minikconf.py\nindex 3d63cc6b21f..07a5152ef54 100644\n--- a/scripts/minikconf.py\n+++ b/scripts/minikconf.py\n@@ -15,11 +15,30 @@\n import random\n import re\n import sys\n+from dataclasses import dataclass\n \n __all__ = [ 'KconfigDataError', 'KconfigParserError',\n 'KconfigData', 'KconfigParser' ,\n 'defconfig', 'allyesconfig', 'allnoconfig', 'randconfig' ]\n \n+@dataclass\n+class IncludeInfo:\n+ file: str\n+ line: int\n+ parent: IncludeInfo | None\n+\n+ def __iter__(self):\n+ inf = self\n+ while inf is not None:\n+ yield \"%s:%d\" % (inf.file, inf.line)\n+ inf = inf.parent\n+\n+ def error_path(self):\n+ res = \"\"\n+ for loc in self:\n+ res = \"In file included from %s:\\n\" % loc + res\n+ return res\n+\n def debug_print(*args):\n #print('# ' + (' '.join(str(x) for x in args)))\n pass\n@@ -202,7 +221,6 @@ def process(self):\n def __init__(self, value_mangler=defconfig):\n self.value_mangler = value_mangler\n self.previously_included = []\n- self.incl_info = None\n self.defined_vars = set()\n self.referenced_vars = dict()\n self.clauses = list()\n@@ -342,13 +360,12 @@ def __str__(self):\n class KconfigParser:\n \n @classmethod\n- def parse(cls, fp, data):\n- cls(data).parse_file(fp)\n+ def parse(cls, fp, data, incl_info=None):\n+ cls(fp, data, incl_info).parse_config()\n \n- def __init__(self, data):\n+ def __init__(self, fp, data, incl_info):\n self.data = data\n-\n- def parse_file(self, fp):\n+ self.incl_info = incl_info\n self.abs_fname = os.path.abspath(fp.name)\n self.fname = fp.name\n self.data.previously_included.append(self.abs_fname)\n@@ -360,19 +377,9 @@ def parse_file(self, fp):\n self.line = 1\n self.line_pos = 0\n self.get_token()\n- self.parse_config()\n \n # file management -----\n \n- def error_path(self):\n- inf = self.data.incl_info\n- res = \"\"\n- while inf:\n- res = (\"In file included from %s:%d:\\n\" % (inf['file'],\n- inf['line'])) + res\n- inf = inf['parent']\n- return res\n-\n def location(self):\n col = 1\n for ch in self.src[self.line_pos:self.pos]:\n@@ -380,33 +387,34 @@ def location(self):\n col += 8 - ((col - 1) % 8)\n else:\n col += 1\n- return '%s%s:%d:%d' %(self.error_path(), self.fname, self.line, col)\n+ inf = self.incl_info\n+ incl_chain = inf.error_path() if inf is not None else \"\"\n+ return '%s%s:%d:%d' % (incl_chain, self.fname, self.line, col)\n \n def do_include(self, include):\n incl_abs_fname = os.path.join(os.path.dirname(self.abs_fname),\n include)\n # catch inclusion cycle\n- inf = self.data.incl_info\n+ inf = self.incl_info\n while inf:\n- if incl_abs_fname == os.path.abspath(inf['file']):\n+ if incl_abs_fname == os.path.abspath(inf.file):\n raise KconfigParserError(self, \"Inclusion loop for %s\"\n % include)\n- inf = inf['parent']\n+ inf = inf.parent\n \n # skip multiple include of the same file\n if incl_abs_fname in self.data.previously_included:\n return\n try:\n- fp = open(incl_abs_fname, 'rt', encoding='utf-8')\n- except IOError as e:\n- raise KconfigParserError(self,\n- '%s: %s' % (e.strerror, include))\n+ try:\n+ fp = open(incl_abs_fname, 'rt', encoding='utf-8')\n+ except IOError as e:\n+ raise KconfigParserError(self, '%s: %s' % (e.strerror, include))\n \n- inf = self.data.incl_info\n- self.data.incl_info = { 'file': self.fname, 'line': self.line,\n- 'parent': inf }\n- KconfigParser(self.data).parse_file(fp)\n- self.data.incl_info = inf\n+ inner = IncludeInfo(file=self.fname, line=self.line, parent=self.incl_info)\n+ type(self).parse(fp, self.data, inner)\n+ finally:\n+ fp.close()\n \n # recursive descent parser -----\n \n", "prefixes": [ "08/13" ] }