Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230957/?format=api
{ "id": 2230957, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230957/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430090534.841894-6-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260430090534.841894-6-pbonzini@redhat.com>", "date": "2026-04-30T09:05:26", "name": "[05/13] minikconf: move command-line assignment out of the parser", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5127195d58a7b96a9354890db3efb7147b3d8ff5", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/1.1/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430090534.841894-6-pbonzini@redhat.com/mbox/", "series": [ { "id": 502245, "url": "http://patchwork.ozlabs.org/api/1.1/series/502245/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502245", "date": "2026-04-30T09:05:25", "name": "kconfig cleanups and mypy annotations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502245/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230957/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230957/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=iF5zLrwZ;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=cB/sqnBz;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5pFC2gkjz1yGq\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 19:06:21 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wINLH-0007xn-6L; Thu, 30 Apr 2026 05:05:55 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1wINLF-0007xE-L4\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 05:05:53 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1wINLD-00037k-Gj\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 05:05:53 -0400", "from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-57-R5PVMPgcPZGwu6tDlDczhQ-1; Thu, 30 Apr 2026 05:05:48 -0400", "by mail-wm1-f70.google.com with SMTP id\n 5b1f17b1804b1-48a5775d647so5622735e9.2\n for <qemu-devel@nongnu.org>; Thu, 30 Apr 2026 02:05:47 -0700 (PDT)", "from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a7c1d0228sm138960685e9.2.2026.04.30.02.05.44\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 02:05:44 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777539950;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4gtxuAH4PAvxNT4xHNaNPMHcitxd/taN2BN54e0wKh4=;\n b=iF5zLrwZOCaj2oRUOQOZNwt0WUO44pNQHC4Y6tiX5cjna43kc5QqXLgtFr1tPA/tOsimon\n aITp+ts8+B0vaOuQiPMWEwt2QPg0Y2Edsulm/vqVmZHkUyu+5yTC8B2VNAggUdks39cKnb\n 8MiEg5xztgwjse3LZQx8WutkPk8BA1U=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777539946; x=1778144746; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=4gtxuAH4PAvxNT4xHNaNPMHcitxd/taN2BN54e0wKh4=;\n b=cB/sqnBzHzkf53K6bMtS7fWgVK0BrnEH3QAhPjO5DSeYoF7QraEo5RqjkfVsKjD3a4\n 9pYxFhkZ+LAdnmuiP3A+EP26S48zA6egZRDz/Npue5oJC1ERtW4PcxshUfAZrWoVbTxb\n LhPYaK4OvrQTYpVeTsS6Z+6HOlKU/okCs6xEXvclWpgOxam9sORjoa2TVBCZE70VC9YS\n VCCLdRu9456EvnmFXQLhh9z2y4pcJFkJ7ixJEMU446R2wySL//zReXkQM9oLOFbiXrHi\n /LBMGU3m042UA8tjzqiTRppOd5f3O6AHb5wdmVam6WdZYuvjP+wkwO7MnihweXtlUOM6\n aVJA==" ], "X-MC-Unique": "R5PVMPgcPZGwu6tDlDczhQ-1", "X-Mimecast-MFC-AGG-ID": "R5PVMPgcPZGwu6tDlDczhQ_1777539947", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777539946; x=1778144746;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=4gtxuAH4PAvxNT4xHNaNPMHcitxd/taN2BN54e0wKh4=;\n b=sMAeT54pN74cOWvw7El/LiCfVPPyHgM7HAlukKDM1r6O4j1QtY0k481eSNzgrK8n7S\n jl3jPI1VZjpRQQZpwhoUywGUC0dG1y0spXDGtdK4NU1KNvbUu3CppZj1NgkN2YZNQxQy\n NrNLhaQnmpQbsP2bZfRaD+P9kmAxTTlH/M2DklnkeTRYAymyH1Tev4sFzq4HO9hflcD6\n nJSQJbP67m4j4U04tQ1oeHjxLvTXq5L+8Q8f21mn1L1XKf0GgDx4Q4U9VsxWAf065N4/\n +5bUf8Qa2SJLkKGFmPpRNd7RqNmNei5DU13pIu5TPAMnyCmZOOEQV0Pea/Vv4FkN/P3f\n C67Q==", "X-Gm-Message-State": "AOJu0Yx1boPlunHgBW4mNpSDz7R2zYOZ738YucGHTYP2r/Z96xk7cpTa\n GS5hLxsraAYzG9kyjZlugFOcA/PQOVYX/B4QccFEI5es9Ta1xMnKW4jRyaG18YZ4dItpQmmKjDq\n 05C32yKz8ZKi2swVJf03dj56fMTYbIJxhiiWHnOSoS2FLU/UECkvkGQDF2SWu8xfyNyO30p/CGe\n AYl3tEyhHME2CLkT5kV6KyEOqwkJLKdSscbUx4dOh9", "X-Gm-Gg": "AeBDieu097q++bUlEh1SWuLtrYKktmp9NeacR7VhXd/VBNAPgJeJn7+D1wyhuYCePh0\n c+wCjveg0iOxdl/Mj667VK/s5yM6dwwW+kdZpZFaWNlJ+DmzTbQbH0KKcM3sAWjFMnNEZS5gd3L\n yaSv2/oBstFeXnKxTWgkIHwR25iCA0bvo6RzAhhWMRC7VlUQHATF8CTYzDfZkqKuWfSJfvItqtJ\n fK8g9pZjx04n5e7S6L5JVlZxIQ6gtyXLXX2B9lUE24A+NWzCJ1K8D92BwmQ+b1rDzs+tjY4hgcg\n 0uf7ejucOScWO+1wxPTVr48SdbEzJo9seUjH4xPvRPF0dbcOMJ/ZDic6ap+rGMVw2lmQVTsJcQM\n 7wHRZ5GrZhJjPsJ7Aff4IaTC1n8ok6qGkPPs1bma9LJycAXI+w7EU8Us6l0bimyivt75IX3B63s\n yx37Q6/doJuVOhk3SFDzWHAMyfRw3ZiWOuRpk=", "X-Received": [ "by 2002:a05:600c:c4a5:b0:483:2c98:4368 with SMTP id\n 5b1f17b1804b1-48a84467651mr33692915e9.18.1777539946098;\n Thu, 30 Apr 2026 02:05:46 -0700 (PDT)", "by 2002:a05:600c:c4a5:b0:483:2c98:4368 with SMTP id\n 5b1f17b1804b1-48a84467651mr33692325e9.18.1777539945419;\n Thu, 30 Apr 2026 02:05:45 -0700 (PDT)" ], "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 05/13] minikconf: move command-line assignment out of the\n parser", "Date": "Thu, 30 Apr 2026 11:05:26 +0200", "Message-ID": "<20260430090534.841894-6-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260430090534.841894-1-pbonzini@redhat.com>", "References": "<20260430090534.841894-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "KconfigParser.do_assignment() only exists to handle CONFIG_FOO=y/n\narguments from the command line; it is never invoked while parsing\na Kconfig source file. Because main() called it on a parser that\nhad never been through parse_file(), a failing CONFIG_ check would\nraise a KconfigParserError whose __init__ and location() touch\nfields of \"self\" that do not exist yet. The regex in main()\ncurrently shields this, but it is fragile.\n\nMove the prefix-stripping assignment to KconfigData as\ndo_cmdline_assignment(), simplify KconfigParser.parse() to accept\nan existing KconfigData, and call it from main() so the parser is\nonly used for actual file parsing.\n\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n scripts/minikconf.py | 27 +++++++++------------------\n 1 file changed, 9 insertions(+), 18 deletions(-)", "diff": "diff --git a/scripts/minikconf.py b/scripts/minikconf.py\nindex 08df8d5dabb..668de577d09 100644\n--- a/scripts/minikconf.py\n+++ b/scripts/minikconf.py\n@@ -278,6 +278,10 @@ def do_var(self, var):\n def do_assignment(self, var, val):\n self.clauses.append(KconfigData.AssignmentClause(var, val))\n \n+ def do_cmdline_assignment(self, var, val):\n+ assert var.startswith(\"CONFIG_\")\n+ self.do_assignment(self.do_var(var[7:]), val)\n+\n def do_default(self, var, val, cond=None):\n val = self.value_mangler(val)\n self.clauses.append(KconfigData.DefaultClause(var, val, cond))\n@@ -338,11 +342,8 @@ def __str__(self):\n class KconfigParser:\n \n @classmethod\n- def parse(cls, fp, mode=None):\n- data = KconfigData(mode or defconfig)\n- parser = cls(data)\n- parser.parse_file(fp)\n- return data\n+ def parse(cls, fp, data):\n+ cls(data).parse_file(fp)\n \n def __init__(self, data):\n self.data = data\n@@ -361,14 +362,6 @@ def parse_file(self, fp):\n self.get_token()\n self.parse_config()\n \n- def do_assignment(self, var, val):\n- if not var.startswith(\"CONFIG_\"):\n- raise KconfigParserError(\n- self, \"assigned variable should start with CONFIG_\"\n- )\n- var = self.data.do_var(var[7:])\n- self.data.do_assignment(var, val)\n-\n # file management -----\n \n def error_path(self):\n@@ -688,18 +681,16 @@ def scan_token(self):\n sys.exit(1)\n \n data = KconfigData(mode)\n- parser = KconfigParser(data)\n external_vars = set()\n for arg in argv[3:]:\n m = re.match(r'^(CONFIG_[A-Z0-9_]+)=([yn]?)$', arg)\n if m is not None:\n name, value = m.groups()\n- parser.do_assignment(name, value == 'y')\n+ data.do_cmdline_assignment(name, value == 'y')\n external_vars.add(name[7:])\n else:\n- fp = open(arg, 'rt', encoding='utf-8')\n- parser.parse_file(fp)\n- fp.close()\n+ with open(arg, 'rt', encoding='utf-8') as fp:\n+ KconfigParser.parse(fp, data)\n \n config = data.compute_config()\n for key in sorted(config.keys()):\n", "prefixes": [ "05/13" ] }