Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230767/?format=api
{ "id": 2230767, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230767/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260430021628.1343154-1-mark.tomlinson@alliedtelesis.co.nz/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/1.1/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260430021628.1343154-1-mark.tomlinson@alliedtelesis.co.nz>", "date": "2026-04-30T02:16:28", "name": "PCI: iproc: Restore map_irq", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3fb2c8bd56fe5231a2dc725ed8e95aaaaaa051ec", "submitter": { "id": 65250, "url": "http://patchwork.ozlabs.org/api/1.1/people/65250/?format=api", "name": "Mark Tomlinson", "email": "mark.tomlinson@alliedtelesis.co.nz" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260430021628.1343154-1-mark.tomlinson@alliedtelesis.co.nz/mbox/", "series": [ { "id": 502179, "url": "http://patchwork.ozlabs.org/api/1.1/series/502179/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=502179", "date": "2026-04-30T02:16:28", "name": "PCI: iproc: Restore map_irq", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502179/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230767/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230767/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-pci+bounces-53439-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz\n header.a=rsa-sha256 header.s=mail181024 header.b=RBnHOaT8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-53439-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=alliedtelesis.co.nz\n header.i=@alliedtelesis.co.nz header.b=\"RBnHOaT8\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=202.36.163.20", "smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=alliedtelesis.co.nz" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5dMz0yrVz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 12:26:39 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 78D3E301D321\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 02:26:00 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id F26AB280A20;\n\tThu, 30 Apr 2026 02:25:58 +0000 (UTC)", "from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz\n [202.36.163.20])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 462F9282F26\n\tfor <linux-pci@vger.kernel.org>; Thu, 30 Apr 2026 02:25:56 +0000 (UTC)", "from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(Client did not present a certificate)\n\tby gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id C090F2C03DB;\n\tThu, 30 Apr 2026 14:16:46 +1200 (NZST)", "from pat.atlnz.lc (Not Verified[10.32.16.33]) by\n svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305)\n\tid <B69f2bb8e0000>; Thu, 30 Apr 2026 14:16:46 +1200", "from markto-dl.ws.atlnz.lc (markto-dl.ws.atlnz.lc [10.33.23.30])\n\tby pat.atlnz.lc (Postfix) with ESMTP id 9352D13EE37;\n\tThu, 30 Apr 2026 14:16:46 +1200 (NZST)", "by markto-dl.ws.atlnz.lc (Postfix, from userid 1155)\n\tid 8D9BA40695; Thu, 30 Apr 2026 14:16:46 +1200 (NZST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777515958; cv=none;\n b=RLjunmke3B98/SiT+RWT45anJBGsbpvuOTZrvujOLM+vt5D6oYQESP5NuFsgOeOf1EOFC7WWcYrPjKyQDd/6zVPghzN1+GMO1Jc4Unj2v8S1niv7rHEzLVtmGG8i+TxUDBdB4VLpbDf9pNWOPtiqvpnv2V85toIj/nCm+17T9kg=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777515958; c=relaxed/simple;\n\tbh=2YfcaCpVj8I0+6vfMIX/411ZUiHo41zjdzHXYSM43QE=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=tFJjixebDudCC2OV0FOohiP9wrj4ptzdjAHdBXIVVYaD1n+tNZOAdKQ1fPQMufkISkFOScZ72cVHSID2iKyIiW7kcwohZ3RB5oGmvqXbn/TUQ8U9iDVevmjm1PNP3siabPH9PhPc7axGDjmY3cATCU1y4nHrnbd9DF2cCMxZ/34=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=alliedtelesis.co.nz;\n spf=pass smtp.mailfrom=alliedtelesis.co.nz;\n dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz\n header.i=@alliedtelesis.co.nz header.b=RBnHOaT8;\n arc=none smtp.client-ip=202.36.163.20", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz;\n\ts=mail181024; t=1777515406;\n\tbh=HCK71yqemvhP7M6VURV0XNIhfF8xXPI+wMqttk0c3rI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=RBnHOaT8DSYkT5MNqWxPAjxIqaG7zpkgXdJ+Lc1ahiwIV7WPD8/gUwQbgBXc7Qoj+\n\t fDXu29nSnT1O0soJMDByI7nfxJKLS/jNTlyOcO17+fxYZgxWezznsxerT31ulqCHxY\n\t 6zXj7tnlHJ+iJJQXEYTuU2/efYGtVtxIeOmNNkIF+OroiXu2TPas5/A0aeMqqxICT7\n\t dKW0bb51kEYIsazPj6p8mDGN0+dghcIEw3svDlZvdOr2CsPy/gBFG1fI0ABCEZPe+T\n\t Ne0WN/IuJXfrzqsKsUfzMOIwnF0PwtctT2WWeki1Jpk6sZaT6upGnMk0prohTrKgKp\n\t mkQgHNbUZXV1g==", "From": "Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>", "To": "rjui@broadcom.com,\n\tsbranden@broadcom.com,\n\tlpieralisi@kernel.org,\n\trobh@kernel.org", "Cc": "linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>", "Subject": "[PATCH] PCI: iproc: Restore map_irq", "Date": "Thu, 30 Apr 2026 14:16:28 +1200", "Message-ID": "<20260430021628.1343154-1-mark.tomlinson@alliedtelesis.co.nz>", "X-Mailer": "git-send-email 2.54.0", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-SEG-SpamProfiler-Analysis": "v=2.4 cv=FPe4xPos c=1 sm=1 tr=0 ts=69f2bb8e\n a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=A5OVakUREuEA:10 a=0iGZelks7BQB0ZmUgWIA:9\n a=3ZKOabzyN94A:10", "X-SEG-SpamProfiler-Score": "0", "x-atlnz-ls": "pat" }, "content": "Some time back, the PCI bridge map_irq and swizzle_irq were set up with\ndefault functions. The iproc PCIe driver was broken by this change, with\nthe mapping function ending up being set to NULL. Restore the original\n(and intended) behaviour to use the default functions.\n\nThe iproc pcie kept the mapping function in a private data structure,\nwhich was then copied into the pci_host_bridge structure. As the private\ndata was initialised to NULL, the NULL would end up being copied. The\nfix is not to keep the mapping function in the private data, but just\nset the function pointer directly when needed.\n\nFixes: b64aa11eb2dd (\"PCI: Set bridge map_irq and swizzle_irq to default functions\")\nSigned-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>\n---\n drivers/pci/controller/pcie-iproc-bcma.c | 2 +-\n drivers/pci/controller/pcie-iproc-platform.c | 2 +-\n drivers/pci/controller/pcie-iproc.c | 1 -\n drivers/pci/controller/pcie-iproc.h | 2 --\n 4 files changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/pci/controller/pcie-iproc-bcma.c b/drivers/pci/controller/pcie-iproc-bcma.c\nindex 99a99900444d..593418c2bc3a 100644\n--- a/drivers/pci/controller/pcie-iproc-bcma.c\n+++ b/drivers/pci/controller/pcie-iproc-bcma.c\n@@ -64,7 +64,7 @@ static int iproc_bcma_pcie_probe(struct bcma_device *bdev)\n \tif (ret)\n \t\treturn ret;\n \n-\tpcie->map_irq = iproc_bcma_pcie_map_irq;\n+\tbridge->map_irq = iproc_bcma_pcie_map_irq;\n \n \tbcma_set_drvdata(bdev, pcie);\n \ndiff --git a/drivers/pci/controller/pcie-iproc-platform.c b/drivers/pci/controller/pcie-iproc-platform.c\nindex 0cb78c583c7e..4c9a0c4bb923 100644\n--- a/drivers/pci/controller/pcie-iproc-platform.c\n+++ b/drivers/pci/controller/pcie-iproc-platform.c\n@@ -98,7 +98,7 @@ static int iproc_pltfm_pcie_probe(struct platform_device *pdev)\n \tswitch (pcie->type) {\n \tcase IPROC_PCIE_PAXC:\n \tcase IPROC_PCIE_PAXC_V2:\n-\t\tpcie->map_irq = NULL;\n+\t\tbridge->map_irq = NULL;\n \t\tbreak;\n \tdefault:\n \t\tbreak;\ndiff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c\nindex ccf71993ea35..c22d0aecaaac 100644\n--- a/drivers/pci/controller/pcie-iproc.c\n+++ b/drivers/pci/controller/pcie-iproc.c\n@@ -1502,7 +1502,6 @@ int iproc_pcie_setup(struct iproc_pcie *pcie, struct list_head *res)\n \n \thost->ops = &iproc_pcie_ops;\n \thost->sysdata = pcie;\n-\thost->map_irq = pcie->map_irq;\n \n \tret = pci_host_probe(host);\n \tif (ret < 0) {\ndiff --git a/drivers/pci/controller/pcie-iproc.h b/drivers/pci/controller/pcie-iproc.h\nindex 969ded03b8c2..c4443f236ca3 100644\n--- a/drivers/pci/controller/pcie-iproc.h\n+++ b/drivers/pci/controller/pcie-iproc.h\n@@ -61,7 +61,6 @@ struct iproc_msi;\n * @base_addr: PCIe host controller register base physical address\n * @mem: host bridge memory window resource\n * @phy: optional PHY device that controls the Serdes\n- * @map_irq: function callback to map interrupts\n * @ep_is_internal: indicates an internal emulated endpoint device is connected\n * @iproc_cfg_read: indicates the iProc config read function should be used\n * @rej_unconfig_pf: indicates the root complex needs to detect and reject\n@@ -91,7 +90,6 @@ struct iproc_pcie {\n \tphys_addr_t base_addr;\n \tstruct resource mem;\n \tstruct phy *phy;\n-\tint (*map_irq)(const struct pci_dev *, u8, u8);\n \tbool ep_is_internal;\n \tbool iproc_cfg_read;\n \tbool rej_unconfig_pf;\n", "prefixes": [] }