Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230629/?format=api
{ "id": 2230629, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230629/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-22-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260429222445.26301-22-richard.henderson@linaro.org>", "date": "2026-04-29T22:24:18", "name": "[PULL,21/48] fpu: Drop parts_float_to_sint_modulo", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a9a2958f1141668fdca47e0677b851c9a22cfe5a", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/1.1/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-22-richard.henderson@linaro.org/mbox/", "series": [ { "id": 502161, "url": "http://patchwork.ozlabs.org/api/1.1/series/502161/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502161", "date": "2026-04-29T22:23:57", "name": "[PULL,01/48] fpu: Drop parts_canonicalize", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502161/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230629/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230629/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=UciMemuX;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5X5d6QTpz1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 08:28:53 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIDLq-0000ZJ-Bw; Wed, 29 Apr 2026 18:25:50 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIDLo-0000P8-B6\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:48 -0400", "from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIDLm-00056S-Gk\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:48 -0400", "by mail-pj1-x1030.google.com with SMTP id\n 98e67ed59e1d1-35d9f68d011so109356a91.2\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 15:25:46 -0700 (PDT)", "from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364a2732502sm1888471a91.3.2026.04.29.15.25.42\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 15:25:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777501545; x=1778106345; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XMNMmP51MzAfmnEvRon5cWfF7WNzLdBZNzrwQ9eWX/c=;\n b=UciMemuXpMx7dhGucB2zn8TW+8KY3lWOwo5xalj4NWElg2W8+JeASUlSw5HLNkaZxU\n rG5/6k9meJKyzXH6TvdXMvtR/3sWPM5KA+moWsbr/9GYjgjQ7bxYffWCrGmlWTaqkuyv\n CK6MsG/FKWC2dQ8ICtQLFHsOT3XhReN2CyLQMTUEFtkbJ8cqhLp9a7KB2seeT3YmaCNr\n TuD3OLjaOMF1Xbs4kkxRQN9SS2Z57LOTSZ5xr0nHhZ+KVlE2WZcVuouVFsncA/X0y1CM\n Sf6TPNdqkSkI9uJKxMcpTB2uomAWcv7GMaa19j8XIbNBLCe+SMvnYHF0erTpHLlNcveS\n n7Hg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777501545; x=1778106345;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=XMNMmP51MzAfmnEvRon5cWfF7WNzLdBZNzrwQ9eWX/c=;\n b=P7V/SmfYAdFOJP5JazYfS//SyoqDIBxFCVEgste3IePFRwNt2zH1wS5R6e7S7wgySY\n 449XSUNWVCcOy8lEtIg14LNW2Y2+AAA5bDfB4oADWrKW1TsGJi0cqTZ7BT7GrMzZU6jc\n SLPO9poWgAW0qhzBBpjW/0Oxv1Co9A/IuZIHsWrBw5fXoPaNQ0WJ4A1IqSx1T1Uvr3zQ\n uLFH1Pxw1ldkeAgmTH72j3ixcSJXuIjwnCGwNW8/WoOiMZJ8J9LBwdjsT2txgqwhla7m\n yWJxeFxGmK5weW3MKnQCV9al0vppI5jAibANzsYgjQkb1ZFw162R6/G57I0afoTooBBa\n BIxg==", "X-Gm-Message-State": "AOJu0YwOT0pjKhfaKiIfX+dgch8fRvd4gweO+8z8HyxcCmjFEPJXNDxN\n z+aQ4/ziWlQTYfoFeNu+bqv2GFG82eN66gYpqN5YQUxU3qhOGbZNyi5N4tZu13Zxw2GeYZfYBE+\n R0OQWJjk=", "X-Gm-Gg": "AeBDievgESicxW1hTOP6RNltboedSg8WgR/qLZxPb5Wu289a4we++EhHrIiotJD9UJR\n RygC7TgiS1iMpz2xr6ARhFHZg4DAuCG7qX3Fbf6zl/9kk7HFvKRbv/ClS3MCsYTO+wzTpyzHKh+\n jHZIauXYuSBhP81SCigVtAp0em4pQQFE7ReHkb5Lh1ouxjcvcy+MmdM9heCZNxIAeV8Cx3mvxRD\n 8j6s99/OjQE9kxsZH793GE3m4N0fUSsV7lUJ1aQrdvcAcF0RGqupovXUUSJE5Nqy25OjPqK6Ii+\n ck72+hhmvc1gX0Haakmw3ugxRL3QusAIKrSl7yzK2ohsqF/RCszZW9ptN/RV8zth2HM/1gXk0Xk\n QudtpUAEP/ycFV5qyKsoHEaKiLpXdVPiur8Uq2rtZkNx/Am1JrKjtPp/AFLvePvc6/tTn/DWskL\n 32OPwhISho1z0Q0Og+K/ON0WQ13QiqNNbLqad2l2lJRBvbZwu6o+k=", "X-Received": "by 2002:a17:90b:1fc6:b0:35b:e4d8:e21d with SMTP id\n 98e67ed59e1d1-364c2f8216cmr167837a91.2.1777501544956;\n Wed, 29 Apr 2026 15:25:44 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "stefanha@redhat.com,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PULL 21/48] fpu: Drop parts_float_to_sint_modulo", "Date": "Thu, 30 Apr 2026 08:24:18 +1000", "Message-ID": "<20260429222445.26301-22-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260429222445.26301-1-richard.henderson@linaro.org>", "References": "<20260429222445.26301-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::1030;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Use parts64_float_to_sint_modulo at each call site.\n\nThat leaves parts128_float_to_sint_modulo unused,\nso move the whole function back to softfloat.c and\nspecialize for FloatParts64.\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 84 +++++++++++++++++++++++++++++++++------\n fpu/softfloat-parts.c.inc | 79 ------------------------------------\n 2 files changed, 72 insertions(+), 91 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 869b592cd0..0b2638c34b 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,16 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n FloatParts128 *: parts128_##NAME, \\\n FloatParts256 *: parts256_##NAME)\n \n-static int64_t parts64_float_to_sint_modulo(FloatParts64 *p,\n- FloatRoundMode rmode,\n- int bitsm1, float_status *s);\n-static int64_t parts128_float_to_sint_modulo(FloatParts128 *p,\n- FloatRoundMode rmode,\n- int bitsm1, float_status *s);\n-\n-#define parts_float_to_sint_modulo(P, R, M, S) \\\n- PARTS_GENERIC_64_128(float_to_sint_modulo, P)(P, R, M, S)\n-\n static void parts64_sint_to_float(FloatParts64 *p, int64_t a,\n int scale, float_status *s);\n static void parts128_sint_to_float(FloatParts128 *p, int64_t a,\n@@ -3558,13 +3548,83 @@ int64_t bfloat16_to_int64_round_to_zero(bfloat16 a, float_status *s)\n return bfloat16_to_int64_scalbn(a, float_round_to_zero, 0, s);\n }\n \n+/*\n+ * Like partsN(float_to_sint), except do not saturate the result.\n+ * Instead, return the rounded unbounded precision two's compliment result,\n+ * modulo 2**(bitsm1 + 1).\n+ */\n+static int64_t parts64_float_to_sint_modulo(FloatParts64 *p,\n+ FloatRoundMode rmode,\n+ int bitsm1, float_status *s)\n+{\n+ int flags = 0;\n+ uint64_t r;\n+ bool overflow = false;\n+\n+ switch (p->cls) {\n+ case float_class_snan:\n+ flags |= float_flag_invalid_snan;\n+ /* fall through */\n+ case float_class_qnan:\n+ flags |= float_flag_invalid;\n+ r = 0;\n+ break;\n+\n+ case float_class_inf:\n+ overflow = true;\n+ r = 0;\n+ break;\n+\n+ case float_class_zero:\n+ return 0;\n+\n+ case float_class_normal:\n+ case float_class_denormal:\n+ /* TODO: 64 - 2 is frac_size for rounding; could use input fmt. */\n+ if (parts64_round_to_int_normal(p, rmode, 0, 64 - 2)) {\n+ flags = float_flag_inexact;\n+ }\n+\n+ if (p->exp <= DECOMPOSED_BINARY_POINT) {\n+ r = p->frac >> (DECOMPOSED_BINARY_POINT - p->exp);\n+ if (p->exp < bitsm1) {\n+ /* Result in range. */\n+ } else if (p->exp == bitsm1) {\n+ /* The only in-range value is INT_MIN. */\n+ overflow = !p->sign || p->frac != DECOMPOSED_IMPLICIT_BIT;\n+ } else {\n+ overflow = true;\n+ }\n+ } else {\n+ /* Overflow, but there might still be bits to return. */\n+ int shl = p->exp - DECOMPOSED_BINARY_POINT;\n+ r = (shl < 64 ? p->frac << shl : 0);\n+ overflow = true;\n+ }\n+\n+ if (p->sign) {\n+ r = -r;\n+ }\n+ break;\n+\n+ default:\n+ g_assert_not_reached();\n+ }\n+\n+ if (overflow) {\n+ flags = float_flag_invalid | float_flag_invalid_cvti;\n+ }\n+ float_raise(flags, s);\n+ return r;\n+}\n+\n int32_t float64_to_int32_modulo(float64 a, FloatRoundMode rmode,\n float_status *s)\n {\n FloatParts64 p;\n \n float64_unpack_canonical(&p, a, s);\n- return parts_float_to_sint_modulo(&p, rmode, 31, s);\n+ return parts64_float_to_sint_modulo(&p, rmode, 31, s);\n }\n \n int64_t float64_to_int64_modulo(float64 a, FloatRoundMode rmode,\n@@ -3573,7 +3633,7 @@ int64_t float64_to_int64_modulo(float64 a, FloatRoundMode rmode,\n FloatParts64 p;\n \n float64_unpack_canonical(&p, a, s);\n- return parts_float_to_sint_modulo(&p, rmode, 63, s);\n+ return parts64_float_to_sint_modulo(&p, rmode, 63, s);\n }\n \n /*\ndiff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex 9b719ac5cf..d8eb9f5b78 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -1415,85 +1415,6 @@ static uint64_t partsN(float_to_uint)(FloatPartsN *p, FloatRoundMode rmode,\n return r;\n }\n \n-/*\n- * Like partsN(float_to_sint), except do not saturate the result.\n- * Instead, return the rounded unbounded precision two's compliment result,\n- * modulo 2**(bitsm1 + 1).\n- */\n-static int64_t partsN(float_to_sint_modulo)(FloatPartsN *p,\n- FloatRoundMode rmode,\n- int bitsm1, float_status *s)\n-{\n- int flags = 0;\n- uint64_t r;\n- bool overflow = false;\n-\n- switch (p->cls) {\n- case float_class_snan:\n- flags |= float_flag_invalid_snan;\n- /* fall through */\n- case float_class_qnan:\n- flags |= float_flag_invalid;\n- r = 0;\n- break;\n-\n- case float_class_inf:\n- overflow = true;\n- r = 0;\n- break;\n-\n- case float_class_zero:\n- return 0;\n-\n- case float_class_normal:\n- case float_class_denormal:\n- /* TODO: N - 2 is frac_size for rounding; could use input fmt. */\n- if (partsN(round_to_int_normal)(p, rmode, 0, N - 2)) {\n- flags = float_flag_inexact;\n- }\n-\n- if (p->exp <= DECOMPOSED_BINARY_POINT) {\n- /*\n- * Because we rounded to integral, and exp < 64,\n- * we know frac_low is zero.\n- */\n- r = p->frac_hi >> (DECOMPOSED_BINARY_POINT - p->exp);\n- if (p->exp < bitsm1) {\n- /* Result in range. */\n- } else if (p->exp == bitsm1) {\n- /* The only in-range value is INT_MIN. */\n- overflow = !p->sign || p->frac_hi != DECOMPOSED_IMPLICIT_BIT;\n- } else {\n- overflow = true;\n- }\n- } else {\n- /* Overflow, but there might still be bits to return. */\n- int shl = p->exp - DECOMPOSED_BINARY_POINT;\n- if (shl < N) {\n- frac_shl(p, shl);\n- r = p->frac_hi;\n- } else {\n- r = 0;\n- }\n- overflow = true;\n- }\n-\n- if (p->sign) {\n- r = -r;\n- }\n- break;\n-\n- default:\n- g_assert_not_reached();\n- }\n-\n- if (overflow) {\n- flags = float_flag_invalid | float_flag_invalid_cvti;\n- }\n- float_raise(flags, s);\n- return r;\n-}\n-\n /*\n * Integer to float conversions\n *\n", "prefixes": [ "PULL", "21/48" ] }