Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230567/?format=api
{ "id": 2230567, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230567/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429210830.594724-8-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260429210830.594724-8-berrange@redhat.com>", "date": "2026-04-29T21:08:28", "name": "[7/9] qom: add object_new_with_props_from_qdict", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "be901f6b80d170ab0eb82625757b527f18a48025", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/1.1/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429210830.594724-8-berrange@redhat.com/mbox/", "series": [ { "id": 502152, "url": "http://patchwork.ozlabs.org/api/1.1/series/502152/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502152", "date": "2026-04-29T21:08:21", "name": "qom: misc cleanups / fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502152/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230567/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230567/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dlhkaTxc;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VKw3l4bz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 07:09:24 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIC9S-0007a6-Nc; Wed, 29 Apr 2026 17:08:58 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wIC9O-0007OI-9y\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:08:54 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wIC9M-0004E7-7g\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:08:54 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-lW501HedOM2r642MboSMiA-1; Wed,\n 29 Apr 2026 17:08:49 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4F45C19560A2\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 21:08:48 +0000 (UTC)", "from berrange.com (unknown [10.44.48.62])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D2123300019F; Wed, 29 Apr 2026 21:08:46 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496930;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4iMiSVCvkm2ytzX3BKXVXaxFnTCTRwNA1ZGhKYgR6MM=;\n b=dlhkaTxcVopVyQ+c7NtK9n92DbI4Y9mw7f+/COatjAW59+RFedsHxMjav8tXY7vSQTvYB8\n X/TGq7Gm1Pf+eWqIp/RTjMyymy1UhlA2R9TEHa3SrYQ2M+kipBE6mS1FlV4R+tzZjaEUbv\n HkzV/uhCeuRBIsTEM5S7JVb3OqmiUp0=", "X-MC-Unique": "lW501HedOM2r642MboSMiA-1", "X-Mimecast-MFC-AGG-ID": "lW501HedOM2r642MboSMiA_1777496928", "From": "=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "Subject": "[PATCH 7/9] qom: add object_new_with_props_from_qdict", "Date": "Wed, 29 Apr 2026 22:08:28 +0100", "Message-ID": "<20260429210830.594724-8-berrange@redhat.com>", "In-Reply-To": "<20260429210830.594724-1-berrange@redhat.com>", "References": "<20260429210830.594724-1-berrange@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "12", "X-Spam_score": "1.2", "X-Spam_bar": "+", "X-Spam_report": "(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This will be used to replace user_creatable_add_type with an impl\nthat shares most code with object_new_with_props, and is not tied\nto the user creatable interface.\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>\n---\n include/qom/object.h | 19 +++++++++++\n qom/object.c | 75 ++++++++++++++++++++++++++++++++++++++++----\n 2 files changed, 88 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/qom/object.h b/include/qom/object.h\nindex 1b2b2702fc..cd59f1f171 100644\n--- a/include/qom/object.h\n+++ b/include/qom/object.h\n@@ -700,6 +700,25 @@ Object *object_new_with_propv(const char *typename,\n va_list vargs,\n Error **errp);\n \n+/**\n+ * object_new_with_props_from_qdict:\n+ * @typename: The name of the type of the object to instantiate.\n+ * @parent: the parent object\n+ * @id: The unique ID of the object\n+ * @props: dictionary of property names and values\n+ * @v: visitor to iterate over @props\n+ * @errp: pointer to error object\n+ *\n+ * A variant of object_new_with_props() which accepts the\n+ * properties in a QDict.\n+ */\n+Object *object_new_with_props_from_qdict(const char *typename,\n+ Object *parent,\n+ const char *id,\n+ QDict *props,\n+ Visitor *v,\n+ Error **errp);\n+\n /**\n * object_set_props:\n * @obj: the object instance to set properties on\ndiff --git a/qom/object.c b/qom/object.c\nindex c44e2b2eff..b35a3dff06 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -758,11 +758,14 @@ Object *object_new_with_props(const char *typename,\n }\n \n \n-Object *object_new_with_propv(const char *typename,\n- Object *parent,\n- const char *id,\n- va_list vargs,\n- Error **errp)\n+static Object *\n+object_new_with_props_helper(const char *typename,\n+ Object *parent,\n+ const char *id,\n+ void *props,\n+ bool (set_props)(Object *obj, void *props,\n+ Error **errp),\n+ Error **errp)\n {\n Object *obj;\n ObjectClass *klass;\n@@ -787,7 +790,7 @@ Object *object_new_with_propv(const char *typename,\n }\n obj = object_new_with_type(klass->type);\n \n- if (!object_set_propv(obj, vargs, errp)) {\n+ if (!set_props(obj, props, errp)) {\n goto error;\n }\n \n@@ -813,6 +816,66 @@ Object *object_new_with_propv(const char *typename,\n return NULL;\n }\n \n+struct ObjectNewVargsData {\n+ va_list vargs;\n+};\n+\n+static bool object_new_with_propv_setter(Object *obj,\n+ void *props,\n+ Error **errp)\n+{\n+ struct ObjectNewVargsData *data = props;\n+ return object_set_propv(obj, data->vargs, errp);\n+}\n+\n+Object *object_new_with_propv(const char *typename,\n+ Object *parent,\n+ const char *id,\n+ va_list vargs,\n+ Error **errp)\n+{\n+ Object *obj;\n+ struct ObjectNewVargsData data;\n+\n+ va_copy(data.vargs, vargs);\n+ obj = object_new_with_props_helper(typename,\n+ parent,\n+ id,\n+ &data,\n+ object_new_with_propv_setter,\n+ errp);\n+ va_end(data.vargs);\n+ return obj;\n+}\n+\n+struct ObjectNewQDictData {\n+ QDict *props;\n+ Visitor *v;\n+};\n+\n+static bool object_new_with_qdict_setter(Object *obj,\n+ void *props,\n+ Error **errp)\n+{\n+ struct ObjectNewQDictData *data = props;\n+ return object_set_props_from_qdict(obj, data->props, data->v, errp);\n+}\n+\n+Object *object_new_with_props_from_qdict(const char *typename,\n+ Object *parent,\n+ const char *id,\n+ QDict *props,\n+ Visitor *v,\n+ Error **errp)\n+{\n+ struct ObjectNewQDictData data = { props, v };\n+ return object_new_with_props_helper(typename,\n+ parent,\n+ id,\n+ &data,\n+ object_new_with_qdict_setter,\n+ errp);\n+}\n \n bool object_set_props(Object *obj,\n Error **errp,\n", "prefixes": [ "7/9" ] }