Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230550/?format=api
{ "id": 2230550, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230550/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-15-be96757428d0@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260430-qemu-vnc-v3-15-be96757428d0@redhat.com>", "date": "2026-04-29T21:02:48", "name": "[v3,15/26] ui/vnc: vnc_display_init() and vnc_display_open() return bool", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fa6e2ac3f4d4bd368c25058c011583df2319fe97", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-15-be96757428d0@redhat.com/mbox/", "series": [ { "id": 502150, "url": "http://patchwork.ozlabs.org/api/1.1/series/502150/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502150", "date": "2026-04-29T21:02:34", "name": "ui: add standalone VNC server over D-Bus", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/502150/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230550/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230550/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=b8WAZlFs;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VGP4SrFz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 07:06:21 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIC6f-0007Zo-Ak; Wed, 29 Apr 2026 17:06:05 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wIC5R-0006Jo-5R\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:04:57 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wIC5P-0003UQ-Gh\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:04:48 -0400", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-RWvMftFHO42LrwLjx79PZw-1; Wed,\n 29 Apr 2026 17:04:44 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 1A1331956050; Wed, 29 Apr 2026 21:04:42 +0000 (UTC)", "from localhost (unknown [10.44.22.2])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id BCB27195608E; Wed, 29 Apr 2026 21:04:40 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496685;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9xsmB+cqBRqaS9skMbjA7XRg5bZVpVFUgMg50GnuroM=;\n b=b8WAZlFscC06ruO5zPzyWVhWGI9JqXbWQLET9KDEFXkBM6b6ZuTW/ULXrpqAISLxITSFR+\n Jq+w6gr8vEgGrVlVaiN5xjZ3KzUOmTkYEm8A3sDE9u09FmYerVXSDYdukTunbXVJyHrxCb\n Aoer9zAPI28tG/7TIFTmKxJCbQz6cD4=", "X-MC-Unique": "RWvMftFHO42LrwLjx79PZw-1", "X-Mimecast-MFC-AGG-ID": "RWvMftFHO42LrwLjx79PZw_1777496682", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Thu, 30 Apr 2026 01:02:48 +0400", "Subject": "[PATCH v3 15/26] ui/vnc: vnc_display_init() and vnc_display_open()\n return bool", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260430-qemu-vnc-v3-15-be96757428d0@redhat.com>", "References": "<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>", "In-Reply-To": "<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3384;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=1BdF+ZE2ZaZ7NQ/12KK1Q24noSi6tIoILVGECxV0ikY=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp8nIMKXhnRdo6HWaNS9G8J/dKMbJdtptmf9uYN\n 0VTyhqYG06JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafJyDAAKCRDa6OEJdZac\n 5XpdEACyKd4WFtudHsU368hBdh6Ab0Ojh6moGqf+tdEGlLib0ez3H7Z5t0WQVqSwmszgUkeQ0wu\n oLqUGbdkB+4oixkVw1r6PrlsNtGxdZnBrycrF2jmcB6DGpe2WtpeGLkpSe1c5L+vunpu5lTryRU\n hjHB4QH+iP3xJ9FpN1MxNdXVaRSB1a+6cRlpf66Gm9OhRATmru5WkxXmzGjd1/krqBFT8NoDnn0\n OY7s1H52kLK2ChMcKCotM1JMg+CO0SpmsS9US1vBBfzUgxAoE+Yuo8N6AYoPSTKdAaZUFAt8PT7\n VD59+9HKrYd3acB0Zrib3oZbQHZx9KOHUctWK9qFuDj5chIS0nIIcA8sl53Q8rmbivzW4iUWKAM\n xqwWVMJq1zopsif4YkET/LyzoC/5wOE1DNmAASSEHasYHUrbqy6gAXHFQah1n8P1smPPAhKNnF+\n FYi2xyMnZYOey0CRv/WSLYonoA8Z1LpPHP34BUWaGDe6nzFZs8Ad5nHeWqN3qSTgi7fW2r+9BIL\n /GRPqoX7+g/Y6q94mD9ZL1oJsfxMY9xKemDvVbA+csBO0bL7mJ2XIljdb/PUKVd5IRj3CJHS/Gk\n hWatWV0o51PFfINn1dQVI/iD/h5rj89JdxTrvZ5FLbMEEwlu5N7rVK+Q4xeJ0rxrtojAqyZ1eCn\n iIxaNRoOdmyN1Gw==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "12", "X-Spam_score": "1.2", "X-Spam_bar": "+", "X-Spam_report": "(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Use the QEMU-style error pattern returning \"true\" on success.\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n include/ui/console.h | 4 ++--\n ui/vnc.c | 20 ++++++++++----------\n 2 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/include/ui/console.h b/include/ui/console.h\nindex 2bf768ed482..7224b8142f3 100644\n--- a/include/ui/console.h\n+++ b/include/ui/console.h\n@@ -438,8 +438,8 @@ const char *qemu_display_get_vc(DisplayOptions *opts);\n void qemu_display_help(void);\n \n /* vnc.c */\n-void vnc_display_init(const char *id, Error **errp);\n-void vnc_display_open(const char *id, Error **errp);\n+bool vnc_display_init(const char *id, Error **errp);\n+bool vnc_display_open(const char *id, Error **errp);\n void vnc_display_add_client(const char *id, int csock, bool skipauth);\n int vnc_display_password(const char *id, const char *password, Error **errp);\n int vnc_display_pw_expire(const char *id, time_t expires);\ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex 3a908670ab9..067f534cf08 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -3425,12 +3425,12 @@ static void vmstate_change_handler(void *opaque, bool running, RunState state)\n \n static void vnc_display_free(VncDisplay *vd);\n \n-void vnc_display_init(const char *id, Error **errp)\n+bool vnc_display_init(const char *id, Error **errp)\n {\n VncDisplay *vd;\n \n if (vnc_display_find(id) != NULL) {\n- return;\n+ return true;\n }\n vd = g_malloc0(sizeof(*vd));\n \n@@ -3451,7 +3451,7 @@ void vnc_display_init(const char *id, Error **errp)\n \n if (!vd->kbd_layout) {\n vnc_display_free(vd);\n- return;\n+ return false;\n }\n \n vd->share_policy = VNC_SHARE_POLICY_ALLOW_EXCLUSIVE;\n@@ -3465,6 +3465,7 @@ void vnc_display_init(const char *id, Error **errp)\n &vmstate_change_handler, vd);\n \n QTAILQ_INSERT_TAIL(&vnc_displays, vd, next);\n+ return true;\n }\n \n static void vnc_display_close(VncDisplay *vd)\n@@ -4070,7 +4071,7 @@ bool vnc_display_update(DisplayUpdateOptionsVNC *arg, Error **errp)\n return true;\n }\n \n-void vnc_display_open(const char *id, Error **errp)\n+bool vnc_display_open(const char *id, Error **errp)\n {\n VncDisplay *vd = vnc_display_find(id);\n QemuOpts *opts = qemu_opts_find(&qemu_vnc_opts, id);\n@@ -4273,7 +4274,7 @@ void vnc_display_open(const char *id, Error **errp)\n qkbd_state_set_delay(vd->kbd, key_delay_ms);\n \n if (saddr_list == NULL) {\n- return;\n+ return true;\n }\n \n if (reverse) {\n@@ -4291,10 +4292,11 @@ void vnc_display_open(const char *id, Error **errp)\n }\n \n /* Success */\n- return;\n+ return true;\n \n fail:\n vnc_display_close(vd);\n+ return false;\n }\n \n void vnc_display_add_client(const char *id, int csock, bool skipauth)\n@@ -4350,12 +4352,10 @@ int vnc_init_func(void *opaque, QemuOpts *opts, Error **errp)\n id = vnc_auto_assign_id(opts);\n }\n \n- vnc_display_init(id, errp);\n- if (*errp) {\n+ if (!vnc_display_init(id, errp)) {\n return -1;\n }\n- vnc_display_open(id, errp);\n- if (*errp) {\n+ if (!vnc_display_open(id, errp)) {\n return -1;\n }\n return 0;\n", "prefixes": [ "v3", "15/26" ] }