Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230546/?format=api
{ "id": 2230546, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230546/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-4-be96757428d0@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260430-qemu-vnc-v3-4-be96757428d0@redhat.com>", "date": "2026-04-29T21:02:37", "name": "[v3,04/26] ui/console: default vc encoding to cp437 for machine < 11.1", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ef0da7b46c49de0624a4998577d9588306d57db7", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-4-be96757428d0@redhat.com/mbox/", "series": [ { "id": 502150, "url": "http://patchwork.ozlabs.org/api/1.1/series/502150/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502150", "date": "2026-04-29T21:02:34", "name": "ui: add standalone VNC server over D-Bus", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/502150/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230546/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230546/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=UVy3Y1Ra;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VFn2fppz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 07:05:49 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIC4P-0003WM-4N; Wed, 29 Apr 2026 17:03:45 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wIC4M-0003Vd-Rq\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:03:43 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wIC4K-0003EY-RH\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:03:42 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-hqAMBod7PvOZbYgooL0sVA-1; Wed,\n 29 Apr 2026 17:03:38 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5BDEB1800366\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 21:03:37 +0000 (UTC)", "from localhost (unknown [10.44.22.2])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EE350300019F; Wed, 29 Apr 2026 21:03:35 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496619;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=lOr5ZL7bHRKd8fAlE/hxuW/GBXSIWog+NxkF9A50Knk=;\n b=UVy3Y1RaMun9rFKNOJtjJF3xVtkDJDPewdD/pkusjP1ju/RTGC2jU1o3bLQZ5X58MBX9vL\n 3DseK6z8EskjZTG/52p43dbGtlQ3r6i+LoqHP2ywEjxNDpa96PaA87bJXeeoEarhfL2xL0\n lsKQ2rBYEpK8I5cGU0/UedA7kXyLyUU=", "X-MC-Unique": "hqAMBod7PvOZbYgooL0sVA-1", "X-Mimecast-MFC-AGG-ID": "hqAMBod7PvOZbYgooL0sVA_1777496617", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Thu, 30 Apr 2026 01:02:37 +0400", "Subject": "[PATCH v3 04/26] ui/console: default vc encoding to cp437 for\n machine < 11.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260430-qemu-vnc-v3-4-be96757428d0@redhat.com>", "References": "<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>", "In-Reply-To": "<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=6927;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=QReFTyG+sKmftwnoD428OyLIJhjEp+YtsXRj2SNT6aw=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp8nILC+QFxP9v1wHNLcMQja/O3xPIpBQaBTdem\n EZpDR/J9pOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafJyCwAKCRDa6OEJdZac\n 5UFuEACfiBbvgfObJ3KBPIt1rBrK39CxH/hyLv5FBojhBh/GXLSuI+y3ktRMqm0YBS26wVv6b+F\n cF6juhUNXgKK5h4GL8yES/kmpFOi8nO0mqp+23KaEQzdrcM6KEGKcw6kf0Pc8ZGF/ARN9EgJJBb\n DlAFq5Hbw8NC8hcOCGG5jN0oJ/WlL7Gmc2tsdFJoLAeZrbfO851UNgSg2EcwN3UGVDRrzvuFK6N\n PEgLNT1RYUaO68RtfE0Du7sxB4pdbl9/iD+1b+cJ1rFUG4ydDWc1zxLCLZnEyK8rAS5cpqmE3qJ\n v3YrR5d0+7pedPIfCN3Cf5JhpROFk0JyF/S+3ydFHISyGqSfQrnS9n51tOJxb+ti7EO+Xrn0jWZ\n x/+7GxPXI1D6kdJ6IUsqzSzsX62VlkZdAXTKzbKhkXb717irEuvFtrE6gOKhIN+6FUY+Ifn6aiw\n 9PTxOkUSsAc5UzBEF1yFg6pDiz77nVK79q+gOV62Q54NUqKJAWKKCRJPj+HUwBTY38W6sFtJB9v\n QaJaje3vHUpqi6J50FdWfNLRtP3S/7OUUMosqWcb/pQxZA0hJobgS8EtvUUVdiuwvm/rVo8iyzH\n wqVdPbJodScds9lpklgUAN6PT3LV53EUtEC1eGns9RLfivpFtOrjfC7kx4+/d3aCVSAL54ByJAa\n DrhZ4O+JEVMOgGA==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add a QOM \"encoding\" enum property to some chardev-vc backends\n(console-vc & dbus - gtk and spice don't make use of it) so that the\nmachine compat mechanism can override the default. For machine versions\nprior to 11.1, the charset defaults to cp437 (raw 8-bit VGA) instead of\nutf8, preserving the historical behaviour.\n\nThe following commits are going to wire this to VT100 emulation code and\nan extra exported D-Bus property.\n\nNote that GTK libvte uses utf8 unconditionally, and Spice doesn't have a\nway to set the encoding, and typically just use libvte in client too.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n include/chardev/char.h | 19 +++++++++++++++++++\n hw/core/machine.c | 4 +++-\n ui/console-vc.c | 18 ++++++++++++++++++\n ui/dbus.c | 40 ++++++++++++++++++++++++++++++++++++++++\n 4 files changed, 80 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/chardev/char.h b/include/chardev/char.h\nindex f05e8dba0a9..7377d8e60a0 100644\n--- a/include/chardev/char.h\n+++ b/include/chardev/char.h\n@@ -332,4 +332,23 @@ void resume_mux_open(void);\n char *qemu_chr_get_pty_name(Chardev *chr);\n char *qemu_chr_get_filename(Chardev *chr);\n \n+#define CHARDEV_VC_ENCODING_PROPERTY_DEFINE(cast_func) \\\n+static int get_encoding(Object *obj, Error **errp) \\\n+{ \\\n+ return cast_func(obj)->encoding; \\\n+} \\\n+ \\\n+static void set_encoding(Object *obj, int value, Error **errp) \\\n+{ \\\n+ cast_func(obj)->encoding = value; \\\n+}\n+\n+static inline void chardev_vc_add_encoding_prop(ObjectClass *oc,\n+ int (*get)(Object *, Error **),\n+ void (*set)(Object *, int, Error **))\n+{\n+ object_class_property_add_enum(oc, \"encoding\", \"ChardevVCEncoding\",\n+ &ChardevVCEncoding_lookup, get, set);\n+}\n+\n #endif\ndiff --git a/hw/core/machine.c b/hw/core/machine.c\nindex 1b661fd36ae..63baff859f3 100644\n--- a/hw/core/machine.c\n+++ b/hw/core/machine.c\n@@ -39,7 +39,9 @@\n #include \"hw/acpi/generic_event_device.h\"\n #include \"qemu/audio.h\"\n \n-GlobalProperty hw_compat_11_0[] = {};\n+GlobalProperty hw_compat_11_0[] = {\n+ { \"chardev-vc\", \"encoding\", \"cp437\" },\n+};\n const size_t hw_compat_11_0_len = G_N_ELEMENTS(hw_compat_11_0);\n \n GlobalProperty hw_compat_10_2[] = {\ndiff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 7bb6a483753..fd7e6fb7b06 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -9,6 +9,7 @@\n #include \"qemu/fifo8.h\"\n #include \"qemu/option.h\"\n #include \"qemu/queue.h\"\n+#include \"qom/compat-properties.h\"\n #include \"ui/console.h\"\n #include \"ui/vgafont.h\"\n \n@@ -109,6 +110,7 @@ struct VCChardev {\n TextAttributes t_attrib; /* currently active text attributes */\n TextAttributes t_attrib_saved;\n int x_saved, y_saved;\n+ ChardevVCEncoding encoding;\n };\n typedef struct VCChardev VCChardev;\n \n@@ -1189,6 +1191,9 @@ static bool vc_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n \n s->chr = chr;\n drv->console = s;\n+ if (vc->has_encoding) {\n+ drv->encoding = vc->encoding;\n+ }\n \n /* set current text attributes to default */\n drv->t_attrib = TEXT_ATTRIBUTES_DEFAULT;\n@@ -1253,6 +1258,8 @@ static void vc_chr_parse(QemuOpts *opts, ChardevBackend *backend, Error **errp)\n }\n }\n \n+CHARDEV_VC_ENCODING_PROPERTY_DEFINE(VC_CHARDEV)\n+\n static void char_vc_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n@@ -1264,12 +1271,23 @@ static void char_vc_class_init(ObjectClass *oc, const void *data)\n cc->chr_set_echo = vc_chr_set_echo;\n cc->supports_size_opts = true;\n cc->supports_encoding_opts = true;\n+\n+ chardev_vc_add_encoding_prop(oc, get_encoding, set_encoding);\n+}\n+\n+static void char_vc_init(Object *obj)\n+{\n+ VCChardev *vc = VC_CHARDEV(obj);\n+\n+ vc->encoding = CHARDEV_VC_ENCODING_UTF8;\n }\n \n static const TypeInfo char_vc_type_info = {\n .name = TYPE_CHARDEV_VC,\n .parent = TYPE_CHARDEV,\n .instance_size = sizeof(VCChardev),\n+ .instance_init = char_vc_init,\n+ .instance_post_init = object_apply_compat_props,\n .class_init = char_vc_class_init,\n };\n \ndiff --git a/ui/dbus.c b/ui/dbus.c\nindex 721cc71d39b..59b73e0aa94 100644\n--- a/ui/dbus.c\n+++ b/ui/dbus.c\n@@ -28,6 +28,7 @@\n #include \"qemu/main-loop.h\"\n #include \"qemu/option.h\"\n #include \"qom/object_interfaces.h\"\n+#include \"qapi-types-char.h\"\n #include \"system/system.h\"\n #include \"ui/dbus-module.h\"\n #ifdef CONFIG_OPENGL\n@@ -455,12 +456,20 @@ dbus_display_class_init(ObjectClass *oc, const void *data)\n \n #define TYPE_CHARDEV_VC \"chardev-vc\"\n \n+typedef struct DBusVCChardev {\n+ DBusChardev parent;\n+\n+ ChardevVCEncoding encoding;\n+} DBusVCChardev;\n+\n typedef struct DBusVCClass {\n DBusChardevClass parent_class;\n \n void (*parent_parse)(QemuOpts *opts, ChardevBackend *b, Error **errp);\n } DBusVCClass;\n \n+DECLARE_INSTANCE_CHECKER(DBusVCChardev, DBUS_VC_CHARDEV,\n+ TYPE_CHARDEV_VC)\n DECLARE_CLASS_CHECKERS(DBusVCClass, DBUS_VC,\n TYPE_CHARDEV_VC)\n \n@@ -500,6 +509,23 @@ dbus_vc_parse(QemuOpts *opts, ChardevBackend *backend,\n }\n }\n \n+CHARDEV_VC_ENCODING_PROPERTY_DEFINE(DBUS_VC_CHARDEV)\n+\n+static bool\n+dbus_vc_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n+{\n+ DBusVCChardev *vc = DBUS_VC_CHARDEV(chr);\n+ ChardevClass *parent =\n+ CHARDEV_CLASS(object_class_by_name(TYPE_CHARDEV_DBUS));\n+ ChardevDBus *be = backend->u.dbus.data;\n+\n+ if (be->has_encoding) {\n+ vc->encoding = be->encoding;\n+ }\n+\n+ return parent->chr_open(chr, backend, errp);\n+}\n+\n static void\n dbus_vc_class_init(ObjectClass *oc, const void *data)\n {\n@@ -508,12 +534,26 @@ dbus_vc_class_init(ObjectClass *oc, const void *data)\n \n klass->parent_parse = cc->chr_parse;\n cc->chr_parse = dbus_vc_parse;\n+ cc->chr_open = dbus_vc_open;\n cc->supports_encoding_opts = true;\n+\n+ chardev_vc_add_encoding_prop(oc, get_encoding, set_encoding);\n+}\n+\n+static void\n+dbus_vc_init(Object *obj)\n+{\n+ DBusVCChardev *vc = DBUS_VC_CHARDEV(obj);\n+\n+ vc->encoding = CHARDEV_VC_ENCODING_UTF8;\n }\n \n static const TypeInfo dbus_vc_type_info = {\n .name = TYPE_CHARDEV_VC,\n .parent = TYPE_CHARDEV_DBUS,\n+ .instance_size = sizeof(DBusVCChardev),\n+ .instance_init = dbus_vc_init,\n+ .instance_post_init = object_apply_compat_props,\n .class_size = sizeof(DBusVCClass),\n .class_init = dbus_vc_class_init,\n };\n", "prefixes": [ "v3", "04/26" ] }