Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230517/?format=api
{ "id": 2230517, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230517/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429170519.2137725-2-joel@airwebreathe.org.uk/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260429170519.2137725-2-joel@airwebreathe.org.uk>", "date": "2026-04-29T17:03:58", "name": "[1/2] target/or1k: fix gen_mulu using signed multiply for unsigned operation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "29edcd7d8f35404c6ef578a372777a021813c74c", "submitter": { "id": 71296, "url": "http://patchwork.ozlabs.org/api/1.1/people/71296/?format=api", "name": "joel--- via qemu development", "email": "qemu-devel@nongnu.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429170519.2137725-2-joel@airwebreathe.org.uk/mbox/", "series": [ { "id": 502145, "url": "http://patchwork.ozlabs.org/api/1.1/series/502145/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502145", "date": "2026-04-29T17:03:58", "name": "target/or1k: fix arithmetic edge cases", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502145/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230517/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230517/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=airwebreathe.org.uk header.i=@airwebreathe.org.uk\n header.a=rsa-sha256 header.s=aaisp1 header.b=k2RnfBXC;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Stc3Cnkz1yHX\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 06:04:07 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIB89-0003dj-Ts; Wed, 29 Apr 2026 16:03:33 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <joel@airwebreathe.org.uk>)\n id 1wI8M7-0005I5-Nd\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 13:05:47 -0400", "from a-painless.mh.aa.net.uk ([2001:8b0:0:30::51])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <joel@airwebreathe.org.uk>)\n id 1wI8M5-00057n-UD\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 13:05:47 -0400", "from thunderhill.nvidia.com ([216.228.112.22]\n helo=jholdsworth-sail.nvidia.com)\n by painless-a.thn.aa.net.uk with esmtpsa (TLS1.3) tls\n TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2)\n (envelope-from <joel@airwebreathe.org.uk>)\n id 1wI8M3-00000003iOT-0qNL; Wed, 29 Apr 2026 18:05:43 +0100" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=airwebreathe.org.uk; s=aaisp1; h=Content-Transfer-Encoding:MIME-Version:\n References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:\n Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From:\n Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:\n List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n bh=hTTlPltB87Jiy4ggwrXJ/CgZ7x1nyauhJv2LXZKrUW0=; b=k2RnfBXCo9otN1fWJiJvc4EIQ8\n wLqMiI6hNhRMcs8HmFLgmLtzrWd1AIaQekvIei1imdRtjj45ho1QmpFNzmjWyhz4UMrFThpHm3zAP\n cCCyCWavW8XJ5hJNnDPqkkeSqwGnKuaJe7yXatw9cYg4xQTctRhwlDtRHy0wna7atBRrQuGZMgOeN\n xfXonDsv5yMSFLmM977hc4gnjKxGX3dm+pOaFJTJI9Ng42WUbUfLK88NfP34R+Npv171z2WlzCGbM\n 9Y397MQf/TE/PmY0KHn42UOIinWQTQYDdteKKoTFu6ZaYMI9VrtK3qYE5dl3b9epO2qJOlCIBvYF4\n ZAoaWMbw==;", "To": "qemu-devel@nongnu.org", "Cc": "Stafford Horne <shorne@gmail.com>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Joel Holdsworth <jholdsworth@nvidia.com>", "Subject": "[PATCH 1/2] target/or1k: fix gen_mulu using signed multiply for\n unsigned operation", "Date": "Wed, 29 Apr 2026 10:03:58 -0700", "Message-ID": "<20260429170519.2137725-2-joel@airwebreathe.org.uk>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20260429170519.2137725-1-joel@airwebreathe.org.uk>", "References": "<20260429170519.2137725-1-joel@airwebreathe.org.uk>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2001:8b0:0:30::51;\n envelope-from=joel@airwebreathe.org.uk; helo=a-painless.mh.aa.net.uk", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-Mailman-Approved-At": "Wed, 29 Apr 2026 16:03:01 -0400", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Reply-to": "joel@airwebreathe.org.uk", "From": "joel--- via qemu development <qemu-devel@nongnu.org>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Joel Holdsworth <jholdsworth@nvidia.com>\n\ngen_mulu() uses tcg_gen_muls2_i32 (signed widening multiply) but it\nimplements the l.mulu instruction which is an unsigned multiply. The\nlow 32-bit result is the same either way, but the high word written to\ncpu_sr_cy (used for carry/overflow detection) will be incorrect when\nthe sign bits of the operands differ.\n\nSwitch to tcg_gen_mulu2_i32 so the carry flag is computed correctly.\n\nSigned-off-by: Joel Holdsworth <jholdsworth@nvidia.com>\n---\n target/or1k/translate.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/target/or1k/translate.c b/target/or1k/translate.c\nindex eb4485312f..1602e204fe 100644\n--- a/target/or1k/translate.c\n+++ b/target/or1k/translate.c\n@@ -269,7 +269,7 @@ static void gen_mul(DisasContext *dc, TCGv_i32 dest,\n static void gen_mulu(DisasContext *dc, TCGv_i32 dest,\n TCGv_i32 srca, TCGv_i32 srcb)\n {\n- tcg_gen_muls2_i32(dest, cpu_sr_cy, srca, srcb);\n+ tcg_gen_mulu2_i32(dest, cpu_sr_cy, srca, srcb);\n tcg_gen_setcondi_i32(TCG_COND_NE, cpu_sr_cy, cpu_sr_cy, 0);\n \n gen_ove_cy(dc);\n", "prefixes": [ "1/2" ] }