Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230459/?format=api
{ "id": 2230459, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230459/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429183310.12455-3-harshpb@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260429183310.12455-3-harshpb@linux.ibm.com>", "date": "2026-04-29T18:32:52", "name": "[PULL,02/13] ppc/mpipl: Implement S0 SBE interrupt", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cf8775523ab5978c0fe1e40828f9fe44feac9dd3", "submitter": { "id": 85411, "url": "http://patchwork.ozlabs.org/api/1.1/people/85411/?format=api", "name": "Harsh Prateek Bora", "email": "harshpb@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429183310.12455-3-harshpb@linux.ibm.com/mbox/", "series": [ { "id": 502132, "url": "http://patchwork.ozlabs.org/api/1.1/series/502132/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502132", "date": "2026-04-29T18:32:53", "name": "[PULL,01/13] ppc/pnv: Move SBE host doorbell function to top of file", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502132/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230459/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230459/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=cqGGqUTu;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Qtl4S6gz1yKJ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 04:34:06 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wI9jD-0007ZJ-V0; Wed, 29 Apr 2026 14:33:43 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <harshpb@linux.ibm.com>)\n id 1wI9jC-0007Yy-4M\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 14:33:42 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <harshpb@linux.ibm.com>)\n id 1wI9jA-00076d-4g\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 14:33:41 -0400", "from pps.filterd (m0360072.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63TAAawi2648672\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 18:33:38 GMT", "from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drn8vjh5j-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 18:33:38 +0000 (GMT)", "from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63TINmlm004882\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 18:33:37 GMT", "from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ds9ehfgp1-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 18:33:37 +0000 (GMT)", "from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com\n [10.20.54.105])\n by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63TIXXMq50266486\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Wed, 29 Apr 2026 18:33:33 GMT", "from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id AA9A720049;\n Wed, 29 Apr 2026 18:33:33 +0000 (GMT)", "from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id C4EF32004E;\n Wed, 29 Apr 2026 18:33:31 +0000 (GMT)", "from localhost.localdomain (unknown [9.39.31.77])\n by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Wed, 29 Apr 2026 18:33:31 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=t6QdNpq2Lpdm5fmub\n W6/oX5deZfDgTJkb5AO4ubPE3k=; b=cqGGqUTuEgYjW4HaOhNPhMc1Tajr8gpfu\n cUFBCOIUa0Kq9xbLlQdRlFqVcwPl9efH0KL1dDnfWcXheMkYuui3Xk963HV3DLCz\n OBz2vrC1caLmIMA+jTqc605EconxrT8ImyWZqxkli8h8tMo7wiOimBAAEk1P0Ew5\n /6f8JvWdPN7pWz+RPEbGNj7nHvSjXpisaIr6tv2lmvwRKhlKY5sAQJ+x4A49Naqy\n lPDavQ7vLwMu226WDPasCD2poMOZWguMS0t9My/pSlpp0ndh9zieeFWjdWhdUM/4\n clwg8p3/Fkfw72nxnKWbODMVtbP/ktORU/+U0icVULYyq6M12yQyw==", "From": "Harsh Prateek Bora <harshpb@linux.ibm.com>", "To": "qemu-devel@nongnu.org", "Cc": "Aditya Gupta <adityag@linux.ibm.com>,\n Hari Bathini <hbathini@linux.ibm.com>,\n Sourabh Jain <sourabhjain@linux.ibm.com>,\n Shivang Upadhyay <shivangu@linux.ibm.com>", "Subject": "[PULL 02/13] ppc/mpipl: Implement S0 SBE interrupt", "Date": "Thu, 30 Apr 2026 00:02:52 +0530", "Message-ID": "<20260429183310.12455-3-harshpb@linux.ibm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260429183310.12455-1-harshpb@linux.ibm.com>", "References": "<20260429183310.12455-1-harshpb@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Authority-Analysis": "v=2.4 cv=CIIamxrD c=1 sm=1 tr=0 ts=69f24f02 cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=A5OVakUREuEA:10 a=f7IdgyKtn90A:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VwQbUJbxAAAA:8\n a=VnNF1IyMAAAA:8 a=0EWF82VJ2pR67mXLOX4A:9", "X-Proofpoint-ORIG-GUID": "oTeEaW6mz1fpJOrT2dd8bcEVgu7GqJDo", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDI5MDE4NCBTYWx0ZWRfX9wPxH8Db3943\n 0d0Glqs0rs6wcIW+7uUrwfX10ZvuimZwEyDS6pJkz5QSKygX0UEfaJNzGesmSnl6cHRNuIg3t8/\n Xr9EUoSydDrhIQMQks25XXcdRgcD+Hmm8f8iC2CVz1z6R1PABlzixoB0VO0SDBTBmTTef848Ez4\n HARdk0W4OVu6bPnu4DJzyZSATU9J1/12MSOE8MU0a7bl8CQ+LbioeYqVIH3frmhUXle7qvgxBek\n ZoXk055OanVFb6Hn7rfxqw6WL1BuxIzmjr/fkzrOa2BH1yDPskgtgIbp7esf6N27qVFJ27O4C0T\n rjugRzjjdolHvi8AtnquzdQA+S0xqyTo8M59SqJM76M1Srqqm1h89Cv+cEJjMKDlGh3PudbWl7+\n WMeTFAgISGkl24ab/rUMIYZqB8jeZJP6YNFmins0YYO4wb1kOjuFOnXK4KTmy5o3fQQO06BDk9S\n LMP04K4KyY5c0f8Ua7A==", "X-Proofpoint-GUID": "oTeEaW6mz1fpJOrT2dd8bcEVgu7GqJDo", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-29_01,2026-04-28_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n spamscore=0 phishscore=0 malwarescore=0 suspectscore=0 adultscore=0\n impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0\n priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604290184", "Received-SPF": "pass client-ip=148.163.158.5;\n envelope-from=harshpb@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Aditya Gupta <adityag@linux.ibm.com>\n\nDuring MPIPL (aka fadump), after a kernel crash, the kernel does\nopal_cec_reboot2 opal call, signifying an abnormal termination.\nWhen OPAL receives this opal call, it further triggers SBE S0 interrupt,\nto trigger a MPIPL boot.\n\nCurrently S0 interrupt is unimplemented in QEMU.\n\nImplement S0 interrupt as 'pause_vcpus' + 'guest_reset' in QEMU, as the\nSBE's implementation of S0 seems to be basically \"stop all clocks\" and\nthen \"host reset\".\n\npause_vcpus is done in a later patch when register preserving support is\nadded\n\nSee 'stopClocksS0' in SBE source code for more information.\n\nAlso log both S0 and S1 interrupts.\n\nReviewed-by: Hari Bathini <hbathini@linux.ibm.com>\nReviewed-by: Sourabh Jain <sourabhjain@linux.ibm.com>\nSigned-off-by: Aditya Gupta <adityag@linux.ibm.com>\nTested-by: Shivang Upadhyay <shivangu@linux.ibm.com>\nLink: https://lore.kernel.org/qemu-devel/20260424083837.214947-3-adityag@linux.ibm.com\nSigned-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>\n---\n include/hw/ppc/pnv.h | 5 +++++\n include/hw/ppc/pnv_mpipl.h | 19 +++++++++++++++++++\n hw/ppc/pnv_mpipl.c | 26 ++++++++++++++++++++++++++\n hw/ppc/pnv_sbe.c | 29 +++++++++++++++++++++++++++++\n hw/ppc/meson.build | 1 +\n 5 files changed, 80 insertions(+)\n create mode 100644 include/hw/ppc/pnv_mpipl.h\n create mode 100644 hw/ppc/pnv_mpipl.c", "diff": "diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h\nindex ce3ce73b53..19c7170e74 100644\n--- a/include/hw/ppc/pnv.h\n+++ b/include/hw/ppc/pnv.h\n@@ -25,6 +25,7 @@\n #include \"hw/core/sysbus.h\"\n #include \"hw/ipmi/ipmi.h\"\n #include \"hw/ppc/pnv_pnor.h\"\n+#include \"hw/ppc/pnv_mpipl.h\"\n \n #define TYPE_PNV_CHIP \"pnv-chip\"\n \n@@ -113,6 +114,7 @@ struct PnvMachineState {\n bool lpar_per_core;\n \n Notifier machine_init_done;\n+ MpiplPreservedState mpipl_state;\n };\n \n PnvChip *pnv_get_chip(PnvMachineState *pnv, uint32_t chip_id);\n@@ -292,4 +294,7 @@ void pnv_bmc_set_pnor(IPMIBmc *bmc, PnvPnor *pnor);\n \n #define PNV11_OCC_SENSOR_BASE(chip) PNV10_OCC_SENSOR_BASE(chip)\n \n+/* MPIPL helpers */\n+void do_mpipl_preserve(PnvMachineState *pnv);\n+\n #endif /* PPC_PNV_H */\ndiff --git a/include/hw/ppc/pnv_mpipl.h b/include/hw/ppc/pnv_mpipl.h\nnew file mode 100644\nindex 0000000000..61ef7ef8fe\n--- /dev/null\n+++ b/include/hw/ppc/pnv_mpipl.h\n@@ -0,0 +1,19 @@\n+/*\n+ * Emulation of MPIPL (Memory Preserving Initial Program Load), aka fadump\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#ifndef PNV_MPIPL_H\n+#define PNV_MPIPL_H\n+\n+#include <stdbool.h>\n+\n+typedef struct MpiplPreservedState MpiplPreservedState;\n+\n+/* Preserved state to be saved in PnvMachineState */\n+struct MpiplPreservedState {\n+ bool is_next_boot_mpipl;\n+};\n+\n+#endif\ndiff --git a/hw/ppc/pnv_mpipl.c b/hw/ppc/pnv_mpipl.c\nnew file mode 100644\nindex 0000000000..d8c9b7a428\n--- /dev/null\n+++ b/hw/ppc/pnv_mpipl.c\n@@ -0,0 +1,26 @@\n+/*\n+ * Emulation of MPIPL (Memory Preserving Initial Program Load), aka fadump\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"system/runstate.h\"\n+#include \"hw/ppc/pnv.h\"\n+#include \"hw/ppc/pnv_mpipl.h\"\n+\n+void do_mpipl_preserve(PnvMachineState *pnv)\n+{\n+ /* Mark next boot as Memory-preserving boot */\n+ pnv->mpipl_state.is_next_boot_mpipl = true;\n+\n+ /*\n+ * Do a guest reset.\n+ * Next reset will see 'is_next_boot_mpipl' as true, and trigger MPIPL\n+ *\n+ * Requirement:\n+ * GUEST_RESET is expected to NOT clear the memory, as is the case when\n+ * this is merged\n+ */\n+ qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET);\n+}\ndiff --git a/hw/ppc/pnv_sbe.c b/hw/ppc/pnv_sbe.c\nindex 247617338a..5a2b3342d1 100644\n--- a/hw/ppc/pnv_sbe.c\n+++ b/hw/ppc/pnv_sbe.c\n@@ -26,6 +26,9 @@\n #include \"hw/ppc/pnv.h\"\n #include \"hw/ppc/pnv_xscom.h\"\n #include \"hw/ppc/pnv_sbe.h\"\n+#include \"hw/ppc/pnv_mpipl.h\"\n+#include \"system/cpus.h\"\n+#include \"system/runstate.h\"\n #include \"trace.h\"\n \n /*\n@@ -113,11 +116,37 @@ static uint64_t pnv_sbe_power9_xscom_ctrl_read(void *opaque, hwaddr addr,\n static void pnv_sbe_power9_xscom_ctrl_write(void *opaque, hwaddr addr,\n uint64_t val, unsigned size)\n {\n+ PnvMachineState *pnv = PNV_MACHINE(qdev_get_machine());\n+ PnvSBE *sbe = opaque;\n uint32_t offset = addr >> 3;\n \n trace_pnv_sbe_xscom_ctrl_write(addr, val);\n \n switch (offset) {\n+ case SBE_CONTROL_REG_RW:\n+ switch (val) {\n+ case SBE_CONTROL_REG_S0:\n+ qemu_log_mask(LOG_UNIMP, \"SBE: S0 Interrupt triggered\\n\");\n+\n+ pnv_sbe_set_host_doorbell(sbe, sbe->host_doorbell | SBE_HOST_RESPONSE_MASK);\n+\n+ /* Preserve memory regions and CPU state, if MPIPL is registered */\n+ do_mpipl_preserve(pnv);\n+\n+ /*\n+ * Control may not come back here as 'do_mpipl_preserve' triggers\n+ * a guest reboot\n+ */\n+ break;\n+ case SBE_CONTROL_REG_S1:\n+ qemu_log_mask(LOG_UNIMP, \"SBE: S1 Interrupt triggered\\n\");\n+ break;\n+ default:\n+ qemu_log_mask(LOG_UNIMP,\n+ \"SBE: CONTROL_REG_RW: Unknown value: Ox%.\"\n+ HWADDR_PRIx \"\\n\", val);\n+ }\n+ break;\n default:\n qemu_log_mask(LOG_UNIMP, \"SBE Unimplemented register: Ox%\"\n HWADDR_PRIx \"\\n\", addr >> 3);\ndiff --git a/hw/ppc/meson.build b/hw/ppc/meson.build\nindex f7dac87a2a..c61fba4ec8 100644\n--- a/hw/ppc/meson.build\n+++ b/hw/ppc/meson.build\n@@ -56,6 +56,7 @@ ppc_ss.add(when: 'CONFIG_POWERNV', if_true: files(\n 'pnv_pnor.c',\n 'pnv_nest_pervasive.c',\n 'pnv_n1_chiplet.c',\n+ 'pnv_mpipl.c',\n ))\n # PowerPC 4xx boards\n ppc_ss.add(when: 'CONFIG_PPC405', if_true: files(\n", "prefixes": [ "PULL", "02/13" ] }