Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230415/?format=api
{ "id": 2230415, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230415/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260429180647.197072-2-thomas.falcon@intel.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/1.1/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260429180647.197072-2-thomas.falcon@intel.com>", "date": "2026-04-29T18:06:43", "name": "[RFC,1/4] pcie/aspm: Add debug logging for aspm policy config", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9bc0b5f6a7d6ef6161dc068b93266146e73587ed", "submitter": { "id": 93044, "url": "http://patchwork.ozlabs.org/api/1.1/people/93044/?format=api", "name": "Falcon, Thomas", "email": "thomas.falcon@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260429180647.197072-2-thomas.falcon@intel.com/mbox/", "series": [ { "id": 502124, "url": "http://patchwork.ozlabs.org/api/1.1/series/502124/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=502124", "date": "2026-04-29T18:06:44", "name": "pcie/aspm: Enable all advertised ASPM states by default", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502124/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230415/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230415/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-pci+bounces-53415-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=FcEfI34o;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-53415-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"FcEfI34o\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=192.198.163.15", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=intel.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5QJR36c2z1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 04:07:51 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id E8EA0300181B\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 18:07:01 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 83E60413241;\n\tWed, 29 Apr 2026 18:07:00 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.15])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9886C3CE495;\n\tWed, 29 Apr 2026 18:06:56 +0000 (UTC)", "from fmviesa003.fm.intel.com ([10.60.135.143])\n by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Apr 2026 11:06:55 -0700", "from iherna2-mobl4.amr.corp.intel.com (HELO tfalcon-desk.intel.com)\n ([10.124.221.251])\n by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Apr 2026 11:06:53 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777486020; cv=none;\n b=RDryy15t1fta6vq0+fs6JIL+h1DMDKHdkWUjQDnyDq5v1iMNgyCUU9Uec9dmwntzBf6IcoPQndFASpeUFdHzyMYjX/cHihrrBLqoS7t8hDWeKBTvIrmkm98laOrZ+MLrurc6bpx1O/UC8sOgW0AK/Oz/LqCzNr28eWuT/Dudeuk=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777486020; c=relaxed/simple;\n\tbh=R3M1Wd/Iys/ZSh84oAQZ8j5ob1LKTDhbBg/wAEZStYU=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=HPHNo3ad8wFB4wgzQdN1KZ/5j1cI05XqA0GF9sLgpPKQs/1tabnem2Iou/V51fum7WF/Fu0JlTXEsd+vCao2Tior8cZ3zXTdxpRw87SPdJeOosqR37vai3MmbQ4fuP7hws9scCj0NLGHpPj+ujS+MTEo83C3n7KxUmgNlsIqK98=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com;\n spf=pass smtp.mailfrom=intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=FcEfI34o; arc=none smtp.client-ip=192.198.163.15", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777486017; x=1809022017;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=R3M1Wd/Iys/ZSh84oAQZ8j5ob1LKTDhbBg/wAEZStYU=;\n b=FcEfI34oAewrquGu/atRxUKOTyxfPOY1evkliLbtErSH1nRLIN0y6u6V\n vBQkoTtt26TFRV51MXYI+M/IDjueodIjwrjF4I2yjkE1BMOjOkHq862Y8\n aJrlB1DVX8gtvlaHJvE6GPdes3ZWTX2LFVnDjMDIT9+evGSsjiuILfuH6\n owTUk+Imp9BJn73iOytzEYLCpx3GUFVnIESt46Ma08YpROkDW6IKk5lpG\n T/9VDlfbNPB9XU0OKrvKiPPI8T8R3yTcWOaPipNBHfRmkP+C9f6kEkoaF\n ja+NMiZ8eM0ggIzFrTqXKme1Vyyx6T4oLRwOS3fFwO9T/GeRnStomNe03\n g==;", "X-CSE-ConnectionGUID": [ "U+CjtDMNTsuQ7UXH47hLVQ==", "mR8rcttgQ56FZ9VCwOI0gw==" ], "X-CSE-MsgGUID": [ "3p4y/EbGQRuWuYmD/WglcA==", "ng0XwoOFRSCNLdXC0cwaMw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11771\"; a=\"78532274\"", "E=Sophos;i=\"6.23,206,1770624000\";\n d=\"scan'208\";a=\"78532274\"" ], "X-ExtLoop1": "1", "From": "Thomas Falcon <thomas.falcon@intel.com>", "To": "Bjorn Helgaas <bhelgaas@google.com>,\n\t\"Rafael J . Wysocki\" <rafael@kernel.org>", "Cc": "\"David E . Box\" <david.e.box@linux.intel.com>,\n\tLukas Wunner <lukas@wunner.de>,\n\tManivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,\n\tLen Brown <lenb@kernel.org>,\n\tlinux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tThomas Falcon <thomas.falcon@intel.com>", "Subject": "[RFC PATCH 1/4] pcie/aspm: Add debug logging for aspm policy config", "Date": "Wed, 29 Apr 2026 13:06:43 -0500", "Message-ID": "<20260429180647.197072-2-thomas.falcon@intel.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260429180647.197072-1-thomas.falcon@intel.com>", "References": "<20260429180647.197072-1-thomas.falcon@intel.com>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Include additional logging for ASPM and Clock PM state changes\nkeeping track of code flow and enabled power saving states.\n\nExample output after enabling powersupersave policy:\n\n[ 130.179249] pcieport 0000:80:1b.0: Updating ASPM state\n[ 130.179256] igc 0000:81:00.0: ASPM: Disabling ASPM on this device before disabling parent\n[ 130.179368] pcieport 0000:80:1b.0: ASPM: Disabling ASPM before applying configuration\n[ 130.179373] pcieport 0000:80:1b.0: ASPM: Configure L1 substates\n[ 130.179391] pcieport 0000:80:1b.0: ASPM: Configure ASPM state on upstream device\n[ 130.179395] igc 0000:81:00.0: ASPM: Configure ASPM state on downstream device\n[ 130.179401] pcieport 0000:80:1b.0: ASPM: enabled states: L1 ASPM-L1.1 PCI-PM-L1.1 PCI-PM-L1.2\n[ 130.179416] pcieport 0000:00:06.0: Updating ASPM state\n[ 130.179418] nvme 0000:01:00.0: ASPM: Disabling ASPM on this device before disabling parent\n[ 130.179422] pcieport 0000:00:06.0: ASPM: Disabling ASPM before applying configuration\n[ 130.179425] pcieport 0000:00:06.0: ASPM: Configure L1 substates\n[ 130.179435] pcieport 0000:00:06.0: ASPM: Configure ASPM state on upstream device\n[ 130.179438] nvme 0000:01:00.0: ASPM: Configure ASPM state on downstream device\n[ 130.179442] pcieport 0000:00:06.0: ASPM: enabled states: L1 ASPM-L1.1 ASPM-L1.2 PCI-PM-L1.1 PCI-PM-L1.2\n\nSuggested-by: David E. Box <david.e.box@linux.intel.com>\nSigned-off-by: Thomas Falcon <thomas.falcon@intel.com>\n---\n drivers/pci/pcie/aspm.c | 34 ++++++++++++++++++++++++++++++----\n 1 file changed, 30 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c\nindex 925373b98dff..cd23c1462502 100644\n--- a/drivers/pci/pcie/aspm.c\n+++ b/drivers/pci/pcie/aspm.c\n@@ -372,6 +372,9 @@ static void pcie_set_clkpm(struct pcie_link_state *link, int enable)\n \t/* Need nothing if the specified equals to current state */\n \tif (link->clkpm_enabled == enable)\n \t\treturn;\n+\n+\tpci_dbg(link->pdev, \"%s Clock PM\\n\",\n+\t\tenable ? \"Enabling\" : \"Disabling\");\n \tpcie_set_clkpm_nocheck(link, enable);\n }\n \n@@ -961,11 +964,14 @@ static void pcie_config_aspm_link(struct pcie_link_state *link, u32 state)\n \tstate &= (link->aspm_capable & ~link->aspm_disable);\n \n \t/* Can't enable any substates if L1 is not enabled */\n-\tif (!(state & PCIE_LINK_STATE_L1))\n+\tif (!(state & PCIE_LINK_STATE_L1)) {\n+\t\tpci_dbg(parent, \"ASPM: L1 not enabled, disabling L1 substates\\n\");\n \t\tstate &= ~PCIE_LINK_STATE_L1SS;\n+\t}\n \n \t/* Spec says both ports must be in D0 before enabling PCI PM substates*/\n \tif (parent->current_state != PCI_D0 || child->current_state != PCI_D0) {\n+\t\tpci_dbg(parent, \"ASPM: Both ports are not in D0, disable PCI PM L1 substates unless explicitly enabled\\n\");\n \t\tstate &= ~PCIE_LINK_STATE_L1_SS_PCIPM;\n \t\tstate |= (link->aspm_enabled & PCIE_LINK_STATE_L1_SS_PCIPM);\n \t}\n@@ -973,6 +979,8 @@ static void pcie_config_aspm_link(struct pcie_link_state *link, u32 state)\n \t/* Nothing to do if the link is already in the requested state */\n \tif (link->aspm_enabled == state)\n \t\treturn;\n+\tpci_dbg(parent, \"Updating ASPM state\\n\");\n+\n \t/* Convert ASPM state to upstream/downstream ASPM register state */\n \tif (state & PCIE_LINK_STATE_L0S_UP)\n \t\tdwstream |= PCI_EXP_LNKCTL_ASPM_L0S;\n@@ -997,16 +1005,34 @@ static void pcie_config_aspm_link(struct pcie_link_state *link, u32 state)\n \t * Sec 7.5.3.7 also recommends programming the same ASPM Control\n \t * value for all functions of a multi-function device.\n \t */\n-\tlist_for_each_entry(child, &linkbus->devices, bus_list)\n+\tlist_for_each_entry(child, &linkbus->devices, bus_list) {\n+\t\tpci_dbg(child, \"ASPM: Disabling ASPM on this device before disabling parent\\n\");\n \t\tpcie_config_aspm_dev(child, 0);\n+\t}\n+\tpci_dbg(parent, \"ASPM: Disabling ASPM before applying configuration\\n\");\n \tpcie_config_aspm_dev(parent, 0);\n \n-\tif (link->aspm_capable & PCIE_LINK_STATE_L1SS)\n+\tif (link->aspm_capable & PCIE_LINK_STATE_L1SS) {\n+\t\tpci_dbg(parent, \"ASPM: Configure L1 substates\\n\");\n \t\tpcie_config_aspm_l1ss(link, state);\n+\t}\n \n+\tpci_dbg(parent, \"ASPM: Configure ASPM state on upstream device\\n\");\n \tpcie_config_aspm_dev(parent, upstream);\n-\tlist_for_each_entry(child, &linkbus->devices, bus_list)\n+\tlist_for_each_entry(child, &linkbus->devices, bus_list) {\n+\t\tpci_dbg(child, \"ASPM: Configure ASPM state on downstream device\\n\");\n \t\tpcie_config_aspm_dev(child, dwstream);\n+\t}\n+\n+\tpci_dbg(parent, \"ASPM: enabled states:%s%s%s%s%s%s%s%s\\n\",\n+\t\tFLAG(state, L0S_UP, \" L0s-Upstream\"),\n+\t\tFLAG(state, L0S_DW, \" L0s-Downstream\"),\n+\t\tFLAG(state, L1, \" L1\"),\n+\t\tFLAG(state, L1_1, \" ASPM-L1.1\"),\n+\t\tFLAG(state, L1_2, \" ASPM-L1.2\"),\n+\t\tFLAG(state, L1_1_PCIPM, \" PCI-PM-L1.1\"),\n+\t\tFLAG(state, L1_2_PCIPM, \" PCI-PM-L1.2\"),\n+\t\tFLAG(state, CLKPM, \" ClockPM\"));\n \n \tlink->aspm_enabled = state;\n \n", "prefixes": [ "RFC", "1/4" ] }