Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230413/?format=api
{ "id": 2230413, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230413/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260429-case-sensitivity-v12-1-8057123bebe0@oracle.com/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/1.1/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260429-case-sensitivity-v12-1-8057123bebe0@oracle.com>", "date": "2026-04-29T18:07:12", "name": "[v12,01/15] fs: Move file_kattr initialization to callers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8399402ad232bd593fad6e92814fdac3177491c6", "submitter": { "id": 86689, "url": "http://patchwork.ozlabs.org/api/1.1/people/86689/?format=api", "name": "Chuck Lever", "email": "cel@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260429-case-sensitivity-v12-1-8057123bebe0@oracle.com/mbox/", "series": [ { "id": 502123, "url": "http://patchwork.ozlabs.org/api/1.1/series/502123/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=502123", "date": "2026-04-29T18:07:11", "name": "Exposing case folding behavior", "version": 12, "mbox": "http://patchwork.ozlabs.org/series/502123/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230413/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230413/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-cifs+bounces-11281-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ZVCLwT2J;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11281-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ZVCLwT2J\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5QJN1pLYz1yK5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 04:07:48 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id B00443008C1A\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 18:07:44 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id AB06641B352;\n\tWed, 29 Apr 2026 18:07:32 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C0F692580CF;\n\tWed, 29 Apr 2026 18:07:31 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 9B172C2BCC4;\n\tWed, 29 Apr 2026 18:07:28 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777486051; cv=none;\n b=mGpsTN78PwUWLNPbdk8X1W6Lf/orf/zdcwZlFLkVsAFJF9wgKeHt5OTBNZjtnRlJ/3ZpDCt+Izy14NrKfcv2wTTUJnzrDxyqNXsgqY2hvoqpsdg+ZxOzyMN/mXLuhGQE1P53/sW5GEs5vtAnQACbLizzb58dNiOgw9sWUPN5mvY=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777486051; c=relaxed/simple;\n\tbh=93lkf1HBQv1pjT23tKqszLwADekuVqw95GHVpFk/qSc=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=CnBOkqFTvHxoZ3JRnqslDSUWqDwTRSTyv9tzFG8AGJTsWYi43iQ0FkycC6HTMUgONtHT4dxDB2+kBtD7wrY30tYja7+H2JnNIDvaGZyZM45NUVCpXYVuVzTZkVGk7z/wDnlpyVObNHLjCa5D39O929SglXkz8gMiRenI0RpAuH8=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ZVCLwT2J; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777486050;\n\tbh=93lkf1HBQv1pjT23tKqszLwADekuVqw95GHVpFk/qSc=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=ZVCLwT2JS/b0gPxpaEN0YF7KgbjQmm6wV0J7GhWwkX3QyqHH+yazRd5ZboSUIi6TQ\n\t QYlGpqAkGR01GGD6dALHeBq5MHxCsZoKoOfVR/bNQlym6azQxo3Bk6jFOMjhkz35MH\n\t a2xa4N+E+YBuhJf4xfQCIyHmvJcIULKBrh0jc8gpUmC0PsuPBFd+jpLS8srTvC1vvH\n\t QJzV9tNsu84CBMExp8q/PtDlItOmTiZXNkFoVmRcGTw0TmtqUKWxBr6OhbvBKqCgN6\n\t gXnRp7E5kuiNH2BL+OQKEPglxrC8fT59Ku+vXb5MLXiPXy+s7D0W8YJyTR4Ta3hC40\n\t TkLe/AMhNpR7A==", "From": "Chuck Lever <cel@kernel.org>", "Date": "Wed, 29 Apr 2026 14:07:12 -0400", "Subject": "[PATCH v12 01/15] fs: Move file_kattr initialization to callers", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260429-case-sensitivity-v12-1-8057123bebe0@oracle.com>", "References": "<20260429-case-sensitivity-v12-0-8057123bebe0@oracle.com>", "In-Reply-To": "<20260429-case-sensitivity-v12-0-8057123bebe0@oracle.com>", "To": "Al Viro <viro@zeniv.linux.org.uk>,\n Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>", "Cc": "linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,\n linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org,\n linux-nfs@vger.kernel.org, linux-api@vger.kernel.org,\n linux-f2fs-devel@lists.sourceforge.net, hirofumi@mail.parknet.co.jp,\n linkinjeon@kernel.org, sj1557.seo@samsung.com, yuezhang.mo@sony.com,\n almaz.alexandrovich@paragon-software.com, slava@dubeyko.com,\n glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu,\n adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org,\n pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com,\n trondmy@kernel.org, anna@kernel.org, jaegeuk@kernel.org, chao@kernel.org,\n hansg@kernel.org, senozhatsky@chromium.org,\n Chuck Lever <chuck.lever@oracle.com>, \"Darrick J. Wong\" <djwong@kernel.org>,\n Roland Mainz <roland.mainz@nrubsig.org>", "X-Mailer": "b4 0.16-dev", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3605;\n i=chuck.lever@oracle.com; h=from:subject:message-id;\n bh=AWgZwG1E8rlvIL3m0PCLX9DfISmeBrTqPl/lfHkVgk0=;\n b=owEBbQKS/ZANAwAKATNqszNvZn+XAcsmYgBp8kjc1Ic/Bfjq/5DuQKcvOvTcxTagFruQ7dnPT\n 244utptZ+mJAjMEAAEKAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCafJI3AAKCRAzarMzb2Z/\n l0TNEADA4ZdMdOORrNfp6K+Q8ADuGu2gwbt9TVtSUsw6Zpa7ZIXnDxtXKod40T2WLEWVm0vcbe6\n 9/2y/hwpHlHZNYFxI7Wa6ZVhzweVveTc4deOvYLqyFdSppZjdKCuL0HadG+6ARd+6fv1QA4aelx\n D4sRLICCK6n3QLYGA8ZYyZ/dxcP5Qhr/yVD9ChuT5tTDrsRrY10fylSIKKvALY6YnbhMqwd8MvD\n +WVByFNB/11d/aNIZY3ey4nW2DVBUYvVs/kTAiPhlBu/8DylnpCQUx5dgQnDjHwSEUcCjNpTr4L\n dIPLXyEGdVaESRGbQ2w30cR4ZDJv74xAFKlVmZzomL06gsAYbpDj8su5zAneVsqOsQoijffq50F\n Ihnqjv9/DpbpIs8BiwXIyKI8IyRj4/xHSls7iIIkpxurSCNYay7ZHS45vrDK/h+3vHl6hxpH8+K\n bKrnMdwxaShsCfLw1A4s/k4Ks14qWy4FrD8YTjYiSc+GQ2qYOgZaa04ZKyRAc5faq1YthA9s/LC\n IwqIEJmTt/w24dH2evlr6Hp9mufrnaUTLcBLFo0S3rmlo6HNhn/PGoQMMLXHbiC3P69NJRf8KOH\n gfMx2w6+tB0BifmDb/7hyfbRY+7FItTJWBPl9XouMYBoQhRf/RMe4Clfxi+cYjUE4kPdDzjo7Q5\n 8xZuhM6IGBLVIRw==", "X-Developer-Key": "i=chuck.lever@oracle.com; a=openpgp;\n fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97" }, "content": "From: Chuck Lever <chuck.lever@oracle.com>\n\nfileattr_fill_xflags() and fileattr_fill_flags() memset the\nentire file_kattr struct before populating select fields, so\ncallers cannot pre-set fields in fa->fsx_xflags without having\ntheir values clobbered. Darrick Wong noted that a function\nnamed \"fill_xflags\" touching more than xflags forces callers\nto know implementation details beyond its apparent scope.\n\nDrop the memset from both fill functions and initialize at the\nentry points instead: ioctl_setflags(), ioctl_fssetxattr(),\nthe file_setattr() syscall, and xfs_ioc_fsgetxattra() now\ndeclare fa with an aggregate initializer. ioctl_getflags(),\nioctl_fsgetxattr(), and the file_getattr() syscall already\naggregate-initialize fa to pass flags_valid/fsx_valid hints\ninto vfs_fileattr_get().\n\nSubsequent patches rely on this so that ->fileattr_get()\nhandlers can set case-sensitivity flags (FS_XFLAG_CASEFOLD,\nFS_XFLAG_CASENONPRESERVING) in fa->fsx_xflags before the fill\nfunctions run.\n\nSuggested-by: Darrick J. Wong <djwong@kernel.org>\nReviewed-by: Jan Kara <jack@suse.cz>\nReviewed-by: Darrick J. Wong <djwong@kernel.org>\nReviewed-by: Roland Mainz <roland.mainz@nrubsig.org>\nSigned-off-by: Chuck Lever <chuck.lever@oracle.com>\n---\n fs/file_attr.c | 12 ++++--------\n fs/xfs/xfs_ioctl.c | 2 +-\n 2 files changed, 5 insertions(+), 9 deletions(-)", "diff": "diff --git a/fs/file_attr.c b/fs/file_attr.c\nindex da983e105d70..f429da66a317 100644\n--- a/fs/file_attr.c\n+++ b/fs/file_attr.c\n@@ -15,12 +15,10 @@\n * @fa:\t\tfileattr pointer\n * @xflags:\tFS_XFLAG_* flags\n *\n- * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags). All\n- * other fields are zeroed.\n+ * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags).\n */\n void fileattr_fill_xflags(struct file_kattr *fa, u32 xflags)\n {\n-\tmemset(fa, 0, sizeof(*fa));\n \tfa->fsx_valid = true;\n \tfa->fsx_xflags = xflags;\n \tif (fa->fsx_xflags & FS_XFLAG_IMMUTABLE)\n@@ -48,11 +46,9 @@ EXPORT_SYMBOL(fileattr_fill_xflags);\n * @flags:\tFS_*_FL flags\n *\n * Set ->flags, ->flags_valid and ->fsx_xflags (translated flags).\n- * All other fields are zeroed.\n */\n void fileattr_fill_flags(struct file_kattr *fa, u32 flags)\n {\n-\tmemset(fa, 0, sizeof(*fa));\n \tfa->flags_valid = true;\n \tfa->flags = flags;\n \tif (fa->flags & FS_SYNC_FL)\n@@ -325,7 +321,7 @@ int ioctl_setflags(struct file *file, unsigned int __user *argp)\n {\n \tstruct mnt_idmap *idmap = file_mnt_idmap(file);\n \tstruct dentry *dentry = file->f_path.dentry;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tunsigned int flags;\n \tint err;\n \n@@ -357,7 +353,7 @@ int ioctl_fssetxattr(struct file *file, void __user *argp)\n {\n \tstruct mnt_idmap *idmap = file_mnt_idmap(file);\n \tstruct dentry *dentry = file->f_path.dentry;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tint err;\n \n \terr = copy_fsxattr_from_user(&fa, argp);\n@@ -431,7 +427,7 @@ SYSCALL_DEFINE5(file_setattr, int, dfd, const char __user *, filename,\n \tstruct path filepath __free(path_put) = {};\n \tunsigned int lookup_flags = 0;\n \tstruct file_attr fattr;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tint error;\n \n \tBUILD_BUG_ON(sizeof(struct file_attr) < FILE_ATTR_SIZE_VER0);\ndiff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c\nindex 46e234863644..ed9b4846c05f 100644\n--- a/fs/xfs/xfs_ioctl.c\n+++ b/fs/xfs/xfs_ioctl.c\n@@ -517,7 +517,7 @@ xfs_ioc_fsgetxattra(\n \txfs_inode_t\t\t*ip,\n \tvoid\t\t\t__user *arg)\n {\n-\tstruct file_kattr\tfa;\n+\tstruct file_kattr\tfa = {};\n \n \txfs_ilock(ip, XFS_ILOCK_SHARED);\n \txfs_fill_fsxattr(ip, XFS_ATTR_FORK, &fa);\n", "prefixes": [ "v12", "01/15" ] }