Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230354/?format=api
{ "id": 2230354, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230354/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260429155418.75429-1-heinrich.schuchardt@canonical.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.1/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260429155418.75429-1-heinrich.schuchardt@canonical.com>", "date": "2026-04-29T15:54:18", "name": "[1/1] fat: initialize ret in disk_rw()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7d17ef91221cdb479c616bb5b73ee532edba2d99", "submitter": { "id": 82181, "url": "http://patchwork.ozlabs.org/api/1.1/people/82181/?format=api", "name": "Heinrich Schuchardt", "email": "heinrich.schuchardt@canonical.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/1.1/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260429155418.75429-1-heinrich.schuchardt@canonical.com/mbox/", "series": [ { "id": 502102, "url": "http://patchwork.ozlabs.org/api/1.1/series/502102/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=502102", "date": "2026-04-29T15:54:18", "name": "[1/1] fat: initialize ret in disk_rw()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502102/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230354/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230354/checks/", "tags": {}, "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=sImViJkl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=canonical.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.b=\"sImViJkl\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=canonical.com", "phobos.denx.de; spf=pass\n smtp.mailfrom=heinrich.schuchardt@canonical.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5MLb5GVtz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 01:54:31 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8A397848B0;\n\tWed, 29 Apr 2026 17:54:27 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 688E7848B6; Wed, 29 Apr 2026 17:54:26 +0200 (CEST)", "from smtp-relay-internal-0.canonical.com\n (smtp-relay-internal-0.canonical.com [185.125.188.122])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 47D8F848A7\n for <u-boot@lists.denx.de>; Wed, 29 Apr 2026 17:54:24 +0200 (CEST)", "from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n [209.85.128.72])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id D83BD3F281\n for <u-boot@lists.denx.de>; Wed, 29 Apr 2026 15:54:23 +0000 (UTC)", "by mail-wm1-f72.google.com with SMTP id\n 5b1f17b1804b1-48919890a95so74799025e9.2\n for <u-boot@lists.denx.de>; Wed, 29 Apr 2026 08:54:23 -0700 (PDT)", "from workstation5 (ip-176-199-115-125.um44.pools.vodafone-ip.de.\n [176.199.115.125]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a81ed659dsm1353335e9.2.2026.04.29.08.54.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 08:54:22 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1777478063;\n bh=pQkw2u/ja27zXeOX3rf5QgUGqeDazdoiOC+616s5b+0=;\n h=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=sImViJklAlxnTkVxBsh02+qS9On7AV21LbDxeeeHxLz/7qLzEaixbMTUkimFfz+B8\n IecD1xZY/DDF22Z+H/BQLlpJlauHWNKQOfMl+PGZ1BqtVJqzTkcR4eoFwnFBQMoejj\n ULpckWCMFG8ox+Re2A2WSWYep5ThrLCE71u/kDQhzft3h5zlXbh4TuPcVDDllyjpJ/\n cyWCZtL7VPaoZqER05BPoL4llGvXiqRxTA+U4wMIbM1mRCBnDIfRsVMOtHDdmhqYbE\n hktjFZvehA7K9YxNzJRinDOrCkZbXyP0VTERRanuVCONzTgOmBHBCAwmJ6veaBDxEw\n 1rX2hMnmVNS8ogUG7V0pt2L4ShMnzfFPUGxwCbQSoPS20uWhSwGIR4Ki076PbbAPKw\n 6wghvq1foFzGvAr56+eA1ae0gX2cuvMqr3+IaK4bbF/CwRl6Tg06qTSsKGYYAtoF3u\n A0Gf+Y2M5OQjKXM+lt6J8LSur5B2edULadnexIsaoNa0yyMSq9uHMIMJZSPZdPquw7\n eF9YjqXVCz+hPu7V0LGfzjE+A7uFPjrQjlSrq4TWnc30bhf4076jdinQVoaX86QpdG\n 716+us2skOclyfWoMZ7lUrvG+zGjEzlf818e9U2bPERGhtaLWDTQmrjBQF8thd6Hy9\n XuMzdR+JQsV23tfsGFIYoGsg=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777478063; x=1778082863;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pQkw2u/ja27zXeOX3rf5QgUGqeDazdoiOC+616s5b+0=;\n b=CvNM16UHdcCUAeJ0182XzT8x79zq503mz3IL+WwpMedo4I1uqDK/KuHDAFDizCv3Vt\n W4nqWLnfS5sAhB60O/vSkWaL7MAqzEAlfsLwFOGQI8bwWmINuM/L+YF3Eg21vFMA19bJ\n IhUY+a+2f7L18Dk1cXr4rrOEhskUzeRF3azlL/4N7PjMS6xdkSVXmLuRrKQ9PZBLgX0c\n jRvXX87iobi597qpHKs7oVALV4MYtHI8PH1hMJiUVrTsCNq4j0X77JWoBNhBWOyIohBw\n XIWZDvPAeyWX4nOc6YFfJoQnKWx4IjUyzHxZTVMO1GNINxJxyya6NkYlVfokCNDMMCLR\n 6D8A==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ9y8QkOUmU8p35Anwhyzgpfmla21prkrFHaTo0IfkAVBTFXONrvlAlRPPeiuckhQlUQioT/hfk=@lists.denx.de", "X-Gm-Message-State": "AOJu0YwH6b0uhXm0sCNz1t+bN9Cpxt5923dvkLGB+dlIu3U678hnrFl1\n 3v05uX4aLBUniHLZUDxkMueXwg+T2i+KyU3xVpABGHROS5UtOu2gyBDXmF1R5+2lPrjbPM02yUV\n qKJG91VzCrTi9sMJ5ltjbpQcHgkVe+462ucCkuwqWKTTbphdruLuD0IGlqHx8WCISf1wXUIA=", "X-Gm-Gg": "AeBDieuEXKd94SMXj3Lbkx2wUCtrYcCPXd9ErLfzoyYSo0o37MSnWhnvi5koMLAsqRr\n 7aQH8DdWM9Ie4bA4V15G4SO5XuH6bnPaDKDgi5RIMprHBww8su844QK3l8HVEUacmCMj7HKorRa\n +JF9h44R937T+5lwQ+0bUh3RG+Mxg2bD9pPzDvGJw41Em3tu64mW/1I7fFe9phkkjGIlbHGhupS\n ZyEGPc9t/7r8PkOkUxF2gVJrWEqQVHNp7erq5oNqnwV2RSWGTGFrqZFVyCEnQXZRCfN8/AtzyPg\n zqtJEf/WIS0pckX8hne0G6scBq4eD9RRQRLp+rh7gdRuTHbPEgMi7oximeQkcSixqPLD+9zpqaW\n q+QQ1X6Z+bg07PutK6FqiWaf70zVoImYBN40U/CsMeF3lEWrgcPAwiUPo+YR460Kz4Ch4qOEweL\n /Px7GokQUp27aqcW6BH0HSOzev+M97WC7YsSSDJ8fe7cSNBZ576MkNkZr/soMj", "X-Received": [ "by 2002:a05:600c:859a:b0:48a:56de:d62a with SMTP id\n 5b1f17b1804b1-48a7b519560mr56694455e9.11.1777478063443;\n Wed, 29 Apr 2026 08:54:23 -0700 (PDT)", "by 2002:a05:600c:859a:b0:48a:56de:d62a with SMTP id\n 5b1f17b1804b1-48a7b519560mr56694075e9.11.1777478062950;\n Wed, 29 Apr 2026 08:54:22 -0700 (PDT)" ], "From": "Heinrich Schuchardt <heinrich.schuchardt@canonical.com>", "To": "Tom Rini <trini@konsulko.com>", "Cc": "Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,\n Daniel Palmer <daniel@thingy.jp>, u-boot@lists.denx.de,\n Heinrich Schuchardt <heinrich.schuchardt@canonical.com>", "Subject": "[PATCH 1/1] fat: initialize ret in disk_rw()", "Date": "Wed, 29 Apr 2026 17:54:18 +0200", "Message-ID": "<20260429155418.75429-1-heinrich.schuchardt@canonical.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "If fat_sect_size = 0 and nr_sect = 0, the value of ret is never intialized.\nA random return value is returned.\n\nInitialize ret to 0.\n\nAddresses-Coverity-ID: - 645495 Uninitialized scalar variable\nSigned-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>\n---\n fs/fat/fat.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/fs/fat/fat.c b/fs/fat/fat.c\nindex 31c136e3b9e..c1ccf30771a 100644\n--- a/fs/fat/fat.c\n+++ b/fs/fat/fat.c\n@@ -71,7 +71,7 @@ static inline __u32 sect_to_block(__u32 sect, __u32 *off)\n \n static int disk_rw(__u32 sect, __u32 nr_sect, void *buf, bool read)\n {\n-\tint ret;\n+\tint ret = 0;\n \t__u8 *block = NULL;\n \t__u32 rem, size, s, n;\n \tconst ulong blksz = cur_part_info.blksz;\n", "prefixes": [ "1/1" ] }