Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230353/?format=api
{ "id": 2230353, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230353/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260429154000.71351-1-heinrich.schuchardt@canonical.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.1/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260429154000.71351-1-heinrich.schuchardt@canonical.com>", "date": "2026-04-29T15:40:00", "name": "[1/1] efi_loader: initialize variables in efi_dp_from_http()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b5ecbd0eda0f1a9fbd67c621d43eb9817522ad3d", "submitter": { "id": 82181, "url": "http://patchwork.ozlabs.org/api/1.1/people/82181/?format=api", "name": "Heinrich Schuchardt", "email": "heinrich.schuchardt@canonical.com" }, "delegate": { "id": 68728, "url": "http://patchwork.ozlabs.org/api/1.1/users/68728/?format=api", "username": "xypron", "first_name": "Heinrich", "last_name": "Schuchardt", "email": "xypron.glpk@gmx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260429154000.71351-1-heinrich.schuchardt@canonical.com/mbox/", "series": [ { "id": 502101, "url": "http://patchwork.ozlabs.org/api/1.1/series/502101/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=502101", "date": "2026-04-29T15:40:00", "name": "[1/1] efi_loader: initialize variables in efi_dp_from_http()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502101/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230353/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230353/checks/", "tags": {}, "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=lKpS/VIm;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=canonical.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.b=\"lKpS/VIm\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=canonical.com", "phobos.denx.de; spf=pass\n smtp.mailfrom=heinrich.schuchardt@canonical.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5M276Whbz1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 01:40:15 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 90008848B0;\n\tWed, 29 Apr 2026 17:40:12 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id C9CB1848B4; Wed, 29 Apr 2026 17:40:09 +0200 (CEST)", "from smtp-relay-internal-0.canonical.com\n (smtp-relay-internal-0.canonical.com [185.125.188.122])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1E5FE84099\n for <u-boot@lists.denx.de>; Wed, 29 Apr 2026 17:40:07 +0200 (CEST)", "from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n [209.85.221.72])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id B97763F281\n for <u-boot@lists.denx.de>; Wed, 29 Apr 2026 15:40:06 +0000 (UTC)", "by mail-wr1-f72.google.com with SMTP id\n ffacd0b85a97d-4411a1f9601so8784558f8f.0\n for <u-boot@lists.denx.de>; Wed, 29 Apr 2026 08:40:06 -0700 (PDT)", "from workstation5 (ip-176-199-115-125.um44.pools.vodafone-ip.de.\n [176.199.115.125]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a7c2ddc65sm33251645e9.4.2026.04.29.08.40.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 08:40:05 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1777477206;\n bh=6y0TnCG3a6jzIozHHxpIsLSSenQueakTEGUrHEYNb1k=;\n h=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=lKpS/VImC3S2NwcbZqwPIF4QH6jKhf+JzPveBDSHPh19qNGqKLGnbWkr9vO8F5SM/\n d63UDkYhX0tj+AKso3G9jkPtXV0s7LRwW+BKMl3AvQwT0iYDYyP7GI7rf/2TCjhEEo\n djLU/d5SJyJkxxXNe9iF5BJ6lta7JLWGLRU9+5K8c6UXk2TvPBKWfM8Sj9rhDhFn3a\n 1DcNWlsOZjGv6/xNyyAcy0p715PQGbowTNUrTcc4upbgB5qw8Ew0Kg5NKmF790AoOf\n OTFrk2cWVIAgf0P9FcBJZRo39wxeOBrOhzbs3dQa5jPXrxim/bbCjrDCel2K333cMj\n CXEEZp4E7nkw3Lf41ZLAqpuaB7GiVEBC3BzwQ+BQQSen2qmdBIlW4OcMeMetAzwxua\n y5hR1vU1/orQ7W7fHmJbpTiwRd8hXP9zALK25cOdTTAAm9pFeckvgDiwEFQ4QqvTG2\n bMjDp7KoK3tAqcIdflo/ZnIQGiPQsaeangOl8FPrUio/HMJryqni6eURCFDHp0MqH+\n h+m0RkSDH2MoPl1xhkkWqd2VGLWcGpzi7TI9Lok6ZWHILeOmxwJTnP91LPaw5/G/aR\n pK6wSVjZEdP1Xw8iGP9mMWk9ifJiBPutzogS4veS0vJGbmWGyKeyW3EUBXWr/cezW2\n eE9RmQ80LM5JKObnfo2cyW6g=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777477206; x=1778082006;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6y0TnCG3a6jzIozHHxpIsLSSenQueakTEGUrHEYNb1k=;\n b=ErBuEpnpIE1CtDxbTRKRM/7EovTxrXa8KSBlJap7SYp71BR2RS/AKd2XOOxq61jcU5\n YY/rUVtFQZIdxittBA5h5Fm0zeHQ9NE/5lr4VbbY3v/eS4xrMlz1PTMb6QWH7i8enuEg\n nipaL4Ku3P0fhJoJ5iuvMMElBaMHhSGIS5BKbIpH0vkEnyw9TaVcXjVQHJLE860ReWFZ\n bkmRNQAT8xTh+G+z6SRiA9zeskuAmLPQCURfa4qih978Q+680QOL9vDXyzUQjBWn4MOR\n xzF4OKM1pBhASlT8mVEemmQ+fUVPPpumQNIppu0bBXCrrDNsyPkqotO1HsNsc4Ym/MHR\n A/Ng==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ8A26rhx8nwKp/A5Mzf5V0Iy+5Yx9oQfymIuIhe87SsRT/h+A+fYtUOT7b42+tg5QISyikYfrw=@lists.denx.de", "X-Gm-Message-State": "AOJu0YxI93BzR9n2ycrk4IKI5Q0HByveHhdh8Pwl21XIMTwkGa+aZ1jQ\n cHbE0hlHdfqlCVdC6ouMQU65kZEfChBFC48ANcHAn4e6+Rwsan15wntMKPvLl6i5m3FapqQgr5n\n PvBoLZ+wgCQjywe6A66AyP7CnmZs/YWEUYKyyTXc7vQToXAiCEfG1xnAYiwkiLu6+oOxAb54=", "X-Gm-Gg": "AeBDiev+uLOinymr4X0pQbHgGLedPqAfZtBUPAvwhdqrc5EZdfOBkpO/Sk0gWmM7alV\n ofAnAjq7lOM+GeVUj8hQEvzIA2cd4VInHsKO1NODN4fqadK7aQfJLCK1KIK8w2uyFBjtiOXQRTR\n h8B+5sxp39q1uiJGiiiLny8NKnDVR43p5gQFIQzjkrkvsZ8xQZ+Sy5Xhk2w5sTnE1RmeeAxPOeI\n GfpTPlbOn+Q32gBVc+3IGGizKwLELYqijczzUqVka4/DMbTGI3oaWWP6HxI7ttQaC7AV6HdATnF\n BssgMSJxt7w+vNRn6/lRBv1k7RjRQOoqfgjiuHwPj8IYuECorgR/cFeTD6zggh1o2JPxAuvuGTx\n W8VeEBqe6eWCUscji1h75S3FWdNdjojGcZVnMApJl+8aqsZY2pjE/hsvAntSboO6T0ySNFmcDqU\n zYWHYtDVAzz29xYDLMX/LV49UVTupshv7jBGO3CUT9B0Fn9VuSTrlqE24qSW5K", "X-Received": [ "by 2002:a05:600c:1e28:b0:48a:75b9:b0bc with SMTP id\n 5b1f17b1804b1-48a77b240c0mr127361015e9.29.1777477206182;\n Wed, 29 Apr 2026 08:40:06 -0700 (PDT)", "by 2002:a05:600c:1e28:b0:48a:75b9:b0bc with SMTP id\n 5b1f17b1804b1-48a77b240c0mr127360515e9.29.1777477205704;\n Wed, 29 Apr 2026 08:40:05 -0700 (PDT)" ], "From": "Heinrich Schuchardt <heinrich.schuchardt@canonical.com>", "To": "Ilias Apalodimas <ilias.apalodimas@linaro.org>", "Cc": "Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,\n u-boot@lists.denx.de,\n Heinrich Schuchardt <heinrich.schuchardt@canonical.com>", "Subject": "[PATCH 1/1] efi_loader: initialize variables in efi_dp_from_http()", "Date": "Wed, 29 Apr 2026 17:40:00 +0200", "Message-ID": "<20260429154000.71351-1-heinrich.schuchardt@canonical.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "When using lwIP, efi_dp_from_http() may fail to initialize ip or mask.\nInitialize the variables before the call.\n\nAddresses-Coverity-ID: 645840 - Uninitialized variables (UNINIT)\nSigned-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>\n---\n lib/efi_loader/efi_device_path.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/efi_loader/efi_device_path.c b/lib/efi_loader/efi_device_path.c\nindex b3fb20b2501..9efb158f5dd 100644\n--- a/lib/efi_loader/efi_device_path.c\n+++ b/lib/efi_loader/efi_device_path.c\n@@ -955,8 +955,8 @@ struct efi_device_path *efi_dp_from_http(const char *server, struct udevice *dev\n \tefi_uintn_t uridp_len;\n \tchar *pos;\n \tchar tmp[128];\n-\tstruct efi_ipv4_address ip;\n-\tstruct efi_ipv4_address mask;\n+\tstruct efi_ipv4_address ip = { .ip_addr = { 0, 0, 0, 0 } };\n+\tstruct efi_ipv4_address mask = { .ip_addr = { 0, 0, 0, 0 } };\n \n \tif ((server && strlen(\"http://\") + strlen(server) + 1 > sizeof(tmp)) ||\n \t (!server && IS_ENABLED(CONFIG_NET_LWIP)))\n", "prefixes": [ "1/1" ] }