Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230230/?format=api
{ "id": 2230230, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230230/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/cd5e9336e5cb1d84af6c7f8cacb7ef7ad38d9ed1.1777463800.git.metze@samba.org/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/1.1/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<cd5e9336e5cb1d84af6c7f8cacb7ef7ad38d9ed1.1777463800.git.metze@samba.org>", "date": "2026-04-29T13:43:36", "name": "[2/2] smb: smbdirect: introduce and use include/linux/smbdirect.h", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6c7344feb2a6d0661eea7cc8db6d1cc775f97365", "submitter": { "id": 8149, "url": "http://patchwork.ozlabs.org/api/1.1/people/8149/?format=api", "name": "Stefan Metzmacher", "email": "metze@samba.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/cd5e9336e5cb1d84af6c7f8cacb7ef7ad38d9ed1.1777463800.git.metze@samba.org/mbox/", "series": [ { "id": 502065, "url": "http://patchwork.ozlabs.org/api/1.1/series/502065/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=502065", "date": "2026-04-29T13:43:34", "name": "smb: smbdirect: symbol export and header cleanups", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502065/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230230/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230230/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-cifs+bounces-11277-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (3072-bit key;\n secure) header.d=samba.org header.i=@samba.org header.a=rsa-sha256\n header.s=42 header.b=o2zcOvof;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11277-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (3072-bit key) header.d=samba.org header.i=@samba.org\n header.b=\"o2zcOvof\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=144.76.82.148", "smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=samba.org", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=samba.org" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Jkr44mKz1yK5\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 23:56:52 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id DA57F30EC64A\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 13:46:05 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2D7392BDC32;\n\tWed, 29 Apr 2026 13:44:00 +0000 (UTC)", "from hr2.samba.org (hr2.samba.org [144.76.82.148])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FBD240243A\n\tfor <linux-cifs@vger.kernel.org>; Wed, 29 Apr 2026 13:43:57 +0000 (UTC)", "from [127.0.0.2] (localhost [127.0.0.1])\n\tby hr2.samba.org with esmtpsa\n (TLS1.3:ECDHE_SECP256R1__ECDSA_SECP256R1_SHA256__CHACHA20_POLY1305:256)\n\t(Exim)\n\tid 1wI5Cl-000000050Xp-2gJU;\n\tWed, 29 Apr 2026 13:43:55 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777470240; cv=none;\n b=hRda2EuaNWm6nVjFAKKB20XelO4Qi3upk+hH5phB5evZ7MQN6IrObPYqZy0VELFz1j8EXg7dD901w5bbhNLgU3m84C2nOnfRhningXjP9mEm6ZFsW2nf6+ZvxsXPWY4TKULFI1vZCZvE66aoDUq9Dec1yNKCEuv7qjUp93cOvw0=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777470240; c=relaxed/simple;\n\tbh=rKDokpU8Qj2ou8InpJka+EwAtkij8Rz31fc3I55hSUM=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=G9MMcYeqMBIHacb/bc+4V9ZhSUIRBnXknROWRKOZZGWP2znuHib2wN1XJ0qW8OcFuAsGTiDinKn1q/hg5wI+bQ/YpoqFyB3aYd6wonUkUUKMt11qZSAk6BloHf6AjN+YNbMhE+eWlmcCiZe8hSIgeAiHEGppWf1z6RJUXaV1tFs=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=samba.org;\n spf=pass smtp.mailfrom=samba.org;\n dkim=pass (3072-bit key) header.d=samba.org header.i=@samba.org\n header.b=o2zcOvof; arc=none smtp.client-ip=144.76.82.148", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=samba.org;\n\ts=42; h=Message-ID:Date:Cc:To:From;\n\tbh=396jvzsjfArsaFWVpdRukF7Y2hwffxEQjnpFNv9IpNQ=; b=o2zcOvofsqAVC4vbrM2fYaPMWF\n\tsvnQFZzsMLohjzacsfiaIcazyOlscvbIA6V2vVvYuKmyiDoj5ZkqH3BJopRrbz2QDLgZa0SOQ8O0c\n\tqBBaExhajx2B8jox6YG2duggvVjCxpTdc/7WchP4FiSQU1CPZ0QhKgsSNliiZk8bJLxK+eWdybKX3\n\t5L56lcXgMHL8sTXhvbk5wr22LFN2kYWESIIB7AKLMi0PdND9cZDqrRYaR8NfOfCdKK/moCjsdVrJy\n\tC9ueuWGyInV+DzAH+x6+RSpNhX8/kUBioVfUJydhs7I/1Lo+uJK7+y4Y0a8wgThGsiLfXXcGN9kBv\n\t7dNxEflum6RbbohQBCoklWGFp3WzVd3MPHLAoBeishbVruFTHZDWoN9KpjXIJy6XDPsa8lGyQWC7z\n\tEy+C50/14oWmhKtfMw/R65PkTWLWJ3H9Dx7kYB3QW1G6DAZ2TjOeFkBmi5iSJPLYb8RfvKvmgaDva\n\t1fuVCRFUZkCC29qGVghKv5FR;", "From": "Stefan Metzmacher <metze@samba.org>", "To": "linux-cifs@vger.kernel.org,\n\tsamba-technical@lists.samba.org", "Cc": "metze@samba.org,\n\tChristoph Hellwig <hch@infradead.org>,\n\tSteve French <smfrench@gmail.com>,\n\tTom Talpey <tom@talpey.com>,\n\tLong Li <longli@microsoft.com>,\n\tNamjae Jeon <linkinjeon@kernel.org>", "Subject": "[PATCH 2/2] smb: smbdirect: introduce and use\n include/linux/smbdirect.h", "Date": "Wed, 29 Apr 2026 15:43:36 +0200", "Message-ID": "\n <cd5e9336e5cb1d84af6c7f8cacb7ef7ad38d9ed1.1777463800.git.metze@samba.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<cover.1777463800.git.metze@samba.org>", "References": "<cover.1777463800.git.metze@samba.org>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "This makes it easier to rebuild cifs.ko and ksmbd.ko against\na running kernel.\n\nSuggested-by: Christoph Hellwig <hch@infradead.org>\nLink: https://lore.kernel.org/linux-cifs/aehrPuY60VMcYGU8@infradead.org/\nCc: Steve French <smfrench@gmail.com>\nCc: Tom Talpey <tom@talpey.com>\nCc: Long Li <longli@microsoft.com>\nCc: Namjae Jeon <linkinjeon@kernel.org>\nCc: Christoph Hellwig <hch@infradead.org>\nCc: linux-cifs@vger.kernel.org\nCc: samba-technical@lists.samba.org\nSigned-off-by: Stefan Metzmacher <metze@samba.org>\n---\n MAINTAINERS | 1 +\n fs/smb/client/smbdirect.c | 1 -\n fs/smb/client/smbdirect.h | 2 +-\n fs/smb/server/transport_rdma.c | 1 -\n fs/smb/server/transport_rdma.h | 2 +-\n fs/smb/smbdirect/internal.h | 3 +-\n fs/smb/smbdirect/smbdirect.h | 52 -------------------\n .../public.h => include/linux/smbdirect.h | 50 ++++++++++++++++--\n 8 files changed, 49 insertions(+), 63 deletions(-)\n delete mode 100644 fs/smb/smbdirect/smbdirect.h\n rename fs/smb/smbdirect/public.h => include/linux/smbdirect.h (76%)", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex 2fb1c75afd16..28bb50923d74 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -24616,6 +24616,7 @@ S:\tMaintained\n F:\tfs/smb/client/smbdirect.*\n F:\tfs/smb/smbdirect/\n F:\tfs/smb/server/transport_rdma.*\n+F:\tinclude/linux/smbdirect.h\n \n SMC91x ETHERNET DRIVER\n M:\tNicolas Pitre <nico@fluxnic.net>\ndiff --git a/fs/smb/client/smbdirect.c b/fs/smb/client/smbdirect.c\nindex b9826185de18..563ef488a225 100644\n--- a/fs/smb/client/smbdirect.c\n+++ b/fs/smb/client/smbdirect.c\n@@ -9,7 +9,6 @@\n #include \"cifs_debug.h\"\n #include \"cifsproto.h\"\n #include \"smb2proto.h\"\n-#include \"../smbdirect/public.h\"\n \n /* Port numbers for SMBD transport */\n #define SMB_PORT\t445\ndiff --git a/fs/smb/client/smbdirect.h b/fs/smb/client/smbdirect.h\nindex 287ac849213d..be205ec02077 100644\n--- a/fs/smb/client/smbdirect.h\n+++ b/fs/smb/client/smbdirect.h\n@@ -12,7 +12,7 @@\n \n #include \"cifsglob.h\"\n \n-#include \"../smbdirect/smbdirect.h\"\n+#include <linux/smbdirect.h>\n \n extern int rdma_readwrite_threshold;\n extern int smbd_max_frmr_depth;\ndiff --git a/fs/smb/server/transport_rdma.c b/fs/smb/server/transport_rdma.c\nindex 346c051e31f5..b6d63ff8a8a3 100644\n--- a/fs/smb/server/transport_rdma.c\n+++ b/fs/smb/server/transport_rdma.c\n@@ -18,7 +18,6 @@\n #include \"smb_common.h\"\n #include \"../common/smb2status.h\"\n #include \"transport_rdma.h\"\n-#include \"../smbdirect/public.h\"\n \n \n #define SMB_DIRECT_PORT_IWARP\t\t5445\ndiff --git a/fs/smb/server/transport_rdma.h b/fs/smb/server/transport_rdma.h\nindex bde3d88aecc7..8b78917a1795 100644\n--- a/fs/smb/server/transport_rdma.h\n+++ b/fs/smb/server/transport_rdma.h\n@@ -25,6 +25,6 @@ static inline void init_smbd_max_io_size(unsigned int sz) { }\n static inline unsigned int get_smbd_max_read_write_size(struct ksmbd_transport *kt) { return 0; }\n #endif\n \n-#include \"../smbdirect/smbdirect.h\"\n+#include <linux/smbdirect.h>\n \n #endif /* __KSMBD_TRANSPORT_RDMA_H__ */\ndiff --git a/fs/smb/smbdirect/internal.h b/fs/smb/smbdirect/internal.h\nindex 82529b41708b..e9959e6dc13a 100644\n--- a/fs/smb/smbdirect/internal.h\n+++ b/fs/smb/smbdirect/internal.h\n@@ -9,9 +9,8 @@\n #define DEFAULT_SYMBOL_NAMESPACE \"SMBDIRECT\"\n #define pr_fmt(fmt) KBUILD_MODNAME \": \" fmt\n \n-#include \"smbdirect.h\"\n+#include <linux/smbdirect.h>\n #include \"pdu.h\"\n-#include \"public.h\"\n \n #include <linux/mutex.h>\n \ndiff --git a/fs/smb/smbdirect/smbdirect.h b/fs/smb/smbdirect/smbdirect.h\ndeleted file mode 100644\nindex bbab5f7f7cc9..000000000000\n--- a/fs/smb/smbdirect/smbdirect.h\n+++ /dev/null\n@@ -1,52 +0,0 @@\n-/* SPDX-License-Identifier: GPL-2.0-or-later */\n-/*\n- * Copyright (C) 2025 Stefan Metzmacher\n- */\n-\n-#ifndef __FS_SMB_COMMON_SMBDIRECT_SMBDIRECT_H__\n-#define __FS_SMB_COMMON_SMBDIRECT_SMBDIRECT_H__\n-\n-#include <linux/types.h>\n-\n-/* SMB-DIRECT buffer descriptor V1 structure [MS-SMBD] 2.2.3.1 */\n-struct smbdirect_buffer_descriptor_v1 {\n-\t__le64 offset;\n-\t__le32 token;\n-\t__le32 length;\n-} __packed;\n-\n-/*\n- * Connection parameters mostly from [MS-SMBD] 3.1.1.1\n- *\n- * These are setup and negotiated at the beginning of a\n- * connection and remain constant unless explicitly changed.\n- *\n- * Some values are important for the upper layer.\n- */\n-struct smbdirect_socket_parameters {\n-\t__u64 flags;\n-#define SMBDIRECT_FLAG_PORT_RANGE_ONLY_IB ((__u64)0x1)\n-#define SMBDIRECT_FLAG_PORT_RANGE_ONLY_IW ((__u64)0x2)\n-\t__u32 resolve_addr_timeout_msec;\n-\t__u32 resolve_route_timeout_msec;\n-\t__u32 rdma_connect_timeout_msec;\n-\t__u32 negotiate_timeout_msec;\n-\t__u16 initiator_depth; /* limited to U8_MAX */\n-\t__u16 responder_resources; /* limited to U8_MAX */\n-\t__u16 recv_credit_max;\n-\t__u16 send_credit_target;\n-\t__u32 max_send_size;\n-\t__u32 max_fragmented_send_size;\n-\t__u32 max_recv_size;\n-\t__u32 max_fragmented_recv_size;\n-\t__u32 max_read_write_size;\n-\t__u32 max_frmr_depth;\n-\t__u32 keepalive_interval_msec;\n-\t__u32 keepalive_timeout_msec;\n-} __packed;\n-\n-#define SMBDIRECT_FLAG_PORT_RANGE_MASK ( \\\n-\t\tSMBDIRECT_FLAG_PORT_RANGE_ONLY_IB | \\\n-\t\tSMBDIRECT_FLAG_PORT_RANGE_ONLY_IW)\n-\n-#endif /* __FS_SMB_COMMON_SMBDIRECT_SMBDIRECT_H__ */\ndiff --git a/fs/smb/smbdirect/public.h b/include/linux/smbdirect.h\nsimilarity index 76%\nrename from fs/smb/smbdirect/public.h\nrename to include/linux/smbdirect.h\nindex d4fb36e65254..97f5ba730fa7 100644\n--- a/fs/smb/smbdirect/public.h\n+++ b/include/linux/smbdirect.h\n@@ -3,11 +3,51 @@\n * Copyright (C) 2025, Stefan Metzmacher\n */\n \n-#ifndef __FS_SMB_COMMON_SMBDIRECT_SMBDIRECT_PUBLIC_H__\n-#define __FS_SMB_COMMON_SMBDIRECT_SMBDIRECT_PUBLIC_H__\n+#ifndef __LINUX_SMBDIRECT_H__\n+#define __LINUX_SMBDIRECT_H__\n \n-struct smbdirect_buffer_descriptor_v1;\n-struct smbdirect_socket_parameters;\n+#include <linux/types.h>\n+\n+/* SMB-DIRECT buffer descriptor V1 structure [MS-SMBD] 2.2.3.1 */\n+struct smbdirect_buffer_descriptor_v1 {\n+\t__le64 offset;\n+\t__le32 token;\n+\t__le32 length;\n+} __packed;\n+\n+/*\n+ * Connection parameters mostly from [MS-SMBD] 3.1.1.1\n+ *\n+ * These are setup and negotiated at the beginning of a\n+ * connection and remain constant unless explicitly changed.\n+ *\n+ * Some values are important for the upper layer.\n+ */\n+struct smbdirect_socket_parameters {\n+\t__u64 flags;\n+#define SMBDIRECT_FLAG_PORT_RANGE_ONLY_IB ((__u64)0x1)\n+#define SMBDIRECT_FLAG_PORT_RANGE_ONLY_IW ((__u64)0x2)\n+\t__u32 resolve_addr_timeout_msec;\n+\t__u32 resolve_route_timeout_msec;\n+\t__u32 rdma_connect_timeout_msec;\n+\t__u32 negotiate_timeout_msec;\n+\t__u16 initiator_depth; /* limited to U8_MAX */\n+\t__u16 responder_resources; /* limited to U8_MAX */\n+\t__u16 recv_credit_max;\n+\t__u16 send_credit_target;\n+\t__u32 max_send_size;\n+\t__u32 max_fragmented_send_size;\n+\t__u32 max_recv_size;\n+\t__u32 max_fragmented_recv_size;\n+\t__u32 max_read_write_size;\n+\t__u32 max_frmr_depth;\n+\t__u32 keepalive_interval_msec;\n+\t__u32 keepalive_timeout_msec;\n+} __packed;\n+\n+#define SMBDIRECT_FLAG_PORT_RANGE_MASK ( \\\n+\t\tSMBDIRECT_FLAG_PORT_RANGE_ONLY_IB | \\\n+\t\tSMBDIRECT_FLAG_PORT_RANGE_ONLY_IW)\n \n struct smbdirect_socket;\n struct smbdirect_send_batch;\n@@ -143,4 +183,4 @@ void smbdirect_connection_legacy_debug_proc_show(struct smbdirect_socket *sc,\n \t\t\t\t\t\t unsigned int rdma_readwrite_threshold,\n \t\t\t\t\t\t struct seq_file *m);\n \n-#endif /* __FS_SMB_COMMON_SMBDIRECT_SMBDIRECT_PUBLIC_H__ */\n+#endif /* __LINUX_SMBDIRECT_H__ */\n", "prefixes": [ "2/2" ] }