Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230055/?format=api
{ "id": 2230055, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230055/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429062004.36582-4-guobin@linux.alibaba.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260429062004.36582-4-guobin@linux.alibaba.com>", "date": "2026-04-29T06:20:04", "name": "[3/3] system/vl.c: inline qemu_opts_parse_noisily() result checks", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b0401dd07af90628d3fe3c6ce98e8f93a8f0de7a", "submitter": { "id": 91693, "url": "http://patchwork.ozlabs.org/api/1.1/people/91693/?format=api", "name": "Bin Guo", "email": "guobin@linux.alibaba.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429062004.36582-4-guobin@linux.alibaba.com/mbox/", "series": [ { "id": 501994, "url": "http://patchwork.ozlabs.org/api/1.1/series/501994/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501994", "date": "2026-04-29T06:20:01", "name": "Minor cleanups: eliminate redundant code in QOM, block-backend and vl.c", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501994/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230055/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230055/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com\n header.a=rsa-sha256 header.s=default header.b=OVbluQTk;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g56f96FFcz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 16:22:09 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHyJ4-0004pj-5T; Wed, 29 Apr 2026 02:21:58 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <guobin@linux.alibaba.com>)\n id 1wHyHz-0004Xq-Li; Wed, 29 Apr 2026 02:20:51 -0400", "from out30-118.freemail.mail.aliyun.com ([115.124.30.118])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <guobin@linux.alibaba.com>)\n id 1wHyHv-00078Y-EO; Wed, 29 Apr 2026 02:20:51 -0400", "from localhost(mailfrom:guobin@linux.alibaba.com\n fp:SMTPD_---0X1wgCi6_1777443629 cluster:ay36) by smtp.aliyun-inc.com;\n Wed, 29 Apr 2026 14:20:36 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linux.alibaba.com; s=default;\n t=1777443637; h=From:To:Subject:Date:Message-ID:MIME-Version;\n bh=7BNMZsf0OZfChDgYsNAXBHtNNdE/HIiReKu3r1PFxt0=;\n b=OVbluQTkoFojZVXSiYms0TDXuBcuZCZIMO04xuYsF+uB+Pnp2nPxivUPpRicP/vP6eyhBXcfoHwV5q+mosPSjBoTuLk85TvPqyRL37mNlp/WkHYOpCfzdVT3yTnJuWTF3tBAjEx5FUNUhLnD+OCoSWdqpCFGo+RlmRygmolA4kE=", "X-Alimail-AntiSpam": "AC=PASS; BC=-1|-1; BR=01201311R171e4; CH=green;\n DM=||false|;\n DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=maildocker-contentspam033037033178;\n MF=guobin@linux.alibaba.com; NM=1; PH=DS; RN=6; SR=0;\n TI=SMTPD_---0X1wgCi6_1777443629;", "From": "Bin Guo <guobin@linux.alibaba.com>", "To": "qemu-devel@nongnu.org", "Cc": "pbonzini@redhat.com, berrange@redhat.com, kwolf@redhat.com,\n hreitz@redhat.com, qemu-block@nongnu.org", "Subject": "[PATCH 3/3] system/vl.c: inline qemu_opts_parse_noisily() result\n checks", "Date": "Wed, 29 Apr 2026 14:20:04 +0800", "Message-ID": "<20260429062004.36582-4-guobin@linux.alibaba.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260429062004.36582-1-guobin@linux.alibaba.com>", "References": "<20260429062004.36582-1-guobin@linux.alibaba.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=115.124.30.118;\n envelope-from=guobin@linux.alibaba.com;\n helo=out30-118.freemail.mail.aliyun.com", "X-Spam_score_int": "-174", "X-Spam_score": "-17.5", "X-Spam_bar": "-----------------", "X-Spam_report": "(-17.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5,\n USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "In qemu_init()'s option parsing switch, several cases assigned the\nreturn value of qemu_opts_parse_noisily() to the shared 'opts'\nvariable solely to check for NULL, without using the pointer\nafterwards. Inline the call directly into the if-condition, matching\nthe style already used by QEMU_OPTION_action.\n\nThis affects the following options:\n -drive, -numa, -iscsi, -m, -mon, -chardev, -fsdev, -fwcfg\n\nCases where the returned QemuOpts* is subsequently used (e.g.\n-acpitable, -smbios, -virtfs) are left unchanged.\n\nSigned-off-by: Bin Guo <guobin@linux.alibaba.com>\n---\n system/vl.c | 37 +++++++++++++++----------------------\n 1 file changed, 15 insertions(+), 22 deletions(-)", "diff": "diff --git a/system/vl.c b/system/vl.c\nindex 0e1fc217b4..0e0d3cb761 100644\n--- a/system/vl.c\n+++ b/system/vl.c\n@@ -2961,9 +2961,8 @@ void qemu_init(int argc, char **argv)\n break;\n }\n case QEMU_OPTION_drive:\n- opts = qemu_opts_parse_noisily(qemu_find_opts(\"drive\"),\n- optarg, false);\n- if (opts == NULL) {\n+ if (!qemu_opts_parse_noisily(qemu_find_opts(\"drive\"),\n+ optarg, false)) {\n exit(1);\n }\n break;\n@@ -2988,9 +2987,8 @@ void qemu_init(int argc, char **argv)\n replay_add_blocker(\"-snapshot\");\n break;\n case QEMU_OPTION_numa:\n- opts = qemu_opts_parse_noisily(qemu_find_opts(\"numa\"),\n- optarg, true);\n- if (!opts) {\n+ if (!qemu_opts_parse_noisily(qemu_find_opts(\"numa\"),\n+ optarg, true)) {\n exit(1);\n }\n break;\n@@ -3049,9 +3047,8 @@ void qemu_init(int argc, char **argv)\n break;\n #ifdef CONFIG_LIBISCSI\n case QEMU_OPTION_iscsi:\n- opts = qemu_opts_parse_noisily(qemu_find_opts(\"iscsi\"),\n- optarg, false);\n- if (!opts) {\n+ if (!qemu_opts_parse_noisily(qemu_find_opts(\"iscsi\"),\n+ optarg, false)) {\n exit(1);\n }\n break;\n@@ -3104,8 +3101,8 @@ void qemu_init(int argc, char **argv)\n exit(0);\n break;\n case QEMU_OPTION_m:\n- opts = qemu_opts_parse_noisily(qemu_find_opts(\"memory\"), optarg, true);\n- if (opts == NULL) {\n+ if (!qemu_opts_parse_noisily(qemu_find_opts(\"memory\"),\n+ optarg, true)) {\n exit(1);\n }\n break;\n@@ -3226,17 +3223,15 @@ void qemu_init(int argc, char **argv)\n default_monitor = 0;\n break;\n case QEMU_OPTION_mon:\n- opts = qemu_opts_parse_noisily(qemu_find_opts(\"mon\"), optarg,\n- true);\n- if (!opts) {\n+ if (!qemu_opts_parse_noisily(qemu_find_opts(\"mon\"), optarg,\n+ true)) {\n exit(1);\n }\n default_monitor = 0;\n break;\n case QEMU_OPTION_chardev:\n- opts = qemu_opts_parse_noisily(qemu_find_opts(\"chardev\"),\n- optarg, true);\n- if (!opts) {\n+ if (!qemu_opts_parse_noisily(qemu_find_opts(\"chardev\"),\n+ optarg, true)) {\n exit(1);\n }\n break;\n@@ -3246,8 +3241,7 @@ void qemu_init(int argc, char **argv)\n error_report(\"fsdev support is disabled\");\n exit(1);\n }\n- opts = qemu_opts_parse_noisily(olist, optarg, true);\n- if (!opts) {\n+ if (!qemu_opts_parse_noisily(olist, optarg, true)) {\n exit(1);\n }\n break;\n@@ -3386,9 +3380,8 @@ void qemu_init(int argc, char **argv)\n smbios_entry_add(opts, &error_fatal);\n break;\n case QEMU_OPTION_fwcfg:\n- opts = qemu_opts_parse_noisily(qemu_find_opts(\"fw_cfg\"),\n- optarg, true);\n- if (opts == NULL) {\n+ if (!qemu_opts_parse_noisily(qemu_find_opts(\"fw_cfg\"),\n+ optarg, true)) {\n exit(1);\n }\n break;\n", "prefixes": [ "3/3" ] }