Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2230030/?format=api
{ "id": 2230030, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2230030/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429044752.4176397-39-alistair.francis@wdc.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260429044752.4176397-39-alistair.francis@wdc.com>", "date": "2026-04-29T04:47:39", "name": "[PULL,38/51] hw/riscv/boot: Warn if a ELF format file is loaded as a binary", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "83c82e50a99951172800ab5d3a294e7e53416e79", "submitter": { "id": 64571, "url": "http://patchwork.ozlabs.org/api/1.1/people/64571/?format=api", "name": "Alistair Francis", "email": "alistair23@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429044752.4176397-39-alistair.francis@wdc.com/mbox/", "series": [ { "id": 501983, "url": "http://patchwork.ozlabs.org/api/1.1/series/501983/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501983", "date": "2026-04-29T04:47:05", "name": "[PULL,01/51] hw/riscv/riscv-iommu: Use standard EN_PRI bit for PRI", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501983/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230030/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230030/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=QWs/jQ78;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g54n65gJMz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 14:58:02 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHwtj-0000Ob-EP; Wed, 29 Apr 2026 00:51:43 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <alistair23@gmail.com>)\n id 1wHwtR-0007lg-IG\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 00:51:29 -0400", "from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <alistair23@gmail.com>)\n id 1wHwtQ-0000yt-0Q\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 00:51:25 -0400", "by mail-pj1-x102f.google.com with SMTP id\n 98e67ed59e1d1-35d95017a68so8206827a91.3\n for <qemu-devel@nongnu.org>; Tue, 28 Apr 2026 21:51:22 -0700 (PDT)", "from toolbx.alistair23.me ([2403:581e:fdf9:0:6209:4521:6813:45b7])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b988772ae8sm7756145ad.7.2026.04.28.21.51.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 21:51:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777438282; x=1778043082; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=BVgwDWm2FZQ7Ipuxdrbl93wK7S5fAE7/3PcrEqAAO2o=;\n b=QWs/jQ78Ywx/Kli2AA/3T1QYNVfeNAqivt+OsdP5XS2TTOoZjTK2PHE58Oe6kKMo6q\n YVClmw5/VH0E3KCJSaHfbv/LtVNfOh5bOyG249h9O4K7+gWTv6Jf4ooiQi380iIVFL/J\n scIvEUIlCg3sFfJOzoxQ8vxa9ZMu/rXXcfeu2bZB03E1UIGTEiNVSgrpuIDSsZoorqTB\n hRmbFaN0qH0YSgWZvtFdSgeveARY2ocWNjmjNnp9Vg09spdTlsk6dBqQsAMz775WzV4L\n 7shYSPegV3kR02Eq14BdC2PXn9xxuOrlXg0XU8pi9sQltG2qT+6aghXZjfsnroo3hlyu\n Ycew==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777438282; x=1778043082;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=BVgwDWm2FZQ7Ipuxdrbl93wK7S5fAE7/3PcrEqAAO2o=;\n b=RspWd9FjOQTk+JMcGbVPmobS1hObPeesxjIRZo5GvAWxUSudTGX/y0L+UBTEvx7luT\n 1LZ+gRPLUaSXDcd5JRDpBldCFvpYmIrFO5igledFd8L6DGCTV36Ri3GiZDIKzr4fYWVi\n lKt4+7nKEZJ545e6spG7HiwhPtZIV6YL5LRJ18nsfBp8+bBBm/deugsAHwMzVkiiXzVy\n 8hJOwfJXytaQ9C8C0f8OqiZedopBhJFDgO8n5GK1QARxjRB+mJApGEWr4QJUZpwtLKiK\n en73saxl8k139EKpF8FTB5yhzDFBgoG2vp4uL/eudBq2dkUMj6D++A9cWR5t36VCXOP0\n UP+A==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ/g8UvlXPhLPikadyKYJakZ+bObZMIa/6BJoJu7cZKHHIxjXcWEDV94n10aGrrnGgG4vkr9kOndoR7h@nongnu.org", "X-Gm-Message-State": "AOJu0Yw09XUugnPYHbUZ7xySMeMOhC7wTOrYsmqs2A8m5Zl+FOnaRv6t\n oXDzOz0pXS/wVG3FJ0Amzq/xcRViTfR70HxSmEcpCETyXayUKz+dWDj9", "X-Gm-Gg": "AeBDieuU6D14XYJfSNVzbBRf4tKckVTBftxbeRp8/YgMhD6dtQLEZC2EbPTMTbMz1E+\n ElCZYfEnk06i4ruetV2Lh8HCOjgQK48q2n1idBQpqBKjcZ7ioieGFgc3iel6zl4auIYFz3SIhGq\n 4cLI2i0wz2qqiUzV5ZSw4IvqbmF4R1mL5P84xdMpBK4aXhfN9UWr7IJpsFiuI5Ef6ikkychZ9CQ\n 14SuBIFierRwEI3bLluBwY7UE2vD8aspC476QibVv607+o5yvMwhYRjPd5gWO7RMbTlDhXYKttN\n BCZzZeHTK4YoUtjhhJl+obvXj4wCciCe+vCZv3a0/EnrrOVjz5463M0EwMIy8P5qKLPnY3LkN9K\n wb6OjPeg54GXchBUZlBTxNU8HOj9iMZdD8zsR1/Uq5BI00cdsao/FlYTMeKSDet+65m77aE9S2H\n AN791QbC9U/HOgDuq/4V6h4xD9SSThvxY1QOkHzyRFxTdPaOGueG3L", "X-Received": "by 2002:a17:90b:2885:b0:35e:5723:85e3 with SMTP id\n 98e67ed59e1d1-36491fb9afdmr6220062a91.9.1777438281806;\n Tue, 28 Apr 2026 21:51:21 -0700 (PDT)", "From": "alistair23@gmail.com", "X-Google-Original-From": "alistair.francis@wdc.com", "To": "palmer@dabbelt.com, liwei1518@gmail.com, daniel.barboza@oss.qualcomm.com,\n zhiwei_liu@linux.alibaba.com, chao.liu.zevorn@gmail.com,\n qemu-riscv@nongnu.org, qemu-devel@nongnu.org", "Cc": "alistair23@gmail.com, Nicholas Piggin <npiggin@gmail.com>,\n Joel Stanley <joel@jms.id.au>, Alistair Francis <alistair.francis@wdc.com>", "Subject": "[PULL 38/51] hw/riscv/boot: Warn if a ELF format file is loaded as a\n binary", "Date": "Wed, 29 Apr 2026 14:47:39 +1000", "Message-ID": "<20260429044752.4176397-39-alistair.francis@wdc.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260429044752.4176397-1-alistair.francis@wdc.com>", "References": "<20260429044752.4176397-1-alistair.francis@wdc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::102f;\n envelope-from=alistair23@gmail.com; helo=mail-pj1-x102f.google.com", "X-Spam_score_int": "-17", "X-Spam_score": "-1.8", "X-Spam_bar": "-", "X-Spam_report": "(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Nicholas Piggin <npiggin@gmail.com>\n\nIt is possible that an ELF file can not be loaded, in that\ncase the loader falls back to loading the file as a binary\nblob. Print a warning in this case because it is likely that\nit is not intended.\n\nSigned-off-by: Nicholas Piggin <npiggin@gmail.com>\nReviewed-by: Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>\nSigned-off-by: Joel Stanley <joel@jms.id.au>\nReviewed-by: Alistair Francis <alistair.francis@wdc.com>\nMessage-ID: <20260415064838.652297-4-joel@jms.id.au>\nSigned-off-by: Alistair Francis <alistair.francis@wdc.com>\n---\n hw/riscv/boot.c | 23 +++++++++++++++++++----\n 1 file changed, 19 insertions(+), 4 deletions(-)", "diff": "diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c\nindex e5490beda0..9086793b7a 100644\n--- a/hw/riscv/boot.c\n+++ b/hw/riscv/boot.c\n@@ -163,13 +163,27 @@ hwaddr riscv_load_firmware(const char *firmware_filename,\n \n g_assert(firmware_filename != NULL);\n \n- if (load_elf_ram_sym(firmware_filename, NULL, NULL, NULL,\n- &firmware_entry, NULL, &firmware_end, NULL,\n- 0, EM_RISCV, 1, 0, NULL, true, sym_cb) > 0) {\n+ firmware_size = load_elf_ram_sym(firmware_filename, NULL, NULL, NULL,\n+ &firmware_entry, NULL, &firmware_end,\n+ NULL, 0, EM_RISCV, 1, 0, NULL, false,\n+ sym_cb);\n+ if (firmware_size > 0) {\n *firmware_load_addr = firmware_entry;\n return firmware_end;\n }\n \n+ if (firmware_size != ELF_LOAD_NOT_ELF) {\n+ /*\n+ * If the user specified an ELF format firmware that could not be\n+ * loaded as an ELF, it's possible that loading it as a binary is\n+ * not what was intended.\n+ */\n+ warn_report(\"could not load ELF format firmware '%s' (%s). \"\n+ \"Attempting to load as binary.\",\n+ firmware_filename,\n+ load_elf_strerror(firmware_size));\n+ }\n+\n firmware_size = load_image_targphys_as(firmware_filename,\n *firmware_load_addr,\n current_machine->ram_size, NULL,\n@@ -179,7 +193,8 @@ hwaddr riscv_load_firmware(const char *firmware_filename,\n return *firmware_load_addr + firmware_size;\n }\n \n- error_report(\"could not load firmware '%s'\", firmware_filename);\n+ error_report(\"could not load firmware '%s': %s\", firmware_filename,\n+ load_elf_strerror(firmware_size));\n exit(1);\n }\n \n", "prefixes": [ "PULL", "38/51" ] }